Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Koenig, Christian
Am 27.05.19 um 17:26 schrieb Daniel Vetter: > On Mon, May 27, 2019 at 3:42 PM Koenig, Christian > wrote: >> Am 27.05.19 um 15:26 schrieb Emil Velikov: >>> On 2019/05/27, Daniel Vetter wrote: On Mon, May 27, 2019 at 10:47:39AM +, Koenig, Christian wrote: > Am 27.05.19 um 10:17 schrieb

Re: [PATCH] drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to amdgpu

2019-05-27 Thread Cui, Flora
the patch is Reviewed-by: Flora Cui 在 5/28/2019 10:52 AM, Chunming Zhou 写道: > Change-Id: I2b1af1478fbddbb5084b90b3ff85c2eb964bd217 > Signed-off-by: Chunming Zhou > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/

[PATCH] drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to amdgpu

2019-05-27 Thread Chunming Zhou
Change-Id: I2b1af1478fbddbb5084b90b3ff85c2eb964bd217 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 78706dfa753a

RE: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-27 Thread Quan, Evan
The original unpin in hw_fini was introduced by https://lists.freedesktop.org/archives/amd-gfx/2018-July/023681.html Evan > -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Monday, May 27, 2019 7:02 PM > To: Deng, Emily ; amd-gfx@lists.freedesktop.org > Subject: R

RE: [PATCH] drm/amdgpu: Need to set the baco cap before baco reset

2019-05-27 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Emily Deng > Sent: Monday, May 27, 2019 3:43 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily > Subject: [PATCH] drm/amdgpu: Need to set the baco cap before baco reset > > For passthrough, after rebooted

[PATCH 13/26] drm/amd/display: 3.2.32

2019-05-27 Thread sunpeng.li
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 7ac0ea8..7ec6884 100644 --

[PATCH 09/26] drm/amd/display: disable PSR/ABM before destroy DMCU struct

2019-05-27 Thread sunpeng.li
From: Paul Hsieh [Why] 1. DMCU is not running on some platform but driver still send ABM command. It may cause assert due to DMCU is not alive. 2. To make sure PSR disable when driver disable [How] 1. Add dmcu_is_running in ABM struct, driver can check this flag to determine driver should

[PATCH 07/26] drm/amd/display: Add GSL source select registers

2019-05-27 Thread sunpeng.li
From: Krunoslav Kovac GSL is a form of locking that can be used to synchronize pipes in a pipe-split configurations when async flip is used. Add the registers here. Signed-off-by: Krunoslav Kovac Reviewed-by: Tony Cheng Acked-by: Aric Cyr Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/

[PATCH 12/26] drm/amd/display: Move link functions from dc to dc_link

2019-05-27 Thread sunpeng.li
From: Chris Park [Why] link-specific functions should reside in dc_link.c [How] Move them there. Signed-off-by: Chris Park Reviewed-by: Charlene Liu Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/core/dc.c | 122 - drivers/gpu/drm/amd/display/dc/core/dc_lin

[PATCH 11/26] drm/amd/display: Add min_dcfclk_mhz field to bb overrides

2019-05-27 Thread sunpeng.li
From: Jun Lei Add min_dcfclk_mhz to bounding box overrides. Signed-off-by: Jun Lei Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h i

[PATCH 19/26] drm/amd/display: Add writeback_config to VBA vars

2019-05-27 Thread sunpeng.li
From: Ilya Bakoulin Adding writeback_config enum to vba_vars_st, replacing old flag. Initialize to dm_normal. Signed-off-by: Ilya Bakoulin Reviewed-by: Charlene Liu Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dml/display_mode_enums.h | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 24/26] drm/amd/display: Reset planes for color management changes

2019-05-27 Thread sunpeng.li
From: Nicholas Kazlauskas [Why] For commits with allow_modeset=false and CRTC degamma changes the planes aren't reset. This results in incorrect rendering. [How] Reset the planes when color management has changed on the CRTC. Technically this will include regamma changes as well, but it doesn't

[PATCH 21/26] drm/amd/display: Refactor DIO stream encoder

2019-05-27 Thread sunpeng.li
From: Eric Bernstein * Pull duplicate audio_clock_info struct to stream_encoder.h * Generalize sec_gsp7* to sec_gsp_pps* * Expose enc1 and enc2 stream encoder audio funcs Signed-off-by: Eric Bernstein Reviewed-by: Charlene Liu Reviewed-by: Dmytro Laktyushkin Acked-by: Leo Li --- .../gpu/drm

[PATCH 08/26] drm/amd/display: Ensure DRR triggers in BP

2019-05-27 Thread sunpeng.li
From: Eryk Brol [Why] In the previous implementation DRR event sometimes came in during FP2 region which is a keep-out zone. This would cause the frame not to latch until the next frame which resulted in heavy flicker. To fix this we need to make sure that it triggers in the BP. [How] 1. Remove

[PATCH 06/26] drm/amd/display: Disable audio stream only if it's currently enabled

2019-05-27 Thread sunpeng.li
From: Eryk Brol [Why] Previously there were 2 consecutive calls being made to disable audio stream. The first one disabled the audio stream, and the second one went through and also tried to disable the audio stream causing BACO entry issues due to the ASIC appearing busy. [How] 1. Add a status

[PATCH 17/26] drm/amd/display: Fix type of pp_smu_wm_set_range struct

2019-05-27 Thread sunpeng.li
From: Eric Yang [why] Value read from SMU is 16 bits, not 32. [How] Fix type, and add wm_type enum in preparation for future interfaces. Signed-off-by: Eric Yang Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dm_pp_smu.h | 31 +- 1 fi

[PATCH 15/26] drm/amd/display: fix crash on setmode when mode is close to bw limit

2019-05-27 Thread sunpeng.li
From: Su Sung Chung [why] during It's possible to call dcn_validate_bandwidth with no plane. In that case, as we are only intersted in if output timing is supported or not, even if we cannot support native resolution, we still want to support lower resolution if it is valid [how] if there exist

[PATCH 26/26] drm/amd/display: program manual trigger only for bottom most pipe

2019-05-27 Thread sunpeng.li
From: Aric Cyr [Why] We only want to manual trigger end-of-frame when the bottom-most pipe is flipped to prevent overlays from ending the frame too early. [How] Check that the manual trigger is only firing on bottom plane. Signed-off-by: Aric Cyr Reviewed-by: Jun Lei Acked-by: Leo Li --- dr

[PATCH 03/26] drm/amd/display: Implement CM dealpha and bias interfaces

2019-05-27 Thread sunpeng.li
From: Gary Kattan Add vtable entries for de-alpha and bias color management interfaces. Move piece-wise transfer function registers to a helper list for future reuse. Signed-off-by: Gary Kattan Reviewed-by: Nevenko Stupar Acked-by: Leo Li --- .../gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.

[PATCH 25/26] drm/amd/display: CS_TFM_1D only applied post EOTF

2019-05-27 Thread sunpeng.li
From: Krunoslav Kovac [Why] There's some unnecessary mem allocation for CS_TFM_ID. What's worse, it depends on LUT size and since it's 4K for CS_TFM_1D, it is 16x bigger than in regular case when it's actually needed. This leads to some crashes in stress conditions. [How] Skip ramp combining des

[PATCH 18/26] drm/amd/display: Refactor clk_mgr functions

2019-05-27 Thread sunpeng.li
From: Eric Yang [Why] Some HW specific implementations can be pulled out into clk_mgr.c. [How] * Pull get_active_display_cnt out to clk_mgr. * Pull out shared logic in set_dispclk and set_dprefclk Signed-off-by: Eric Yang Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/disp

[PATCH 20/26] drm/amd/display: Modified AUX_DPHY_RX_CONTROL0

2019-05-27 Thread sunpeng.li
From: Daniel He [Description] This is cause by failing to read link caps from driver. Signed-off-by: Daniel He Reviewed-by: Charlene Liu Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH 14/26] drm/amd/display: fix calculation of total_data_read_bandwidth

2019-05-27 Thread sunpeng.li
From: Su Sung Chung [why] by adding fast_validate flag, we are skipping some portion of dcn_validate_bandwidth code that is not necessary for mode validation. However we have a bug where it does not calculate v->total_data_read_bandwidth, which is one of the factors determines the result of the v

[PATCH 23/26] drm/amd/display: Increase Backlight Gain Step Size

2019-05-27 Thread sunpeng.li
From: Eryk Brol [Why] Some backlight tests fail due to backlight settling taking too long. This happens because the step size used to change backlight levels is too small. [How] 1. Change the size of the backlight gain step size 2. Change how DMCU firmware gets the step size value so that it

[PATCH 16/26] drm/amd/display: do not power on eDP power rail early

2019-05-27 Thread sunpeng.li
From: Anthony Koo [Why] Modern Standby may toggle display adapter state between D0 and D3 state unpredictably. But events that cause transition to D0 are not always resulting in a display light up scenario. Modern eDP panels should be able to power on panel logic quickly upon VDD going high. Bas

[PATCH 05/26] drm/amd/display: assign new stream id in dc_copy_stream

2019-05-27 Thread sunpeng.li
From: Wenjing Liu [why] stream id should uniquely identify an instance of stream. the copy constructor should be treated as a new stream instance. [how] assign a new stream id in this copy constructor. Signed-off-by: Wenjing Liu Reviewed-by: Jun Lei Acked-by: Leo Li --- drivers/gpu/drm/amd/

[PATCH 22/26] drm/amd/display: fix issues with bad AUX reply on some displays

2019-05-27 Thread sunpeng.li
From: Anthony Koo [Why] Some displays take some time to power up AUX CH once they are put into D3 state via write to DPCD 600h=2. Interestingly enough, some display may simply NACK, but some might also ACK with a bunch of 0s, which can cause issues with receiver cap retrieval. Note that not all

[PATCH 00/26] DC Patches 27 May 2019

2019-05-27 Thread sunpeng.li
From: Leo Li Summary of change: * Major refactor of clk_mgr, to better reflect different HW policies between dGPU and APU * Fix degamma when allow_modeset is false * Calculation fixes in DML Anthony Koo (2): drm/amd/display: do not power on eDP power rail early drm/amd/display: fix issues

[PATCH 04/26] drm/amd/display: Move CLK_BASE_INNER macro

2019-05-27 Thread sunpeng.li
From: Eric Yang This macro is specificly used by RV1. Move it to the appropriate location. Signed-off-by: Eric Yang Reviewed-by: Aric Cyr Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dcn10/rv1_clk_mgr_clk.c | 4 drivers/gpu/drm/amd/display/dc/inc/hw/clk_mgr_internal.h | 3 +--

[PATCH 02/26] drm/amd/display: Don't use ROM for output TF if GAMMA_CS_TFM_1D

2019-05-27 Thread sunpeng.li
From: Hugo Hu We can’t use hardcoded SRGB ROM for output TF if we have GAMMA_CS_TFM_1D (unless we know 1D LUT is identity), so we never want to return here early. We apply the LUT part of ColorTransform3x4 only in apply_lut_1d() which is called near the end of that function. Signed-off-by: Hugo

Re: [PATCH] drm/amdgpu: enable PCIE atomics ops support

2019-05-27 Thread Kuehling, Felix
On 2019-05-27 7:51 a.m., Christian König wrote: > That idea sounds sane to me as well. > > By the way, do we somewhere signal to userspace if atomics are > supported or not? Yes. KFD topology (a flag in the iolink) provides that information to user mode. Regards,   Felix > > I mean would be n

RE: [PATCH] drm/amdgpu: fix ring test failure issue during s3 in vce 3.0

2019-05-27 Thread Li, Ching-shih (Louis)
I don’t mean to read it twice. The solution is to make first read later. I didn’t modify the original code to make code difference less and simple. I guess it should work to remove the original read there. From: Liu, Leo Sent: Tuesday, May 28, 2019 12:40 AM To: Li, Ching-shih (Louis) ; S, Shir

Re: [PATCH] drm/amdgpu: fix ring test failure issue during s3 in vce 3.0

2019-05-27 Thread Liu, Leo
int amdgpu_vce_ring_test_ring(struct amdgpu_ring *ring) { struct amdgpu_device *adev = ring->adev; uint32_t rptr = amdgpu_ring_get_rptr(ring); unsigned i; int r, timeout = adev->usec_timeout; /* skip ring test for sriov*/ if (amdgpu_sriov_vf(adev)) return 0;

RE: [PATCH] drm/amdgpu: fix ring test failure issue during s3 in vce 3.0

2019-05-27 Thread Li, Ching-shih (Louis)
Hi Leo, Yes, I confirm it is the root cause for the Chrome S3 issue. Whenever system is resumed, the original instruction always gets zero. However, I have no idea why it fails, and didn’t verify this problem on CRB or any other Linux platform yet. Although I think the ideal solution is an indic

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Emil Velikov
On 2019/05/27, Koenig, Christian wrote: > Am 27.05.19 um 15:26 schrieb Emil Velikov: > > On 2019/05/27, Daniel Vetter wrote: > >> On Mon, May 27, 2019 at 10:47:39AM +, Koenig, Christian wrote: > >>> Am 27.05.19 um 10:17 schrieb Emil Velikov: > From: Emil Velikov > > Currently on

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Daniel Vetter
On Mon, May 27, 2019 at 3:42 PM Koenig, Christian wrote: > > Am 27.05.19 um 15:26 schrieb Emil Velikov: > > On 2019/05/27, Daniel Vetter wrote: > >> On Mon, May 27, 2019 at 10:47:39AM +, Koenig, Christian wrote: > >>> Am 27.05.19 um 10:17 schrieb Emil Velikov: > From: Emil Velikov >

Re: [PATCH v15 05/17] arms64: untag user pointers passed to memory syscalls

2019-05-27 Thread Catalin Marinas
On Mon, May 06, 2019 at 06:30:51PM +0200, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > This patch allows tagged pointers to be p

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Emil Velikov
On 2019/05/27, Daniel Vetter wrote: > On Mon, May 27, 2019 at 09:17:29AM +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > Currently one can circumvent DRM_AUTH, when the ioctl is exposed via the > > render node. A seemingly deliberate design decision. > > > > Hence we can drop the DRM_A

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Koenig, Christian
Am 27.05.19 um 15:26 schrieb Emil Velikov: > On 2019/05/27, Daniel Vetter wrote: >> On Mon, May 27, 2019 at 10:47:39AM +, Koenig, Christian wrote: >>> Am 27.05.19 um 10:17 schrieb Emil Velikov: From: Emil Velikov Currently one can circumvent DRM_AUTH, when the ioctl is exposed v

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Daniel Vetter
On Mon, May 27, 2019 at 3:26 PM Daniel Vetter wrote: > > On Mon, May 27, 2019 at 01:52:05PM +0100, Emil Velikov wrote: > > On 2019/05/27, Koenig, Christian wrote: > > > Am 27.05.19 um 14:05 schrieb Emil Velikov: > > > > On 2019/05/27, Koenig, Christian wrote: > > > >> Am 27.05.19 um 10:17 schrieb

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Emil Velikov
On 2019/05/27, Daniel Vetter wrote: > On Mon, May 27, 2019 at 10:47:39AM +, Koenig, Christian wrote: > > Am 27.05.19 um 10:17 schrieb Emil Velikov: > > > From: Emil Velikov > > > > > > Currently one can circumvent DRM_AUTH, when the ioctl is exposed via the > > > render node. A seemingly delib

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Daniel Vetter
On Mon, May 27, 2019 at 01:52:05PM +0100, Emil Velikov wrote: > On 2019/05/27, Koenig, Christian wrote: > > Am 27.05.19 um 14:05 schrieb Emil Velikov: > > > On 2019/05/27, Koenig, Christian wrote: > > >> Am 27.05.19 um 10:17 schrieb Emil Velikov: > > >>> From: Emil Velikov > > >>> > > >>> Currentl

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Daniel Vetter
On Mon, May 27, 2019 at 10:47:39AM +, Koenig, Christian wrote: > Am 27.05.19 um 10:17 schrieb Emil Velikov: > > From: Emil Velikov > > > > Currently one can circumvent DRM_AUTH, when the ioctl is exposed via the > > render node. A seemingly deliberate design decision. > > > > Hence we can drop

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Daniel Vetter
On Mon, May 27, 2019 at 09:17:29AM +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently one can circumvent DRM_AUTH, when the ioctl is exposed via the > render node. A seemingly deliberate design decision. > > Hence we can drop the DRM_AUTH all together (details in follow-up patch) > ye

Re: [PATCH] drm/amdgpu: fix ring test failure issue during s3 in vce 3.0

2019-05-27 Thread Liu, Leo
On 5/27/19 3:42 AM, S, Shirish wrote: From: Louis Li [What] vce ring test fails consistently during resume in s3 cycle, due to mismatch read & write pointers. On debug/analysis its found that rptr to be compared is not being correctly updated/read, which leads to t

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Emil Velikov
On 2019/05/27, Koenig, Christian wrote: > Am 27.05.19 um 14:05 schrieb Emil Velikov: > > On 2019/05/27, Koenig, Christian wrote: > >> Am 27.05.19 um 10:17 schrieb Emil Velikov: > >>> From: Emil Velikov > >>> > >>> Currently one can circumvent DRM_AUTH, when the ioctl is exposed via the > >>> rende

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Koenig, Christian
Am 27.05.19 um 14:05 schrieb Emil Velikov: > On 2019/05/27, Koenig, Christian wrote: >> Am 27.05.19 um 10:17 schrieb Emil Velikov: >>> From: Emil Velikov >>> >>> Currently one can circumvent DRM_AUTH, when the ioctl is exposed via the >>> render node. A seemingly deliberate design decision. >>> >>

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Emil Velikov
On 2019/05/27, Koenig, Christian wrote: > Am 27.05.19 um 10:17 schrieb Emil Velikov: > > From: Emil Velikov > > > > Currently one can circumvent DRM_AUTH, when the ioctl is exposed via the > > render node. A seemingly deliberate design decision. > > > > Hence we can drop the DRM_AUTH all together

Re: [PATCH] drm/amdgpu: enable PCIE atomics ops support

2019-05-27 Thread Christian König
That idea sounds sane to me as well. By the way, do we somewhere signal to userspace if atomics are supported or not? I mean would be nice to keep the state inside adev if this fails for some reason. Christian. Am 27.05.19 um 13:16 schrieb Zhang, Hawking: How about put pci_enable_atomic_o

RE: [PATCH] drm/amdgpu: enable PCIE atomics ops support

2019-05-27 Thread Zhang, Hawking
How about put pci_enable_atomic_ops_to_root ahead of amdgpu_device_ip_early_init, while move pci_atomic_requested from kfd device to kgd device ? In such way, we can avoid duplicate atomic request from both amdgpu and amdkfd. Regards, Hawking -Original Message- From: amd-gfx On Behalf

Re: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-27 Thread Christian König
Am 27.05.19 um 10:41 schrieb Emily Deng: As it will destroy clear_state_obj, and also will unpin it in the gfx_v9_0_sw_fini, so don't need to call csb_vram unpin in gfx_v9_0_hw_fini, or it will have unpin warning. v2: For suspend, still need to do unpin Signed-off-by: Emily Deng --- drivers/

Re: [PATCH 02/12] dma-buf: add dma_buf_(un)map_attachment_locked variants v3

2019-05-27 Thread Christian König
Thanks for the comments, but you are looking at a completely outdated patchset. If you are interested in the newest one please ping me and I'm going to CC you when I send out the next version. Christian. Am 25.05.19 um 03:04 schrieb Hillf Danton: On Tue, 16 Apr 2019 20:38:31 +0200 Christian

Re: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-27 Thread Koenig, Christian
Am 24.05.19 um 23:34 schrieb Kuehling, Felix: > On 2019-05-23 5:06 a.m., Christian König wrote: >> [CAUTION: External Email] >> >> Leaving BOs on the LRU is harmless. We always did this for VM page table >> and per VM BOs. >> >> The key point is that BOs which couldn't be reserved can't be evicted.

Re: [PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Koenig, Christian
Am 27.05.19 um 10:17 schrieb Emil Velikov: > From: Emil Velikov > > Currently one can circumvent DRM_AUTH, when the ioctl is exposed via the > render node. A seemingly deliberate design decision. > > Hence we can drop the DRM_AUTH all together (details in follow-up patch) > yet not all userspace c

[PATCH] drm/amdgpu: enable PCIE atomics ops support

2019-05-27 Thread Xiao, Jack
GPU atomics operation depends on PCIE atomics support. Always enable PCIE atomics ops support in case that it hasn't been enabled. Signed-off-by: Jack Xiao --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH v15 05/17] arms64: untag user pointers passed to memory syscalls

2019-05-27 Thread Catalin Marinas
On Mon, May 06, 2019 at 06:30:51PM +0200, Andrey Konovalov wrote: > +SYSCALL_DEFINE2(arm64_mlock2, unsigned long, start, size_t, len) > +{ > + start = untagged_addr(start); > + return ksys_mlock(start, len, VM_LOCKED); > +} Copy/paste error: sys_mlock2() has 3 arguments and should call ksy

RE: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-27 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Emily Deng > Sent: Monday, May 27, 2019 4:41 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily > Subject: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin > > As it will destroy clear_state_obj, and

[PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-27 Thread Emily Deng
As it will destroy clear_state_obj, and also will unpin it in the gfx_v9_0_sw_fini, so don't need to call csb_vram unpin in gfx_v9_0_hw_fini, or it will have unpin warning. v2: For suspend, still need to do unpin Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 ++- 1 fil

[PATCH 02/13] drm/amdgpu: drop DRM_AUTH usage from the driver

2019-05-27 Thread Emil Velikov
From: Emil Velikov The authentication can be circumvented, by design, by using the render node. From the driver POV htere is no distinction between primary and render nodes, thus we can drop the token. Note: authentication is required on a single ioctl, due to a bug in userspace. The issue has

[PATCH 01/13] drm/amdgpu: introduce and honour DRM_FORCE_AUTH workaround

2019-05-27 Thread Emil Velikov
From: Emil Velikov Currently one can circumvent DRM_AUTH, when the ioctl is exposed via the render node. A seemingly deliberate design decision. Hence we can drop the DRM_AUTH all together (details in follow-up patch) yet not all userspace checks if it's authenticated, but instead uses uncommon

[PATCH 10/13] drm/radeon: drop DRM_AUTH from DRM_RENDER_ALLOW ioctls

2019-05-27 Thread Emil Velikov
From: Emil Velikov The authentication can be circumvented, by design, by using the render node. From the driver POV there is no distinction between primary and render nodes, thus we can drop the token. Note: the outstanding DRM_AUTH instances are: - legacy DRI1 ioctls, which are already neuter

[PATCH] drm/amdgpu: Need to set the baco cap before baco reset

2019-05-27 Thread Emily Deng
For passthrough, after rebooted the VM, driver will do a baco reset before doing other driver initialization during loading driver. For doing the baco reset, it will first check the baco reset capability. So first need to set the cap from the vbios information or baco reset won't be enabled. Sign

[PATCH] drm/amdgpu: fix ring test failure issue during s3 in vce 3.0

2019-05-27 Thread S, Shirish
From: Louis Li [What] vce ring test fails consistently during resume in s3 cycle, due to mismatch read & write pointers. On debug/analysis its found that rptr to be compared is not being correctly updated/read, which leads to this failure. Below is the failure signature: [drm:amdgpu_vce_r