Re: [PATCH 2/2] drm/amdgpu: handle AMDGPU_IB_FLAG_RESET_GDS_MAX_WAVE_ID on gfx10

2019-06-28 Thread Marek Olšák
Thanks. I'll push both patches with emit_ib_size updated for this patch. Marek On Thu, Jun 27, 2019 at 3:50 AM zhoucm1 wrote: > any reason for not care .emit_ib_size in this one? > > -David > > > On 2019年06月27日 06:35, Marek Olšák wrote: > > From: Marek Olšák > > > > Signed-off-by: Marek Olšák

Re: [RFC PATCH v3 09/11] drm, cgroup: Add per cgroup bw measure and control

2019-06-28 Thread Kenny Ho
On Thu, Jun 27, 2019 at 2:11 AM Daniel Vetter wrote: > I feel like a better approach would by to add a cgroup for the various > engines on the gpu, and then also account all the sdma (or whatever the > name of the amd copy engines is again) usage by ttm_bo moves to the right > cgroup. I think tha

Re: [RFC PATCH v3 04/11] drm, cgroup: Add total GEM buffer allocation limit

2019-06-28 Thread Kenny Ho
On Thu, Jun 27, 2019 at 5:24 PM Daniel Vetter wrote: > On Thu, Jun 27, 2019 at 02:42:43PM -0400, Kenny Ho wrote: > > Um... I am going to get a bit philosophical here and suggest that the > > idea of sharing (especially uncontrolled sharing) is inherently at odd > > with containment. It's like, if

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Koenig, Christian
Am 28.06.19 um 18:40 schrieb Daniel Vetter: > On Fri, Jun 28, 2019 at 5:21 PM Koenig, Christian > wrote: >> Am 28.06.19 um 16:38 schrieb Daniel Vetter: >> [SNIP] >>> - when you submit command buffers, you _dont_ attach fences to all >>> involved buffers >> That's not going to work beca

Re: [PATCH libdrm 1/9] amdgpu: Pass file descriptor directly to amdgpu_close_kms_handle

2019-06-28 Thread Emil Velikov
On Mon, 24 Jun 2019 at 17:54, Michel Dänzer wrote: > > From: Michel Dänzer > > And propagate drmIoctl's return value. > > This allows replacing all remaining open-coded DRM_IOCTL_GEM_CLOSE > ioctl calls with amdgpu_close_kms_handle calls. > > Signed-off-by: Michel Dänzer > --- > amdgpu/amdgpu_b

Re: [PATCH v3 00/22] Associate ddc adapters with connectors

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 06:01:14PM +0200, Andrzej Pietrasiewicz wrote: > It is difficult for a user to know which of the i2c adapters is for which > drm connector. This series addresses this problem. > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > > ls -l /sys/clas

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 5:21 PM Koenig, Christian wrote: > > Am 28.06.19 um 16:38 schrieb Daniel Vetter: > [SNIP] > > - when you submit command buffers, you _dont_ attach fences to all > > involved buffers > That's not going to work because then the memory management then thinks > >>>

[PATCH v3 07/22] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 5d6a9f

[PATCH v3 22/22] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/radeon/radeon_connectors.c | 82 +- 1 file changed, 63 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/ra

[PATCH v3 05/22] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c index 07b4cb877d82.

[PATCH v3 12/22] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_hdmi.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/drm/zte/zx_hdmi.c index bfe918b

[PATCH v3 18/22] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-

[PATCH v3 00/22] Associate ddc adapters with connectors

2019-06-28 Thread Andrzej Pietrasiewicz
It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have a symbolic link in connector's sysfs directory, e.g.: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0

[PATCH v3 06/22] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sun4i/sun4i_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 14 +++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hd

[PATCH v3 11/22] drm/vc4: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/vc4/vc4_hdmi.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 87ad0879edf3..

[PATCH v3 09/22] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-ldb.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index 383733302280..44fdb2

[PATCH v3 20/22] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/ti-tfp410.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c ind

[PATCH v3 03/22] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_h

[PATCH v3 08/22] drm/tegra: Provide ddc symlink in output connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tegra/drm.h| 1 - drivers/gpu/drm/tegra/output.c | 12 ++-- drivers/gpu/drm/tegra/sor.c| 6 +++--- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/dri

[PATCH v3 10/22] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-tve.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index e725af8a0025..b8bee4e1f169

[PATCH v3 04/22] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/inno_hdmi.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c

[PATCH v3 14/22] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c index 62d014c20988..c373edb9

[PATCH v3 16/22] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mgag200/mgag200_mode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index a25054015e8c..a22dbecd

[PATCH v3 21/22] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 70 ++- 1 file changed, 51 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/dr

[PATCH v3 01/22] drm: Include ddc adapter pointer in struct drm_connector

2019-06-28 Thread Andrzej Pietrasiewicz
Add generic code which creates symbolic links in sysfs, pointing to ddc interface used by a particular video output. For example: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ -> ../../../../soc/1388.i2c/i2c-2 This ma

[PATCH v3 13/22] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_vga.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm/zte/zx_vga.c index 1634a08707

[PATCH v3 15/22] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index f03d617edc4c..c5e6c33ff2cd 100644 --- a/drivers

[PATCH v3 19/22] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bri

[PATCH v3 17/22] drm/ast: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/ast/ast_mode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index ffccbef962a4..155c3487a1a7 100644 --- a/drivers

[PATCH v3 02/22] drm/exynos: Provide ddc symlink in connector's sysfs

2019-06-28 Thread Andrzej Pietrasiewicz
Switch to using the ddc provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c in

Re: [PATCH v3 00/22] Associate ddc adapters with connectors

2019-06-28 Thread Laurent Pinchart
Hi Andrzej, Just FYI, I have a patch series that reworks how bridges and connectors are handled, and it will heavily conflict with this. The purpose of the two series isn't the same, so both make sense. I will post the patches this weekend, and will then review this series in that context. Hopeful

Re: [PATCH][next] drm/amdgpu/mes10.1: fix duplicated assignment to adev->mes.ucode_fw_version

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 11:05:39 AM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; Xiao, Jack; Zhang, Hawking; amd-gfx@lists.freedesktop.org; dri

Re: [PATCH][next] drm/amd/powerplay: remove a less than zero uint32_t check

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 11:28:04 AM To: Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesktop.org; dri-de...@

Re: [PATCH][next] drm/amd/powerplay: fix out of memory check on od8_settings

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 11:13:54 AM To: Wang, Kevin(Yang); Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesk

[PATCH][next] drm/amd/powerplay: remove a less than zero uint32_t check

2019-06-28 Thread Colin King
From: Colin Ian King The check to see if the uint32_t variable 'size' is less than zero is redundant as it is unsigned and can never be less than zero. Remove this redundant check. Addresses-Coverity: ("Unsigned compared to zero") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/powerplay

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-06-28 Thread Christian König
Am 28.06.19 um 16:30 schrieb Chunming Zhou: 在 2019/6/28 20:18, Christian König 写道: This allows us to update page tables directly while in a page fault. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c |

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Koenig, Christian
Am 28.06.19 um 16:38 schrieb Daniel Vetter: [SNIP] > - when you submit command buffers, you _dont_ attach fences to all > involved buffers That's not going to work because then the memory management then thinks that the buffer is immediately movable, which it isn't, >>> I guess we

Re: [PATCH] drm/amd/powerplay: fix incorrect assignments to mclk_mask and soc_mask

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:45:17 AM To: Wang, Kevin(Yang); Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesk

Re: [PATCH] drm/amd/powerplay: fix off-by-one array bounds check

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:24:02 AM To: Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesktop.org; dri-de...@

[PATCH][next] drm/amd/powerplay: fix out of memory check on od8_settings

2019-06-28 Thread Colin King
From: Colin Ian King The null pointer check on od8_settings is currently the opposite of what it is intended to do. Fix this by adding in the missing ! operator. Addressed-Coverity: ("Resource leak") Fixes: 0c83d32c565c ("drm/amd/powerplay: simplified od_settings for each asic") Signed-off-by: C

Re: [PATCH][next] drm/amdkfd: fix a missing break in a switch statement

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:54:43 AM To: Cox, Philip; Oded Gabbay; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; dri-de...@lists.freedesktop.org; amd

Re: [PATCH][next] drm/amdgpu: fix off-by-one comparison on a WARN_ON message

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:08:01 AM To: Zhang, Hawking; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesktop.org; dri-de...@lists

Re: [PATCH] drm/amdgpu: fix a missing break in a switch statement

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:33:20 AM To: Zhang, Hawking; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesktop.org; dri-de...@lists

[PATCH][next] drm/amdgpu/mes10.1: fix duplicated assignment to adev->mes.ucode_fw_version

2019-06-28 Thread Colin King
From: Colin Ian King Currently adev->mes.ucode_fw_version is being assigned twice with different values. This looks like a cut-n-paste error and instead the second assignment should be adev->mes.data_fw_version. Fix this. Addresses-Coverity: ("Unused value") Fixes: 298d05460cc4 ("drm/amdgpu/mes1

[PATCH] drm/amdgpu: fix a missing break in a switch statement

2019-06-28 Thread Colin King
From: Colin Ian King Currently for the AMDGPU_IRQ_STATE_DISABLE there is a missing break causing the code to fall through to the AMDGPU_IRQ_STATE_ENABLE case. Fix this by adding in the missing break statement. Addresses-Coverity: ("Missing break in switch") Fixes: a644d85a5cd4 ("drm/amdgpu: add

[PATCH][next] drm/amdkfd: fix a missing break in a switch statement

2019-06-28 Thread Colin King
From: Colin Ian King Currently for the CHIP_RAVEN case there is a missing break causing the code to fall through to the new CHIP_NAVI10 case. Fix this by adding in the missing break statement. Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)") Signed-off-by: Colin Ian King -

[PATCH] drm/amd/powerplay: fix incorrect assignments to mclk_mask and soc_mask

2019-06-28 Thread Colin King
From: Colin Ian King There are null pointer checks on mlck_mask and soc_mask however the sclk_mask is being used in assignments in what looks to be a cut-n-paste coding error. Fix this by using the correct pointers in the assignments. Addresses-Coverity: ("Dereference after null check") Fixes: 2

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 12:24 PM Koenig, Christian wrote: > > Am 28.06.19 um 11:41 schrieb Daniel Vetter: > > On Fri, Jun 28, 2019 at 10:40 AM Christian König > > wrote: > >> Am 28.06.19 um 09:30 schrieb Daniel Vetter: > >>> On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian > >>> wrote: > A

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-06-28 Thread Chunming Zhou
在 2019/6/28 20:18, Christian König 写道: > This allows us to update page tables directly while in a page fault. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5 > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c | 4 +++ > drivers/gpu/drm/amd/amdgpu/

[PATCH] drm/amd/powerplay: fix off-by-one array bounds check

2019-06-28 Thread Colin King
From: Colin Ian King The array bounds check for index is currently off-by-one and should be using >= rather than > on the upper bound. Fix this. Addresses-Coverity: ("Out-of-bounds read") Fixes: b3490673f905 ("drm/amd/powerplay: introduce the navi10 pptable implementation") Signed-off-by: Colin

[PATCH][next] drm/amdgpu: fix off-by-one comparison on a WARN_ON message

2019-06-28 Thread Colin King
From: Colin Ian King The WARN_ON is currently throwing a warning when i is 65 or higher which is off by one. It should be 64 or higher (64 queues from 0..63 inclusive), so fix this off-by-one comparison. Fixes: 849aca9f9c03 ("drm/amdgpu: Move common code to amdgpu_gfx.c") Signed-off-by: Colin Ia

Re: [PATCH] drm/amdgpu: Don't skip display settings in hwmgr_resume()

2019-06-28 Thread Alex Deucher
On Thu, Jun 20, 2019 at 7:22 PM Lyude Paul wrote: > > I'm not entirely sure why this is, but for some reason: > > 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on > needed") > > Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the > pre-production laptops

Re: [PATCH] drm/amd/powerplay: use hardware fan control if no powerplay fan table

2019-06-28 Thread Abramov, Slava
Tested-by: Slava Abramov Acked-by: Slava Abramov From: amd-gfx on behalf of Evan Quan Sent: Thursday, June 27, 2019 11:15:29 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: use hardware fan control if no powerplay fan

Re: [PATCH] drm/amd/powerplay: use hardware fan control if no powerplay fan table

2019-06-28 Thread Alex Deucher
On Thu, Jun 27, 2019 at 11:15 PM Evan Quan wrote: > > Use SMC default fan table if no external powerplay fan table. Maybe add a line saying you may get errors if the table is empty and you try and use it. With that, Reviewed-by: Alex Deucher > > Change-Id: Icd7467a7fc5287a92945ba0fcc19699192b1

Re: [PATCH] drm/amdgpu: fix MGPU fan boost enablement for XGMI reset

2019-06-28 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, June 27, 2019 11:31 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amdgpu: fix MGPU fan boost enablement for XGMI reset MGPU fan boost feature should not b

[PATCH 2/5] drm/amdgpu: allow direct submission of PDE updates.

2019-06-28 Thread Christian König
For handling PDE updates directly in the fault handler. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH 5/5] drm/amdgpu: add graceful VM fault handling

2019-06-28 Thread Christian König
Next step towards HMM support. For now just silence the retry fault and optionally redirect the request to the dummy page. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 59 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 + drivers/gpu/drm/amd

[PATCH 3/5] drm/amdgpu: allow direct submission of PTE updates

2019-06-28 Thread Christian König
For handling PTE updates directly in the fault handler. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm

[PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-06-28 Thread Christian König
This allows us to update page tables directly while in a page fault. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c | 4 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 29 + 3 files cha

[PATCH 4/5] drm/amdgpu: allow direct submission of clears

2019-06-28 Thread Christian König
For handling PD/PT clears directly in the fault handler. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm

Re: [PATCH v3] drm/amdgpu: fix scheduler timeout calc

2019-06-28 Thread Christian König
Am 28.06.19 um 11:23 schrieb Cui, Flora: scheduler timeout is in jiffies v2: move timeout check to amdgpu_device_get_job_timeout_settings after parsing the value v3: add lockup_timeout param check. 0: keep default value. negative: infinity timeout. Change-Id: I26708c163db943ff8d930dd81bcab4b4b9d

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Koenig, Christian
Am 28.06.19 um 11:41 schrieb Daniel Vetter: > On Fri, Jun 28, 2019 at 10:40 AM Christian König > wrote: >> Am 28.06.19 um 09:30 schrieb Daniel Vetter: >>> On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian >>> wrote: Am 27.06.19 um 21:57 schrieb Daniel Vetter: > [SNIP] >>> Well yeah you h

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 10:40 AM Christian König wrote: > > Am 28.06.19 um 09:30 schrieb Daniel Vetter: > > On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian > > wrote: > >> Am 27.06.19 um 21:57 schrieb Daniel Vetter: > >>> [SNIP] > Again, the reason to remove the fence from one reservation

[PATCH v3] drm/amdgpu: fix scheduler timeout calc

2019-06-28 Thread Cui, Flora
scheduler timeout is in jiffies v2: move timeout check to amdgpu_device_get_job_timeout_settings after parsing the value v3: add lockup_timeout param check. 0: keep default value. negative: infinity timeout. Change-Id: I26708c163db943ff8d930dd81bcab4b4b9d84eb2 Signed-off-by: Flora Cui --- driver

[PATCH v3 08/18] drm/ttm: use gem vma_node

2019-06-28 Thread Gerd Hoffmann
Drop vma_node from ttm_buffer_object, use the gem struct (base.vma_node) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/qxl/qxl_object.h | 2 +- drivers/gpu/drm/radeon/radeon_object.h | 2 +-

[PATCH v3 12/18] drm/radeon: switch driver from bo->resv to bo->base.resv

2019-06-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_benchmark.c | 4 ++-- drivers/gpu/drm/radeon/radeon_cs.c| 2 +- drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 6 +++--- drivers/gpu/drm/radeon/radeo

[PATCH v3 04/18] drm/radeon: use embedded gem object

2019-06-28 Thread Gerd Hoffmann
Drop drm_gem_object from radeon_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon.h | 3 +-- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- drivers/gpu/drm/radeon/radeon_display.

[PATCH v3 14/18] drm/amdgpu: switch driver from bo->resv to bo->base.resv

2019-06-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- drivers/gp

[PATCH v3 05/18] drm/amdgpu: use embedded gem object

2019-06-28 Thread Gerd Hoffmann
Drop drm_gem_object from amdgpu_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Christian König
Am 28.06.19 um 09:30 schrieb Daniel Vetter: On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian wrote: Am 27.06.19 um 21:57 schrieb Daniel Vetter: [SNIP] Again, the reason to remove the fence from one reservation object is simply that it is faster to remove it from one object than to attach a n

XDC 2019: 10 days left to submit your talks!

2019-06-28 Thread Mark Filion
Hello! Onlyh 10 days to go to submit your talks, workshops or demos for this year's X.Org Developer Conference, which will be taking place in beautiful Montréal, Canada on October 2-4, 2019! Whether it's the Linux kernel, Mesa, DRM, Wayland or X11, if it's related to the Open Source graphics stac

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian wrote: > Am 27.06.19 um 21:57 schrieb Daniel Vetter: > > [SNIP] > >> Again, the reason to remove the fence from one reservation object is > >> simply that it is faster to remove it from one object than to attach a > >> new fence to all other object

Re: [PATCH] drm/amd/powerplay: update smu11_driver_if_navi10.h

2019-06-28 Thread Yin, Tianci (Rico)
Thanks Alex! From: Deucher, Alexander Sent: Thursday, June 27, 2019 23:38 To: Yin, Tianci (Rico); amd-gfx@lists.freedesktop.org Cc: Xiao, Jack; Zhang, Hawking Subject: Re: [PATCH] drm/amd/powerplay: update smu11_driver_if_navi10.h Acked-by: Alex Deucher __