RE: [PATCH 1/2] amd/amdgpu/sriov enable onevf mode for ARCTURUS VF

2019-12-26 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] >-Original Message- >From: Zhang, Jack (Jian) >Sent: Friday, December 27, 2019 3:00 PM >To: Feng, Kenneth ; Deucher, Alexander >; Quan, Evan ; Wang, >Kevin(Yang) ; Tao, Yintian ; >Deng, Emily ; Min, Frank ; Liu, >Monk ;

RE: [PATCH 1/2] amd/amdgpu/sriov enable onevf mode for ARCTURUS VF

2019-12-26 Thread Zhang, Jack (Jian)
Hi, all, Here is some description about sriov and pp_one_vf mode: 1) amdgpu_sriov_vf marks if it is sriov or bare-metal. While amdgpu_sriov_is_pp_one_vf is a mode of sriov- It means there is only one VF generated by host driver. 2) Host administrator can determine “vf number” when

RE: [PATCH 1/2] amd/amdgpu/sriov enable onevf mode for ARCTURUS VF

2019-12-26 Thread Zhang, Jack (Jian)
-Original Message- From: Jack Zhang Sent: Friday, December 27, 2019 2:57 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) Subject: [PATCH 1/2] amd/amdgpu/sriov enable onevf mode for ARCTURUS VF Before, initialization of smu ip block would be skipped for sriov ASICs. But

RE: [PATCH 2/2] amd/amdgpu/sriov use resume for smc recover under sriov

2019-12-26 Thread Zhang, Jack (Jian)
-Original Message- From: Jack Zhang Sent: Friday, December 27, 2019 2:57 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) Subject: [PATCH 2/2] amd/amdgpu/sriov use resume for smc recover under sriov Under sriov and pp_onevf mode, 1.take resume function for smc recover to

Re: Warning: check cp_fw_version and update it to realize GRBM requires 1-cycle delay in cp firmware

2019-12-26 Thread Alex Deucher
On Thu, Dec 26, 2019 at 5:11 AM Paul Menzel wrote: > > Dear Chang, Christian, and Alex, > > > With Linux 5.5-rc3 I am seeing the warning and null pointer dereference > below. Are those related? They are not related. > > > [ 13.406253] [drm] amdgpu kernel modesetting enabled. > > [

Re: [PATCH] drm/amdgpu/powerplay: fix NULL pointer issue when SMU disabled

2019-12-26 Thread Huang Rui
On Thu, Dec 26, 2019 at 01:06:33PM +0800, Likun Gao wrote: > From: Likun Gao > > Fix smu related NULL pointer issue which occurs when SMU is disabled. > > Signed-off-by: Likun Gao Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 12 +--- > 1 file changed,

Re: [PATCH] drm/dp_mst: Avoid NULL pointer dereference

2019-12-26 Thread Lipski, Mikita
[AMD Official Use Only - Internal Distribution Only] Thanks for the catch, Reviewed-by: Mikita Lipski From: Wayne Lin Sent: Wednesday, December 25, 2019 9:31 PM To: dri-de...@lists.freedesktop.org ; amd-gfx@lists.freedesktop.org Cc: ly...@redhat.com ; Kazlauskas, Nicholas ; Wentland,

[PATCH] drm/radeon: remove three set but not used variable

2019-12-26 Thread yu kuai
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/radeon/radeon_atombios.c: In function ‘radeon_get_atom_connector_info_from_object_table’: drivers/gpu/drm/radeon/radeon_atombios.c:651:26: warning: variable ‘grph_obj_num’ set but not used [-Wunused-but-set-variable]

Warning: check cp_fw_version and update it to realize GRBM requires 1-cycle delay in cp firmware

2019-12-26 Thread Paul Menzel
Dear Chang, Christian, and Alex, With Linux 5.5-rc3 I am seeing the warning and null pointer dereference below. Are those related? [ 13.406253] [drm] amdgpu kernel modesetting enabled. [ 13.406294] checking generic (7fe000 30) vs hw (7fe000 1000) [ 13.406294] fb0:

[PATCH 2/2] drm/amdgpu: avoid unnecessary SMC firmware reloading

2019-12-26 Thread Evan Quan
E.g. During non-RAS baco reset, the SMC is still alive. Thus there is no need to reload the SMC firmware. Change-Id: I73f6284541d0ca0e82761380a27e32484fb0061c Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH 1/2] drm/amdgpu: handle mp1 state properly on suspend or device removal

2019-12-26 Thread Evan Quan
Set mp1 state properly for non gpu reset cases. Change-Id: I2a007910da6b5e2d1f8915d17827621ebd2e8c59 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 16 ++-- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c |

RE: [PATCH] drm/amd/powerplay free driver_pptable for smu reinit

2019-12-26 Thread Quan, Evan
As I know, the smu hw reinit is not on the path of gpu recover. Can you help me understand the use case? Regards, Evan > -Original Message- > From: Zhang, Jack (Jian) > Sent: Thursday, December 26, 2019 10:58 AM > To: Wang, Kevin(Yang) ; Feng, Kenneth > ; Quan, Evan ; Zhang, Jack >