[AMD Official Use Only - Internal Distribution Only]
Patch2 is reviewed-by: Evan Quan
Others from the series are acked-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Friday, May 8, 2020 12:08 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only]
Acked-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, May 6, 2020 12:42 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu: implement soft_recovery for
On 5/7/2020 9:21 PM, Alex Deucher wrote:
On Thu, May 7, 2020 at 4:15 PM Nirmoy Das wrote:
Create sysfs file using attributes when possible.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 36 +++
Reviewed-by: Alex Deucher
for the amdgpu_device.c changes.
On Thu, May 7, 2020 at 4:15 PM Nirmoy Das wrote:
>
> Create sysfs file using attributes when possible.
>
> Signed-off-by: Nirmoy Das
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 36 +++
Reviewed-by: Alex Deucher
for the amdgpu_device.c changes. For amdgpu_pm.c, I think Kevin has
Create sysfs file using attributes when possible.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 36 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 114 +++--
2 files changed, 48 insertions(+), 102 deletions(-)
diff --git
Applied. Thanks!
Alex
On Thu, May 7, 2020 at 2:45 AM Christian König
wrote:
>
> Am 07.05.20 um 04:02 schrieb Chunming Zhou:
> > Glad to spend time on kernel driver in past years.
> > I've moved to new focus in umd and couldn't commit
> > enough time to discussions.
> >
> > Signed-off-by:
On Thu, May 7, 2020 at 3:36 PM D Marinus wrote:
>
> Hi!
>
> Since I've updated the linux kernel to 5.6 my builtin display of my
> Apple Macbook Pro 13,3 is blank. The following bug reports have been
> opened:
>
> https://github.com/Dunedan/mbp-2016-linux/issues/142
>
Applied. Thanks!
Alex
On Thu, May 7, 2020 at 11:27 AM Chen Zhou wrote:
>
> Remove duplicate headers which are included twice.
>
> Signed-off-by: Chen Zhou
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
On Thu, May 7, 2020 at 9:35 AM ChenTao wrote:
>
> Fix the following warning:
>
> 'en' is uint32_t and can never be negative.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_hpd.c:132:10: warning:
> comparison of unsigned expression < 0 is always false [-Wtype-limits]
> if ((en <
Hi!
Since I've updated the linux kernel to 5.6 my builtin display of my
Apple Macbook Pro 13,3 is blank. The following bug reports have been
opened:
https://github.com/Dunedan/mbp-2016-linux/issues/142
https://bugzilla.kernel.org/show_bug.cgi?id=207589
Applied thanks!
Alex
On Thu, May 7, 2020 at 9:35 AM Jason Yan wrote:
>
> Fix the following coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c:3216:16-22:
> Unneeded variable: "result". Return "DC_OK" on line 3229
>
> Signed-off-by: Jason Yan
> ---
>
On Thu, May 7, 2020 at 5:22 AM Christian König wrote:
>
> Am 07.05.20 um 11:13 schrieb Bernard Zhao:
> > There is DEVICE_ATTR mechanism in separate attribute define.
> > So this change is to use attr array, also use
> > sysfs_create_files in init function & sysfs_remove_files in
> > fini
[AMD Public Use]
Series is:
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Kent Russell
Sent: Thursday, May 7, 2020 2:54 PM
To: amd-gfx@lists.freedesktop.org
Cc: Russell, Kent
Subject: [PATCH 2/2] Revert "drm/amdgpu: Add ReadSerial defines for
This reverts commit b3abbca4eca6091e0e657baf9a5402e204e97d4c.
SMU does not support this on Arcturus right now
Signed-off-by: Kent Russell
Change-Id: Ia5f29f91a64005f68dbb9499b43789fe473cd00c
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 10 --
1 file changed, 10 deletions(-)
diff
This reverts commit a0d4939d8616fab676699dab8ba3cbe519d4a8e9.
SMU does not support this on Arcturus right now
Signed-off-by: Kent Russell
Change-Id: I50efa3695570302231986d56c2351aac331726ca
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 --
Hi Emil.
On Thu, May 07, 2020 at 04:07:52PM +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> The driver does not hold struct_mutex, thus using the locked version of
> the helper is incorrect.
>
> Cc: Alex Deucher
> Cc: Christian König
> Cc: amd-gfx@lists.freedesktop.org
> Fixes:
It applies on top of Alex's amd-staging-drm-next-branch.
It is essentially just a revert to the old behavior with
acrtc_state->active_planes == 0 special case you added on top and some
small refactoring.
The only remaining bits that are kind of questionable is the
VUPDATE_NO_LOCK vs VUPDATE
Looking over it now, will do some testing. Alex amdgpu-drm-next branch
would be the best to test this?
It looks like a revert of the whole vstartup series, except for that one
if(acrtc_state->active_planes == 0) special case, so i expect it should be
fine?
thanks,
-mario
On Thu, May 7, 2020
On 2020-05-07 4:27 p.m., Sasha Levin wrote:
> From: Marek Olšák
>
> [ Upstream commit 9017a4897a20658f010bebea825262963c10afa6 ]
>
> This fixes GPU hangs due to cache coherency issues.
> Bump the driver version. Split out from the original patch.
>
> Signed-off-by: Marek Olšák
> Reviewed-by:
Ping?
On Tue, May 5, 2020 at 12:42 PM Alex Deucher wrote:
>
> Same as gfx9. This allows us to kill the waves for hung
> shaders.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git
Ping?
On Tue, May 5, 2020 at 3:48 PM Alex Deucher wrote:
>
> Just register the a pointer to the backlight device and use
> that. Unifies the DC and non-DC handling.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 73 ++--
> 1 file changed,
The pci core handles this for us in pci_pm_init.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index c7f42ff6ab5e..233d6c8c4ca3 100644
We should be checking whether the driver enabled runtime pm
rather than whether the asic supports BOCO or BACO. That said
in general they are equivalent unless the user has disabled
runpm or it has been disabled for a specific asic.
Signed-off-by: Alex Deucher
---
We only need to set DPM_FLAG_NEVER_SKIP for the legacy ATPX
BOCO case. D3cold and BACO work as expected.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
The core handles this for us.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index ea2b4254d30c..5407edeeccc2 100644
---
On 2020-05-06 3:47 p.m., Nicholas Kazlauskas wrote:
[Why]
We're the drm vblank event a frame too early in the case where the
^sending
Thanks for catching this!
Reviewed-by: Leo Li
pageflip happens close to VUPDATE and ends up blocking the signal.
The implementation in DM was
Remove duplicate headers which are included twice.
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index
[AMD Public Use]
[AMD Public Use]
Indeed. I was trying to keep it all in there anyways to make less churn, but I
can remove it altogether, including the definitions that aren't supported. I
was informed that it wasn't supported nor working correctly, so I'll revert
both patches (definitions
From: Emil Velikov
The driver does not hold struct_mutex, thus using the locked version of
the helper is incorrect.
Cc: Alex Deucher
Cc: Christian König
Cc: amd-gfx@lists.freedesktop.org
Fixes: a39414716ca0 ("drm/amdgpu: add independent DMA-buf import v9"):
Signed-off-by: Emil Velikov
---
[AMD Public Use]
Shouldn't all of this code be moved later anyway to make sure the SMU is up and
running already?
Alex
From: amd-gfx on behalf of Kent Russell
Sent: Thursday, May 7, 2020 9:53 AM
To: amd-gfx@lists.freedesktop.org
Cc: Russell, Kent
Subject:
From: Dmytro Laktyushkin
[ Upstream commit 3159d41db3a04330c31ece32f8b29752fc114848 ]
Check before programming the register since it isn't present on
all IPs using this code.
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Eric Bernstein
Acked-by: Aurabindo Pillai
Signed-off-by: Alex Deucher
From: Tiecheng Zhou
[ Upstream commit 690ae30be163d5262feae01335b2a6f30569e5aa ]
hwmgr->pm_en is initialized at hwmgr_hw_init.
during amdgpu_device_init, there is amdgpu_asic_reset that calls to
soc15_asic_reset (for V320 usecase, Vega10 asic), in which:
1) soc15_asic_reset_method calls to
From: Sung Lee
[ Upstream commit 668a6741f809f2d15d125cfe2b39661e8f1655ea ]
[WHY]
The downspread percentage was copied over from a previous version
of the display_mode_lib spreadsheet. This value has been updated,
and the previous value is too high to allow for such modes as
4K120hz. The new
From: Nicholas Kazlauskas
[ Upstream commit fdfd2a858590d318cfee483bd1c73e00f77533af ]
[Why]
Fixes the following scenario:
- Flip has been prepared sometime during the frame, update pending
- Cursor update happens right when VUPDATE would happen
- OPTC lock acquired, VUPDATE is blocked until
From: Sung Lee
[ Upstream commit 668a6741f809f2d15d125cfe2b39661e8f1655ea ]
[WHY]
The downspread percentage was copied over from a previous version
of the display_mode_lib spreadsheet. This value has been updated,
and the previous value is too high to allow for such modes as
4K120hz. The new
From: Dmytro Laktyushkin
[ Upstream commit 3159d41db3a04330c31ece32f8b29752fc114848 ]
Check before programming the register since it isn't present on
all IPs using this code.
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Eric Bernstein
Acked-by: Aurabindo Pillai
Signed-off-by: Alex Deucher
From: Tiecheng Zhou
[ Upstream commit 690ae30be163d5262feae01335b2a6f30569e5aa ]
hwmgr->pm_en is initialized at hwmgr_hw_init.
during amdgpu_device_init, there is amdgpu_asic_reset that calls to
soc15_asic_reset (for V320 usecase, Vega10 asic), in which:
1) soc15_asic_reset_method calls to
From: Marek Olšák
[ Upstream commit 9017a4897a20658f010bebea825262963c10afa6 ]
This fixes GPU hangs due to cache coherency issues.
Bump the driver version. Split out from the original patch.
Signed-off-by: Marek Olšák
Reviewed-by: Christian König
Tested-by: Pierre-Eric Pelloux-Prayer
From: Xiaodong Yan
[ Upstream commit 718a5569b6fa6e1f49f1ae76a3c18acb4ddb74f1 ]
[Why]
When link loss happened, monitor can not light up if only re-train the
link.
[How]
Blank all the DP streams on this link before re-train the link, and then
unblank the stream
Signed-off-by: Xiaodong Yan
This isn't supported in the SMU yet, so just break early. This can be
reverted once the SMU supports the feature
Signed-off-by: Kent Russell
Change-Id: I09945613aa7400afdf3f9d5dc0ffb636ee2896f7
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 +
1 file changed, 5 insertions(+)
diff
On Wed, May 6, 2020 at 3:48 PM Nicholas Kazlauskas
wrote:
>
> [Why]
> We're the drm vblank event a frame too early in the case where the
> pageflip happens close to VUPDATE and ends up blocking the signal.
>
> The implementation in DM was previously correct *before* we started
> sending vblank
Fix the following warning:
'en' is uint32_t and can never be negative.
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_hpd.c:132:10: warning:
comparison of unsigned expression < 0 is always false [-Wtype-limits]
if ((en < GPIO_DDC_LINE_MIN) || (en > GPIO_DDC_LINE_MAX)) {
There is DEVICE_ATTR mechanism in separate attribute define.
So this change is to use attr array, also use
sysfs_create_files in init function & sysfs_remove_files in
fini function.
This maybe make the code a bit readable.
Signed-off-by: Bernard Zhao
Changes since V1:
*Use DEVICE_ATTR mechanism
Fix the following coccicheck warning:
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c:3216:16-22:
Unneeded variable: "result". Return "DC_OK" on line 3229
Signed-off-by: Jason Yan
---
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 +---
1 file changed, 1 insertion(+), 3
On Thu, May 7, 2020 at 6:26 AM Evan Quan wrote:
>
> BACO is needed to support hibernate on Navi1X.
>
> Change-Id: Ia283612919e9a5b4e1e198ab2cc0bc15f7f94760
> Signed-off-by: Evan Quan
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
>
On Thu, May 7, 2020 at 8:38 AM Tom St Denis wrote:
>
> On my raven1 system (rev c6) with VBIOS 113-RAVEN-114 GFXOFF is
> not stable (resulting in large block tiling noise in some applications).
>
> Disabling GFXOFF via the quirk list fixes the problems for me.
>
> Signed-off-by: Tom St Denis
On my raven1 system (rev c6) with VBIOS 113-RAVEN-114 GFXOFF is
not stable (resulting in large block tiling noise in some applications).
Disabling GFXOFF via the quirk list fixes the problems for me.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++
1 file changed,
BACO is needed to support hibernate on Navi1X.
Change-Id: Ia283612919e9a5b4e1e198ab2cc0bc15f7f94760
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 2 ++
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +-
3 files
the amdgpu device attribute node will be created accordding to sriov vf
mode at runtime.
cleanup unnecessary sriov check in attribute operation function.
Signed-off-by: Kevin Wang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 105 -
1 file changed, 105 deletions(-)
diff
unified amdgpu device attribute node functions:
1. add some helper functions to create amdgpu device attribute node.
2. create device node according to device attr flags on different VF mode.
3. rename some functions name to adapt a new interface.
v2:
1. remove ATTR_STATE_DEAD, ATTR_STATE_ALIVE
[AMD Official Use Only - Internal Distribution Only]
Good catch.
Reviewed-by: Hawking Zhang
Regards,
Hawking
From: Clements, John
Sent: Thursday, May 7, 2020 17:12
To: amd-gfx@lists.freedesktop.org; Zhang, Hawking
Subject: [PATCH] drm/amdgpu: Fix bug in RAS invoke
[AMD Official Use Only -
cleanup unnecessary check in internal swsmu driver:
1. cleanup amdgpu_sriov_is_pp_one_vf() check logic.
2. cleanup amdgpu_sriov_vf() check logic.
3. add sw smu ip block according to different vf mode.
Signed-off-by: Kevin Wang
---
drivers/gpu/drm/amd/amdgpu/nv.c | 29 +++-
the swsmu or powerplay(hwmgr) need to handle task according to different VF
mode,
this function to help query vf mode.
vf mode:
1. SRIOV_VF_MODE_BARE_METAL: the driver work on host OS (PF)
2. SRIOV_VF_MODE_ONE_VF: the driver work on guest OS with one VF
3. SRIOV_VF_MODE_MULTI_VF : the
Am 07.05.20 um 11:13 schrieb Bernard Zhao:
There is DEVICE_ATTR mechanism in separate attribute define.
So this change is to use attr array, also use
sysfs_create_files in init function & sysfs_remove_files in
fini function.
This maybe make the code a bit readable.
Signed-off-by: Bernard Zhao
[AMD Official Use Only - Internal Distribution Only]
Invoke sequence should abort when RAS interrupt is detected before reading TA
host shared memory
0001-drm-amdgpu-Fix-bug-in-RAS-invoke.patch
Description: 0001-drm-amdgpu-Fix-bug-in-RAS-invoke.patch
On Thu, 2020-05-07 at 08:42 +0200, Christian König wrote:
> Am 06.05.20 um 21:01 schrieb Joe Perches:
[]
> > And trivia:
> >
> > The !! uses with bool seem unnecessary and it's probably better
> > to make amdgpu_ras_is_feature_enabled to return bool.
[]
> > diff --git
Am 07.05.20 um 04:02 schrieb Chunming Zhou:
Glad to spend time on kernel driver in past years.
I've moved to new focus in umd and couldn't commit
enough time to discussions.
Signed-off-by: Chunming Zhou
So Long, and Thanks for All the Fish :)
Reviewed-by: Christian König
---
Am 06.05.20 um 21:01 schrieb Joe Perches:
On Tue, 2020-05-05 at 16:01 +0200, Arnd Bergmann wrote:
After the structure was padded to 1024 bytes, it is no longer
suitable for being a local variable, as the function surpasses
the warning limit for 32-bit architectures:
58 matches
Mail list logo
