RE: [PATCH 2/2] drm/amdgpu: add debugfs node to toggle ras error cnt harvest

2020-08-09 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: DennisLi Best Regards Dennis Li -Original Message- From: Chen, Guchun Sent: Monday, August 10, 2020 1:23 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Lazar, Lijo ; Zhou1, Tao ; Clements, John

[PATCH 1/2] drm/amdgpu: bypass querying ras error count registers

2020-08-09 Thread Guchun Chen
Once ras recovery is issued by ras sync flood interrupt or ras controller interrupt, add this guard to bypass or execute ras error count register harvest of all IPs. Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 22 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h

[PATCH 2/2] drm/amdgpu: add debugfs node to toggle ras error cnt harvest

2020-08-09 Thread Guchun Chen
Before ras recovery is issued, user could operate this debugfs node to enable/disable the harvest of all RAS IPs' ras error count registers, which will help keep hardware's registers' status instead of cleaning up them. Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7

RE: [PATCH] drm/amdgpu: update gc golden register for arcturus

2020-08-09 Thread Chen, Guchun
[AMD Public Use] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Zhang, Morris Sent: Monday, August 10, 2020 1:15 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Chen, Guchun Cc: Zhang, Morris Subject: [PATCH] drm/amdgpu: update gc golden register for

[PATCH] drm/amdgpu: update gc golden register for arcturus

2020-08-09 Thread shiwu.zhang
Update golden setting to improve performance on HPC and ML apps Signed-off-by: shiwu.zhang Tested-by: gang.long --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index

RE: [PATCH v2] drm/amdgpu: annotate a false positive recursive locking

2020-08-09 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Dennis Li Sent: Friday, August 7, 2020 15:53 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking ; Koenig, Christian Cc: Li, Dennis Subject: [PATCH v2]

RE: [PATCH] drm/amdgpu: fix reload KMD hang on GFX10 KIQ

2020-08-09 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Emily Deng >-Original Message- >From: amd-gfx On Behalf Of Monk >Liu >Sent: Monday, August 10, 2020 11:59 AM >To: amd-gfx@lists.freedesktop.org >Cc: Liu, Monk >Subject: [PATCH] drm/amdgpu: fix reload KMD hang on GFX10

[PATCH] drm/amdgpu: fix reload KMD hang on GFX10 KIQ

2020-08-09 Thread Monk Liu
GFX10 KIQ will hang if we try below steps: modprobe amdgpu rmmod amdgpu modprobe amdgpu sched_hw_submission=4 Due to KIQ is always living there even after KMD unloaded thus when doing the realod KIQ will crash upon its register being programed by different values with the previous loading (the

Re: [PATCH] gpu/drm: Remove TTM_PL_FLAG_WC of VRAM to fix writecombine issue for Loongson64

2020-08-09 Thread Thomas Bogendoerfer
On Sat, Aug 08, 2020 at 03:25:02PM +0800, Tiezhu Yang wrote: > Loongson processors have a writecombine issue that maybe failed to > write back framebuffer used with ATI Radeon or AMD GPU at times, > after commit 8a08e50cee66 ("drm: Permit video-buffers writecombine > mapping for MIPS"), there

[PATCH] dma-buf.rst: repair length of title underline

2020-08-09 Thread Lukas Bulwahn
With commit 72b6ede73623 ("dma-buf.rst: Document why indefinite fences are a bad idea"), document generation warns: Documentation/driver-api/dma-buf.rst:182: \ WARNING: Title underline too short. Repair length of title underline to remove warning. Fixes: 72b6ede73623 ("dma-buf.rst: Document

Re: [PATCH 12/15] drm/amd/display: Use hw lock mgr

2020-08-09 Thread Brandon Wright
Just curious, but I noticed this new lock manager isn't being used because of the definitive false return value in display/dc/dce/dmub_hw_lock_mgr.c: should_use_dmub_lock. Was this supposed to be enabled? From: Wyatt Wood > > [Why] > Feature requires synchronization of dig, pipe, and cursor

[PATCH] drm: amdgpu: Use the correct size when allocating memory

2020-08-09 Thread Christophe JAILLET
When '*sgt' is allocated, we must allocated 'sizeof(**sgt)' bytes instead of 'sizeof(*sg)'. 'sg' (i.e. struct scatterlist) is smaller than 'sgt' (i.e struct sg_table), so this could lead to memory corruption. Fixes: f44ffd677fb3 ("drm/amdgpu: add support for exporting VRAM using DMA-buf v3")

[PATCH] gpu/drm: Remove TTM_PL_FLAG_WC of VRAM to fix writecombine issue for Loongson64

2020-08-09 Thread Tiezhu Yang
Loongson processors have a writecombine issue that maybe failed to write back framebuffer used with ATI Radeon or AMD GPU at times, after commit 8a08e50cee66 ("drm: Permit video-buffers writecombine mapping for MIPS"), there exists some errors such as blurred screen and lockup, and so on. Remove

Re: [PATCH v2] drm/amd/display: use correct scale for actual_brightness

2020-08-09 Thread Alexander Monakov
On Tue, 4 Aug 2020, Alexander Monakov wrote: > Documentation for sysfs backlight level interface requires that > values in both 'brightness' and 'actual_brightness' files are > interpreted to be in range from 0 to the value given in the > 'max_brightness' file. > > With amdgpu, max_brightness

Re: [PATCH] gpu/drm: Remove TTM_PL_FLAG_WC of VRAM to fix writecombine issue for Loongson64

2020-08-09 Thread Jiaxun Yang
在 2020/8/8 下午9:41, Thomas Bogendoerfer 写道: On Sat, Aug 08, 2020 at 03:25:02PM +0800, Tiezhu Yang wrote: Loongson processors have a writecombine issue that maybe failed to write back framebuffer used with ATI Radeon or AMD GPU at times, after commit 8a08e50cee66 ("drm: Permit video-buffers

Re: [PATCH 2/9] drm/amd/display: Fix incorrect backlight register offset for DCN

2020-08-09 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.8, v5.7.13, v5.4.56, v4.19.137, v4.14.192, v4.9.232, v4.4.232. v5.8: Build OK!

Re: [PATCH 8/9] drm/amd/display: Fix EDID parsing after resume from suspend

2020-08-09 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.8, v5.7.13, v5.4.56, v4.19.137, v4.14.192, v4.9.232, v4.4.232. v5.8: Build OK!

Re: [PATCH 9/9] drm/amd/display: Blank stream before destroying HDCP session

2020-08-09 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.8, v5.7.13, v5.4.56, v4.19.137, v4.14.192, v4.9.232, v4.4.232. v5.8: Build OK!

Re: [PATCH] gpu/drm: Remove TTM_PL_FLAG_WC of VRAM to fix writecombine issue for Loongson64

2020-08-09 Thread Christian König
Am 08.08.20 um 15:50 schrieb Jiaxun Yang: 在 2020/8/8 下午9:41, Thomas Bogendoerfer 写道: On Sat, Aug 08, 2020 at 03:25:02PM +0800, Tiezhu Yang wrote: Loongson processors have a writecombine issue that maybe failed to write back framebuffer used with ATI Radeon or AMD GPU at times, after commit