On 2020-09-17 1:11 p.m., Ramesh Errabolu wrote:
+ if (pdd->qpd.queue_count == 0) {
+ pr_info("%s: Gpu-Id: %d has no active queues for process %d\n",
+ __func__, dev->id, proc->pasid);
pr_debug can be dynamically enabled in dmesg if needed, pr_info
Hi Dave, Daniel,
More new stuff for 5.10.
The following changes since commit 818280d5adf1d80e78f95821815148abe9407e14:
Merge v5.9-rc5 into drm-next (2020-09-14 17:19:11 +0200)
are available in the Git repository at:
git://people.freedesktop.org/~agd5f/linux
To avoid having to create all the device and driver scaffolding we
just manually create and destroy a devres_group.
v2: Rebased
v3: use devres_open/release_group so we can use devm without real
hacks in the driver core or having to create an entire fake bus for
testing drivers. Might want to
On Fri, Sep 18, 2020 at 8:31 PM Matthew Auld
wrote:
>
> On Fri, 18 Sep 2020 at 19:22, Daniel Vetter wrote:
> >
> > On Fri, Sep 18, 2020 at 7:50 PM Matthew Auld
> > wrote:
> > >
> > > On Fri, 18 Sep 2020 at 14:25, Daniel Vetter
> > > wrote:
> > > >
> > > > The big change is device_add so that
Am 2020-09-18 um 1:31 p.m. schrieb Kent Russell:
> Instead of guessing at a sufficient size for the CPU VCRAT, base the
> size on the number of online NUMA nodes.
>
> Signed-off-by: Kent Russell
> Change-Id: I5fb6e60f1410ad696ab78d780d0b40d01a4f829b
Please remove the ChangeId.
> ---
>
On Fri, 18 Sep 2020 at 19:22, Daniel Vetter wrote:
>
> On Fri, Sep 18, 2020 at 7:50 PM Matthew Auld
> wrote:
> >
> > On Fri, 18 Sep 2020 at 14:25, Daniel Vetter wrote:
> > >
> > > The big change is device_add so that device_del can auto-cleanup
> > > devres resources. This allows us to use
On Fri, Sep 18, 2020 at 7:50 PM Matthew Auld
wrote:
>
> On Fri, 18 Sep 2020 at 14:25, Daniel Vetter wrote:
> >
> > The big change is device_add so that device_del can auto-cleanup
> > devres resources. This allows us to use devm_drm_dev_alloc, which
> > removes the last user of drm_dev_init.
> >
[AMD Public Use]
Sorry, I read this yesterday and forgot to reply.
Reviewed-by: Kent Russell
> -Original Message-
> From: amd-gfx On Behalf Of Felix
> Kuehling
> Sent: Thursday, September 17, 2020 12:16 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 1/1] drm/amdgpu: Fix
On Fri, 18 Sep 2020 at 14:25, Daniel Vetter wrote:
>
> The big change is device_add so that device_del can auto-cleanup
> devres resources. This allows us to use devm_drm_dev_alloc, which
> removes the last user of drm_dev_init.
>
> v2: Rebased
>
> v3: use devres_open/release_group so we can use
Instead of guessing at a sufficient size for the CPU VCRAT, base the
size on the number of online NUMA nodes.
Signed-off-by: Kent Russell
Change-Id: I5fb6e60f1410ad696ab78d780d0b40d01a4f829b
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 26 --
1 file changed, 16
On Fri, Sep 18, 2020 at 11:03:12AM -0400, Alex Deucher wrote:
> On Fri, Sep 18, 2020 at 9:25 AM Daniel Vetter wrote:
> >
> > Hi all,
> >
> > These are the leftovers of the leftovers of my initial drmm series to
> > manage drm_device.
> >
> > Changes:
> > - bugfixed i915 selftests
> > - patch from
On 2020-09-17 4:54 a.m., Shirish S wrote:
read/writes to aux_dpcd_* sysfs entries leads to system
reboot or hang.
Hence fix the handling of input data and reporting of errors
appropriately to the user space.
Signed-off-by: Shirish S
Reviewed-by: Harry Wentland
Harry
---
On Fri, Sep 18, 2020 at 9:25 AM Daniel Vetter wrote:
>
> Hi all,
>
> These are the leftovers of the leftovers of my initial drmm series to
> manage drm_device.
>
> Changes:
> - bugfixed i915 selftests
> - patch from Luben to finalize the admgpu conversion
>
> Alex & i915 maintainers, pls ack for
Hello Eryk Brol,
The patch c44a22b3128d: "drm/amd/display: Add connector to the state
if DSC debugfs is set" from Aug 27, 2020, leads to the following
static checker warning:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:917
amdgpu_check_debugfs_connector_property_change()
Am 18.09.20 um 15:25 schrieb Daniel Vetter:
> We can now also delete drm_dev_init, now that vkms, vgem and i915
> selftests are resolved.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/drm_drv.c | 41 +++---
>
[AMD Public Use]
Re - it came up as warning/error-free. Peculiar
This is not something new. simple grep else in current kernel tree, there will
be bunches of "} else" there.
Regards,
Hawking
e.g.
if (!IS_ERR(dacl) && !IS_ERR(pacl)) {
set_cached_acl(inode, ACL_TYPE_DEFAULT,
You comment was clear enough, I just wanted to explain it inline instead
of referencing the documentation :)
Christian.
Am 18.09.20 um 15:32 schrieb Russell, Kent:
[AMD Public Use]
Thanks for clarifying my ambiguity, Christian. And for sanity, I just ran checkpatch on a
local file with an
[AMD Public Use]
Thanks for clarifying my ambiguity, Christian. And for sanity, I just ran
checkpatch on a local file with an "} else" and it came up as
warning/error-free. Peculiar.
Kent
> -Original Message-
> From: Koenig, Christian
> Sent: Friday, September 18, 2020 8:17 AM
>
We can now also delete drm_dev_init, now that vkms, vgem and i915
selftests are resolved.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_drv.c | 41 +++---
drivers/gpu/drm/drm_internal.h | 1 +
drivers/gpu/drm/drm_managed.c | 13 ---
Just some prep work before we rework the lifetime handling, which
requires replacing all the drm_dev_put in selftests by something else.
v2: Don't go with a static inline, upsets the header tests and
separation.
Reviewed-by: Maarten Lankhorst
Signed-off-by: Daniel Vetter
---
The big change is device_add so that device_del can auto-cleanup
devres resources. This allows us to use devm_drm_dev_alloc, which
removes the last user of drm_dev_init.
v2: Rebased
v3: use devres_open/release_group so we can use devm without real
hacks in the driver core or having to create an
From: Luben Tuikov
Convert to using devm_drm_dev_alloc(),
as drm_dev_init() is going away.
v2: Remove drm_dev_put() since
a) devres doesn't do refcounting, see
Documentation/driver-api/driver-model/devres.rst,
Section 4, paragraph 1; and since
b) devres acts as garbage collector
Hi all,
These are the leftovers of the leftovers of my initial drmm series to
manage drm_device.
Changes:
- bugfixed i915 selftests
- patch from Luben to finalize the admgpu conversion
Alex & i915 maintainers, pls ack for merging this all through
drm-misc-next since otherwise the final patch
Ping?
On Thu, Jul 30, 2020 at 2:16 PM Alex Deucher wrote:
>
> From: Evan Quan
>
> Different mclk dpm policy will be applied based on the VRAM
> width.
>
> Signed-off-by: Evan Quan
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 16 +---
>
Am 18.09.20 um 14:37 schrieb Hawking Zhang:
support both direct and indirect accessor in unified
helper functions.
v2: Retire indirect mmio access via mm_index/data
Signed-off-by: Hawking Zhang
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 23 +++
Switch WREG32/RREG32_PCIE to use indirect reg access
helper for soc15 and onwards
Signed-off-by: Hawking Zhang
Reviewed-by: Alex Deucher
Reviewed-by: Kevin Wang
Reviewed-by: Christian König
Reviewed-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/nv.c| 51
support both direct and indirect accessor in unified
helper functions.
v2: Retire indirect mmio access via mm_index/data
Signed-off-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 23 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
Add helper function in order to remove RREG32/WREG32
in current pcie_rreg/wreg function for soc15 and
onwards adapters.
PCIE_INDEX/DATA pairs are used to access regsiters
outside of mmio bar in the helper functions.
The new helper functions help remove the recursion
of amdgpu_mm_rreg/wreg from
To be more precise you can either use "else" or "} else {", but don't
use "} else" or "else {".
Interesting that checkpatch.pl doesn't complain, I thought that this
would be checked.
Regards,
Christian.
Am 18.09.20 um 14:12 schrieb Russell, Kent:
[AMD Public Use]
It's preferred to have
[AMD Public Use]
Hi Emily,
I can't find the implementation of dce_virtual_pageflip in the patch. Is it
dropped by accident?
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Emily.Deng
Sent: Friday, September 18, 2020 18:13
To: amd-gfx@lists.freedesktop.org
Cc: Deng,
[AMD Public Use]
It's preferred to have braces if the else has a single line:
https://www.kernel.org/doc/html/v4.10/process/coding-style.html#placing-braces-and-spaces
Right above "3.1) Spaces"
Kent
> -Original Message-
> From: amd-gfx On Behalf Of Zhang,
> Hawking
> Sent: Friday,
[AMD Public Use]
> + } else
RE - This should use "} else {". Apart from that looks good to me.
Hi Chris,
Since there is only one line under "else", I dropped the "{}". I thought that
is okay in current kernel coding style and checkpatch.pl also shows no complain.
So you mean you want the
Am 18.09.20 um 11:51 schrieb Hawking Zhang:
support both direct and indirect accessor in unified
helper functions.
v2: Retire indirect mmio access via mm_index/data
Signed-off-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 23 +++
[AMD Official Use Only - Internal Distribution Only]
Hi Hawking,
You are right, my base is not the tip. I have updated now. Please help to
review again.
Best wishes
Emily Deng
>-Original Message-
>From: Emily.Deng
>Sent: Friday, September 18, 2020 6:13 PM
>To:
Always start vblank timer, but only calls vblank function
when vblank is enabled.
This is used to fix the dead lock issue.
When drm_crtc_vblank_off want to disable vblank,
it first get event_lock, and then call hrtimer_cancel,
but hrtimer_cancel want to wait timer handler function finished.
Timer
support both direct and indirect accessor in unified
helper functions.
v2: Retire indirect mmio access via mm_index/data
Signed-off-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 23 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
Switch WREG32/RREG32_PCIE to use indirect reg access
helper for soc15 and onwards
Signed-off-by: Hawking Zhang
Reviewed-by: Alex Deucher
Reviewed-by: Kevin Wang
Reviewed-by: Christian König
Reviewed-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/nv.c| 51
Add helper function in order to remove RREG32/WREG32
in current pcie_rreg/wreg function for soc15 and
onwards adapters.
PCIE_INDEX/DATA pairs are used to access regsiters
outside of mmio bar in the helper functions.
The new helper functions help remove the recursion
of amdgpu_mm_rreg/wreg from
Can some of them be null and others not? Perhaps write that in the comments
somewhere.
Like v1 doesn't have get_fb_location for example.
Regards
//Ernst
Den fre 18 sep. 2020 kl 01:16 skrev Oak Zeng :
> gfxhub functions are now called from function pointers,
> instead of from asic-specific
Thanks, will double check.
Best wishes
Emily Deng
>-Original Message-
>From: Zhang, Hawking
>Sent: Friday, September 18, 2020 4:20 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Cc: Deng, Emily
>Subject: RE: [PATCH 2/2] drm/amdgpu: Fix dead lock issue for vblank
>
>[AMD Public
[AMD Public Use]
+ spin_lock_irqsave(>ddev->event_lock, flags);
Are you sure you used the latest code base? I think recently we already switch
to adev_to_drm(adev).
Could you please double check?
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Emily.Deng
Sent:
Fix the compile warning:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:892:26: warning:
variable ‘stream’ set but not used [-Wunused-but-set-variable]
struct dc_stream_state *stream;
^~
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
Fix the compile warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c:322:27: warning:
variable ‘optc’ set but not used [-Wunused-but-set-variable]
struct timing_generator *optc;
^~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c:641:7:
43 matches
Mail list logo
