[PATCH] drm/amd: move DRM_ERROR log out of the mutex protect area

2020-11-02 Thread Bernard Zhao
In function amdgpu_register_gpu_instance, there is no need to protect DRM_ERROR in mutex mgpu_info.mutex. This change is to make the code to run a bit fast. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 2/3] drm/amdgpu: enabled software IH ring for Vega

2020-11-02 Thread Christian König
Seems like we won't get the hardware IH1/2 rings on Vega20 working. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c index 407c6093

[PATCH 1/3] drm/amdgpu: add infrastructure for soft IH ring

2020-11-02 Thread Christian König
Add a soft IH ring implementation similar to the hardware IH1/2. This can be used if the hardware delegation of interrupts to IH1/2 doesn't work for some reason. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 29 drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 3/3] drm/amdgpu: make sure retry faults are handled in a work item on Vega

2020-11-02 Thread Christian König
Looks like we can't enabled the IH1/IH2 feature for Vega20, make sure retry faults are handled on a separate ring anyway. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 31 --- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/driv

amdgpu kernel stacktrace on 5.10-rc2 on Ryzen 5 4500U

2020-11-02 Thread John Gilmore
I'm testing the mainline 5.10-rc2 kernel on my Lenovo Ideapad Flex 5 14" (AMD Ryzen 5 4500U). There have been bugs in Linux support for changing the screen brightness even in the stock Ubuntu kernels. There are still bugs in -rc2, but I also noticed a stack trace in dmesg, so I thought I would le

[PATCH] drm/amd: fix typoes

2020-11-02 Thread Bernard Zhao
Fix typoes. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c index 2c6db379afae..e994d233aa21 1

[PATCH -next] drm/amd/pm: remove unused variable

2020-11-02 Thread Zou Wei
Fix variable set but not used compilation warning: ./vangogh_ppt.c:397:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int ret = 0; ^~~ Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 -- 1 file changed, 2

[PATCH][next] drm/amdgpu: fix spelling mistake: "Successed" -> "Succeeded"

2020-11-02 Thread Colin King
From: Colin Ian King There is a spelling mistake in a deb_dbg message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/

Re: [PATCH] drm/amd: move DRM_ERROR log out of the mutex protect area

2020-11-02 Thread Christian König
Am 02.11.20 um 04:14 schrieb Bernard Zhao: In function amdgpu_register_gpu_instance, there is no need to protect DRM_ERROR in mutex mgpu_info.mutex. This change is to make the code to run a bit fast. NAK, performance for an error path in module load is pretty much irrelevant. This just looks l

Re: [PATCH] drm/amdgpu: replace ih ip block for vega20 and arcturus

2020-11-02 Thread Deucher, Alexander
[AMD Public Use] It might be cleaner to just split out vega20 into a separate switch case in that function. Alex From: amd-gfx on behalf of Alex Sierra Sent: Friday, October 30, 2020 11:06 PM To: amd-gfx@lists.freedesktop.org Cc: Sierra Guiza, Alejandro (Ale

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-02 Thread Deucher, Alexander
[AMD Public Use] That's the IP discovery table. The Object header is part of atombios. Do you have an vbios image from that system? Alex From: Yin, Tianci (Rico) Sent: Sunday, November 1, 2020 10:46 PM To: Deucher, Alexander ; Zhang, Hawking ; amd-gfx@lists

[PATCH] drm/amdgpu: fix off by one in amdgpu_vm_handle_fault

2020-11-02 Thread Christian König
The value is inclusive, not exclusive. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index dc0bc550e42b..fdbe7d4e8b8b 1

[PATCH] amdkfd: Check kvmalloc return before memcpy

2020-11-02 Thread Kent Russell
If we can't kvmalloc the pcrat_image, then we shouldn't memcpy Signed-off-by: Kent Russell Reported-by: kernel test robot --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/am

Re: [PATCH] amdkfd: Check kvmalloc return before memcpy

2020-11-02 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Monday, November 2, 2020 11:27 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] amdkfd: Check kvmalloc return b

Re: [PATCH -next] drm/amd/pm: remove unused variable

2020-11-02 Thread kernel test robot
Hi Zou, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20201102] url: https://github.com/0day-ci/linux/commits/Zou-Wei/drm-amd-pm-remove-unused-variable/20201102-195853 base:b49976d8ef6448e86a7fda6a86f64867942b442d config: x86_64-randconfig-a004

Re: [PATCH] amdkfd: Check kvmalloc return before memcpy

2020-11-02 Thread Felix Kuehling
Am 2020-11-02 um 11:27 a.m. schrieb Kent Russell: > If we can't kvmalloc the pcrat_image, then we shouldn't memcpy > > Signed-off-by: Kent Russell > Reported-by: kernel test robot Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- > 1 file changed, 1 insertion(

[PATCH 2/6] drm/amdgpu/gfx: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 10 +- drivers/gpu/drm/amd/amdgpu/

[PATCH 5/6] drm/amdgpu/amdgpu: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. The patch corrects issues for various amdgpu_*.c files for this driver. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu

[PATCH 3/6] drm/amdgpu/vcn: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.

[PATCH 4/6] drm/amdgpu/nbio: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/nbio_v7

[PATCH 6/6] drm/amdgpu: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. The patch covers various .c files for this driver. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/atom.

[PATCH 1/6] drm/amdgpu/dce: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-02 Thread Alex Deucher
Does everything work as expected if we don't skip DCN in nv_set_ip_blocks? Alex On Mon, Nov 2, 2020 at 10:38 AM Deucher, Alexander wrote: > > [AMD Public Use] > > > That's the IP discovery table. The Object header is part of atombios. Do > you have an vbios image from that system? > > Alex >

Re: [PATCH] drm/amdgpu: fix off by one in amdgpu_vm_handle_fault

2020-11-02 Thread Felix Kuehling
Am 2020-11-02 um 11:23 a.m. schrieb Christian König: > The value is inclusive, not exclusive. > > Signed-off-by: Christian König Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH] drm/amdgpu: fix off by one in amdgpu_vm_handle_fault

2020-11-02 Thread Alex Deucher
On Mon, Nov 2, 2020 at 11:23 AM Christian König wrote: > > The value is inclusive, not exclusive. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > b

[PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Deepak R Varma
Initializing global variable to 0 or NULL is not necessary and should be avoided. Issue reported by checkpatch script as: ERROR: do not initialise globals to 0 (or NULL). Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 46 - drivers/gpu/drm/amd

Re: [PATCH] drm/amdgpu/display: fix warnings when CONFIG_DRM_AMD_DC_DCN is not set

2020-11-02 Thread Alex Deucher
Ping? Alex On Tue, Oct 27, 2020 at 11:04 AM Alex Deucher wrote: > > Properly protect the relevant code with CONFIG_DRM_AMD_DC_DCN. > > Fixes: 0b08c54bb7a3 ("drm/amd/display: Fix the display corruption issue on > Navi10") > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/amdgpu

Re: [PATCH 2/3] drm/amdgpu: enabled software IH ring for Vega

2020-11-02 Thread Alex Deucher
On Mon, Nov 2, 2020 at 6:34 AM Christian König wrote: > > Seems like we won't get the hardware IH1/2 rings on Vega20 working. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdg

Re: [PATCH] drm/amd: fix typoes

2020-11-02 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 2, 2020 at 8:43 AM Bernard Zhao wrote: > > Fix typoes. > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_c

Re: [PATCH 2/3] drm/amdgpu: enabled software IH ring for Vega

2020-11-02 Thread Felix Kuehling
Am 2020-11-02 um 1:53 p.m. schrieb Alex Deucher: > On Mon, Nov 2, 2020 at 6:34 AM Christian König > wrote: >> Seems like we won't get the hardware IH1/2 rings on Vega20 working. >> >> Signed-off-by: Christian König >> --- >> drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 7 +++ >> 1 file changed,

Re: [PATCH][next] drm/amdgpu: fix spelling mistake: "Successed" -> "Succeeded"

2020-11-02 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 2, 2020 at 9:17 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a deb_dbg message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PATCH -next] drm/amd/pm: remove unused variable

2020-11-02 Thread Alex Deucher
On Mon, Nov 2, 2020 at 8:44 AM Zou Wei wrote: > > Fix variable set but not used compilation warning: > > ./vangogh_ppt.c:397:6: warning: variable ‘ret’ set but not used > [-Wunused-but-set-variable] > int ret = 0; > ^~~ > Maybe you have an older version of the code? It's currently used.

RE: [PATCH][next] drm/amdgpu: fix spelling mistake: "Successed" -> "Succeeded"

2020-11-02 Thread Chauhan, Madhav
[AMD Public Use] -Original Message- From: amd-gfx On Behalf Of Colin King Sent: Monday, November 2, 2020 7:47 PM To: Deucher, Alexander ; Koenig, Christian ; David Airlie ; Daniel Vetter ; Dave Airlie ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: kernel-janit...@

RE: [PATCH] drm/amdgpu: fix off by one in amdgpu_vm_handle_fault

2020-11-02 Thread Chauhan, Madhav
[AMD Public Use] -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Monday, November 2, 2020 9:54 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: [PATCH] drm/amdgpu: fix off by one in amdgpu_vm_handle_fault The value is inclusive, not exclusive. Look

Re: [PATCH] drm/amdgpu/display: fix warnings when CONFIG_DRM_AMD_DC_DCN is not set

2020-11-02 Thread Kazlauskas, Nicholas
On 2020-11-02 1:49 p.m., Alex Deucher wrote: Ping? Alex On Tue, Oct 27, 2020 at 11:04 AM Alex Deucher wrote: Properly protect the relevant code with CONFIG_DRM_AMD_DC_DCN. Fixes: 0b08c54bb7a3 ("drm/amd/display: Fix the display corruption issue on Navi10") Signed-off-by: Alex Deucher Rev

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2020-11-02 Thread Kenny Ho
Adding a few more emails from get_maintainer.pl and bumping this thread since there hasn't been any comments so far. Is this too crazy? Am I missing something fundamental? Regards, Kenny On Wed, Oct 7, 2020 at 11:24 AM Kenny Ho wrote: > > This is a skeleton implementation to invite comments a

[PATCH 6/6] drm/amdgpu: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

[PATCH 3/6] drm/amdgpu/jpeg: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

[PATCH 4/6] drm/amdgpu/sdma: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

[PATCH 1/6] drm/amdgpu/vcn: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding style standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo

Re: [PATCH 6/6] drm/amdgpu: improve code indentation and alignment

2020-11-02 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Nov 2, 2020 at 12:44 PM Deepak R Varma wrote: > > General code indentation and alignment changes such as replace spaces > by tabs or align function arguments as per the coding style > guidelines. The patch covers various .c files for this driver. > Issue

[PATCH 2/6] drm/amdgpu/umc: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

[PATCH 5/6] drm/amdgpu/amdgpu: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Alex Deucher
On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: > > Initializing global variable to 0 or NULL is not necessary and should > be avoided. Issue reported by checkpatch script as: > ERROR: do not initialise globals to 0 (or NULL). I agree that this is technically correct, but a lot of people don

Re: [PATCH 6/6] drm/amdgpu: use "*" adjacent to data name

2020-11-02 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Nov 2, 2020 at 2:41 PM Deepak R Varma wrote: > > When declaring pointer data, the "*" symbol should be used adjacent to > the data name as per the coding standards. This resolves following > issues reported by checkpatch script: > ERROR: "foo *

Re: [PATCH 2/3] drm/amdgpu: enabled software IH ring for Vega

2020-11-02 Thread Christian König
Am 02.11.20 um 19:59 schrieb Felix Kuehling: Am 2020-11-02 um 1:53 p.m. schrieb Alex Deucher: On Mon, Nov 2, 2020 at 6:34 AM Christian König wrote: Seems like we won't get the hardware IH1/2 rings on Vega20 working. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c

Re: [PATCH] drm/amd: fix typoes

2020-11-02 Thread Christian König
Am 02.11.20 um 13:57 schrieb Bernard Zhao: Fix typoes. Signed-off-by: Bernard Zhao Acked-by: Christian König --- drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drive

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Christian König
Am 02.11.20 um 20:43 schrieb Alex Deucher: On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: Initializing global variable to 0 or NULL is not necessary and should be avoided. Issue reported by checkpatch script as: ERROR: do not initialise globals to 0 (or NULL). I agree that this is techni

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Greg KH
On Mon, Nov 02, 2020 at 02:43:45PM -0500, Alex Deucher wrote: > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: > > > > Initializing global variable to 0 or NULL is not necessary and should > > be avoided. Issue reported by checkpatch script as: > > ERROR: do not initialise globals to 0 (or N

[PATCH] drm/amdgpu/display: FP fixes for DCN3.x

2020-11-02 Thread Alex Deucher
Add proper FP_START/END handling and adjust Makefiles per previous asics. Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/dc/clk_mgr/Makefile | 13 .../drm/amd/display/dc/dcn30/dcn30_resource.c | 71 +-- drivers/gpu/drm/amd/display/dc/dml/Makefile | 6 +- 3 file

Re: [PATCH 4/4] drm/amdgpu: fold CONFIG_DRM_AMD_DC_DCN3* into CONFIG_DRM_AMD_DC_DCN

2020-11-02 Thread Alex Deucher
On Thu, Oct 29, 2020 at 6:14 PM Nathan Chancellor wrote: > > On Fri, Oct 16, 2020 at 12:50:04PM -0400, Alex Deucher wrote: > > Avoids confusion in configurations. > > > > Signed-off-by: Alex Deucher > > This patch causes a build failure with Fedora's aarch64 config (at > commit 2e3a5bc5feeab1ed21

[PATCH AUTOSEL 5.9 23/35] drm/amd/display: Fixed panic during seamless boot.

2020-11-02 Thread Sasha Levin
From: David Galiffi [ Upstream commit 866e09f0110c6e86071954033e3067975946592a ] [why] get_pixel_clk_frequency_100hz is undefined in clock_source_funcs. [how] set function pointer: ".get_pixel_clk_frequency_100hz = get_pixel_clk_frequency_100hz" Signed-off-by: David Galiffi Reviewed-by: Bhaw

[PATCH AUTOSEL 5.9 25/35] drm/amd/display: adding ddc_gpio_vga_reg_list to ddc reg def'ns

2020-11-02 Thread Sasha Levin
From: Martin Leung [ Upstream commit a1d2afc5dde29a943d32bf92eb0408c9f19541fc ] why: oem-related ddc read/write fails without these regs how: copy from hw_factory_dcn20.c Signed-off-by: Martin Leung Acked-by: Aurabindo Pillai Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../

[PATCH AUTOSEL 5.9 22/35] drm/amdgpu: add DID for navi10 blockchain SKU

2020-11-02 Thread Sasha Levin
From: "Tianci.Yin" [ Upstream commit 8942881144a7365143f196f5eafed24783a424a3 ] Reviewed-by: Alex Deucher Reviewed-by: Guchun Chen Signed-off-by: Tianci.Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion

[PATCH AUTOSEL 5.9 21/35] drm/amdgpu: disable DCN and VCN for navi10 blockchain SKU(v3)

2020-11-02 Thread Sasha Levin
From: "Tianci.Yin" [ Upstream commit a305e7dc5fa86ff9cf6cd2da30215a92d43c9285 ] The blockchain SKU has no display and video support, remove them. Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/nv.c |

[PATCH AUTOSEL 5.8 19/29] drm/amdgpu: add DID for navi10 blockchain SKU

2020-11-02 Thread Sasha Levin
From: "Tianci.Yin" [ Upstream commit 8942881144a7365143f196f5eafed24783a424a3 ] Reviewed-by: Alex Deucher Reviewed-by: Guchun Chen Signed-off-by: Tianci.Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion

[PATCH AUTOSEL 5.4 14/24] drm/amdgpu: add DID for navi10 blockchain SKU

2020-11-02 Thread Sasha Levin
From: "Tianci.Yin" [ Upstream commit 8942881144a7365143f196f5eafed24783a424a3 ] Reviewed-by: Alex Deucher Reviewed-by: Guchun Chen Signed-off-by: Tianci.Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion

[PATCH] drm/amdgpu: Add Fine Grain Clock Gating

2020-11-02 Thread Jinzhou.Su
1.Enable Fine Grain Clock Gating - SRAM(SW control) for Vangogh 2.Add FGCG flags on amdgpu_pm_info debugfs Change-Id: I839a623fcc1a444c880d644035531435c0b0eeb6 Signed-off-by: Jinzhou.Su --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 45 drivers/gpu/drm/amd/amdgpu/nv.c

Re: [PATCH] drm/amdgpu: Add Fine Grain Clock Gating

2020-11-02 Thread Huang Rui
On Tue, Nov 03, 2020 at 10:14:01AM +0800, Su, Jinzhou (Joe) wrote: > 1.Enable Fine Grain Clock Gating - SRAM(SW control) for Vangogh > 2.Add FGCG flags on amdgpu_pm_info debugfs > > Change-Id: I839a623fcc1a444c880d644035531435c0b0eeb6 > Signed-off-by: Jinzhou.Su > --- > drivers/gpu/drm/amd/amdgp

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-02 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Hi Alex, If we don't skip DCN in nv_set_ip_blocks, I find below error, [ 103.949926] [drm:amdgpu_dm_init.cold [amdgpu]] *ERROR* amdgpu: failed to initialize hdcp_workqueue. Thanks! Rico From: Alex Deucher Se

[PATCH] drm/amd/amdgpu: Enable arcturus devices to access the method kgd_gfx_v9_get_cu_occupancy that is already defined

2020-11-02 Thread Ramesh Errabolu
[Why] Allow user to know number of compute units (CU) that are in use at any given moment. [How] Remove the keyword static for the method kgd_gfx_v9_get_cu_occupancy Signed-off-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_a

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2020-11-02 Thread Kenny Ho
Thanks for the reply. Cgroup awareness is desired because the intent is to use this for resource management as well (potentially along with other cgroup controlled resources.) I will dig into bpf_lsm and learn more about it. Regards, Kenny On Tue, Nov 3, 2020 at 12:32 AM Alexei Starovoitov wr

[PATCH] drm/amd/amdgpu: Add checksun check for pf2vf message

2020-11-02 Thread Li, Xin (Justin)
[AMD Official Use Only - Internal Distribution Only] Add checksum checking for pf2vf message Signed-off-by: Li, Xin (Justin) mailto:xin2...@amd.com>> Signed-off-by: Zhou, Tiecheng mailto:thecheng.z...@amd.com>> --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 5 ++--- 1 file changed, 2 insertions

[PATCH] drm/amd/swsmu: correct wrong feature bit mapping

2020-11-02 Thread Kevin Wang
1. when smc feature bit isn't mapped, the feature state isn't showed on sysfs node of pp_features. 2. add pp_features table title Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 27 -- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/

[PATCH] drm/amdgpu: update module paramter doc of amdgpu_dpm

2020-11-02 Thread Kevin Wang
the vega20 isn't supported swsmu. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 03f4aab1fe99..9d28054b8aae 100644 -

Re: [PATCH] drm/amd/swsmu: correct wrong feature bit mapping

2020-11-02 Thread Wang, Kevin(Yang)
sorry, please ignore this patch, the patch has been merged. Best Regards, Kevin From: Wang, Kevin(Yang) Sent: Tuesday, November 3, 2020 1:54 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Wang, Kevin(Yang) Subject: [PATCH] drm/amd/swsmu: correct wrong

[PATCH 3/3] drm/amdgpu: Enable FGCG for Vangogh

2020-11-02 Thread Jinzhou.Su
Add flags AMD_CG_SUPPORT_GFX_FGCG for Vangogh Signed-off-by: Jinzhou.Su Change-Id: I730754a0929368bb35221e586fbfa5bda0af0eaf --- drivers/gpu/drm/amd/amdgpu/nv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index 1f8659a1a4c

[PATCH 1/3] drm/amdgpu: Add GFX Fine Grain Clock Gating flag

2020-11-02 Thread Jinzhou.Su
Add AMD_CG_SUPPORT_GFX_FGCG for FGCG Signed-off-by: Jinzhou.Su Change-Id: I97e10e258e25a60de2604b8a31514421f6819448 --- drivers/gpu/drm/amd/include/amd_shared.h | 1 + drivers/gpu/drm/amd/pm/amdgpu_pm.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/include/amd_s

[PATCH 2/3] drm/amdgpu: Add Fine Grain Clock Gating for GFX10

2020-11-02 Thread Jinzhou.Su
1. Add FGCG for gfx10 2. Get FGCG status for pm info debugfs Change-Id: I4df242c4afb0907706a1aaafb04c89cad2495b13 Signed-off-by: Jinzhou.Su --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 45 ++ 1 file changed, 45 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v1

Re: [PATCH 1/3] drm/amdgpu: Add GFX Fine Grain Clock Gating flag

2020-11-02 Thread Huang Rui
With Kevin's comments addressed (remove change-id), the series are Reviewed-by: Huang Rui On Tue, Nov 03, 2020 at 02:16:19PM +0800, Su, Jinzhou (Joe) wrote: > Add AMD_CG_SUPPORT_GFX_FGCG for FGCG > > Signed-off-by: Jinzhou.Su > Change-Id: I97e10e258e25a60de2604b8a31514421f6819448 > --- > dr

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Christian König
Am 03.11.20 um 07:53 schrieb Greg KH: On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian König wrote: Am 02.11.20 um 20:43 schrieb Alex Deucher: On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: Initializing global variable to 0 or NULL is not necessary and should be avoided. Issue report