RE: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

[AMD Official Use Only] Hi James: With the following patch, an error will be reported when the driver is loaded +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c @@ -1202,6 +1204,9 @@ static int vcn_v1_0_stop(struct amdgpu_device *adev) else r = vcn_v1_0_stop_spg_mode(adev); +

Re: [PATCH 1/2] drm/amd/display: Reduce stack size for dml31_ModeSupportAndSystemConfigurationFull

On 2021-12-11 13:20, Rodrigo Siqueira Jordao wrote: > > > On 2021-12-09 11:46 a.m., Michel Dänzer wrote: >> From: Michel Dänzer >> >> Move code using the Pipe struct to a new helper function. >> >> Works around[0] this warning (resulting in failure to build a RHEL debug >> kernel with Werror ena

RE: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

[AMD Official Use Only] Checked the log paste below with Curry. The way to add this fix in vcn_v1_0_stop is not workable. As it will induce a circle calling(below) and lead to dead lock. VCN ring begin use -> amdgpu_dpm_enable_uvd -> acquire the smu_lock -> smu10_powergate_vcn -> amdgpu_device_i

Re: [PATCH V2] drm/amdgpu: move smu_debug_mask to a more proper place

On 12/13/2021 12:49 PM, Evan Quan wrote: As the smu_context will be invisible from outside(of power). Also, the smu_debug_mask can be shared around all power code instead of some specific framework(swSMU) only. Signed-off-by: Evan Quan Change-Id: I1a0e1a436a51fc520a47b3fb28cde527d4e5eb6e R

RE: [PATCH 3/3] drm/amdkfd: reset queue which consumes RAS poison

[AMD Official Use Only] } else if (source_id == SOC15_INTSRC_SDMA_ECC) { - kfd_signal_poison_consumed_event(dev, pasid); - amdgpu_amdkfd_ras_poison_consumption_handler(dev->adev); + event_interrupt_poison_consumption

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > From: Ira Weiny > > kmap() is being deprecated and these usages are all local to the thread > so there is no reason kmap_local_page() can't be used. > > Replace kmap() calls with kmap_local_page(). > > Signed-off-by: Ira Wei

Re: [PATCH v2 06/10] drm/amd/display: fix function scopes

Hi Isabella, Sorry for the delay. Since this is a large patch, I submitted it to our CI, and I was waiting for the result. Apparently, everything is alright and your patch lgtm. Reviewed-by: Rodrigo Siqueira And applied to amd-staging-drm-next Thanks Siqueira On 2021-12-09 10:47 a.m., Isa

RE: [PATCH V2] drm/amdgpu: move smu_debug_mask to a more proper place

[Public] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Quan, Evan Sent: Monday, December 13, 2021 3:20 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Chen, Guchun ; Lazar, Lijo ; Quan, Evan Subject: [PATCH V2] drm/amdgpu: move smu_debug_mask to a

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > - vaddr = kmap(page); > + vaddr = kmap_local_page(page); > memcpy(vaddr, data, len); > - kunmap(page); > + kunmap_local(vaddr); memcpy_to_page?

RE: DC Patches January 10, 2020

[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Leno

Re: [PATCH 1/2] drm/amd/display: Reduce stack size for dml31_ModeSupportAndSystemConfigurationFull

On 2021-12-13 4:46 a.m., Michel Dänzer wrote: On 2021-12-11 13:20, Rodrigo Siqueira Jordao wrote: On 2021-12-09 11:46 a.m., Michel Dänzer wrote: From: Michel Dänzer Move code using the Pipe struct to a new helper function. Works around[0] this warning (resulting in failure to build a RH

[PATCH] drm/amd/display: Guard debug option for dp_force_sst_set

[Why&How] Debug option for forcing SST mode when using MST capable receivers is guarded under the config option CONFIG_DRM_AMD_DC_DCN. Hence the corresponding code exposing it in debugfs must be guarded as well, to prevent compile errors for non DCN builds. Fixes: ad9601f00 (drm/amd/display: Add D

Re: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

[AMD Official Use Only] +Greg From: Marina Nikolic Sent: Friday, December 10, 2021 4:05 PM To: amd-gfx@lists.freedesktop.org Cc: Nikolic, Marina ; Nikolic, Marina Subject: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

Re: [PATCH] drm/amdgpu: use adev_to_drm to get drm_device pointer

[AMD Official Use Only] Reviewed-by: Alex Deucher From: Chen, Guchun Sent: Sunday, December 12, 2021 11:08 PM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; Yu, Lang Cc: Chen, Guchun Subject: [PATCH] drm/amdgpu: us

[PATCH v2 1/2] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC

This value does not get cached into adev->pm.fw_version during startup for smu13 like it does for other SMU like smu12. Signed-off-by: Mario Limonciello --- v1->v2: * Run on all v13 APU to match v12 behavior drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH v2 2/2] drivers/amd/pm: drop statement to print FW version for smu_v13

Update smu_v13 to match smu_v12 and smu_v11 behavior where this is fetched from debugfs rather than in kernel logs on every boot. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu

RE: [PATCH] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC

[Public] > -Original Message- > From: Chen, Guchun > Sent: Sunday, December 12, 2021 21:36 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Limonciello, Mario > Subject: RE: [PATCH] drm/amd/pm: fix reading SMU FW version from > amdgpu_firmware_info on YC > > [Public] >

Re: [PATCH] drm/amd/display: Guard debug option for dp_force_sst_set

Please disregard this, Jerry already has a fix. On 12/13/21 9:51 AM, Aurabindo Pillai wrote: [Why&How] Debug option for forcing SST mode when using MST capable receivers is guarded under the config option CONFIG_DRM_AMD_DC_DCN. Hence the corresponding code exposing it in debugfs must be guarded

Re: [PATCH] drm/amd/display: Fix Compile Error for DCE

[AMD Official Use Only] The following patch has been Reviewed-by: Nicholas Choi Thanks, Nicholas From: Alex Deucher Sent: Saturday, December 11, 2021 9:08 AM To: Zuo, Jerry Cc: amd-gfx list ; Choi, Nicholas Subject: Re: [PATCH] drm/amd/display: Fix Compile

Re: [PATCH v2 1/2] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC

[Public] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Mario Limonciello Sent: Monday, December 13, 2021 10:08 AM To: amd-gfx@lists.freedesktop.org Cc: Limonciello, Mario Subject: [PATCH v2 1/2] drm/amd/pm: fix reading SMU FW version from a

Re: [PATCH v2 00/10] drm/amd: fix various compilation warnings

Hi all, Thank you for the reviews and quick responses :) I'm really glad all of the patches got applied and am looking forward to making more contributions! Cheers, -- Isabella Basso

RE: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

[AMD Official Use Only] Some comment inline. -Original Message- From: amd-gfx On Behalf Of Marina Nikolic Sent: Friday, December 10, 2021 10:06 AM To: amd-gfx@lists.freedesktop.org Cc: Nikolic, Marina Subject: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

On Mon, Dec 13, 2021 at 02:39:59PM +0200, Ville Syrjälä wrote: > On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > kmap() is being deprecated and these usages are all local to the thread > > so there is no reason kmap_local_page() can't be used. > >

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

On Mon, Dec 13, 2021 at 01:04:07AM -0800, Christoph Hellwig wrote: > On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > > - vaddr = kmap(page); > > + vaddr = kmap_local_page(page); > > memcpy(vaddr, data, len); > > - kunmap(page); > > +

Re: [PATCH v4 4/6] drm: implement a method to free unused pages

On 01/12/2021 16:39, Arunpravin wrote: On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim

Re: [PATCH v4 2/6] drm: improve drm_buddy_alloc function

On 09/12/2021 15:47, Paneer Selvam, Arunpravin wrote: [AMD Official Use Only] Hi Matthew, Ping on this? No new comments from me :) I guess just a question of what we should do with the selftests, and then ofc at some point being able to throw this at CI, or at least test locally, once the s

[PATCH 1/4] drm/amdgpu: Increase potential product_name to 64 characters

Having seen at least 1 42-character product_name, bump the number up to 64. Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/g

[PATCH 2/4] drm/amdgpu: Enable unique_id for Aldebaran

It's supported, so support the unique_id sysfs file Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index 082539c70fd4..dfefb147ac2c 1

[PATCH 3/4] drm/amdgpu: Only overwrite serial if field is empty

On Aldebaran, the serial may be obtained from the FRU. Only overwrite the serial with the unique_id if the serial is empty. This will support printing serial numbers for mGPU devices where there are 2 unique_ids for the 2 GPUs, but only one serial number for the board Signed-off-by: Kent Russell

[PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran

This is supported, although the offset is different from VG20, so fix that with a variable and enable getting the product name and serial number from the FRU. Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 12 +--- 1 file changed, 9 insertions(+), 3 dele

Re: [PATCH v2 1/3] Documentation/gpu: split amdgpu/index for readability

On 2021-12-10 1:20 p.m., Yann Dirson wrote: This starts to make the formated index much more manageable to the reader. Signed-off-by: Yann Dirson --- Documentation/gpu/amdgpu/driver-core.rst | 65 Documentation/gpu/amdgpu/driver-misc.rst | 112 ++ Documentation/gpu/am

Re: [PATCH v2 2/3] Documentation/gpu: include description of AMDGPU hardware structure

On 2021-12-10 1:20 p.m., Yann Dirson wrote: This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Maybe you can improve this commit message by describing what you are documenting and also adding a link to the original discussion. Perhaps you can use this lin

Re: [PATCH v2 3/3] Documentation/gpu: include description of some of the GC microcontrollers

On 2021-12-10 1:20 p.m., Yann Dirson wrote: This is Alex' description from the "Looking for clarifications around gfx/kcq/kiq" thread, edited to fit as ReST. Originally-by: Alex Deucher Signed-off-by: Yann Dirson Acked-by: Harry Wentland --- Documentation/gpu/amdgpu/driver-core.rst | 35

Re: [PATCH v2 2/3] Documentation/gpu: include description of AMDGPU hardware structure

On 2021-12-13 3:16 p.m., Rodrigo Siqueira Jordao wrote: On 2021-12-10 1:20 p.m., Yann Dirson wrote: This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Maybe you can improve this commit message by describing what you are documenting and also adding a lin

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

On Sun, Dec 12, 2021 at 5:19 PM Yann Dirson wrote: > > Alex wrote: > > On Mon, Dec 6, 2021 at 4:36 PM Yann Dirson wrote: > > > > > > Hi Alex, > > > > > > > We have not validated virtualization of our integrated GPUs. I > > > > don't > > > > know that it will work at all. We had done a bit of te

Re: [PATCH v2 1/3] Documentation/gpu: split amdgpu/index for readability

Applied. thanks! Alex On Mon, Dec 13, 2021 at 3:07 PM Rodrigo Siqueira Jordao wrote: > > > > On 2021-12-10 1:20 p.m., Yann Dirson wrote: > > This starts to make the formated index much more manageable to the reader. > > > > Signed-off-by: Yann Dirson > > --- > > Documentation/gpu/amdgpu/drive

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: From: Ira Weiny The default case leaves the buffer object mapped in error. Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up. Mhm, good catch. But why do you want to do this in the first place? Christian. Signed-off-

Re: [PATCH] drm:amdgpu:remove unneeded variable

Applied. Thanks! Alex On Thu, Dec 9, 2021 at 11:56 AM wrote: > > From: chiminghao > > return value form directly instead of > taking this in another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: chiminghao > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ioc32.c | 5 + > dri

Re: [v3] drm/amdgpu: reset asic after system-wide suspend aborted (v3)

On 11/24/2021 23:48, Prike Liang wrote: Do ASIC reset at the moment Sx suspend aborted behind of amdgpu suspend to keep AMDGPU in a clean reset state and that can avoid re-initialize device improperly error. Currently,we just always do asic reset in the amdgpu resume until sort out the PM abort c

[PATCH v3 0/4] Enrich amdgpu docs from recent threads

This series is basically bringing Alex' descriptions of the hardware and driver internals into the doc. Changes in v3: * camel case in titles (Rodrigo Siqueira) * link DCN description to DC doc (Rodrigo Siqueira) * links to email archive in commit messages (Rodrigo Siqueira) * acronym expansion in

[PATCH v3 3/4] amdgpu: fix some kernel-doc markup

Those are not today pulled by the sphinx doc, but better be ready. Signed-off-by: Yann Dirson --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 6 +++--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 ++-- 3 files changed, 6

[PATCH v3 2/4] Documentation/gpu: include description of some of the GC microcontrollers

This is Alex' description from the "Looking for clarifications around gfx/kcq/kiq" thread, edited to fit as ReST. Original text: https://www.spinics.net/lists/amd-gfx/msg71383.html Originally-by: Alex Deucher Signed-off-by: Yann Dirson Acked-by: Harry Wentland Reviewed-by: Rodrigo Siqueira -

[PATCH v3 1/4] Documentation/gpu: include description of AMDGPU hardware structure

This describes in broad lines the how an AMD GPU is organized, in terms of hardware blocks. This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Original text: https://www.spinics.net/lists/amd-gfx/msg71543.html Originally-by: Alex Deucher Signed-off-by: Yann Di

[PATCH v3 4/4] amdgpu: fix some comment typos

Signed-off-by: Yann Dirson --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +- include/uapi/drm/amdgpu_drm.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/

[PATCH] drm/amdgpu: correct the wrong cached state for GMC on PICASSO

Pair the operations did in GMC ->hw_init and ->hw_fini. That can help to maintain correct cached state for GMC and avoid unintention gate operation dropping due to wrong cached state. BUG: https://gitlab.freedesktop.org/drm/amd/-/issues/1828 Signed-off-by: Evan Quan Change-Id: I9976672a64464b86b

RE: [v3] drm/amdgpu: reset asic after system-wide suspend aborted (v3)

[Public] > -Original Message- > From: Limonciello, Mario > Sent: Tuesday, December 14, 2021 5:48 AM > To: Liang, Prike ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Lazar, Lijo > ; Huang, Ray > Subject: Re: [v3] drm/amdgpu: reset asic after system-wide suspend aborted > (v3)

RE: [PATCH v2 1/2] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC

[Public] A nitpick. As we have defined a local variable 'adev', so code like 'smu->adev' should be replaced directly by 'adev' in the function to make code clean. With above addressed, the series is: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behal

Re: [PATCH v2 1/2] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC

I've pushed it already after Alex's review comment. I'll send an extra patch tomorrow for this extra cleanup. Get Outlook for Android From: Chen, Guchun Sent: Monday, December 13, 2021 8:41:17 PM To: Limonciello, Mario ; amd-gfx@lists.fre

RE: [PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran

[Public] + if (adev->asic_type == CHIP_ALDEBARAN) + offset = 0; if (!is_fru_eeprom_supported(adev)) return 0; I assume the logic should be adjusted. It's better to put the asic_type check after is_fru_eeprom_supported. Regards, Guchun -Original

[PATCH v2] drm/amd/pm: skip setting gfx cgpg in the s0ix suspend-resume

In the s0ix entry need retain gfx in the gfxoff state,so here need't set gfx cgpg in the S0ix suspend-resume process. Moreover move the S0ix check into SMU12 can simplify the code condition check. Signed-off-by: Prike Liang --- v1->v2: - Move s0ix check into SMU12. --- drivers/gpu/drm/amd/pm/sws

RE: [PATCH v2] drm/amd/pm: skip setting gfx cgpg in the s0ix suspend-resume

[AMD Official Use Only] Reviewed-by: Evan Quan > -Original Message- > From: Liang, Prike > Sent: Tuesday, December 14, 2021 11:17 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Huang, Ray > ; Quan, Evan ; Limonciello, > Mario ; Liang, Prike > Subject: [PATCH v2] drm/

RE: [PATCH 1/4] drm/amdgpu: Increase potential product_name to 64 characters

[Public] How about set a define like PRODUCT_NAME_LEN to be 64, and use it in FRU code? In this case, if it needs to bump string length of product name later on, it will be simple. #define PRODUCT_NAME_LEN 64 unsigned char buff[PRODUCT_NAME_LEN + 2]; Regards, Guchun -Original Message

RE: [PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran

[Public] BTW, does FRU exists on all the Aldebaran SKUs? This patch acks FRU's presence when it's Aldebaran. So if some Aldebaran SKUs do not have a FRU, some i2c access failures will be observed during boot up. This is not friendly to user. Please check Vega20 case we talked before, and there

RE: [PATCH] drm/amdgpu: correct the wrong cached state for GMC on PICASSO

[Public] Acked-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Tuesday, December 14, 2021 9:34 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan ; Limonciello, Mario Subject: [PATCH] drm/amdgpu: correct the wrong ca

RE: [PATCH] drm/amdgpu: correct the wrong cached state for GMC on PICASSO

[Public] > -Original Message- > From: Chen, Guchun > Sent: Monday, December 13, 2021 21:49 > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > ; Limonciello, Mario > Subject: RE: [PATCH] drm/amdgpu: correct the wrong cached state for GMC on > PICASS

[PATCH 1/2] drm/amd/amdgpu: fix psp tmr bo pin count leak in SRIOV

[Why] psp tmr bo will be pinned during loading amdgpu and reset in SRIOV while only unpinned in unload amdgpu [How] add amdgpu_in_reset and sriov judgement for psp_tmr_init Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 ++- 1 file changed, 6 insertions(+),

[PATCH 2/2] drm/amd/amdgpu: fix gmc bo pin count leak in SRIOV

[Why] gmc bo will be pinned during loading amdgpu and reset in SRIOV while only unpinned in unload amdgpu [How] add amdgpu_in_reset and sriov judgement for pin bo in gart_enable Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 8 +--- drivers/gpu/drm/amd/amdgpu/gmc_v

[PATCH] drivers/amd/pm: smu13: use local variable adev

Since this variable was made available by the previous commit, use it to make function access cleaner. Suggested-by: Guchun Chen Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dri

Re: [PATCH 2/2] drm/amd/amdgpu: fix gmc bo pin count leak in SRIOV

patch abandoned On 2021/12/14 上午11:52, Jingwen Chen wrote: > [Why] > gmc bo will be pinned during loading amdgpu and reset in SRIOV while > only unpinned in unload amdgpu > > [How] > add amdgpu_in_reset and sriov judgement for pin bo in gart_enable > > Signed-off-by: Jingwen Chen > --- > drivers

[PATCH 1/2] drm/amd/amdgpu: fix psp tmr bo pin count leak in SRIOV

[Why] psp tmr bo will be pinned during loading amdgpu and reset in SRIOV while only unpinned in unload amdgpu [How] add amdgpu_in_reset and sriov judgement to skip pin bo Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 1 file changed, 4 insertions(+) diff --gi

[PATCH 2/2] drm/amd/amdgpu: fix gmc bo pin count leak in SRIOV

[Why] gmc bo will be pinned during loading amdgpu and reset in SRIOV while only unpinned in unload amdgpu [How] add amdgpu_in_reset and sriov judgement to skip pin bo Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 4 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4

[PATCH v2 1/2] drm/amd/amdgpu: fix psp tmr bo pin count leak in SRIOV

[Why] psp tmr bo will be pinned during loading amdgpu and reset in SRIOV while only unpinned in unload amdgpu [How] add amdgpu_in_reset and sriov judgement to skip pin bo v2: fix wrong judgement Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 1 file changed, 4

[PATCH v2 2/2] drm/amd/amdgpu: fix gmc bo pin count leak in SRIOV

[Why] gmc bo will be pinned during loading amdgpu and reset in SRIOV while only unpinned in unload amdgpu [How] add amdgpu_in_reset and sriov judgement to skip pin bo v2: fix wrong judgement Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 4 drivers/gpu/drm/amd/am

RE: [PATCH] drivers/amd/pm: smu13: use local variable adev

[Public] Thank you, Mario. Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Limonciello, Mario Sent: Tuesday, December 14, 2021 11:58 AM To: amd-gfx@lists.freedesktop.org Cc: Limonciello, Mario ; Chen, Guchun Subject: [PATCH] drivers/amd/pm: smu13: use local variab

RE: [PATCH] drm/amdgpu: correct the wrong cached state for GMC on PICASSO

[Public] > -Original Message- > From: Limonciello, Mario > Sent: Tuesday, December 14, 2021 11:50 AM > To: Chen, Guchun ; Quan, Evan > ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: RE: [PATCH] drm/amdgpu: correct the wrong cached state for GMC > on

RE: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

[AMD Official Use Only] From: Zhu, James Sent: Monday, December 13, 2021 9:39 PM To: Gong, Curry ; Zhu, James ; amd-gfx@lists.freedesktop.org Cc: Liu, Leo ; Quan, Evan ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabl

Re: [PATCH] drm/amdgpu: correct the wrong cached state for GMC on PICASSO

On 12/14/2021 7:04 AM, Evan Quan wrote: Pair the operations did in GMC ->hw_init and ->hw_fini. That can help to maintain correct cached state for GMC and avoid unintention gate operation dropping due to wrong cached state. BUG: https://gitlab.freedesktop.org/drm/amd/-/issues/1828 Signed-off

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

Am 14.12.21 um 04:37 schrieb Ira Weiny: On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: From: Ira Weiny The default case leaves the buffer object mapped in error. Add amdgpu_bo_kunmap() to that case to ensure the mapping is c

[PATCH] drm/amd/pm: Skip power state allocation

Power states are not valid for arcturus and aldebaran, no need to allocate memory. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 10 -- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 10 -- 2 files changed, 20 deletions(-) diff --git a/

Re: [Patch v2] drm/amdgpu: Don't inherit GEM object VMAs in child process

Am 11.12.21 um 01:55 schrieb Felix Kuehling: On 2021-12-10 4:48 p.m., Rajneesh Bhardwaj wrote: When an application having open file access to a node forks, its shared mappings also get reflected in the address space of child process even though it cannot access them with the object permissions a

RE: [PATCH v2 1/2] drm/amd/amdgpu: fix psp tmr bo pin count leak in SRIOV

[AMD Official Use Only] Reviewed-by: Horace Chen -Original Message- From: Chen, JingWen Sent: Tuesday, December 14, 2021 12:18 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk ; Chen, Horace ; Chen, JingWen Subject: [PATCH v2 1/2] drm/amd/amdgpu: fix psp tmr bo pin count leak in SRI

RE: [PATCH v2 2/2] drm/amd/amdgpu: fix gmc bo pin count leak in SRIOV

[AMD Official Use Only] Reviewed-by: Horace Chen -Original Message- From: Chen, JingWen Sent: Tuesday, December 14, 2021 12:18 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk ; Chen, Horace ; Chen, JingWen Subject: [PATCH v2 2/2] drm/amd/amdgpu: fix gmc bo pin count leak in SRIOV

Re: [PATCH] drm/amd/pm: Skip power state allocation

[AMD Official Use Only] Reviewed-by: Yang Wang Best Regards, Kevin From: Lazar, Lijo Sent: Tuesday, December 14, 2021 3:12 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Wang, Yang(Kevin) ; Quan, Evan Subject: [PATCH] drm/amd/

RE: [PATCH] drm/amdgpu: correct the wrong cached state for GMC on PICASSO

[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, December 14, 2021 2:13 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Limonciello, Mario > > Subject: Re: [PATCH] drm/amdgpu: correct the wrong cached state for GMC > on PI

RE: [PATCH] drm/amd/pm: Skip power state allocation

[AMD Official Use Only] Reviewed-by: Evan Quan > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, December 14, 2021 3:13 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Wang, Yang(Kevin) > ; Quan, Evan > Subject: [PATCH] drm/amd/pm: Skip powe

Re: [PATCH] drm/amdgpu: correct the wrong cached state for GMC on PICASSO

On 12/14/2021 1:16 PM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Tuesday, December 14, 2021 2:13 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Limonciello, Mario Subject: Re: [PATCH] drm/amdgpu: correct the w