Re: AMDGPU: RX 6500 XT: System reset when loading module

2022-02-23 Thread Christian König
Am 23.02.22 um 23:59 schrieb Cal Peake: On Fri, 18 Feb 2022, Christian König wrote: That's a really strong evidence that you have a hardware problem here. BTW: Where do you got that hardware from? Is it used or a new one? Was it maybe used for mining? Nah, this was a brand new card I bought

Re: [RFC v4 02/11] drm/amdgpu: Move scheduler init to after XGMI is ready

2022-02-23 Thread JingWen Chen
Hi Andrey, Will you port this patch into amd-staging-drm-next? on 2/10/22 2:06 AM, Andrey Grodzovsky wrote: > All comments are fixed and code pushed. Thanks for everyone > who helped reviewing. > > Andrey > > On 2022-02-09 02:53, Christian König wrote: >> Am 09.02.22 um 01:23 schrieb Andrey

Re: [PATCH v3 0/3] amdgpu/pm: Implement parallel sysfs_emit solution for navi10

2022-02-23 Thread Alex Deucher
On Tue, Jan 25, 2022 at 11:55 PM Darren Powell wrote: > > == Description == > Scnprintf use within the kernel is not recommended, but simple sysfs_emit > replacement has > not been successful due to the page alignment requirement of the function. > This patch > set implements a new api

Re: [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5

2022-02-23 Thread Huang Rui
On Thu, Feb 24, 2022 at 11:45:43AM +0800, Zhang, Yifan wrote: > SMU MSG index should be used as parameter. > > Signed-off-by: Yifan Zhang Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > >

Re: [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5

2022-02-23 Thread Alex Deucher
On Wed, Feb 23, 2022 at 10:46 PM Yifan Zhang wrote: > > SMU MSG index should be used as parameter. > > Signed-off-by: Yifan Zhang Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff

[PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5

2022-02-23 Thread Yifan Zhang
SMU MSG index should be used as parameter. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c

[PATCH] drm/amdgpu: Add use_xgmi_p2p module parameter

2022-02-23 Thread Alex Sierra
This parameter controls xGMI p2p communication, which is enabled by default. However, it can be disabled by setting it to 0. In case xGMI p2p is disabled in a dGPU, PCIe p2p interface will be used instead. This parameter is ignored in GPUs that do not support xGMI p2p configuration.

[PATCH v2] drm/amd/display: move FPU-related code from dcn20 to dml folder

2022-02-23 Thread Melissa Wen
Move parts of dcn20 code that uses FPU to dml folder. It aims to isolate FPU operations as described by series: drm/amd/display: Introduce FPU directory inside DC https://patchwork.freedesktop.org/series/93042/ This patch moves the following functions from dcn20_resource to dml/dcn20_fpu and

Re: AMDGPU: RX 6500 XT: System reset when loading module

2022-02-23 Thread Cal Peake
On Fri, 18 Feb 2022, Christian König wrote: > That's a really strong evidence that you have a hardware problem here. > > BTW: Where do you got that hardware from? Is it used or a new one? Was it > maybe used for mining? > Nah, this was a brand new card I bought on launch day from a reputable

[pull] amdgpu drm-fixes-5.17

2022-02-23 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.17. The following changes since commit cfb92440ee71adcc2105b0890bb01ac3cddb8507: Linux 5.17-rc5 (2022-02-20 13:07:20 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.17-2022-02-23 for you to

Re: [PATCH] drm/amd/display: move FPU-related code from dcn20 to dml folder

2022-02-23 Thread Melissa Wen
On 02/23, Rodrigo Siqueira Jordao wrote: > > > On 2022-02-21 06:31, Melissa Wen wrote: > > Move parts of dcn20 code that uses FPU to dml folder. It aims to isolate > > FPU operations as described by series: > > > > drm/amd/display: Introduce FPU directory inside DC > >

Re: [PATCH] PCI: Apply quirk_amd_harvest_no_ats to all navi10 and 14 asics

2022-02-23 Thread Bjorn Helgaas
On Tue, Feb 22, 2022 at 11:08:01AM -0500, Alex Deucher wrote: > There are enough vbios escapes without the proper workaround > that some users still hit this. MS never productized ATS on > windows so OEM platforms that were windows only didn't always > validate ATS. > > The advantages of ATS are

Re: [PATCH] drm/amdgpu: Add use_xgmi_p2p module parameter

2022-02-23 Thread Alex Deucher
On Wed, Feb 23, 2022 at 1:47 PM Felix Kuehling wrote: > > On 2022-02-23 12:47, Alex Sierra wrote: > > This parameter controls xGMI p2p communication, which is enabled by > > default. However, it can be disabled by setting it to 0. In case xGMI > > p2p is disabled in a dGPU, PCIe p2p interface

Re: [PATCH] drm/amdgpu: Add use_xgmi_p2p module parameter

2022-02-23 Thread Felix Kuehling
On 2022-02-23 12:47, Alex Sierra wrote: This parameter controls xGMI p2p communication, which is enabled by default. However, it can be disabled by setting it to 0. In case xGMI p2p is disabled in a dGPU, PCIe p2p interface will be used instead. This parameter is ignored in GPUs that do not

[PATCH] drm/amdgpu: Add use_xgmi_p2p module parameter

2022-02-23 Thread Alex Sierra
This parameter controls xGMI p2p communication, which is enabled by default. However, it can be disabled by setting it to 0. In case xGMI p2p is disabled in a dGPU, PCIe p2p interface will be used instead. This parameter is ignored in GPUs that do not support xGMI p2p configuration.

RE: [PATCH] amdgpu/pm: Disable managing hwmon sysfs attributes for ONEVF mode

2022-02-23 Thread Kasiviswanathan, Harish
[AMD Official Use Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Kasiviswanathan, Harish Sent: Thursday, February 17, 2022 2:17 PM To: Slivka, Danijel ; amd-gfx@lists.freedesktop.org Cc: Slivka, Danijel Subject: RE: [PATCH] amdgpu/pm: Disable

Re: [PATCH] Revert "drm/amd/display: Remove unused temp variable"

2022-02-23 Thread Harry Wentland
On 2022-02-22 21:28, Alex Deucher wrote: > This reverts commit b1f0ab445ec609f9b58e0969c5d052b52d9a54e7. > > This patch is not valid. The driver needs to actually read the > entries in the ring buffer. Add a comment to make this clear. > > Bug:

Re: [PATCH] drm/amdgpu: install ctx entities with cmpxchg

2022-02-23 Thread Christian König
No, as I wrote in the comment that is not an error and should just be ignored. Regards, Christian. Am 23.02.22 um 16:18 schrieb Chen, Guchun: [Public] Shall we add a print to aware user when failing to install a new ctx entity? Regards, Guchun *From:* amd-gfx *On Behalf Of *Deucher,

RE: [PATCH] drm/amdgpu: install ctx entities with cmpxchg

2022-02-23 Thread Chen, Guchun
[Public] Shall we add a print to aware user when failing to install a new ctx entity? Regards, Guchun From: amd-gfx On Behalf Of Deucher, Alexander Sent: Wednesday, February 23, 2022 11:06 PM To: Christian König ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Xue, Ken Subject: Re:

Re: [PATCH] drm/amdgpu/benchmark: fix error handling

2022-02-23 Thread Christian König
Am 23.02.22 um 15:23 schrieb Alex Deucher: Forgot to assign the return value here. Reported-by: kernel test robot Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH] drm/amdgpu: install ctx entities with cmpxchg

2022-02-23 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Wednesday, February 23, 2022 8:38 AM To: amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Xue, Ken Subject: [PATCH] drm/amdgpu: install ctx entities with cmpxchg Since we

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-23 Thread Alex Deucher
On Wed, Feb 23, 2022 at 2:42 AM Christian König wrote: > > Well that's bad. This should not be pushed to amd-staging-drm-next at all. > > This patch is touching multiple drivers and therefore needs to go > upstream through drm-misc-next. > > Alex can you drop that one before you send out a pull

RE: [PATCH] drm/amdgpu/benchmark: fix error handling

2022-02-23 Thread Chen, Guchun
Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, February 23, 2022 10:23 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; kernel test robot Subject: [PATCH] drm/amdgpu/benchmark: fix error handling

Re: [PATCH v2] drm/amdgpu: config HDP_MISC_CNTL.READ_BUFFER_WATERMARK to fix applications running across multiple GPU config hang.

2022-02-23 Thread Deucher, Alexander
[Public] Please include a patch description. With that fixed, Reviewed-by: Alex Deucher From: amd-gfx on behalf of Xiaogang.Chen Sent: Wednesday, February 23, 2022 1:24 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Chen, Xiaogang ;

[PATCH] drm/amdgpu/benchmark: fix error handling

2022-02-23 Thread Alex Deucher
Forgot to assign the return value here. Reported-by: kernel test robot Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c

Re: [PATCH] drm/amd/display: move FPU-related code from dcn20 to dml folder

2022-02-23 Thread Rodrigo Siqueira Jordao
On 2022-02-21 06:31, Melissa Wen wrote: Move parts of dcn20 code that uses FPU to dml folder. It aims to isolate FPU operations as described by series: drm/amd/display: Introduce FPU directory inside DC https://patchwork.freedesktop.org/series/93042/ This patch moves the following functions

[PATCH] drm/amdgpu: install ctx entities with cmpxchg

2022-02-23 Thread Christian König
Since we removed the context lock we need to make sure that not two threads are trying to install an entity at the same time. Signed-off-by: Christian König Fixes: e68efb27647f ("drm/amdgpu: remove ctx->lock") --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 8 +++- 1 file changed, 7