On Tue, Jun 28, 2022 at 10:46:04AM +0100, Mauro Carvalho Chehab wrote:
> As we're currently discussing about making kernel-doc issues fatal when
> CONFIG_WERROR is enable, let's fix all 60 kernel-doc warnings
> inside linux-next:
>
To be fair, besides triggering error on kernel-doc warnings, Sph
On 29.06.22 05:54, Alex Sierra wrote:
> is_pinnable_page() and folio_is_pinnable() were renamed to
> is_longterm_pinnable_page() and folio_is_longterm_pinnable()
> respectively. These functions are used in the FOLL_LONGTERM flag
> context.
Subject talks about "*_pages"
Can you elaborate why the
On 6/28/22 19:48, Rob Clark wrote:
> On Tue, Jun 28, 2022 at 5:51 AM Dmitry Osipenko
> wrote:
>>
>> On 6/28/22 15:31, Robin Murphy wrote:
>>> ->8-
>>> [ 68.295951] ==
>>> [ 68.295956] WARNING: possible circular locking dependency dete
On 6/28/22 14:41, Jocelyn Falempe wrote:
> On 28/06/2022 10:43, Thomas Zimmermann wrote:
[snip]
>>
>> Unfortunately, this currently only works if a driver is bound to the
>> platform device. Without simpledrm or simplefb, amdgpu won't find the
>> platform device to remove.
>>
>> I guess, what h
On 06/29/ , Jack Xiao wrote:
> Use read/write register to test mes ring.
>
> Signed-off-by: Jack Xiao
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 36 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 1 +
> drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 6 +
> 3 files
On 6/29/22 10:22, Dmitry Osipenko wrote:
On 6/29/22 09:40, Thomas Hellström (Intel) wrote:
On 5/27/22 01:50, Dmitry Osipenko wrote:
Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't
handle imported dma-bufs properly, which results in mapping of something
else than the impor
On 6/28/22 23:12, Thomas Hellström (Intel) wrote:
> Hi,
>
> On 5/27/22 01:50, Dmitry Osipenko wrote:
>> Use ww_acquire_fini() in the error code paths. Otherwise lockdep
>> thinks that lock is held when lock's memory is freed after the
>> drm_gem_lock_reservations() error. The WW needs to be annota
On 6/29/22 09:40, Thomas Hellström (Intel) wrote:
>
> On 5/27/22 01:50, Dmitry Osipenko wrote:
>> Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't
>> handle imported dma-bufs properly, which results in mapping of something
>> else than the imported dma-buf. For example, on NVID
On 29.06.22 05:54, Alex Sierra wrote:
> With DEVICE_COHERENT, we'll soon have vm_normal_pages() return
> device-managed anonymous pages that are not LRU pages. Although they
> behave like normal pages for purposes of mapping in CPU page, and for
> COW. They do not support LRU lists, NUMA migration
Am 2022-06-28 um 20:03 schrieb Errabolu, Ramesh:
[AMD Official Use Only - General]
My responses are inline
-Original Message-
From: Kuehling, Felix
Sent: Tuesday, June 28, 2022 6:41 PM
To: Errabolu, Ramesh ; amd-gfx@lists.freedesktop.org;
dan.carpen...@oracle.com
Subject: Re: [PATCH]
On Tue, 07 Jun 2022, Lyude Paul wrote:
> As Daniel Vetter pointed out, if we only use the atomic modesetting locks
> with MST it's technically possible for a driver with non-blocking modesets
> to race when it comes to MST displays - as we make the mistake of not doing
> our own CRTC commit tracki
On Tue, 07 Jun 2022, Lyude Paul wrote:
> We already open-code this quite often, and will be iterating through
> payloads even more once we've moved all of the payload tracking into the
> atomic state. So, let's add a helper for doing this.
>
> Signed-off-by: Lyude Paul
> Cc: Wayne Lin
> Cc: Vill
On Tue, 07 Jun 2022, Lyude Paul wrote:
> Ugh, thanks ./scripts/get_maintainers.pl for confusing and breaking
> git-send email <<. Sorry for the resend everyone.
>
> For quite a while we've been carrying around a lot of legacy modesetting
> code in the MST helpers that has been rather annoying to k
Was dropped when we converted to the generic helpers.
Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up
AMD own's.")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 25 +
1 file changed, 21 insertions(+), 4 deletions
Seems to break hibernation. Disable for now until we can root
cause it.
Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up
AMD own's.")
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=216119
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
[AMD Official Use Only - General]
Will post updated patch. My responses inline below
Regards,
Ramesh
-Original Message-
From: Kuehling, Felix
Sent: Wednesday, June 29, 2022 8:58 AM
To: Errabolu, Ramesh ; amd-gfx@lists.freedesktop.org;
dan.carpen...@oracle.com
Subject: Re: [PATCH] drm/
On Tue, Jun 28, 2022 at 07:41:09PM -0400, Felix Kuehling wrote:
>
> Am 2022-06-28 um 19:25 schrieb Ramesh Errabolu:
> > The patch fixes couple of warnings, as reported by Smatch
> > a static analyzer
> >
> > Signed-off-by: Ramesh Errabolu
> > Reported-by: Dan Carpenter
> > ---
> > drivers/gpu
On Tue, Jun 28, 2022 at 06:25:38PM -0500, Ramesh Errabolu wrote:
> The patch fixes couple of warnings, as reported by Smatch
> a static analyzer
>
I had forgotten what the warnings were. Could you put that in the
commit message or describe the bug somehow?
> Signed-off-by: Ramesh Errabolu
> R
The patch fixes couple of warnings, as reported by Smatch
a static analyzer
Signed-off-by: Ramesh Errabolu
Reported-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 34 +++
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/amd/a
[Why&How]
TA firmware is needed to enable HDCP.
Changes in v2:
Load separate firmware for PSP 13.0.0
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c
b/drivers/gpu/drm/am
[AMD Official Use Only - General]
Thanks for running Smatch on the patch.
Will update the commit message with the list of warnings/errors pointed out by
Smatch. Will post the updated patch shortly.
Regards,
Ramesh
-Original Message-
From: Dan Carpenter
Sent: Wednesday, June 29, 2022
The patch fixes couple of warnings, as reported by Smatch
a static analyzer.
Fixes: 40d6aa758b13 ("drm/amdkfd: Extend KFD device topology to surface
peer-to-peer links")
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1428
kfd_create_indirect_link_prop() warn: iterator used outside loop: 'c
[Public]
Acked-by: Alex Deucher
From: amd-gfx on behalf of Aurabindo
Pillai
Sent: Wednesday, June 29, 2022 12:45 PM
To: alexdeuc...@gmail.com ;
amd-gfx@lists.freedesktop.org
Cc: Pillai, Aurabindo ; Zhang, Hawking
Subject: [PATCH] drm/amd: Load TA firmware f
GFX10 and up have work group processors (WGP) and WGP mode is the native
compile mode.
KFD and ROCr have no visibility into whether a dispatch is operating
in CU or WGP mode.
Enforce CU masking to be pairwise continguous in enablement and
round robin distribute CUs across the SEs in a pairwise ma
On 29.06.22 05:54, Alex Sierra wrote:
> Device memory that is cache coherent from device and CPU point of view.
> This is used on platforms that have an advanced system bus (like CAPI
> or CXL). Any page of a process can be migrated to such memory. However,
> no one should be allowed to pin such me
On 6/29/22 00:23, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20220628:
>
on i386:
ld: drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.o: in function
`dcn32_init_clocks':
dcn32_clk_mgr.c:(.text+0x70d): undefined reference to `__nedf2'
ld: dcn32_clk_mgr.c:(.text+0x9bf): und
On Wed, Jun 29, 2022 at 3:05 PM Randy Dunlap wrote:
>
>
>
> On 6/29/22 00:23, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20220628:
> >
>
> on i386:
>
> ld: drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.o: in function
> `dcn32_init_clocks':
> dcn32_clk_mgr.c:(.text+0x70
Hi Dave, Daniel,
Fixes for 5.19.
The following changes since commit 76f0544428aced9e2f0d50ac7429e0f3064658cd:
Merge tag 'drm-msm-fixes-2022-06-28' of
https://gitlab.freedesktop.org/drm/msm into drm-fixes (2022-06-29 14:16:46
+1000)
are available in the Git repository at:
https://gitlab.f
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: c4ef528bd006febc7de444d9775b28706d924f78 Add linux-next specific
files for 20220629
Error/Warning reports:
https://lore.kernel.org/linux-mm/202206292052.lsfui3zo-...@intel.com
Error/Warning
Sorry for the late review. I finally got some time to look at this.
On Mon, 16 May 2022 16:56:39 -0600
Jim Cromie wrote:
> diff --git a/include/trace/events/drm.h b/include/trace/events/drm.h
> new file mode 100644
> index ..6de80dd68620
> --- /dev/null
> +++ b/include/trace/event
On 2022-06-29 03:33, David Hildenbrand wrote:
On 29.06.22 05:54, Alex Sierra wrote:
is_pinnable_page() and folio_is_pinnable() were renamed to
is_longterm_pinnable_page() and folio_is_longterm_pinnable()
respectively. These functions are used in the FOLL_LONGTERM flag
context.
Subject talks abo
On 2022-06-28 17:43, Eric Huang wrote:
Two changes:
1. reducing unnecessary evict/unmap when range is not mapped to gpu.
2. adding always evict when flags is set to always_mapped.
Signed-off-by: Eric Huang
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 10 --
1 file changed, 8 insertions
On 2022-06-29 14:16, Jonathan Kim wrote:
GFX10 and up have work group processors (WGP) and WGP mode is the native
compile mode.
KFD and ROCr have no visibility into whether a dispatch is operating
in CU or WGP mode.
Enforce CU masking to be pairwise continguous in enablement and
round robin d
On 2022-06-29 18:20, Felix Kuehling wrote:
On 2022-06-28 17:43, Eric Huang wrote:
Two changes:
1. reducing unnecessary evict/unmap when range is not mapped to gpu.
2. adding always evict when flags is set to always_mapped.
Signed-off-by: Eric Huang
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c
On 2022-06-29 18:53, Eric Huang wrote:
On 2022-06-29 18:20, Felix Kuehling wrote:
On 2022-06-28 17:43, Eric Huang wrote:
Two changes:
1. reducing unnecessary evict/unmap when range is not mapped to gpu.
2. adding always evict when flags is set to always_mapped.
Signed-off-by: Eric Huang
---
Hi Ramesh,
On 6/29/22 14:04, Ramesh Errabolu wrote:
> The patch fixes couple of warnings, as reported by Smatch
> a static analyzer.
>
> Fixes: 40d6aa758b13 ("drm/amdkfd: Extend KFD device topology to surface
> peer-to-peer links")>
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1428
> k
On 30.06.22 00:08, Felix Kuehling wrote:
> On 2022-06-29 03:33, David Hildenbrand wrote:
>> On 29.06.22 05:54, Alex Sierra wrote:
>>> is_pinnable_page() and folio_is_pinnable() were renamed to
>>> is_longterm_pinnable_page() and folio_is_longterm_pinnable()
>>> respectively. These functions are use
On Wed, 29 Jun 2022 18:08:40 -0400 Felix Kuehling
wrote:
> >
> > I'd have called it "is_longterm_pinnable_page", but I am not a native
> > speaker, so no strong opinion :)
>
> I think only the patch title has the name backwards. The code uses
> is_longterm_pinnable_page.
Patch title was quite
On 6/29/22 11:43, Thomas Hellström (Intel) wrote:
>
> On 6/29/22 10:22, Dmitry Osipenko wrote:
>> On 6/29/22 09:40, Thomas Hellström (Intel) wrote:
>>> On 5/27/22 01:50, Dmitry Osipenko wrote:
Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't
handle imported dma-bufs p
On Wed, 29 Jun 2022 11:59:26 +0200 David Hildenbrand wrote:
> On 29.06.22 05:54, Alex Sierra wrote:
> > With DEVICE_COHERENT, we'll soon have vm_normal_pages() return
> > device-managed anonymous pages that are not LRU pages. Although they
> > behave like normal pages for purposes of mapping in C
[AMD Official Use Only - General]
will drop this single patch, and send out another independent patch for this.
Thanks,
Jack
From: Yu, Lang
Sent: Wednesday, 29 June 2022 16:35
To: Xiao, Jack
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/7] drm/amdgpu/
DMI check is required to distinguish Jadeite platform from
Stoney base variant.
Add DMI check logic for Jadeite platform.
Signed-off-by: Vijendar Mukunda
Acked-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 36 +
1 file changed, 36 insertions(+)
diff --g
Jadeite platform uses I2S MICSP instance.
Create platform devices for DMA controller and I2S controller for
Jadeite platform.
Signed-off-by: Vijendar Mukunda
Acked-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 293 +++-
1 file changed, 184 insertions(+), 109
Jadeite(JD) platform is Stoney APU varaint which uses I2S MICSP
instance and ES8336 Codec.
This patch series creates I2S platform devices for JD platform,
adds I2S MICSP instance support and Machine driver support
This patch set depends on:
--checkpatch warnings patch
--https://pa
Add I2S MICSP instance support for Stoney variant.
Signed-off-by: Vijendar Mukunda
---
sound/soc/amd/acp-pcm-dma.c | 50 +++--
sound/soc/amd/acp.h | 13 ++
2 files changed, 61 insertions(+), 2 deletions(-)
diff --git a/sound/soc/amd/acp-pcm-dma.c
Add Machine driver for Jadeite platform which uses ES8336 codec.
Signed-off-by: Vijendar Mukunda
---
sound/soc/amd/acp-es8336.c | 333 +
1 file changed, 333 insertions(+)
create mode 100644 sound/soc/amd/acp-es8336.c
diff --git a/sound/soc/amd/acp-es8336.c b
Enable machine driver build for Jadeite platform using ES8336 Codec.
Signed-off-by: Vijendar Mukunda
---
sound/soc/amd/Kconfig | 11 +++
sound/soc/amd/Makefile | 2 ++
2 files changed, 13 insertions(+)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 1381aec23048..da0c
47 matches
Mail list logo
