[PATCH] drm/amdgpu: skip call ras_late_init if ras feature is not enabled

2024-01-17 Thread Yang Wang
skip call ras_late_init callback if ras feature is not enabled. Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 5c817c155d72..5c73d

Re: [PATCH v2] drm/amd/pm: enable amdgpu smu send message log

2024-01-17 Thread Lazar, Lijo
On 1/18/2024 11:07 AM, Yang Wang wrote: From: Yang Wang v1: enable amdgpu smu driver message log. v2: add smu/pmfw response value into debug log. Signed-off-by: Yang Wang Reviewed-by: Lijo Lazar Thanks, Lijo --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 9 - 1 file changed, 8

[PATCH 2/2] update check condition of query for ras page retire

2024-01-17 Thread Tao Zhou
Support page retirement handling in debug mode. v2: revert smu_v13_0_6_get_ecc_info directly. Signed-off-by: Tao Zhou Change-Id: I0aaa807d7fe87b3da0f023c380e57ab6dd446fcf --- drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH 1/2] Revert "drm/amd/pm: smu v13_0_6 supports ecc info by default"

2024-01-17 Thread Tao Zhou
This reverts commit affdce050ab4119a3cdf74d7faa8f1eb30f6f6aa. We use debug mode flag instead of this interface. Signed-off-by: Tao Zhou Change-Id: I49eae821ce352d542143d68c05802634b4bf469d --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 8 1 file changed, 8 deletions(-) diff

[PATCH v2] drm/amdgpu/pm: Fix the power source flag error

2024-01-17 Thread Ma Jun
The power source flag should be updated when [1] System receives an interrupt indicating that the power source has changed. [2] System resumes from suspend or runtime suspend Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 13 +++-- drivers/gpu/drm/amd/pm/swsmu

Re: [PATCH] drm/amdgpu/pm: Fix the power source flag error

2024-01-17 Thread Ma, Jun
On 1/18/2024 1:05 PM, Lazar, Lijo wrote: > On 1/18/2024 7:54 AM, Ma, Jun wrote: >> Hi Lijo, >> >> On 1/17/2024 5:41 PM, Lazar, Lijo wrote: >>> On 1/17/2024 2:22 PM, Ma Jun wrote: The power source flag should be updated when [1] System receives an interrupt indicating that the power sou

RE: [PATCH v2] drm/amd/pm: enable amdgpu smu send message log

2024-01-17 Thread Feng, Kenneth
[AMD Official Use Only - General] Reviewed-by: Kenneth Feng -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Thursday, January 18, 2024 1:37 PM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Feng, Kenneth ; Wang, Yang(Kevin) Subject: [PATCH v2] drm/amd/pm: enable am

[PATCH V2 3/5] drm/amdgpu: Use asynchronous polling to handle umc_v12_0 poisoning

2024-01-17 Thread YiPeng Chai
Use asynchronous polling to handle umc_v12_0 poisoning. v2: 1. Change function name. 2. Change the debugging information content. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 139 ++-- drivers/g

[PATCH V2 4/5] drm/amdgpu: add interface to check mca umc status

2024-01-17 Thread YiPeng Chai
Add interface to check mca umc status. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 12 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_mca.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h | 4 +++- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c| 20

[PATCH V2 5/5] drm/amdgpu:Support retiring multiple MCA error address pages

2024-01-17 Thread YiPeng Chai
Support retiring multiple MCA error address pages in one in-band query for umc v12_0. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 43 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 8 ++- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 66 +

[PATCH V2 2/5] drm/amdgpu: Prepare for asynchronous processing of umc page retirement

2024-01-17 Thread YiPeng Chai
Preparing for asynchronous processing of umc page retirement. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 34 + drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 5 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH V2 1/5] drm/amdgpu: Add log info for umc_v12_0 and smu_v13_0_6

2024-01-17 Thread YiPeng Chai
Add log info for umc_v12_0 and smu_v13_0_6. v2: Delete redundant logs. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 11 +++ drivers/gpu/drm/amd/amdkfd/kfd_events.c | 6 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/am

[PATCH v2] drm/amd/pm: enable amdgpu smu send message log

2024-01-17 Thread Yang Wang
From: Yang Wang v1: enable amdgpu smu driver message log. v2: add smu/pmfw response value into debug log. Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/d

RE: [PATCH 1/5] drm/amdgpu: Add log info for umc_v12_0 and smu_v13_0_6

2024-01-17 Thread Chai, Thomas
[AMD Official Use Only - General] OK - Best Regards, Thomas -Original Message- From: Wang, Yang(Kevin) Sent: Thursday, January 18, 2024 11:00 AM To: Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Yang, Stanley Subject: RE:

RE: [PATCH 3/5] drm/amdgpu: Use asynchronous polling to handle umc_v12_0 poisoning

2024-01-17 Thread Chai, Thomas
[AMD Official Use Only - General] - Best Regards, Thomas _ From: Zhou1, Tao Sent: Thursday, January 18, 2024 11:24 AM To: Chai, Thomas ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Li, Candice ; Wang, Yang(Kevin) ; Yang, Stan

RE: [PATCH] drm/amd/pm: enable amdgpu smu send message log

2024-01-17 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] -Original Message- From: Lazar, Lijo Sent: Thursday, January 18, 2024 1:13 PM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: Re: [PATCH] drm/amd/pm: enable amdgpu smu send message log On 1/18/2024 8:56 AM, Yang Wang wro

Re: [PATCH] drm/amd/pm: enable amdgpu smu send message log

2024-01-17 Thread Lazar, Lijo
On 1/18/2024 8:56 AM, Yang Wang wrote: From: Yang Wang enable amdgpu smu driver message log. Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/

Re: [PATCH] drm/amdgpu/pm: Fix the power source flag error

2024-01-17 Thread Lazar, Lijo
On 1/18/2024 7:54 AM, Ma, Jun wrote: Hi Lijo, On 1/17/2024 5:41 PM, Lazar, Lijo wrote: On 1/17/2024 2:22 PM, Ma Jun wrote: The power source flag should be updated when [1] System receives an interrupt indicating that the power source has changed. [2] System resumes from suspend or runtime susp

[linux-next:master] BUILD REGRESSION 943b9f0ab2cfbaea148dd6ac279957eb08b96904

2024-01-17 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 943b9f0ab2cfbaea148dd6ac279957eb08b96904 Add linux-next specific files for 20240117 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202401172119.fc2ic3l9-...@intel.com https

[PATCH] drm/amd/pm: enable amdgpu smu send message log

2024-01-17 Thread Yang Wang
From: Yang Wang enable amdgpu smu driver message log. Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c index 00cd615bbc

[PATCH Review 1/1] drm/amdgpu: Fix ras features value calltrace

2024-01-17 Thread Stanley . Yang
The high three bits of ras features mask indicate socket id, it should skip to check high three bits of ras features mask before disable all ras features. Signed-off-by: Stanley.Yang Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 11 ++- drivers/gpu/drm/amd/amd

[PATCH Review 1/1] drm/amdgpu: Skip do PCI error slot reset during RAS recovery

2024-01-17 Thread Stanley . Yang
Why: The PCI error slot reset maybe triggered after inject ue to UMC multi times, this caused system hang. [ 557.371857] amdgpu :af:00.0: amdgpu: GPU reset succeeded, trying to resume [ 557.373718] [drm] PCIE GART of 512M enabled. [ 557.373722] [drm] PTB located at 0x00

[PATCH Review 1/1] drm/amdgpu: Show deferred error count for UMC

2024-01-17 Thread Stanley . Yang
Show deferred error count for UMC syfs node Signed-off-by: Stanley.Yang Reviewed-by: Tao Zhou Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gp

RE: [PATCH 3/5] drm/amdgpu: Use asynchronous polling to handle umc_v12_0 poisoning

2024-01-17 Thread Zhou1, Tao
[AMD Official Use Only - General] _ From: Chai, Thomas Sent: Thursday, January 18, 2024 11:06 AM To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, Stanley S

[PATCH] drm/amdgpu: Cleanup inconsistent indenting in 'amdgpu_gfx_enable_kcq()'

2024-01-17 Thread Srinivasan Shanmugam
Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:645 amdgpu_gfx_enable_kcq() warn: inconsistent indenting Cc: Le Ma Cc: Hawking Zhang Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 ++-- 1 file changed, 2 inse

RE: [PATCH 3/5] drm/amdgpu: Use asynchronous polling to handle umc_v12_0 poisoning

2024-01-17 Thread Chai, Thomas
[AMD Official Use Only - General] - Best Regards, Thomas _ From: Zhang, Hawking Sent: Wednesday, January 17, 2024 7:54 PM To: Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, Stanl

RE: [PATCH 1/5] drm/amdgpu: Add log info for umc_v12_0 and smu_v13_0_6

2024-01-17 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] -Original Message- From: Chai, Thomas Sent: Tuesday, January 16, 2024 4:21 PM To: amd-gfx@lists.freedesktop.org Cc: Chai, Thomas ; Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, Stanley ; Chai, Thomas Subject: [PATCH 1/5] drm/am

RE: [PATCH 1/5] drm/amdgpu: Add log info for umc_v12_0 and smu_v13_0_6

2024-01-17 Thread Chai, Thomas
[AMD Official Use Only - General] OK - Best Regards, Thomas -Original Message- From: Zhang, Hawking Sent: Wednesday, January 17, 2024 7:40 PM To: Zhang, Hawking ; Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Yang, Stanley ; Wang, Yang(Kevin) ; Li, Can

Re: [PATCH] drm/amdgpu/pm: Fix the power source flag error

2024-01-17 Thread Ma, Jun
Hi Alex, On 1/17/2024 10:13 PM, Alex Deucher wrote: > On Wed, Jan 17, 2024 at 4:01 AM Ma Jun wrote: >> >> The power source flag should be updated when >> [1] System receives an interrupt indicating that the power source >> has changed. >> [2] System resumes from suspend or runtime suspend >> >> S

Re: [PATCH] drm/amdgpu/pm: Fix the power source flag error

2024-01-17 Thread Ma, Jun
Hi Lijo, On 1/17/2024 5:41 PM, Lazar, Lijo wrote: > On 1/17/2024 2:22 PM, Ma Jun wrote: >> The power source flag should be updated when >> [1] System receives an interrupt indicating that the power source >> has changed. >> [2] System resumes from suspend or runtime suspend >> >> Signed-off-by: Ma

RE: [PATCH 2/2] update check condition of query for ras page retire

2024-01-17 Thread Zhou1, Tao
[AMD Official Use Only - General] Sure, will revert related patch in the next version. Regards, Tao > -Original Message- > From: Zhang, Hawking > Sent: Wednesday, January 17, 2024 8:09 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao > Subject: RE: [PATCH 2/2] updat

Re: [PATCH 1/2] drm/amdgpu: Reset IH OVERFLOW_CLEAR bit after writing rptr

2024-01-17 Thread Friedrich Vock
On 18.01.24 00:00, Alex Deucher wrote: On Wed, Jan 17, 2024 at 7:36 AM Christian König wrote: Am 16.01.24 um 11:31 schrieb Friedrich Vock: On 16.01.24 08:03, Christian König wrote: Am 15.01.24 um 12:18 schrieb Friedrich Vock: [SNIP] +if (ih->overflow) { +tmp = RREG32(mmIH_RB_CNT

Re: [PATCH 1/2] drm/amdgpu: Reset IH OVERFLOW_CLEAR bit after writing rptr

2024-01-17 Thread Alex Deucher
On Wed, Jan 17, 2024 at 7:36 AM Christian König wrote: > > Am 16.01.24 um 11:31 schrieb Friedrich Vock: > > On 16.01.24 08:03, Christian König wrote: > >> Am 15.01.24 um 12:18 schrieb Friedrich Vock: > >>> [SNIP] > > +if (ih->overflow) { > > +tmp = RREG32(mmIH_RB_CNTL); > >

Re: [PATCH v2] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions

2024-01-17 Thread Rodrigo Siqueira Jordao
Hi Srinivasan On 1/17/24 08:23, Srinivasan Shanmugam wrote: The 'status' variable in 'core_link_read_dpcd()' & 'core_link_write_dpcd()' was uninitialized. Thus, initializing 'status' variable to 'DC_ERROR_UNEXPECTED' by default. Fixes the below: drivers/gpu/drm/amd/amdgpu/../display/dc/link/pr

[PATCH 2/2] amdgpu: use trace_dma_fence_sync_to in amdgpu_fence_sync

2024-01-17 Thread Pierre-Eric Pelloux-Prayer
This makes it possible to understand the dependencies between jobs. Possible usage of this trace: * stuttering issues like Mesa !9189 * incorrect synchronization: I don't have a link for this one, but having these events was very useful to debug a virtio-gpu / native-context / radeonsi sync iss

[PATCH 1/2] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-01-17 Thread Pierre-Eric Pelloux-Prayer
This new event can be used to trace where a given dma_fence is added as a dependency of some other work. I plan to use it in amdgpu. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/dma-buf/dma-fence.c | 1 + include/trace/events/dma_fence.h | 34 2 f

[PATCH] drm/amd/amdgpu: Assign GART pages to AMD device mapping

2024-01-17 Thread Tom St Denis
This allows kernel mapped pages like the PDB and PTB to be read via the iomem debugfs when there is no vram in the system. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ga

[PATCH v2] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions

2024-01-17 Thread Srinivasan Shanmugam
The 'status' variable in 'core_link_read_dpcd()' & 'core_link_write_dpcd()' was uninitialized. Thus, initializing 'status' variable to 'DC_ERROR_UNEXPECTED' by default. Fixes the below: drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:226 core_link_read_dpcd() error: uninitial

Re: [PATCH] drm/amdgpu: only remove existing FBs for devices with displays

2024-01-17 Thread Alex Deucher
On Wed, Jan 17, 2024 at 2:42 AM Christian König wrote: > > Am 16.01.24 um 15:39 schrieb Alex Deucher: > > Seems calling drm_aperture_remove_conflicting_pci_framebuffers() > > will take away the apertures for unrelated devices on some kernel > > versions. E.g., calling this on a PCIe accelerator w

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-17 Thread Michel Dänzer
On 2024-01-17 13:57, Xaver Hugl wrote: > Am Mi., 17. Jan. 2024 um 09:55 Uhr schrieb Pekka Paalanen > : >> Is it important enough to be special-cased, e.g. to be always allowed >> with async commits? > > I thought so, and sent a patch to dri-devel to make it happen, but > there are some > concerns

Re: [PATCH] drm/amdgpu/pm: Fix the power source flag error

2024-01-17 Thread Alex Deucher
On Wed, Jan 17, 2024 at 4:01 AM Ma Jun wrote: > > The power source flag should be updated when > [1] System receives an interrupt indicating that the power source > has changed. > [2] System resumes from suspend or runtime suspend > > Signed-off-by: Ma Jun > --- > drivers/gpu/drm/amd/pm/swsmu/am

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-17 Thread Xaver Hugl
Am Mi., 17. Jan. 2024 um 09:55 Uhr schrieb Pekka Paalanen : > Is it important enough to be special-cased, e.g. to be always allowed > with async commits? I thought so, and sent a patch to dri-devel to make it happen, but there are some concerns about untested driver paths. https://lists.freedeskto

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-17 Thread Andri Yngvason
mið., 17. jan. 2024 kl. 09:21 skrifaði Pekka Paalanen : > > On Tue, 16 Jan 2024 14:11:43 + > Andri Yngvason wrote: > > > þri., 16. jan. 2024 kl. 13:29 skrifaði Sebastian Wick > > : > > > > > > On Tue, Jan 16, 2024 at 01:13:13PM +, Andri Yngvason wrote: > > [...] > > > > şri., 16. jan. 2024

Re: [PATCH 1/2] drm/amdgpu: Reset IH OVERFLOW_CLEAR bit after writing rptr

2024-01-17 Thread Christian König
Am 16.01.24 um 11:31 schrieb Friedrich Vock: On 16.01.24 08:03, Christian König wrote: Am 15.01.24 um 12:18 schrieb Friedrich Vock: [SNIP] +    if (ih->overflow) { +    tmp = RREG32(mmIH_RB_CNTL); +    tmp &= ~IH_RB_CNTL__WPTR_OVERFLOW_CLEAR_MASK; +    WREG32(mmIH_RB_CNTL, tmp); + 

RE: [PATCH 2/2] update check condition of query for ras page retire

2024-01-17 Thread Zhang, Hawking
[AMD Official Use Only - General] static ssize_t smu_v13_0_6_get_ecc_info(struct smu_context *smu, void *table) { - /* Support ecc info by default */ - return 0; + /* we use debug mode flag instead of this interface */ + return -EOPNOTSUPP; } Shal

RE: [PATCH 1/2] update error condition check for umc_v12_0_query_error_address

2024-01-17 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Wednesday, January 17, 2024 17:14 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 1/2] update error condition check for umc_v12_0

RE: [PATCH 3/5] drm/amdgpu: Use asynchronous polling to handle umc_v12_0 poisoning

2024-01-17 Thread Zhang, Hawking
[AMD Official Use Only - General] Please check my comments inline Regards, Hawking -Original Message- From: Chai, Thomas Sent: Tuesday, January 16, 2024 16:21 To: amd-gfx@lists.freedesktop.org Cc: Chai, Thomas ; Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, St

RE: [PATCH 1/5] drm/amdgpu: Add log info for umc_v12_0 and smu_v13_0_6

2024-01-17 Thread Zhang, Hawking
[AMD Official Use Only - General] Please ignore my first comment. It doesn't necessarily associated with socket id in UMC MCA status log at this stage. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: Wednesday, January 17, 2024 19:12 To: Chai, Thom

RE: [PATCH 1/5] drm/amdgpu: Add log info for umc_v12_0 and smu_v13_0_6

2024-01-17 Thread Zhang, Hawking
[AMD Official Use Only - General] + dev_info(adev->dev, + "MCA_UMC_STATUS(0x%llx): Val:%llu, Poison:%llu, Deferred:%llu, PCC:%llu, UC:%llu, TCC:%llu\n", + mc_umc_status, Please also print out socket id for UMC MCA status. + dev_info(smu->adev->dev, "MSG %

Re: [PATCH] drm/amdgpu/pm: Fix the power source flag error

2024-01-17 Thread Lazar, Lijo
On 1/17/2024 2:22 PM, Ma Jun wrote: The power source flag should be updated when [1] System receives an interrupt indicating that the power source has changed. [2] System resumes from suspend or runtime suspend Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 24 +

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-17 Thread Andri Yngvason
Hi Sebastian, þri., 16. jan. 2024 kl. 11:42 skrifaði Sebastian Wick : > > On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > > From: Werner Sembach > > > > Add a new general drm property "force color format" which can be used > > by userspace to tell the graphics driver which color

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-17 Thread Xaver Hugl
My plan is to require support for IN_FENCE_FD at least. If the driver doesn't allow tearing with that, then tearing just doesn't happen. For overlay planes though, it depends on how the compositor prioritizes things. If the compositor prioritizes overlay planes and would like to do tearing if poss

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-17 Thread Andri Yngvason
þri., 16. jan. 2024 kl. 13:29 skrifaði Sebastian Wick : > > On Tue, Jan 16, 2024 at 01:13:13PM +, Andri Yngvason wrote: [...] > > şri., 16. jan. 2024 kl. 11:42 skrifaği Sebastian Wick > > : > > > > > > On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > > > > From: Werner Sembach

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-17 Thread Pekka Paalanen
On Tue, 16 Jan 2024 14:11:43 + Andri Yngvason wrote: > þri., 16. jan. 2024 kl. 13:29 skrifaði Sebastian Wick > : > > > > On Tue, Jan 16, 2024 at 01:13:13PM +, Andri Yngvason wrote: > [...] > > > şri., 16. jan. 2024 kl. 11:42 skrifaği Sebastian Wick > > > : > > > > > > > > On Mon, Jan

[PATCH 2/2] update check condition of query for ras page retire

2024-01-17 Thread Tao Zhou
Support page retirement handling in debug mode. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 9 +++-- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 ++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 1/2] update error condition check for umc_v12_0_query_error_address

2024-01-17 Thread Tao Zhou
Deferred error is also taken into account. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c index 10edf818acf5..2e0bd4312f2c

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-17 Thread Pekka Paalanen
On Tue, 16 Jan 2024 17:10:18 +0100 Xaver Hugl wrote: > My plan is to require support for IN_FENCE_FD at least. If the driver > doesn't > allow tearing with that, then tearing just doesn't happen. That's an excellent point. I think this is important enough in its own right, that it should be call

[PATCH] drm/amdgpu/pm: Fix the power source flag error

2024-01-17 Thread Ma Jun
The power source flag should be updated when [1] System receives an interrupt indicating that the power source has changed. [2] System resumes from suspend or runtime suspend Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 24 +++ .../gpu/drm/amd/pm/swsm