Re: [PATCH v3 2/5] drm:amdgpu: Enable IH ring1 for IH v6.1

2024-04-16 Thread Christian König
Am 17.04.24 um 08:43 schrieb Friedrich Vock: On 16.04.24 15:34, Sunil Khatri wrote: We need IH ring1 for handling the pagefault interrupts which over flow in default ring for specific usecases. Signed-off-by: Sunil Khatri ---   drivers/gpu/drm/amd/amdgpu/ih_v6_1.c | 11 +--   1 file chan

Re: [PATCH v2] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-16 Thread Christian König
Am 17.04.24 um 08:21 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS flag in the buffer's placement function. This patch will change

Re: [PATCH v3 2/5] drm:amdgpu: Enable IH ring1 for IH v6.1

2024-04-16 Thread Friedrich Vock
On 16.04.24 15:34, Sunil Khatri wrote: We need IH ring1 for handling the pagefault interrupts which over flow in default ring for specific usecases. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/ih_v6_1.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --g

[PATCH v2] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-16 Thread Arunpravin Paneer Selvam
Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS flag in the buffer's placement function. This patch will change the default behaviour of the two flags. When we set AMDG

RE: [PATCH] drm/amdgpu/pm: Remove gpu_od if it's an empty directory

2024-04-16 Thread Wang, Yang(Kevin)
Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Ma, Jun Sent: 2024年4月17日 13:54 To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Deucher, Alexander ; Wang, Yang(Kevin) ; Lazar, Lijo ; Ma, Jun Subject: [PATCH] drm/amdgpu/pm: Remove gpu_od if it's an empty dire

[PATCH] drm/amdgpu/pm: Remove gpu_od if it's an empty directory

2024-04-16 Thread Ma Jun
gpu_od should be removed if it's an empty directory Signed-off-by: Ma Jun Reported-by: Yang Wang --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index a20e03e69d38..0c13e55

[PATCH v3 2/6] drm/amdgpu: add support of gfx10 register dump

2024-04-16 Thread Sunil Khatri
Adding gfx10 gc registers to be used for register dump via devcoredump during a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 8 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 4 + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 130 ++

[PATCH v3 4/6] drm/amdgpu: add support for gfx v10 print

2024-04-16 Thread Sunil Khatri
Add support to print ip information to be used to print registers in devcoredump buffer. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/

[PATCH v3 5/6] drm/amdgpu: dump ip state before reset for each ip

2024-04-16 Thread Sunil Khatri
Invoke the dump_ip_state function for each ip before the asic resets and save the register values for debugging via devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH v3 6/6] drm/amdgpu: add ip dump for each ip in devcoredump

2024-04-16 Thread Sunil Khatri
Add ip dump for each ip of the asic in the devcoredump for all the ips where a callback is registered for register dump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v3 3/6] drm/amdgpu: add protype for print ip state

2024-04-16 Thread Sunil Khatri
Add the protoype for print ip state to be used to print the registers in devcoredump during a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c

[PATCH v3 1/6] drm/amdgpu: add prototype for ip dump

2024-04-16 Thread Sunil Khatri
Add the prototype to dump ip registers for all ips of different asics and set them to NULL for now. Based on the requirement add a function pointer for each of them. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_m

Re: [PATCH v2] drm/amdgpu: Skip the coredump collection on reset during driver reload

2024-04-16 Thread Lazar, Lijo
On 4/17/2024 9:43 AM, Ahmad Rehman wrote: > In passthrough environment, the driver triggers the mode-1 reset on > reload. The reset causes the core dump collection which is delayed task > and prevents driver from unloading until it is completed. Since we do > not need to collect data on "reset o

[PATCH v2] drm/amdgpu: Skip the coredump collection on reset during driver reload

2024-04-16 Thread Ahmad Rehman
In passthrough environment, the driver triggers the mode-1 reset on reload. The reset causes the core dump collection which is delayed task and prevents driver from unloading until it is completed. Since we do not need to collect data on "reset on reload" case, we can skip core dump collection. v2

Re: [PATCH] drm/amdgpu: Skip the coredump collection on reset during driver reload

2024-04-16 Thread Lazar, Lijo
On 4/17/2024 12:05 AM, Ahmad Rehman wrote: > In passthrough environment, the driver triggers the mode-1 reset on > reload. The reset causes the core dump collection which is delayed task > and prevents driver from unloading until it is completed. Since we do > not need to collect data on "reset

[PATCH] drm/amdgpu: add ACA error query support for umc_v12_0

2024-04-16 Thread Yang Wang
add ACA error query support for umc_v12_0. Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 4 drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 18 ++ 3 files changed, 21 insertions(+), 7 deletions(-) diff

[linux-next:master] BUILD REGRESSION 66e4190e92ce0e4a50b2f6be0e5f5b2e47e072f4

2024-04-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 66e4190e92ce0e4a50b2f6be0e5f5b2e47e072f4 Add linux-next specific files for 20240416 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404161933.izfqz32k-...@intel.com https

Re: [PATCH] rock-dgb_defconfig: Update for Linux 6.7 with UBSAN

2024-04-16 Thread Felix Kuehling
On 2024-04-16 13:02, Chen, Xiaogang wrote: On 4/15/2024 2:49 PM, Felix Kuehling wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. make rock-dbg_defconfig make savedefconfig cp defconfig arch/x86/config

Re: [PATCH 4/6] drm/amdgpu: add support for gfx v10 print

2024-04-16 Thread Alex Deucher
On Tue, Apr 16, 2024 at 1:36 PM Khatri, Sunil wrote: > > > On 4/16/2024 7:27 PM, Alex Deucher wrote: > > On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote: > > Add support to print ip information to be > used to print registers in devcoredump > buffer. > > Signed-off-by: Sunil Khatri > --- > d

[PATCH v2 3/6] drm/amdgpu: add protype for print ip state

2024-04-16 Thread Sunil Khatri
Add the protoype for print ip state to be used to print the registers in devcoredump during a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c

[PATCH v2 6/6] drm/amdgpu: add ip dump for each ip in devcoredump

2024-04-16 Thread Sunil Khatri
Add ip dump for each ip of the asic in the devcoredump for all the ips where a callback is registered for register dump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v2 5/6] drm/amdgpu: dump ip state before reset for each ip

2024-04-16 Thread Sunil Khatri
Invoke the dump_ip_state function for each ip before the asic resets and save the register values for debugging via devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH v2 1/6] drm/amdgpu: add prototype for ip dump

2024-04-16 Thread Sunil Khatri
Add the prototype to dump ip registers for all ips of different asics and set them to NULL for now. Based on the requirement add a function pointer for each of them. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_m

[PATCH v2 4/6] drm/amdgpu: add support for gfx v10 print

2024-04-16 Thread Sunil Khatri
Add support to print ip information to be used to print registers in devcoredump buffer. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/

[PATCH v2 2/6] drm/amdgpu: add support of gfx10 register dump

2024-04-16 Thread Sunil Khatri
Adding gfx10 gc registers to be used for register dump via devcoredump during a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 8 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 4 + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 130 ++

[PATCH 0/6] Infrastructure to dump ip registers in devcoredump

2024-04-16 Thread Sunil Khatri
starting with gfx 10 registers here we add the complete infra for ip dump needed in devcoredump. Sunil Khatri (6): drm/amdgpu: add prototype for ip dump drm/amdgpu: add support of gfx10 register dump drm/amdgpu: add protype for print ip state drm/amdgpu: add support for gfx v10 print drm

[PATCH] drm/amdgpu: Skip the coredump collection on reset during driver reload

2024-04-16 Thread Ahmad Rehman
In passthrough environment, the driver triggers the mode-1 reset on reload. The reset causes the core dump collection which is delayed task and prevents driver from unloading until it is completed. Since we do not need to collect data on "reset on reload" case, we can skip core dump collection. Si

Re: [PATCH 6/6] drm/amdgpu: add ip dump for each ip in devcoredump

2024-04-16 Thread Khatri, Sunil
On 4/16/2024 7:29 PM, Alex Deucher wrote: On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote: Add ip dump for each ip of the asic in the devcoredump for all the ips where a callback is registered for register dump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_dev_core

Re: [PATCH 4/6] drm/amdgpu: add support for gfx v10 print

2024-04-16 Thread Khatri, Sunil
On 4/16/2024 7:27 PM, Alex Deucher wrote: On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote: Add support to print ip information to be used to print registers in devcoredump buffer. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 17 - 1 file chang

Re: [PATCH 2/6] drm/amdgpu: add support of gfx10 register dump

2024-04-16 Thread Khatri, Sunil
On 4/16/2024 7:30 PM, Christian König wrote: Am 16.04.24 um 15:55 schrieb Alex Deucher: On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote: Adding gfx10 gc registers to be used for register dump via devcoredump during a gpu reset. Signed-off-by: Sunil Khatri ---   drivers/gpu/drm/amd/amdgpu

Re: [PATCH 2/6] drm/amdgpu: add support of gfx10 register dump

2024-04-16 Thread Khatri, Sunil
On 4/16/2024 7:25 PM, Alex Deucher wrote: On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote: Adding gfx10 gc registers to be used for register dump via devcoredump during a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 12 ++ drivers/gpu/drm/a

Re: [PATCH] rock-dgb_defconfig: Update for Linux 6.7 with UBSAN

2024-04-16 Thread Chen, Xiaogang
On 4/15/2024 2:49 PM, Felix Kuehling wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. make rock-dbg_defconfig make savedefconfig cp defconfig arch/x86/config/rock-dbg_defconfig This also enables UBSA

Re: [PATCH v3 4/5] drm/amdgpu: enable redirection of irq's for IH V6.0

2024-04-16 Thread Khatri, Sunil
On 4/16/2024 7:56 PM, Alex Deucher wrote: On Tue, Apr 16, 2024 at 9:34 AM Sunil Khatri wrote: Enable redirection of irq for pagefaults for specific clients to avoid overflow without dropping interrupts. So here we redirect the interrupts to another IH ring i.e ring1 where only these interrup

Re: [PATCH 1/6] drm/amdgpu: Support contiguous VRAM allocation

2024-04-16 Thread Philip Yang
On 2024-04-15 08:02, Christian König wrote: Am 12.04.24 um 22:12 schrieb Philip Yang: RDMA device with limited scatter-gather capability requires physical address contiguous VRAM buffer for RDMA peer direct access.

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-16 Thread Philip Yang
On 2024-04-16 02:50, Paneer Selvam, Arunpravin wrote: On 4/16/2024 3:32 AM, Philip Yang wrote: On 2024-04-14 10:57, Arunpravin Paneer Selvam wrote: Now we have two flags for contiguous

Re: [PATCH v3 4/5] drm/amdgpu: enable redirection of irq's for IH V6.0

2024-04-16 Thread Alex Deucher
On Tue, Apr 16, 2024 at 9:34 AM Sunil Khatri wrote: > > Enable redirection of irq for pagefaults for specific > clients to avoid overflow without dropping interrupts. > > So here we redirect the interrupts to another IH ring > i.e ring1 where only these interrupts are processed. > > Signed-off-by:

Re: [PATCH 2/2] drm/amdgpu: IB test encode test package change for VCN5

2024-04-16 Thread Jiang, Sonny
[AMD Official Use Only - General] These changes are for vcn_unified_ring_test_ib which only used on VCN4 and VCN5. The only exception is ib_size_alignment of hw_ip_info. The VCN5 adds address_patch_enabled in session_info. VCN4 doesn't have it, so it should just ignore the extra 0. typedef str

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-16 Thread Harry Wentland
On 2024-04-16 04:01, Pekka Paalanen wrote: > On Mon, 15 Apr 2024 18:33:39 -0400 > Leo Li wrote: > >> On 2024-04-15 04:19, Pekka Paalanen wrote: >>> On Fri, 12 Apr 2024 16:14:28 -0400 >>> Leo Li wrote: >>> On 2024-04-12 11:31, Alex Deucher wrote: > On Fri, Apr 12, 2024 at 11:08 A

Re: Proposal to add CRIU support to DRM render nodes

2024-04-16 Thread Tvrtko Ursulin
On 01/04/2024 18:58, Felix Kuehling wrote: On 2024-04-01 12:56, Tvrtko Ursulin wrote: On 01/04/2024 17:37, Felix Kuehling wrote: On 2024-04-01 11:09, Tvrtko Ursulin wrote: On 28/03/2024 20:42, Felix Kuehling wrote: On 2024-03-28 12:03, Tvrtko Ursulin wrote: Hi Felix, I had one more t

Re: [PATCH 2/6] drm/amdgpu: add support of gfx10 register dump

2024-04-16 Thread Christian König
Am 16.04.24 um 15:55 schrieb Alex Deucher: On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote: Adding gfx10 gc registers to be used for register dump via devcoredump during a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 12 ++ drivers/gpu/drm/

Re: [PATCH 6/6] drm/amdgpu: add ip dump for each ip in devcoredump

2024-04-16 Thread Alex Deucher
On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote: > > Add ip dump for each ip of the asic in the > devcoredump for all the ips where a callback > is registered for register dump. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 15 +++ > 1

Re: [PATCH 4/6] drm/amdgpu: add support for gfx v10 print

2024-04-16 Thread Alex Deucher
On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote: > > Add support to print ip information to be > used to print registers in devcoredump > buffer. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 17 - > 1 file changed, 16 insertions(+), 1 deleti

Re: [PATCH 2/6] drm/amdgpu: add support of gfx10 register dump

2024-04-16 Thread Alex Deucher
On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote: > > Adding gfx10 gc registers to be used for register > dump via devcoredump during a gpu reset. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 12 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h |

Re: [PATCH v3 1/5] drm:amdgpu: enable IH RB ring1 for IH v6.0

2024-04-16 Thread Christian König
Am 16.04.24 um 15:34 schrieb Sunil Khatri: We need IH ring1 for handling the pagefault interrupts which are overflowing the default ring for specific usecases. Signed-off-by: Sunil Khatri Reviewed-by: Christian König for the entire series. --- drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 11

[PATCH v3 1/5] drm:amdgpu: enable IH RB ring1 for IH v6.0

2024-04-16 Thread Sunil Khatri
We need IH ring1 for handling the pagefault interrupts which are overflowing the default ring for specific usecases. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ih_

[PATCH v3 2/5] drm:amdgpu: Enable IH ring1 for IH v6.1

2024-04-16 Thread Sunil Khatri
We need IH ring1 for handling the pagefault interrupts which over flow in default ring for specific usecases. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/ih_v6_1.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ih_v6_1.c

[PATCH v3 5/5] drm/amdgpu: enable redirection of irq's for IH V6.1

2024-04-16 Thread Sunil Khatri
Enable redirection of irq for pagefaults for specific clients to avoid overflow without dropping interrupts. So here we redirect the interrupts to another IH ring i.e ring1 where only these interrupts are processed. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/ih_v6_1.c | 15 +

[PATCH v3 4/5] drm/amdgpu: enable redirection of irq's for IH V6.0

2024-04-16 Thread Sunil Khatri
Enable redirection of irq for pagefaults for specific clients to avoid overflow without dropping interrupts. So here we redirect the interrupts to another IH ring i.e ring1 where only these interrupts are processed. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 15 +

[PATCH v3 3/5] drm/amdgpu: Add IH_RING1_CFG headers for IH v6.0

2024-04-16 Thread Sunil Khatri
Add offsets, mask and shift macros for IH v6.0 which are needed to configure ring1 client irq redirection. Signed-off-by: Sunil Khatri --- .../drm/amd/include/asic_reg/oss/osssys_6_0_0_offset.h | 4 .../amd/include/asic_reg/oss/osssys_6_0_0_sh_mask.h| 10 ++ 2 files changed, 14

reportbug-linux-image-6.1.0-20-amd64-20240416120723-rsdr2h84

2024-04-16 Thread lv . oats-soap
reportbug-linux-image-6.1.0-20-amd64-20240416120723-rsdr2h84 Hi Daniel, Alexander, Bug Team I am very humble to reporting this same (from YOU) BUG that has killed a new ROG16" within hours of a 1st Debian Install (some glitches I believe already from the install Menue), here this also has a

[PATCH v5.10] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-16 Thread Zhu Wang
From: Nicholas Kazlauskas stable inclusion from stable-v6.7.3 commit 2ef98c6d753a7 ("drm/amd/display: Wake DMCUB before executing GPINT commands") category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9BV4C CVE: CVE-2023-52624 Reference: https://git.kernel.org/pub/scm/linu

Re: [PATCH] drm/amdgpu: validate the parameters of bo mapping operations more clearly

2024-04-16 Thread Jann Horn
On Fri, Apr 12, 2024 at 9:36 AM xinhui pan wrote: > Verify the parameters of > amdgpu_vm_bo_(map/replace_map/clearing_mappings) in one common place. > > Reported-by: Vlad Stolyarov > Suggested-by: Christian König > Signed-off-by: xinhui pan Please add something like this when committing the fi

Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-16 Thread Greg KH
On Tue, Apr 16, 2024 at 03:52:40AM +, Zhu Wang wrote: > From: Nicholas Kazlauskas > > stable inclusion > from stable-v6.7.3 > commit 2ef98c6d753a744e333b7e34b9cf687040fba57d > category: bugfix > bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9BV4C > CVE: CVE-2023-52624 > > Referenc

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-16 Thread Pekka Paalanen
On Mon, 15 Apr 2024 18:33:39 -0400 Leo Li wrote: > On 2024-04-15 04:19, Pekka Paalanen wrote: > > On Fri, 12 Apr 2024 16:14:28 -0400 > > Leo Li wrote: > > > >> On 2024-04-12 11:31, Alex Deucher wrote: > >>> On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen > >>> wrote: > > On Fri

Re: [PATCH v5.10] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-16 Thread Greg KH
On Tue, Apr 16, 2024 at 02:43:47AM +, Zhu Wang wrote: > From: Nicholas Kazlauskas > > stable inclusion > from stable-v6.7.3 > commit2ef98c6d753a7 ("drm/amd/display: Wake DMCUB before executing > GPINT commands") > category: bugfix > bugzilla: https://gitee.com/src-openeuler/kernel/is

Re: [PATCH] drm/radeon: make -fstrict-flex-arrays=3 happy

2024-04-16 Thread Kees Cook
On Mon, Apr 15, 2024 at 09:38:16AM -0400, Alex Deucher wrote: > The driver parses a union where the layout up through the first > array is the same, however, the array has different sizes > depending on the elements in the union. Be explicit to > fix the UBSAN checker. > > Closes: https://gitlab.

Re: [PATCH] drm/radeon: silence UBSAN warning (v3)

2024-04-16 Thread Kees Cook
On Fri, Apr 12, 2024 at 10:28:19AM -0400, Alex Deucher wrote: > Convert a variable sized array from [1] to []. > > v2: fix up a few more. > v3: integrate comments from Kees. > > Tested-by: Jeff Johnson > Acked-by: Christian König (v1) > Signed-off-by: Alex Deucher LGTM! :) Reviewed-by: Kees

AMD-Scatter-Gather-Re-Enabled(phoronix)

2024-04-16 Thread lv . oats-soap
Hi Daniel, Alexander, Bug Team I am very humble to reporting this same (from YOU) BUG that has killed a new ROG16" within hours of a 1st Debian Install (some glitches I believe already from the install Menue), here this also has appearently destroyed my internal HARDWARE / BIOS graphics (Gli

[PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-16 Thread Zhu Wang
From: Nicholas Kazlauskas stable inclusion from stable-v6.7.3 commit 2ef98c6d753a744e333b7e34b9cf687040fba57d category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9BV4C CVE: CVE-2023-52624 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-16 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/16/2024 6:24 PM, Christian König wrote: Am 16.04.24 um 14:34 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 5:47 PM, Christian König wrote: Am 16.04.24 um 14:16 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote: A

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-16 Thread Christian König
Am 16.04.24 um 14:34 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 5:47 PM, Christian König wrote: Am 16.04.24 um 14:16 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote: Am 15.04.24 um 20:48 schrieb Arunpravin Paneer Selvam: We sho

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-16 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/16/2024 5:47 PM, Christian König wrote: Am 16.04.24 um 14:16 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote: Am 15.04.24 um 20:48 schrieb Arunpravin Paneer Selvam: We should clear the memory on free. Otherwise, there is a chanc

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-16 Thread Christian König
Am 16.04.24 um 14:16 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote: Am 15.04.24 um 20:48 schrieb Arunpravin Paneer Selvam: We should clear the memory on free. Otherwise, there is a chance that we will access the previous application data and this

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-16 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote: Am 15.04.24 um 20:48 schrieb Arunpravin Paneer Selvam: We should clear the memory on free. Otherwise, there is a chance that we will access the previous application data and this would leads to an abnormal behaviour in the current appli

[PATCH 4/6] drm/amdgpu: add support for gfx v10 print

2024-04-16 Thread Sunil Khatri
Add support to print ip information to be used to print registers in devcoredump buffer. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/

[PATCH 3/6] drm/amdgpu: add protype for print ip state

2024-04-16 Thread Sunil Khatri
Add the protoype for print ip state to be used to print the registers in devcoredump during a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c

[PATCH 2/6] drm/amdgpu: add support of gfx10 register dump

2024-04-16 Thread Sunil Khatri
Adding gfx10 gc registers to be used for register dump via devcoredump during a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 12 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 4 + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 131 ++

[PATCH 1/6] drm/amdgpu: add prototype for ip dump

2024-04-16 Thread Sunil Khatri
Add the prototype to dump ip registers for all ips of different asics and set them to NULL for now. Based on the requirement add a function pointer for each of them. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_m

[PATCH 6/6] drm/amdgpu: add ip dump for each ip in devcoredump

2024-04-16 Thread Sunil Khatri
Add ip dump for each ip of the asic in the devcoredump for all the ips where a callback is registered for register dump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgp

[PATCH 5/6] drm/amdgpu: dump ip state before reset for each ip

2024-04-16 Thread Sunil Khatri
Invoke the dump_ip_state function for each ip before the asic resets and save the register values for debugging via devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 0/6] Infrastructure to dump ip registers in devcoredump

2024-04-16 Thread Sunil Khatri
starting with gfx 10 registers here we add the complete infra for ip dump needed in devcoredump. Sunil Khatri (6): drm/amdgpu: add prototype for ip dump drm/amdgpu: add support of gfx10 register dump drm/amdgpu: add protype for print ip state drm/amdgpu: add support for gfx v10 print drm

Re: [PATCH v2] drm/amdkfd: make sure VM is ready for updating operations

2024-04-16 Thread Christian König
Looks valid to me of hand, but it's really Felix who needs to judge this. On the other hand if it blocks any CI feel free to add my acked-by and submit it. Christian. Am 16.04.24 um 04:05 schrieb Yu, Lang: [Public] ping -Original Message- From: Yu, Lang Sent: Thursday, April 11,

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-16 Thread Christian König
Am 15.04.24 um 20:48 schrieb Arunpravin Paneer Selvam: We should clear the memory on free. Otherwise, there is a chance that we will access the previous application data and this would leads to an abnormal behaviour in the current application. Mhm, I would strongly expect that we initialize the

[PATCH 1/3] drm/amdgpu: Add AMDGPU benchmark dump function skeleton

2024-04-16 Thread Prike Liang
This will add the following bechmark dump for the amdgpu driver performance tunning. 1. AMDGPU hardware configuration. 2. AMDGPU engine clock setting 3. AMDGPU link speed 4. AMDGPU momory move performance Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + driv

[PATCH 2/3] drm/amdgpu: add firmware info to benchmark metrics

2024-04-16 Thread Prike Liang
Export the firmware info in the benchmark metrics. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 + 3 files changed, 10 insertions(+), 1 deletion(-

[PATCH 3/3] drm/amdgpu: add the amdgpu buffer object move speed metrics

2024-04-16 Thread Prike Liang
Add the amdgpu buffer object move speed metrics. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 78 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- 3 files changed, 61 insertions(+),

Re: [PATCH V2] drm/amdgpu: Fix incorrect return value

2024-04-16 Thread Christian König
Well multiple things to consider here. This is clearly not called from the interrupt, otherwise locking a mutex would be illegal. So question is who is calling this? And can the function be called from different threads at the same time? As far as I can see you don't take that into account in

Re: [PATCH] drm/ttm: Make ttm shrinkers NUMA aware

2024-04-16 Thread Christian König
Am 08.04.24 um 19:49 schrieb Rajneesh Bhardwaj: Otherwise the nid is always passed as 0 during memory reclaim so make TTM shrinkers NUMA aware. Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/ttm/ttm_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-16 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/16/2024 1:16 PM, Christian König wrote: Am 16.04.24 um 00:02 schrieb Philip Yang: On 2024-04-14 10:57, Arunpravin Paneer Selvam wrote: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-16 Thread Christian König
Am 16.04.24 um 00:02 schrieb Philip Yang: On 2024-04-14 10:57, Arunpravin Paneer Selvam wrote: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS flag in the buffer's pla