Re: [PATCH 4/6] drm/amdgpu: add macro of umc for each channel

2019-08-01 Thread Deucher, Alexander
Please include a patch description. Explain why you need the new helper function. Alex From: amd-gfx on behalf of Tao Zhou Sent: Thursday, August 1, 2019 2:43 AM To: amd-gfx@lists.freedesktop.org ; Zhang, Hawking ; Li, Dennis ; Chen, Guchun ; Pan, Xinhui

Re: [PATCH 2/6] drm/amdgpu: add more parameters and functions to amdgpu_umc structure

2019-08-01 Thread Deucher, Alexander
Please include a patch description. Explain why you need the new interface. Alex From: amd-gfx on behalf of Tao Zhou Sent: Thursday, August 1, 2019 2:43 AM To: amd-gfx@lists.freedesktop.org ; Zhang, Hawking ; Li, Dennis ; Chen, Guchun ; Pan, Xinhui Cc:

Re: [PATCH 3/6] drm/amdgpu: initialize new parameters and functions for amdgpu_umc structure

2019-08-01 Thread Deucher, Alexander
Please include a patch description. Alex From: amd-gfx on behalf of Tao Zhou Sent: Thursday, August 1, 2019 2:43 AM To: amd-gfx@lists.freedesktop.org ; Zhang, Hawking ; Li, Dennis ; Chen, Guchun ; Pan, Xinhui Cc: Zhou1, Tao Subject: [PATCH 3/6] drm/amdgpu:

Re: [PATCH 1/6] drm/amdgpu: remove the clear of MCA_ADDR

2019-08-01 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Tao Zhou Sent: Thursday, August 1, 2019 2:43 AM To: amd-gfx@lists.freedesktop.org ; Zhang, Hawking ; Li, Dennis ; Chen, Guchun ; Pan, Xinhui Cc: Zhou1, Tao Subject: [PATCH 1/6] drm/amdgpu: remove the

Re: [PATCH] drm/amdgpu: Update pitch on page flips without DC as well

2019-07-29 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Monday, July 29, 2019 12:20 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: Update pitch on page flips without DC as well From: Michel Dänzer DC already handles this

Re: [PATCH] drm/amdgpu: Fix amdgpu_display_supported_domains logic.

2019-07-26 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Andrey Grodzovsky Sent: Friday, July 26, 2019 9:28 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Grodzovsky, Andrey ; mic...@daenzer.net ; Koenig, Christian ; S, Shirish Subject: [PATCH

Re: [PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu

2019-07-26 Thread Deucher, Alexander
Sure. Alex From: Wang, Kevin(Yang) Sent: Friday, July 26, 2019 5:05 AM To: StDenis, Tom ; Deucher, Alexander ; Huang, Ray ; Quan, Evan ; amd-gfx@lists.freedesktop.org ; Zhang, Hawking Cc: Feng, Kenneth Subject: Re: [PATCH 5/5] drm/amd/powerplay: implment

Re: [PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu

2019-07-25 Thread Deucher, Alexander
Tom, does umr use it? Alex From: Huang, Ray Sent: Thursday, July 25, 2019 4:49 AM To: Wang, Kevin(Yang) ; Quan, Evan ; amd-gfx@lists.freedesktop.org ; Zhang, Hawking ; Deucher, Alexander Cc: Feng, Kenneth Subject: RE: [PATCH 5/5] drm/amd/powerplay: implment

Re: [PATCH] drm/amd/powerplay: fix null pointer dereference around dpm state relates

2019-07-25 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, July 25, 2019 12:23 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: fix null pointer dereference around dpm state relates DPM state

Re: [PATCH] drm/amd/powerplay: minor fixes around SW SMU power and fan setting

2019-07-25 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Wednesday, July 24, 2019 10:39 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: minor fixes around SW SMU power and fan setting Add checking for

Re: [PATCH v2 0/2] This series enables S/G for Picasso.

2019-07-23 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Andrey Grodzovsky Sent: Tuesday, July 23, 2019 2:25 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Grodzovsky, Andrey ; Wu, Hersen ; Koenig, Christian ; S, Shirish Subject

Re: [PATCH] drm/amdkfd: Fix byte align on VegaM

2019-07-23 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Russell, Kent Sent: Tuesday, July 23, 2019 10:22 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdkfd: Fix byte align on VegaM This was missed during the addition of VegaM

Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

2019-07-23 Thread Deucher, Alexander
Looks good to me. Acked-by: Alex Deucher From: Wang, Kevin(Yang) Sent: Tuesday, July 23, 2019 5:43 AM To: Feng, Kenneth ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander Subject: Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

Re: [PATCH 2/2] drm/amd/powerplay: some cosmetic fixes

2019-07-23 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Tuesday, July 23, 2019 4:41 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/2] drm/amd/powerplay: some cosmetic fixes Drop redundant check, duplicate check,

Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement

2019-07-22 Thread Deucher, Alexander
We need to add a /*fall through */ comment then. Alex From: Liu, Shaoyun Sent: Monday, July 22, 2019 11:14 AM To: Gustavo A. R. Silva ; Cox, Philip ; Oded Gabbay ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter

Re: [PATCH] drm/amd/powerplay: refine AMDGPU_PP_SENSOR_XXX index for powerplay

2019-07-19 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Wang, Kevin(Yang) Sent: Friday, July 19, 2019 8:17 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang); Huang, Ray; Feng, Kenneth; Quan, Evan Subject: [PATCH] drm/amd/powerplay: refine

Re: [PATCH] drm/amd/powerplay: correct the bit mask for checking VCN power status

2019-07-19 Thread Deucher, Alexander
Sure. That makes more sense. We should switch raven to use it as well. Alex From: Quan, Evan Sent: Friday, July 19, 2019 5:47 AM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: RE: [PATCH] drm/amd/powerplay: correct the bit mask for checking VCN

Re: [PATCH] drm/amdgpu/: use VCN firmware offset for cache window

2019-07-18 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Liu, Leo Sent: Thursday, July 18, 2019 11:46 AM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo Subject: [PATCH] drm/amdgpu/: use VCN firmware offset for cache window Since we are using the signed FW now, and

Re: [PATCH 2/2] drm/amdgpu: add sclk/uclk sensor support for vega20

2019-07-17 Thread Deucher, Alexander
Ah, I missed that they were already handled in smu_v11_0.c. In that case, I think I can drop these patches. Alex From: Quan, Evan Sent: Wednesday, July 17, 2019 8:58 PM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH 2

Re: [PATCH] drm/amdkfd: Remove GWS from process during uninit

2019-07-17 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Greathouse, Joseph Sent: Wednesday, July 17, 2019 10:58 AM To: amd-gfx@lists.freedesktop.org Cc: Greathouse, Joseph Subject: [PATCH] drm/amdkfd: Remove GWS from process during uninit If we shut down a process

Re: [PATCH] drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface

2019-07-17 Thread Deucher, Alexander
RB, thanks, Alex From: amd-gfx on behalf of StDenis, Tom Sent: Wednesday, July 17, 2019 8:44 AM To: Koenig, Christian; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface Thanks. Alex can I

Re: [PATCH] drm/amd/powerplay: report bootup clock as max supported on dpm disabled

2019-07-17 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Wednesday, July 17, 2019 5:34 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Xu, Feifei; Quan, Evan; Ma, Le Subject: [PATCH] drm/amd/powerplay: report bootup clock as max

Re: [PATCH] drm/amdgpu/psp11: check if prior to navi10 for sram map

2019-07-16 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yuan, Xiaojie Sent: Tuesday, July 16, 2019 11:55 AM To: amd-gfx@lists.freedesktop.org Cc: tao1.z...@amd.com; Xiao, Jack; Yuan, Xiaojie; Zhang, Hawking Subject: [PATCH] drm/amdgpu/psp11: check if prior to

Re: [PATCH] drm/amdgpu: Fix Vega20 Perf counter for pcie_bw

2019-07-15 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Russell, Kent Sent: Monday, July 15, 2019 8:54 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdgpu: Fix Vega20 Perf counter for pcie_bw The perf counter for Vega20 is 108, instead

Re: [PATCH] drm/amd/display: avoid 64-bit division

2019-07-09 Thread Deucher, Alexander
peng (Leo); Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter Cc: Liu, Charlene; Park, Chris; Cheng, Tony; Francis, David; linux-ker...@vger.kernel.org; amd-gfx@lists.freedesktop.org; Cornij, Nikola; Laktyushkin, Dmytro; dri-de...@lists.freedesktop.org; Lei

Re: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time

2019-07-09 Thread Deucher, Alexander
: Tuesday, July 9, 2019 1:41 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Grodzovsky, Andrey; Quan, Evan; Wu, Xiaowei Subject: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time Increase the waiting time to 1s from 200ms. This is expected to fix some mode1 reset

Re: [PATCH] drm/amdgpu: don't invalidate caches in RELEASE_MEM, only do the writeback

2019-07-08 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Marek Olšák Sent: Monday, July 8, 2019 1:31 PM To: amd-gfx mailing list Subject: Re: [PATCH] drm/amdgpu: don't invalidate caches in RELEASE_MEM, only do the writeback ping On Tue, Jul 2, 2019 at 2:29 PM Marek

Re: [PATCH 2/2] drm/amdgpu: enable IP discovery by default on navi

2019-07-08 Thread Deucher, Alexander
the table. Alex From: Yuan, Xiaojie Sent: Monday, July 8, 2019 11:31 AM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 2/2] drm/amdgpu: enable IP discovery by default on navi Hi Alex, I see there are many 'auto' module

Re: [PATCH 1/1] drm/amdgpu: Prepare for hmm_range_register API change

2019-07-05 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kuehling, Felix Sent: Friday, July 5, 2019 3:50 PM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip; Kuehling, Felix Subject: [PATCH 1/1] drm/amdgpu: Prepare for hmm_range_register API change From: Philip

Re: Where do I file AMDGPU bugs nowadays?

2019-07-05 Thread Deucher, Alexander
That is the correct bug tracker. Thanks, Alex From: amd-gfx on behalf of Kai-Heng Feng Sent: Thursday, July 4, 2019 4:05 AM To: amd-gfx list Subject: Where do I file AMDGPU bugs nowadays? Hi AMDGPU folks, I’ve filed a bug [1] a while back, but no response so

Re: [PATCH] drm/amdgpu: fix MGPU fan boost enablement for XGMI reset

2019-06-28 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, June 27, 2019 11:31 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amdgpu: fix MGPU fan boost enablement for XGMI reset MGPU fan boost feature should not

Re: [PATCH] drm/amd/powerplay: update smu11_driver_if_navi10.h

2019-06-27 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Tianci Yin Sent: Thursday, June 27, 2019 2:49 AM To: amd-gfx@lists.freedesktop.org Cc: Xiao, Jack; Yin, Tianci (Rico); Zhang, Hawking Subject: [PATCH] drm/amd/powerplay: update smu11_driver_if_navi10.h From:

Re: [PATCH] drm/amdgpu: Set queue_preemption_timeout_ms default value

2019-06-26 Thread Deucher, Alexander
Acked-by: Alex Deucher From: Zeng, Oak Sent: Wednesday, June 26, 2019 11:22 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix; Deucher, Alexander; Li, Candice; Zeng, Oak Subject: [PATCH] drm/amdgpu: Set queue_preemption_timeout_ms default value Set default

Re: [PATCH] drm/amd/powerplay: support runtime ppfeatures setting on Navi10

2019-06-25 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Tuesday, June 25, 2019 4:49 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: support runtime ppfeatures setting on Navi10 Implement Navi10 backend for

Re: [PATCH v2] drm/amd/display: update infoframe after dig fe is turned on (v2)

2019-06-24 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Monday, June 24, 2019 1:58 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry; Kazlauskas, Nicholas; Li, Roman Subject: [PATCH v2] drm/amd/display: update

Re: [PATCH] drm/amd/powerplay: no memory activity support on Vega10

2019-06-24 Thread Deucher, Alexander
Sounds good. Thanks for confirming. Alex From: Quan, Evan Sent: Monday, June 24, 2019 3:50 AM To: Deucher, Alexander; Russell, Kent; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/powerplay: no memory activity support on Vega10 Smu7 ASICs support

Re: [PATCH] drm/amd/powerplay: no memory activity support on Vega10

2019-06-21 Thread Deucher, Alexander
Maybe it's dependent on the SMU firwmare version? Alex From: Russell, Kent Sent: Friday, June 21, 2019 9:54 AM To: Deucher, Alexander; Quan, Evan; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/powerplay: no memory activity support on Vega10 It works

Re: [PATCH] drm/amdgpu: add sw_init to df_v1_7

2019-06-21 Thread Deucher, Alexander
If both init and sw_init are empty, we don't need both. Just rename the init callback to sw_init. Alex From: amd-gfx on behalf of Kim, Jonathan Sent: Friday, June 21, 2019 5:45 AM To: amd-gfx@lists.freedesktop.org Cc: Kim, Jonathan Subject: [PATCH]

Re: [PATCH] drm/amd/powerplay: no memory activity support on Vega10

2019-06-21 Thread Deucher, Alexander
Is this supported on smu7 parts as well? Might be better to just enable it on the specific asics that support it. I think it might just be vega20. Alex From: amd-gfx on behalf of Evan Quan Sent: Thursday, June 20, 2019 10:07 PM To:

Re: [PATCH] Revert "drm/amd/display: Enable fast plane updates when state->allow_modeset = true"

2019-06-20 Thread Deucher, Alexander
Is there a bugzilla this fixes? If so, can you add a link? Alex From: amd-gfx on behalf of Francis, David Sent: Thursday, June 20, 2019 9:43 AM To: Kazlauskas, Nicholas; amd-gfx@lists.freedesktop.org Cc: Wentland, Harry Subject: Re: [PATCH] Revert

Re: amdgpu vce crash

2019-06-20 Thread Deucher, Alexander
If any of the engines hang, you can end up with a deadlock if you schedule dependencies across rings since one of the engines is hung. If you try a newer kernel, GPU reset is enabled and you should be able to recover after a hang. At that point, you can either restart your applications or use

Re: [PATCH] drm/amdgpu: wait to fetch the vbios until after common init

2019-06-17 Thread Deucher, Alexander
I'll make that a tested-by. Thanks! Alex From: Russell, Kent Sent: Monday, June 17, 2019 11:14 AM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu: wait to fetch the vbios until after common init This also

Re: [PATCH xf86-video-ati 3/3] Remove dri2_drawable_crtc parameter consider_disabled

2019-06-14 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Friday, June 14, 2019 5:27 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati 3/3] Remove dri2_drawable_crtc parameter consider_disabled From: Michel Dänzer

Re: [PATCH] drm/amd/powerplay: detect version of smu backend

2019-06-14 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Prike Liang Sent: Friday, June 14, 2019 3:01 AM To: amd-gfx@lists.freedesktop.org Cc: Liang, Prike; Huang, Ray; Feng, Kenneth; Quan, Evan Subject: [PATCH] drm/amd/powerplay: detect version of smu backend

Re: [PATCH v2] drm/amdgpu: explicitly set mmGDS_VMID0_BASE to 0

2019-06-12 Thread Deucher, Alexander
Please use udelay directly rather than DRM_UDELAY() those old macros are deprecated and going away. Alex From: amd-gfx on behalf of Zhu, James Sent: Wednesday, June 12, 2019 8:59 AM To: amd-gfx@lists.freedesktop.org Cc: Shamis, Leonid;

Re: [PATCH] drm/amdgpu: Add CHIP_VEGAM to amdgpu_amdkfd_device_probe

2019-06-11 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Russell, Kent Sent: Tuesday, June 11, 2019 8:44 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdgpu: Add CHIP_VEGAM to amdgpu_amdkfd_device_probe We have the rest of the

Re: [PATCH] drm/amdgpu: drop the incorrect soft_reset for SRIOV

2019-06-10 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Monk Liu Sent: Monday, June 10, 2019 2:37 AM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH] drm/amdgpu: drop the incorrect soft_reset for SRIOV It's incorrect to do soft reset for SRIOV,

Re: FW: [PATCH] drm/ttm: fix ttm client driver (e.g. amdgpu) reload issue

2019-06-06 Thread Deucher, Alexander
/~agd5f/linux/commit/?h=amd-staging-drm-next=bd4264112f93045704731850c5e4d85db981cd85 Where are you seeing it missing? Alex From: Christian K?nig Sent: Thursday, June 6, 2019 10:00 AM To: Koenig, Christian; Liu, Monk; amd-gfx@lists.freedesktop.org; Deucher

Re: [PATCH] drm/amd/display: Use current connector state if NULL when checking bpc

2019-06-05 Thread Deucher, Alexander
Maybe add a reference to the bug report? Acked-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Wednesday, June 5, 2019 12:33 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry; Kazlauskas, Nicholas Subject:

Re: [PATCH] drm/amd/display: Add back missing hw translate init for DCN1_01

2019-05-31 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Friday, May 31, 2019 12:05 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry; Kazlauskas, Nicholas Subject: [PATCH] drm/amd/display: Add back missing hw translate init for

Re: [PATCH] drm/amdkfd: Return proper error code for gws alloc API

2019-05-28 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Zeng, Oak Sent: Tuesday, May 28, 2019 3:53 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix; Zeng, Oak Subject: [PATCH] drm/amdkfd: Return proper error code for gws alloc API Change-Id:

Re: Quick question for the mobile Raven Ridge auto-rotate function

2019-05-28 Thread Deucher, Alexander
The FCH team is working on a driver for it and should have something available by August. Alex From: amd-gfx on behalf of Luya Tshimbalanga Sent: Thursday, May 23, 2019 1:34 AM To: amd-gfx@lists.freedesktop.org Subject: Quick question for the mobile Raven

Re: [PATCH 2/2] drm/amd/display: Use new connector state when getting color depth

2019-05-22 Thread Deucher, Alexander
Series is: Acked-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Wednesday, May 22, 2019 11:11 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry; Kazlauskas, Nicholas Subject: [PATCH 2/2] drm/amd/display: Use new

Re: [PATCH 2/2] drm/amd/powerplay: support sw smu hotspot and memory temperature retrieval

2019-05-14 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Tuesday, May 14, 2019 7:19 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/2] drm/amd/powerplay: support sw smu hotspot and memory temperature retrieval

RE: [PATCH] drm/amdgpu/sriov: Need to initialize the HDP_NONSURFACE_BAStE

2019-05-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of > Christian König > Sent: Tuesday, May 14, 2019 6:34 AM > To: Zhou, Tiecheng ; amd- > g...@lists.freedesktop.org > Cc: Deng, Emily > Subject: Re: [PATCH] drm/amdgpu/sriov: Need to initialize the > HDP_NONSURFACE_BAStE > > [CAUTION:

Re: [PATCH] drm/amdgpu/sriov: Need to initialize the HDP_NONSURFACE_BAStE

2019-05-14 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Tiecheng Zhou Sent: Monday, May 13, 2019 11:34 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou, Tiecheng; Deng, Emily Subject: [PATCH] drm/amdgpu/sriov: Need to initialize the HDP_NONSURFACE_BAStE [CAUTION:

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-13 Thread Deucher, Alexander
I reverted all the amdgpu HMM patches for 5.2 because they also depended on this patch: https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip=ce05ef71564f7cbe270cd4337c36ee720ea534db which did not have a clear line of sight for 5.2 either. Alex

Re: Kernel crash at reloading amdgpu

2019-05-08 Thread Deucher, Alexander
The attached patch should fix it. Alex From: amd-gfx on behalf of Lin, Amber Sent: Wednesday, May 8, 2019 4:56 PM To: amd-gfx@lists.freedesktop.org Subject: Kernel crash at reloading amdgpu [CAUTION: External Email] Hi, When I do "rmmod amdgpu; modprobe

Re: [PATCH] drm/radeon: prefer lower reference dividers

2019-05-06 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Monday, May 6, 2019 2:01 PM To: amd-gfx@lists.freedesktop.org; dufres...@gmail.com; werner.luec...@googlemail.com Subject: [PATCH] drm/radeon: prefer lower reference dividers [CAUTION:

Re: [PATCH] drm/amdgpu: Use FW addr returned by PSP for VF MM

2019-05-06 Thread Deucher, Alexander
As long as this doesn't break bare metal, I'm ok with it. Acked-by: Alex Deucher From: amd-gfx on behalf of Trigger Huang Sent: Thursday, May 2, 2019 8:56 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Trigger Subject: [PATCH] drm/amdgpu: Use FW addr returned

Re: [PATCH] drm/amd/amdgpu: Add MEM_LOAD to amdgpu_pm_info debugfs file

2019-05-02 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of StDenis, Tom Sent: Thursday, May 2, 2019 10:22 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] drm/amd/amdgpu: Add MEM_LOAD to amdgpu_pm_info debugfs file [CAUTION: External Email]

Re: [PATCH] drm/amdgpu: Add IDH_QUERY_ALIVE event for SR-IOV

2019-05-01 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Trigger Huang Sent: Tuesday, April 30, 2019 4:30 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Trigger Subject: [PATCH] drm/amdgpu: Add IDH_QUERY_ALIVE event for SR-IOV [CAUTION: External Email] SR-IOV host

Re: [PATCH 2/2] drm/amdgpu: Add PCIe replay count sysfs file

2019-05-01 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Russell, Kent Sent: Wednesday, May 1, 2019 8:01 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH 2/2] drm/amdgpu: Add PCIe replay count sysfs file [CAUTION: External Email]

Re: [PATCH] drm/amd/powerplay: enable ppfeaturemask module parameter support on Vega20

2019-04-29 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Monday, April 29, 2019 4:56 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Quan, Evan Subject: [PATCH] drm/amd/powerplay: enable ppfeaturemask module parameter support on Vega20

Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-28 Thread Deucher, Alexander
maybe just: amdgpu.lockup_timeout= I don't think we really need separate timeouts for all the different video related engines. Alex From: Quan, Evan Sent: Sunday, April 28, 2019 1:37 AM To: Deucher, Alexander; Michel Dänzer; Koenig, Christian Cc: Xu, Feifei

Re: [PATCH AUTOSEL 4.19 29/53] drm/amdkfd: Add picasso pci id

2019-04-27 Thread Deucher, Alexander
NACK. 4.19 did not contain support for picasso. Please drop this patch for 4.19. Alex From: amd-gfx on behalf of Sasha Levin Sent: Friday, April 26, 2019 9:40 PM To: linux-ker...@vger.kernel.org; sta...@vger.kernel.org Cc: Deucher, Alexander; Sasha Levin; amd

Re: print firmware versions on amdgpu sysfs

2019-04-26 Thread Deucher, Alexander
We also expose the firmware versions via ioctl which is what the UMDs uses. If you'd prefer it in sysfs, we could do that too. Alex From: amd-gfx on behalf of Lin, Amber Sent: Friday, April 26, 2019 10:14 AM To: amd-gfx@lists.freedesktop.org Cc: Freehill,

Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-26 Thread Deucher, Alexander
How about an interface to change the timeout on a per engine (gfx, compute, dma, etc.) basis? amdgpu.lockup_timeout=, if only one parameter is given, we change it globably. If more are given, we override the global one. Could also do a sysfs interface to change it on the fly. Alex

Re: [PATCH 1/3] drm/amd/powerplay: expose Vega20 realtime memory utilization

2019-04-25 Thread Deucher, Alexander
on behalf of Evan Quan Sent: Thursday, April 25, 2019 4:05 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Xu, Feifei; Quan, Evan; Russell, Kent; Freehill, Chris Subject: [PATCH 1/3] drm/amd/powerplay: expose Vega20 realtime memory utilization A new sysfs interface mem_busy_percent

Re: [PATCH] drm/amdgpu: update Vega20 sdma golden settings

2019-04-25 Thread Deucher, Alexander
Are you sure these were actually removed? I feel like they may have been added to the golden registers in the driver, but they never actually got updated in the golden database, but the driver is still responsible for programming them correctly. I don't remember the details. Alex

Re: [PATCH 2/2] drm/amdgpu: power down the Vega20 VCE engine on request

2019-04-25 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, April 25, 2019 3:52 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Quan, Evan; Liu, Leo Subject: [PATCH 2/2] drm/amdgpu: power down the Vega20 VCE engine

Re: [PATCH] drm/amdgpu: value of amdgpu_sriov_vf cannot be set into F32_POLL_ENABLE

2019-04-25 Thread Deucher, Alexander
Reviewed-by: Alex Deucher Please fix up your mail client or git config so your email address matches your signed off line. E.g., wentalou vs. Wentao Lou Thanks, Alex From: amd-gfx on behalf of wentalou Sent: Thursday, April 25, 2019 12:50 AM To:

Re: [PATCH xf86-video-ati] Retry get_fb_ptr in get_fb

2019-04-24 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Wednesday, April 24, 2019 6:32 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati] Retry get_fb_ptr in get_fb From: Michel Dänzer If get_fb_ptr returns NULL, try again

Re: [PATCH] drm/amd/display: Expose DRM_FORMAT_RGB565 on overlay planes

2019-04-23 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Tuesday, April 23, 2019 10:40 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry; Kazlauskas, Nicholas Subject: [PATCH] drm/amd/display: Expose

Re: [PATCH 5/5] drm/amd/powerplay: support hwmon temperature channel labels V2

2019-04-23 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Tuesday, April 23, 2019 4:37 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Quan, Evan Subject: [PATCH 5/5] drm/amd/powerplay: support hwmon temperature channel

Re: [PATCH] drm/amdgpu: Change VRAM lost print from ERR to INF

2019-04-19 Thread Deucher, Alexander
Maybe change the message to: VRAM is lost due to GPU reset! Either way, Reviewed-by: Alex Deucher From: amd-gfx on behalf of Andrey Grodzovsky Sent: Thursday, April 18, 2019 6:48 PM To: amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey; Kuehling, Felix

Re: [PATCH] drm/amd/include: Add HUBPREQ_DEBUG register offsets

2019-04-19 Thread Deucher, Alexander
Acked-by: Alex Deucher From: sunpeng...@amd.com Sent: Thursday, April 18, 2019 1:13 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Cheng, Tony; Wentland, Harry; StDenis, Tom; Li, Sun peng (Leo) Subject: [PATCH] drm/amd/include: Add HUBPREQ_DEBUG

RE: [PATCH 2/2] drm/amdkfd: Expose HDP registers to user space

2019-04-17 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of > Zeng, Oak > Sent: Wednesday, April 17, 2019 10:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Kuehling, Felix > ; Zeng, Oak ; Keely, Sean > ; Koenig, Christian > Subject: [PATCH

RE: [PATCH] drm/amd/include: Add USB_C_TYPE to atom_encoder_cap_defs

2019-04-16 Thread Deucher, Alexander
> -Original Message- > From: sunpeng...@amd.com > Sent: Tuesday, April 16, 2019 12:00 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Sun peng (Leo) ; Tam, Samson > ; Wentland, Harry ; > Deucher, Alexander > Subject: [PATCH] drm/amd/include: Add USB_C_TYPE to

Re: [PATCH] SWDEV-183622 4k@60hz dp monitor always flicking

2019-04-15 Thread Deucher, Alexander
Maybe mention that this fixes issues with stutter mode and 4k. With that, Acked-by: Alex Deucher From: amd-gfx on behalf of hersen wu Sent: Monday, April 15, 2019 9:52 AM To: amd-gfx@lists.freedesktop.org; Feng, Kenneth Cc: Wu, Hersen Subject: [PATCH]

Re: [PATCH libdrm V2] amdgpu: Fix a structure initialization issue

2019-04-12 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: Pan, Xinhui Sent: Friday, April 12, 2019 1:42 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH libdrm V2] amdgpu: Fix a structure initialization issue struct drmPciBusInfo has been aligned to 6 bytes. So

Re: [PATCH libdrm] amdgpu: Fix a structure initialization issue

2019-04-11 Thread Deucher, Alexander
Please use memset rather than {0}. Apparently some compilers don't like that. Alex From: Zhang, Hawking Sent: Thursday, April 11, 2019 9:24 AM To: Pan, Xinhui; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH libdrm] amdgpu: Fix

Re: Screen flicckering due to "drm/amdgpu: enable gfxoff again on raven series"

2019-04-05 Thread Deucher, Alexander
Make sure you have this patch as well: https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip=083d022913f2f8c3bc1183a13874ad777b9f5bdd Alex From: Pinky Sent: Friday, April 5, 2019 2:38 PM To: Deucher, Alexander Cc: Huang, Ray; amd-gfx

Re: Screen flicckering due to "drm/amdgpu: enable gfxoff again on raven series"

2019-04-05 Thread Deucher, Alexander
+ Ray Ray, any ideas? Pinkava, can you provide the output of: sudo cat /sys/kernel/debug/dri/0/amdgpu_firmware_info Thanks, Alex From: Pinky Sent: Friday, April 5, 2019 1:53 PM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: Screen

Re: Screen flicckering due to "drm/amdgpu: enable gfxoff again on raven series"

2019-04-05 Thread Deucher, Alexander
Kernel command line in grub. From: amd-gfx on behalf of Deucher, Alexander Sent: Friday, April 5, 2019 1:07 PM To: Pinky; amd-gfx@lists.freedesktop.org Subject: Re: Screen flicckering due to "drm/amdgpu: enable gfxoff again on raven series" This may

Re: Screen flicckering due to "drm/amdgpu: enable gfxoff again on raven series"

2019-04-05 Thread Deucher, Alexander
This may be related to stutter mode rather than gfxoff. If so, there is a fix in the pipeline for that. Does setting appending amdgpu.ppfeaturemask=0xfffdbfff on the kernel command line fix it? Alex From: amd-gfx on behalf of Pinky Sent: Friday, April 5,

Re: [PATCH] drm/amd/powerplay: check for invalid profile mode before switching

2019-03-27 Thread Deucher, Alexander
Sure no problem. Acked-by: Alex Deucher From: Quan, Evan Sent: Wednesday, March 27, 2019 9:55 PM To: Quan, Evan; amd-gfx@lists.freedesktop.org; Deucher, Alexander Cc: Russell, Kent Subject: RE: [PATCH] drm/amd/powerplay: check for invalid profile mode before

Re: [PATCH 2/2] drm/amd/powerplay: correct data type to avoid overflow

2019-03-26 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Quan, Evan Sent: Tuesday, March 26, 2019 6:15 AM To: Quan, Evan; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/2] drm/amd/powerplay: correct data type to avoid overflow Ping.. >

Re: [PATCH] drm/amd/powerplay: fix possible hang with 3+ 4K monitors

2019-03-26 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Tuesday, March 26, 2019 6:13 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: fix possible hang with 3+ 4K monitors If DAL requires to force MCLK high, the

Re: [PATCH] drm/amd/display: Fix "dc has no member named dml" compile error

2019-03-21 Thread Deucher, Alexander
Thanks! Acked-by: Alex Deucher From: amd-gfx on behalf of sunpeng...@amd.com Sent: Thursday, March 21, 2019 10:44 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Alex Deucher; Wentland, Harry; Kazlauskas, Nicholas Subject: [PATCH]

Re: [PATCH xf86-video-ati] modesetting: add tile property support

2019-03-14 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Thursday, March 14, 2019 6:19 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati] modesetting: add tile property support From: Dave Airlie This adds tiling support to

Re: [PATCH xf86-video-ati] Use radeon_finish in drmmode_crtc_scanout_update

2019-03-14 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Thursday, March 14, 2019 6:15 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati] Use radeon_finish in drmmode_crtc_scanout_update From: Michel Dänzer

Re: [PATCH] drm/amdgpu: enable gfxoff again on raven series

2019-03-13 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Huang Rui Sent: Wednesday, March 13, 2019 8:27 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: [PATCH] drm/amdgpu: enable gfxoff again on raven series This patch enables gfxoff and stutter mode

Re: Slow memory access when using OpenCL without X11

2019-03-12 Thread Deucher, Alexander
Forcing the sclk and mclk high may impact the CPU frequency since they share TDP. Alex From: amd-gfx on behalf of Lauri Ehrenpreis Sent: Tuesday, March 12, 2019 5:31 PM To: Kuehling, Felix Cc: Tom St Denis; amd-gfx@lists.freedesktop.org Subject: Re: Slow

Re: [PATCH 2/3] drm/amdgpu: free up the first paging queue

2019-03-12 Thread Deucher, Alexander
I don't think Raven has a paging queue in the first place. Alex From: amd-gfx on behalf of Kuehling, Felix Sent: Tuesday, March 12, 2019 11:29 AM To: Christian König; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/3] drm/amdgpu: free up the first paging

RE: [PATCH 2/2] drm/amdgpu: add new ras workflow control flags

2019-03-12 Thread Deucher, Alexander
> -Original Message- > From: Pan, Xinhui > Sent: Tuesday, March 12, 2019 6:14 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > ; Zhang, Hawking > Subject: [PATCH 2/2] drm/amdgpu: add new ras workflow control flags > > add ras po

Re: [PATCH 1/2] drm/amdgpu: let ras initialization a little noticeable

2019-03-12 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: Pan, Xinhui Sent: Tuesday, March 12, 2019 6:13 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Quan, Evan; Zhang, Hawking Subject: [PATCH 1/2] drm/amdgpu: let ras initialization a little noticeable add drm info output

Re: [PATCH xf86-video-ati] Revert "glamor: Avoid glamor_create_pixmap for pixmaps backing windows"

2019-03-08 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Friday, March 8, 2019 5:51 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati] Revert "glamor: Avoid glamor_create_pixmap for pixmaps backing windows" From: Michel Dänzer

Re: [PATCH] drm/amd/display: avoid passing enum as NULL pointer

2019-03-07 Thread Deucher, Alexander
(Leo); Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing) Cc: Nick Desaulniers; Arnd Bergmann; David Airlie; Daniel Vetter; Koo, Anthony; Cyr, Aric; Tatla, Harmanprit; Chalmers, Kenneth; Kumarasamy, Sivapiriyan; Kees Cook; Bayan Zabihiyan; Cheng, Tony; amd-gfx@lists.freedesktop.org; dri

Re: [PATCH] drm/amdgpu: fix ras parameter descriptions

2019-03-07 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, March 7, 2019 2:00 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Pan, Xinhui; Quan, Evan; Zhang, Hawking Subject: [PATCH] drm/amdgpu: fix ras parameter descriptions

<    4   5   6   7   8   9   10   11   12   13   >