WRITEBACK)
Fixes: fa7041d9d2fc ("drm/amd/display: Fix ineffective setting of max bpc
property")
Reported-by: Dan Carpenter
Cc: Tom Chung
Cc: Rodrigo Siqueira
Cc: Roman Li
Cc: Hersen Wu
Cc: Alex Hung
Cc: Aurabindo Pillai
Cc: Harry Wentland
Cc: Hamza Mahfooz
Signed-off-by: Sriniv
Hi Sasha,
On 7/16/24 10:24, Sasha Levin wrote:
From: Tom Chung
[ Upstream commit 6b8487cdf9fc7bae707519ac5b5daeca18d1e85b ]
[Why]
Sometimes the new_crtc_state->vrr_infopacket did not sync up with the
current state.
It will affect the update_freesync_state_on_stream() does not update
the
On 7/10/24 04:43, Daniel Vetter wrote:
On Tue, Jul 09, 2024 at 10:02:08AM -0400, Hamza Mahfooz wrote:
On 7/9/24 06:09, Daniel Vetter wrote:
On Tue, Jul 09, 2024 at 11:32:11AM +0200, Daniel Vetter wrote:
On Mon, Jul 08, 2024 at 04:29:07PM -0400, Hamza Mahfooz wrote:
Hook up
On 7/3/24 01:17, Mario Limonciello wrote:
During the Display Next hackfest 2024 one of the topics discussed
was the need for compositor to be able to relay intention to drivers
that color fidelity is preferred over power savings.
To accomplish this a new optional DRM property is being
On 7/9/24 06:09, Daniel Vetter wrote:
On Tue, Jul 09, 2024 at 11:32:11AM +0200, Daniel Vetter wrote:
On Mon, Jul 08, 2024 at 04:29:07PM -0400, Hamza Mahfooz wrote:
Hook up drm_crtc_set_vblank_offdelay() in amdgpu_dm, so that we can
enable PSR more quickly for displays that support it.
Signed
Hook up drm_crtc_set_vblank_offdelay() in amdgpu_dm, so that we can
enable PSR more quickly for displays that support it.
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 30 ++-
1 file changed, 22 insertions(+), 8 deletions(-)
diff --git
-by: Hamza Mahfooz
---
drivers/gpu/drm/drm_vblank.c | 31 ++-
include/drm/drm_vblank.h | 7 +++
2 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 702a12bc93bd..4f475131a092 100644
We want all DML changes to be reviewed by Chaitanya or Jun. So, add an
entry for DML to MAINTAINERS.
Suggested-by: Rodrigo Siqueira
Signed-off-by: Hamza Mahfooz
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7fec8ddb8d5b..d2fb60fee7e8
On 6/24/24 09:58, Alex Deucher wrote:
Leftover copy pasta from original code.
Signed-off-by: Alex Deucher
Cc: harry.wentl...@amd.com
Reviewed-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dcn301/Makefile | 11 ++-
drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 10
From: Anthony Koo
- Add new condition for PSR exit due to ESD recovery
- Add new VB scaling feature for ABM by interpolating between
existing VB parameters, allowing driver to have fine grain
scaled VB levels between 0 - 250
Acked-by: Hamza Mahfooz
Signed-off-by: Anthony Koo
inting
to an OTG master before operate in the old OTG master reference. If it's
not, the function must set the old OTG reference to NULL and avoid
calling resource_get_opp_heads_for_otg_master before the context is
updated.
Reviewed-by: Wenjing Liu
Acked-by: Hamza Mahfooz
Co-developed-by: Wenji
From: Ivan Lipski
These portions of code are flagged as 'UNUSED_VALUE' by the
Coverity analysis since the assigned values of these vars
are never used in the code.
Reviewed-by: Alex Hung
Reviewed-by: Aurabindo Pillai
Acked-by: Hamza Mahfooz
Signed-off-by: Ivan Lipski
---
.../drm/amd
rry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c
b/drivers/gpu/drm/amd/display/dc/d
From: Alex Hung
The null checks for res_pool->dccg are redundant as it was already
dereferenced previously, as reported by Coverity; therefore the
null checks are removed.
This fixes 6 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-
ked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 3 ---
3 files changed, 4 insertions(+), 7 deleti
From: Aric Cyr
This version brings along the following:
- DCN401 fixes
- DPIA fixes
- DML21 fixes
- Misc Coverity fixes
Acked-by: Hamza Mahfooz
Signed-off-by: Aric Cyr
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
From: Alex Hung
The null checks are redundant as they were already dereferenced
previously, as reported by Coverity; therefore the null checks
are removed.
This fixes 7 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
From: Alex Hung
The null checks for context are redundant as it was already
dereferenced previously, as reported by Coverity; therefore
the null checks are removed.
This fixes 2 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex
From: Alvin Lee
Need to reconfigure ODM when resyncing FIFO because on OTG disable we
clear all ODM programming
Reviewed-by: Nicholas Kazlauskas
Acked-by: Hamza Mahfooz
Signed-off-by: Alvin Lee
---
.../amd/display/dc/hwss/dcn314/dcn314_hwseq.c | 19 ++-
.../amd/display/dc
From: Alex Hung
dc_state_get_stream_status dc_state_get_paired_subvp_stream and other
functions can return null, and therefore null must be checked before
status can be used.
This fixes 21 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed
From: Alex Hung
The null checks for opp are redundant as they were already
dereferenced previously, as reported by Coverity; therefore
the null checks are removed.
This fixes 2 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex
- update_plane_addr should only be public, as it's used outside HWSS
Reviewed-by: Aric Cyr
Acked-by: Hamza Mahfooz
Signed-off-by: Joshua Aberback
---
.../gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c | 1 -
.../gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c| 10 +-
drivers/gpu/drm
From: Ivan Lipski
[WHY]
Coverity analysis flagged this condition as DEADCODE since the
variable 'req128_c' is always false, thus the condition is never
true.
[HOW]
Remove the condition.
Reviewed-by: Aurabindo Pillai
Acked-by: Hamza Mahfooz
Signed-off-by: Ivan Lipski
---
.../gpu/drm/amd
From: Alex Hung
Checks null pointer before accessing various structs.
This fixes 5 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_utils.c | 2 ++
.../display/dc
-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
.../drm/amd/display/dc/dml/calcs/dcn_calcs.c | 2 +-
.../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 20 ++---
.../dc/dml/dcn20/display_mode_vba_20.c| 16 +--
.../dc/dml/dcn20/display_mode_vba_20v2.c
From: Alex Hung
The null checks for ctx->dc_bios are redundant as it was already
dereferenced previously, as reported by Coverity; therefore the
null checks are removed.
This fixes 7 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-
From: Alex Hung
resource_get_odm_slice_count and resource_get_otg_master_for_stream can
return null, and their returns must be checked before used.
This fixes 4 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
to describe why the warning was triggered to make the
debugging more straightforward.
Reviewed-by: Wenjing Liu
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd
From: Sridevi Arvindekar
Mirror case unsupported for cursors. So, remove code for mirror case
with cursors.
Reviewed-by: Nevenko Stupar
Acked-by: Hamza Mahfooz
Signed-off-by: Sridevi Arvindekar
---
.../amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 30 +--
1 file changed, 1
From: Alex Hung
Callers can pass null in filter (i.e. from returned from the function
wbscl_get_filter_coeffs_16p) and a null check is added to ensure that is
not the case.
This fixes 4 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off
the gamut_remap callback in
case the specific ASIC did not implement this function.
Reviewed-by: Aurabindo Pillai
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
.../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 49 ++-
1 file changed, 27 insertions(+), 22 deletions(-)
diff --git
From: Alex Hung
BIOS images may fail to load and null checks are added before they are
used.
This fixes 6 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 14
From: Sung Joon Kim
[why]
Tell the system about the current host router bandwidth to be used to
measure and calculate the right voltage to be used.
[how]
Send SMU message of each DPIA host router bandwidth.
Reviewed-by: Nicholas Kazlauskas
Acked-by: Hamza Mahfooz
Signed-off-by: Sung Joon Kim
From: Dillon Varone
When a phantom stream is in the process of being deconstructed, there
could be pipes with no associated planes. In that case, ignore the
phantom stream entirely when searching for associated pipes.
Cc: sta...@vger.kernel.org
Reviewed-by: Alvin Lee
Acked-by: Hamza Mahfooz
From: Alex Hung
Checks null pointer before passing variables to functions.
This fixes 3 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 ++---
1 file changed
From: Wenjing Liu
There is a coding error which causes incorrect variables to be assigned
in DML21 phase 5.
Reviewed-by: Dillon Varone
Acked-by: Hamza Mahfooz
Signed-off-by: Wenjing Liu
---
.../gpu/drm/amd/display/dc/dml2/dml21/src/dml2_top/dml_top.c | 4 ++--
1 file changed, 2 insertions
pper bits of the result will all be 1.
Cast it to unsigned long to avoid possible overflow.
This fixes 4 SIGN_EXTENSION issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-
is low enough that we will
never require 2:1 ODM combine.
Cc: sta...@vger.kernel.org # 6.6+
Reviewed-by: Wenjing Liu
Acked-by: Hamza Mahfooz
Signed-off-by: Michael Strauss
---
.../amd/display/dc/hwss/dcn35/dcn35_hwseq.c | 72 +++
.../amd/display/dc/hwss/dcn35/dcn35_hwseq.h
From: Joshua Aberback
This reverts commit e296c84e7d0561ed626591e1cf9b71a7ba0133f4.
A proper fix for this issue has been implemented in DMUB FW. So, no need
to keep the workaround.
Reviewed-by: Wenjing Liu
Acked-by: Hamza Mahfooz
Signed-off-by: Joshua Aberback
---
drivers/gpu/drm/amd
From: Mounika Adhuri
[why]
Move DCN3X files to unique component folder.
[how]
Create respective component folder in dc, move the DCN3X files into
corresponding new folders and made appropriate changes for compilation
in Makefiles.
Reviewed-by: Martin Leung
Acked-by: Hamza Mahfooz
Signed-off
-by: Aurabindo Pillai
Reviewed-by: Alex Hung
Acked-by: Hamza Mahfooz
Signed-off-by: Ivan Lipski
---
.../drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c
b/drivers/gpu/drm
From: Dillon Varone
[WHY]
Re-enable idle optimizations by default.
Reviewed-by: Alvin Lee
Acked-by: Hamza Mahfooz
Signed-off-by: Dillon Varone
---
drivers/gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display
WSS function for DCN401
- remove debug bit to disable boot optimizations for DCN401
Reviewed-by: Wenjing Liu
Acked-by: Hamza Mahfooz
Signed-off-by: Joshua Aberback
---
drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_init.c | 1 +
drivers/gpu/drm/amd/display/dc/resource/dcn
to ensure the
timing is valid and unchanged.
Reviewed-by: Alvin Lee
Acked-by: Hamza Mahfooz
Signed-off-by: Chris Park
---
.../display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c | 17 +
.../amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 11 ++-
2 files changed, 27 insertions
Cc: Daniel Wheeler
Alex Hung (15):
drm/amd/display: Explicitly extend unsigned 16 bit to 64 bit
drm/amd/display: Add null checker before passing variables
drm/amd/display: Check BIOS images before it is used
drm/amd/display: Skip wbscl_set_scaler_filter if filter is null
Acked-by: Hamza Mahfooz
Signed-off-by: Relja Vojvodic
---
.../gpu/drm/amd/display/dc/dcn35/dcn35_dio_stream_encoder.c | 4 ++--
.../gpu/drm/amd/display/dc/dcn35/dcn35_dio_stream_encoder.h | 6 ++
.../drm/amd/display/dc/dcn401/dcn401_dio_stream_encoder.c | 4 +++-
3 files changed, 11 insertions
On 6/4/24 13:45, Aurabindo Pillai wrote:
This reverts commit 44069f0f9b1fe577c5d4f05fa9eb02db8c618adc since
the code path is called from FPU context, and triggers error like:
[ 26.924055] BUG: sleeping function called from invalid context at
include/linux/sched/mm.h:306
[ 26.924060]
We can't read/write to DCN registers while in IPS. Since, that can cause
the system to hang. So, before proceeding with the access in that
scenario, force the system out of IPS.
Cc: sta...@vger.kernel.org # 6.6+
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
On 5/28/24 08:57, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Currently when one enables driver debugging dmesg gets spammed, at I
suspect vblank rate, with messages like:
[drm:amdgpu_dm_atomic_check [amdgpu]] MPO enablement requested on
crtc:[f073c3bb]
Fix if by converting some
From: Aric Cyr
This version brings along the following:
- DCN10 fixes
- DCN316 fixes
- DML2 fixes
- DWB fixes
- Expanded FAMS support
- Misc code style fixes
- ODM fixes
- VSC SDP fixes
Acked-by: Hamza Mahfooz
Signed-off-by: Aric Cyr
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file
From: Rodrigo Siqueira
Some of the resource capabilities for DCN201 and the debug default
option are outdated. This commit just set some of the missing
configurations for DCN201.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/dc/resource/dcn201
From: Rodrigo Siqueira
[WHY]
DCN 1.0 is not ready for the P010 support.
[HOW]
1. Set the P010 plan_cap of DCN 1.0 to be false.
2. Let the DM do the plan cap initialization of DCN 1.0.
Reviewed-by: Rodrigo Siqueira
Signed-off-by: Figo Wang
Signed-off-by: Rodrigo Siqueira
---
From: Rodrigo Siqueira
Set OTG/OPTC parameter to 0 if failed to set DRR.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/dc/optc/dcn32/dcn32_optc.c| 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd
From: Rodrigo Siqueira
Some of the includes used in the DC can be removed and others need to be
update. This commit adjusts some of those headers in the display code.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr.c
From: Rodrigo Siqueira
Update DCN10 to use legacy fast update and ensure that the MPCC count is
the same as the pipe_count.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/resource/dcn10/dcn10_resource.c | 2 ++
1 file changed, 2 insertions(+)
diff
From: Rodrigo Siqueira
Set OTG/OPTC parameters to 0 if something goes wrong on DCN10.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
.../drm/amd/display/dc/optc/dcn10/dcn10_optc.c| 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu
From: Rodrigo Siqueira
This commit makes some small adjustments in the dwb header.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/inc/hw/dwb.h | 30 +
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu
From: Rodrigo Siqueira
Change DP_PHY_REPEATER_EXTENDED_WAIT_TIMEOUT with
DP_PHY_REPEATER_128B132B_RATES.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Harry Wentland
The previous check for the is_vsc_sdp_colorimetry_supported flag
for MST sink signals did nothing. Simplify the code and use the
same check for MST and SST.
Cc: sta...@vger.kernel.org
Reviewed-by: Agustin Gutierrez
Acked-by: Hamza Mahfooz
Signed-off-by: Harry Wentland
From: Rodrigo Siqueira
This commit just introduce some basic comments that helps to understand
the overall behavior of some structs.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/inc/core_types.h | 2 ++
drivers/gpu/drm/amd/display
From: Rodrigo Siqueira
This commit removes code that are not used by display anymore.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
.../amd/display/dc/inc/hw/stream_encoder.h| 4 ---
drivers/gpu/drm/amd/display/dc/inc/resource.h | 7
.../amd/display/dc/optc/dcn20
From: Allen Pan
[Why]
6.75 Gbps link rate training for DP_TEST_LINK_RATE_RATE_8
Reviewed-by: Charlene Liu
Acked-by: Hamza Mahfooz
Signed-off-by: Allen Pan
---
drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc
of the previously enabled test pattern.
[How]
Rebuild test pattern params even when test pattern is video mode,
allowing the pipe to have updated test_pattern_params values.
Reviewed-by: Nevenko Stupar
Reviewed-by: Chaitanya Dhere
Acked-by: Hamza Mahfooz
Signed-off-by: George Shen
---
drivers/gpu/drm
From: Anthony Koo
- Add boot option to change the ONO powerup flow, impacting
the order of power domains to power up or down first
Acked-by: Hamza Mahfooz
Signed-off-by: Anthony Koo
---
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 1 +
1 file changed, 1 insertion(+)
diff --git
From: Rodrigo Siqueira
DCN10 OPTC is used by other DCNs, and in some cases it might be useful
to have V_TOTAL_REGS available. This commit add V_TOTAL_REGS as part of
the TG field.
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/optc/dcn10
From: Fudongwang
[Why]
Wrong logic cause screen corruption.
[How]
Port logic from DCN35/314.
Cc: sta...@vger.kernel.org
Reviewed-by: Nicholas Kazlauskas
Acked-by: Hamza Mahfooz
Signed-off-by: Fudongwang
---
.../dc/clk_mgr/dcn316/dcn316_clk_mgr.c| 19 ---
1 file
From: Qili Lu
This reverts commit 5145de86407c2d28cfed007b5014c0d0b40d5913.
It causes a dead loop in dml_prefetch_check.
Reviewed-by: Nicholas Kazlauskas
Acked-by: Hamza Mahfooz
Signed-off-by: Qili Lu
---
drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 4 ++--
1 file changed, 2
: Xaver Hugl
Cc: Melissa Wen
Cc: Agustin Gutierrez
Reviewed-by: Agustin Gutierrez
Acked-by: Hamza Mahfooz
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display
From: Zhongwei
[Why]
OLED panels show no display for large vtotal timings.
[How]
Check if ss is enabled and read from lut for spread spectrum percentage.
Adjust dprefclk as required. DP_DTO adjustment is for edp only.
Cc: sta...@vger.kernel.org
Reviewed-by: Nicholas Kazlauskas
Acked-by: Hamza
From: Dillon Varone
[WHY]
We should not be recursively calling the manual trigger programming function
when
FAMS is not in use.
Cc: sta...@vger.kernel.org
Reviewed-by: Alvin Lee
Acked-by: Hamza Mahfooz
Signed-off-by: Dillon Varone
---
drivers/gpu/drm/amd/display/dc/optc/dcn32/dcn32_optc.c
up
Reviewed-by: Chris Park
Acked-by: Hamza Mahfooz
Signed-off-by: Charlene Liu
---
.../amd/display/dc/dml2/display_mode_core.c | 1 +
.../amd/display/dc/dml2/display_mode_core.h | 1 +
.../dc/dml2/display_mode_lib_defines.h| 2 +
.../display/dc/dml2/dml2_translation_helper.c | 45
From: Parandhaman K
why and how:
as part of cleanup, need to refactor vpg. It was improperly referenced
as a dcn specfic part of link. the dcn agnostic code needed was ripped out
and put into vpg.h, now in dc/inc/hw.
Reviewed-by: Alvin Lee
Acked-by: Hamza Mahfooz
Signed-off-by: Parandhaman K
Cc: Daniel Wheeler
Alex Hung (1):
drm/amd/display: Return max resolution supported by DWB
Allen Pan (1):
drm/amd/display: expand the non standard link rate for testing
Anthony Koo (1):
drm/amd/display: [FW Promotion] Release 0.0.212.0
Aric Cyr (1):
drm/amd/display: 3.2.280
Charlene
ODM policy
logic. So it doesn't matter whether if main pipe's ODM policy is set,
phantom pipe will always have the same policy because it running the
same calcualtion to derive ODM policy.
Cc: sta...@vger.kernel.org
Reviewed-by: Alvin Lee
Acked-by: Hamza Mahfooz
Signed-off-by: Wenjing Liu
From: Dillon Varone
[WHY]
Changes to support future versions of FAMS.
Reviewed-by: Alvin Lee
Acked-by: Hamza Mahfooz
Signed-off-by: Dillon Varone
---
.../gpu/drm/amd/display/dc/bios/bios_parser.c | 2 --
drivers/gpu/drm/amd/display/dc/core/dc.c | 5 -
.../drm/amd/display/dc/core
removed. This
has caused an issue where we kept ODM combine when it should have been
remove when a plane is added. The change is to reset ODM mode when
adding the first plane.
Cc: sta...@vger.kernel.org
Reviewed-by: Alvin Lee
Acked-by: Hamza Mahfooz
Signed-off-by: Wenjing Liu
---
drivers/gpu/drm
From: Lewis Huang
[Why]
We want flexibility to choose how pwrseq instance is mapped to eDP panel
[How]
Add configuration option to choose the pwrseq mapping policy.
When enabled, allow fixed mapping between DIG inst to pwrseq inst.
Reviewed-by: Anthony Koo
Acked-by: Hamza Mahfooz
Signed-off
From: Alex Hung
mode_config's max width x height is 4096x2160 and is higher than DWB's
max resolution 3840x2160 which is returned instead.
Cc: sta...@vger.kernel.org
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/amdgpu_dm
: 2cd3271b7a31 ("kbuild: avoid duplicate warning options")
Signed-off-by: Arnd Bergmann
Acked-by: Hamza Mahfooz
For the amdgpu changes.
---
drivers/gpu/drm/amd/display/dc/dce110/Makefile | 2 +-
drivers/gpu/drm/amd/display/dc/dce112/Makefile | 2 +-
drivers/gpu/drm/amd/display
hecks for exiting idle in DC")
Tested-by: Mark Broadworth
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 8 +---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.h | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/a
On 3/12/24 09:47, Harry Wentland wrote:
We need the min/max vfreq on the amdgpu_dm_connector in order to
program VRR.
Fixes: db3e4f1cbb84 ("drm/amd/display: Use freesync when
`DRM_EDID_FEATURE_CONTINUOUS_FREQ` found")
Signed-off-by: Harry Wentland
Acked-by: Hamza Mahfooz
---
Add Display Manager specific changes for DCN3.5.1.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 +
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 1 +
2 files changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/amd/display
Add DC support for DCN 3.5.1.
Signed-off-by: Hamza Mahfooz
---
.../display/dc/bios/command_table_helper2.c |1 +
.../gpu/drm/amd/display/dc/core/dc_resource.c |6 +
.../dc/dcn35/dcn35_dio_stream_encoder.h |1 +
drivers/gpu/drm/amd/display/dc/dml/Makefile |3 +
.../amd
Add DCN3.5.1 interrupt support.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/irq/Makefile | 11 +-
.../dc/irq/dcn351/irq_service_dcn351.c| 409 ++
.../dc/irq/dcn351/irq_service_dcn351.h| 12 +
3 files changed, 431 insertions(+), 1 deletion
DMUB support is required to light-up displays.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dmub/src/Makefile | 1 +
.../drm/amd/display/dmub/src/dmub_dcn351.c| 34 +++
.../drm/amd/display/dmub/src/dmub_dcn351.h| 13 +++
.../gpu/drm/amd/display/dmub
Add DCN3.5.1 ASIC identifiers.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1 +
drivers/gpu/drm/amd/display/include/dal_asic_id.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dmub/dmub_srv.h
b/drivers/gpu/drm/amd
: Hamza Mahfooz
Cc: Tsung-hua Lin
Cc: Chris Chi
Cc: Harry Wentland
Tested-by: Daniel Wheeler
Reviewed-by: Sun peng Li
Acked-by: Rodrigo Siqueira
Signed-off-by: Ivan Lipski
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
/2985
Signed-off-by: Alex Deucher
Series is:
Acked-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 27 +
2 files changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu
On 2/16/24 03:19, Pekka Paalanen wrote:
On Fri, 2 Feb 2024 10:28:35 -0500
Hamza Mahfooz wrote:
We want programs besides the compositor to be able to enable or disable
panel power saving features.
Could you also explain why, in the commit message, please?
It is unexpected for arbitrary
On 2/16/24 03:19, Pekka Paalanen wrote:
On Fri, 2 Feb 2024 10:28:35 -0500
Hamza Mahfooz wrote:
We want programs besides the compositor to be able to enable or disable
panel power saving features.
Could you also explain why, in the commit message, please?
It is unexpected for arbitrary
those includes.
Signed-off-by: Rodrigo Siqueira
Reviewed-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/basics/dce_calcs.c | 2 --
drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 2 --
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr.c | 2
On 2/14/24 13:38, Rodrigo Siqueira wrote:
The function dcn32_build_wm_range_table call DC_FP_START/END. Drop the
unnecessary FPU guard.
Signed-off-by: Rodrigo Siqueira
Reviewed-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 --
1 file changed, 2
On 2/14/24 13:38, Rodrigo Siqueira wrote:
The file rv1_clk_mgr_clk.c is not used and for this reason useless. Drop
the unnecessary file.
Signed-off-by: Rodrigo Siqueira
Reviewed-by: Hamza Mahfooz
---
.../dc/clk_mgr/dcn10/rv1_clk_mgr_clk.c| 79 ---
1 file changed
On 2/14/24 13:38, Rodrigo Siqueira wrote:
Set a default value for target_div.
Signed-off-by: Rodrigo Siqueira
Reviewed-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
On 2/14/24 13:38, Rodrigo Siqueira wrote:
Remove break after return since it will never be reached.
Signed-off-by: Rodrigo Siqueira
Reviewed-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd
On 2/14/24 13:38, Rodrigo Siqueira wrote:
Instead of only asserting in the case of the SMU wait time is not what
we expect, add the SMU timeout check and try again.
Signed-off-by: Rodrigo Siqueira
Acked-by: Hamza Mahfooz
---
.../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 11
from changing the ABM level if the module parameter
is set to a non-auto value.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 11 ++-
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15
On 2/9/24 08:02, Dan Carpenter wrote:
These ANDs should be ORs or it will lead to a NULL dereference.
Fixes: fb5a3d037082 ("drm/amd/display: Add NULL test for 'timing generator' in
'dcn21_set_pipe()'")
Fixes: 886571d217d7 ("drm/amd/display: Fix 'panel_cntl' could be null in
Limonciello
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 13 +
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++
3 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/amd
ctors")
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index adda423615a1..b3
1 - 100 of 526 matches
Mail list logo
