Re: [PATCH 2/2] drm/amdgpu: add reset register trace function on GPU reset

2022-02-10 Thread Sharma, Shashank
On 2/10/2022 6:29 AM, Somalapuram, Amaranath wrote: On 2/9/2022 1:17 PM, Christian König wrote: Am 08.02.22 um 16:28 schrieb Alex Deucher: On Tue, Feb 8, 2022 at 3:17 AM Somalapuram Amaranath wrote: Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram

Re: [PATCH 2/2] drm/amdgpu: add reset register trace function on GPU reset

2022-02-10 Thread Sharma, Shashank
On 2/10/2022 8:38 AM, Christian König wrote: Am 10.02.22 um 08:34 schrieb Somalapuram, Amaranath: On 2/10/2022 12:39 PM, Christian König wrote: Am 10.02.22 um 06:29 schrieb Somalapuram, Amaranath: On 2/9/2022 1:17 PM, Christian König wrote: Am 08.02.22 um 16:28 schrieb Alex Deucher: On

Re: [PATCH 2/2] drm/amdgpu: add reset register trace function on GPU reset

2022-02-10 Thread Sharma, Shashank
On 2/10/2022 3:05 PM, Christian König wrote: Am 10.02.22 um 14:18 schrieb Sharma, Shashank: On 2/10/2022 8:38 AM, Christian König wrote: Am 10.02.22 um 08:34 schrieb Somalapuram, Amaranath: On 2/10/2022 12:39 PM, Christian König wrote: Am 10.02.22 um 06:29 schrieb Somalapuram

Re: [PATCH 2/2] drm/amdgpu: add work function for GPU reset event

2022-03-07 Thread Sharma, Shashank
Hey Amar, On 3/7/2022 5:46 PM, Somalapuram, Amaranath wrote: On 3/7/2022 9:56 PM, Shashank Sharma wrote: From: Shashank Sharma This patch adds a work function, which will get scheduled in event of a GPU reset, and will send a uevent to user with some reset context infomration, like a PID and

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Sharma, Shashank
On 3/8/2022 8:06 AM, Christian König wrote: Am 07.03.22 um 17:26 schrieb Shashank Sharma: From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about a GPU reset, and can also provide some information like: - which PID was involved in the GPU reset - what

Re: [PATCH 2/2] drm/amdgpu: add work function for GPU reset event

2022-03-08 Thread Sharma, Shashank
On 3/8/2022 8:15 AM, Christian König wrote: Am 07.03.22 um 17:26 schrieb Shashank Sharma: From: Shashank Sharma This patch adds a work function, which will get scheduled in event of a GPU reset, and will send a uevent to user with some reset context infomration, like a PID and some flags.

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Sharma, Shashank
On 3/8/2022 11:32 AM, Christian König wrote: Am 08.03.22 um 10:31 schrieb Sharma, Shashank: On 3/8/2022 8:06 AM, Christian König wrote: Am 07.03.22 um 17:26 schrieb Shashank Sharma: From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about a GPU

Re: [PATCH 2/2] drm/amdgpu: add work function for GPU reset event

2022-03-08 Thread Sharma, Shashank
Hello Andrey On 3/8/2022 5:26 PM, Andrey Grodzovsky wrote: On 2022-03-07 11:26, Shashank Sharma wrote: From: Shashank Sharma This patch adds a work function, which will get scheduled in event of a GPU reset, and will send a uevent to user with some reset context infomration, like a PID and s

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Sharma, Shashank
On 3/8/2022 5:25 PM, Andrey Grodzovsky wrote: On 2022-03-07 11:26, Shashank Sharma wrote: From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about a GPU reset, and can also provide some information like: - which PID was involved in the GPU reset - wha

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Sharma, Shashank
On 3/8/2022 12:56 PM, Sharma, Shashank wrote: On 3/8/2022 11:32 AM, Christian König wrote: Am 08.03.22 um 10:31 schrieb Sharma, Shashank: On 3/8/2022 8:06 AM, Christian König wrote: Am 07.03.22 um 17:26 schrieb Shashank Sharma: From: Shashank Sharma This patch adds a new sysfs event

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Sharma, Shashank
shank Sharma ; amd-gfx@lists.freedesktop.org *Cc:* Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian ; Sharma, Shashank *Subject:* Re: [PATCH 1/2] drm: Add GPU reset sysfs event On 2022-03-07 11:26, Shashank Sharma wrote: > From: Shashank Sharma > > This patch adds a n

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Sharma, Shashank
bugfs dump but it looks like pretty straight forward to expose their buffer to external client like amdgpu. Noted, thanks for the pointer. - Shashank Andrey On 2022-03-08 11:46, Sharma, Shashank wrote: I have a very limited understanding of PMC driver and its interfaces, so I would just go ahe

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Sharma, Shashank
Hey Mario, On 3/8/2022 6:27 PM, Limonciello, Mario wrote: On 3/8/2022 10:57, Sharma, Shashank wrote: On 3/8/2022 5:55 PM, Andrey Grodzovsky wrote: You can read on their side here - https://www.phoronix.com/scan.php?page=news_item&px=AMD-STB-Linux-5.17 and see their patch. THey don&#x

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Sharma, Shashank
On 3/9/2022 8:47 AM, Simon Ser wrote: Hi, Maybe it would be a good idea to state the intended use-case in the commit message? It was added in the second patch, but yeah, it makes more sense to add a cover-letter probably. And explain why the current (driver-specific IIRC) APIs aren't e

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-10 Thread Sharma, Shashank
On 3/10/2022 4:24 PM, Rob Clark wrote: On Thu, Mar 10, 2022 at 1:55 AM Christian König wrote: Am 09.03.22 um 19:12 schrieb Rob Clark: On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma wrote: From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-10 Thread Sharma, Shashank
On 3/10/2022 6:10 PM, Rob Clark wrote: On Thu, Mar 10, 2022 at 8:21 AM Sharma, Shashank wrote: On 3/10/2022 4:24 PM, Rob Clark wrote: On Thu, Mar 10, 2022 at 1:55 AM Christian König wrote: Am 09.03.22 um 19:12 schrieb Rob Clark: On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-10 Thread Sharma, Shashank
On 3/10/2022 7:33 PM, Abhinav Kumar wrote: On 3/10/2022 9:40 AM, Rob Clark wrote: On Thu, Mar 10, 2022 at 9:19 AM Sharma, Shashank wrote: On 3/10/2022 6:10 PM, Rob Clark wrote: On Thu, Mar 10, 2022 at 8:21 AM Sharma, Shashank wrote: On 3/10/2022 4:24 PM, Rob Clark wrote: On Thu

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-10 Thread Sharma, Shashank
On 3/10/2022 8:35 PM, Rob Clark wrote: On Thu, Mar 10, 2022 at 11:14 AM Sharma, Shashank wrote: On 3/10/2022 7:33 PM, Abhinav Kumar wrote: On 3/10/2022 9:40 AM, Rob Clark wrote: On Thu, Mar 10, 2022 at 9:19 AM Sharma, Shashank wrote: On 3/10/2022 6:10 PM, Rob Clark wrote: On

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-10 Thread Sharma, Shashank
On 3/10/2022 8:56 PM, Rob Clark wrote: On Thu, Mar 10, 2022 at 11:44 AM Sharma, Shashank wrote: On 3/10/2022 8:35 PM, Rob Clark wrote: On Thu, Mar 10, 2022 at 11:14 AM Sharma, Shashank wrote: On 3/10/2022 7:33 PM, Abhinav Kumar wrote: On 3/10/2022 9:40 AM, Rob Clark wrote: On

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Sharma, Shashank
On 3/16/2022 10:50 PM, Rob Clark wrote: On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma wrote: From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about a GPU reset, and can also provide some information like: - process ID of the process involved with

Re: [PATCH v2 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2022-09-26 Thread Sharma, Shashank
Hello Christian, On 9/26/2022 5:10 PM, Christian König wrote: Am 26.09.22 um 17:02 schrieb Shashank Sharma: Allow the user to specify a workload hint to the kernel. We can use these to tweak the dpm heuristics to better match the workload for improved performance. Signed-off-by: Alex Deucher

Re: [PATCH v2 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2022-09-26 Thread Sharma, Shashank
On 9/26/2022 5:19 PM, Christian König wrote: Am 26.09.22 um 17:14 schrieb Sharma, Shashank: Hello Christian, On 9/26/2022 5:10 PM, Christian König wrote: Am 26.09.22 um 17:02 schrieb Shashank Sharma: Allow the user to specify a workload hint to the kernel. We can use these to tweak the

Re: [PATCH v3 2/5] drm/amdgpu: add new functions to set GPU power profile

2022-09-27 Thread Sharma, Shashank
, Christian ; Sharma, Shashank Subject: [PATCH v3 2/5] drm/amdgpu: add new functions to set GPU power profile This patch adds new functions which will allow a user to change the GPU power profile based a GPU workload hint flag. Cc: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm

Re: [PATCH v3 2/5] drm/amdgpu: add new functions to set GPU power profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 11:29 AM, Quan, Evan wrote: [AMD Official Use Only - General] -Original Message- From: Sharma, Shashank Sent: Tuesday, September 27, 2022 3:30 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian

Re: [PATCH v3 2/5] drm/amdgpu: add new functions to set GPU power profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 11:58 AM, Lazar, Lijo wrote: On 9/27/2022 3:10 AM, Shashank Sharma wrote: This patch adds new functions which will allow a user to change the GPU power profile based a GPU workload hint flag. Cc: Alex Deucher Signed-off-by: Shashank Sharma ---   drivers/gpu/drm/amd/amdgpu/Ma

Re: [PATCH v3 4/5] drm/amdgpu: switch GPU workload profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 12:03 PM, Lazar, Lijo wrote: On 9/27/2022 3:10 AM, Shashank Sharma wrote: This patch and switches the GPU workload based profile based on the workload hint information saved in the workload context. The workload profile is reset to NONE when the job is done. Signed-off-by: Ale

Re: [PATCH v3 2/5] drm/amdgpu: add new functions to set GPU power profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 2:10 PM, Lazar, Lijo wrote: On 9/27/2022 5:11 PM, Sharma, Shashank wrote: On 9/27/2022 11:58 AM, Lazar, Lijo wrote: On 9/27/2022 3:10 AM, Shashank Sharma wrote: This patch adds new functions which will allow a user to change the GPU power profile based a GPU workload

Re: [PATCH v3 4/5] drm/amdgpu: switch GPU workload profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 2:20 PM, Lazar, Lijo wrote: On 9/27/2022 5:17 PM, Sharma, Shashank wrote: On 9/27/2022 12:03 PM, Lazar, Lijo wrote: On 9/27/2022 3:10 AM, Shashank Sharma wrote: This patch and switches the GPU workload based profile based on the workload hint information saved in the

Re: [PATCH v3 2/5] drm/amdgpu: add new functions to set GPU power profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 2:39 PM, Lazar, Lijo wrote: On 9/27/2022 5:53 PM, Sharma, Shashank wrote: On 9/27/2022 2:10 PM, Lazar, Lijo wrote: On 9/27/2022 5:11 PM, Sharma, Shashank wrote: On 9/27/2022 11:58 AM, Lazar, Lijo wrote: On 9/27/2022 3:10 AM, Shashank Sharma wrote: This patch adds

Re: [PATCH v3 2/5] drm/amdgpu: add new functions to set GPU power profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 3:29 PM, Lazar, Lijo wrote: On 9/27/2022 6:23 PM, Sharma, Shashank wrote: On 9/27/2022 2:39 PM, Lazar, Lijo wrote: On 9/27/2022 5:53 PM, Sharma, Shashank wrote: On 9/27/2022 2:10 PM, Lazar, Lijo wrote: On 9/27/2022 5:11 PM, Sharma, Shashank wrote: On 9/27/2022 11

Re: [PATCH v3 2/5] drm/amdgpu: add new functions to set GPU power profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 4:00 PM, Lazar, Lijo wrote: On 9/27/2022 7:17 PM, Sharma, Shashank wrote: On 9/27/2022 3:29 PM, Lazar, Lijo wrote: On 9/27/2022 6:23 PM, Sharma, Shashank wrote: On 9/27/2022 2:39 PM, Lazar, Lijo wrote: On 9/27/2022 5:53 PM, Sharma, Shashank wrote: On 9/27/2022 2

Re: [PATCH v3 2/5] drm/amdgpu: add new functions to set GPU power profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 4:34 PM, Lazar, Lijo wrote: On 9/27/2022 7:50 PM, Sharma, Shashank wrote: On 9/27/2022 4:00 PM, Lazar, Lijo wrote: On 9/27/2022 7:17 PM, Sharma, Shashank wrote: On 9/27/2022 3:29 PM, Lazar, Lijo wrote: On 9/27/2022 6:23 PM, Sharma, Shashank wrote: On 9/27/2022 2

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-27 Thread Sharma, Shashank
Hello Felix, Thank for the review comments. On 9/27/2022 4:48 PM, Felix Kuehling wrote: Am 2022-09-27 um 02:12 schrieb Christian König: Am 26.09.22 um 23:40 schrieb Shashank Sharma: This patch switches the GPU workload mode to/from compute mode, while submitting compute workload. Signed-off-

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 5:23 PM, Felix Kuehling wrote: Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: Hello Felix, Thank for the review comments. On 9/27/2022 4:48 PM, Felix Kuehling wrote: Am 2022-09-27 um 02:12 schrieb Christian König: Am 26.09.22 um 23:40 schrieb Shashank Sharma: This patch

Re: [PATCH v3 0/5] GPU workload hints for better performance

2022-09-27 Thread Sharma, Shashank
Hey Michel, Thanks for the review coments. On 9/27/2022 6:24 PM, Michel Dänzer wrote: On 2022-09-26 23:40, Shashank Sharma wrote: AMDGPU SOCs supports dynamic workload based power profiles, which can provide fine-tuned performance for a particular type of workload. This patch series adds an int

Re: [PATCH v3 4/5] drm/amdgpu: switch GPU workload profile

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 6:33 PM, Michel Dänzer wrote: On 2022-09-27 13:47, Sharma, Shashank wrote: On 9/27/2022 12:03 PM, Lazar, Lijo wrote: On 9/27/2022 3:10 AM, Shashank Sharma wrote: This patch and switches the GPU workload based profile based on the workload hint information saved in the workload

Re: [PATCH v3 0/5] GPU workload hints for better performance

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 7:13 PM, Michel Dänzer wrote: On 2022-09-27 18:59, Sharma, Shashank wrote: Hey Michel, Thanks for the review coments. On 9/27/2022 6:24 PM, Michel Dänzer wrote: On 2022-09-26 23:40, Shashank Sharma wrote: AMDGPU SOCs supports dynamic workload based power profiles, which can

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-28 Thread Sharma, Shashank
On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank wrote: On 9/27/2022 5:23 PM, Felix Kuehling wrote: Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: Hello Felix, Thank for the review comments. On 9/27/2022 4:48 PM, Felix Kuehling wrote: Am

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-28 Thread Sharma, Shashank
Small correction, On 9/28/2022 10:56 AM, Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank wrote: On 9/27/2022 5:23 PM, Felix Kuehling wrote: Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: Hello Felix, Thank for the

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Sharma, Shashank
On 9/28/2022 11:51 PM, Alex Deucher wrote: On Wed, Sep 28, 2022 at 4:57 AM Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank wrote: On 9/27/2022 5:23 PM, Felix Kuehling wrote: Am 2022-09-27 um 10:58 schrieb Sharma

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Sharma, Shashank
On 9/29/2022 1:10 PM, Lazar, Lijo wrote: On 9/29/2022 2:18 PM, Sharma, Shashank wrote: On 9/28/2022 11:51 PM, Alex Deucher wrote: On Wed, Sep 28, 2022 at 4:57 AM Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Sharma, Shashank
On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clear your understanding - Nothing is automatic in PMFW. PMFW picks a priority based on the actual mask sent by driver. Assuming lower bits corresponds to highest priority - If driver sends a mask with Bit3 and Bit 0 set, PMFW will chose prof

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Sharma, Shashank
On 9/29/2022 4:14 PM, Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clear your understanding - Nothing is automatic in PMFW. PMFW picks a priority based on the actual mask sent by driver. Assuming lower bits

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Sharma, Shashank
On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clear your understanding - Nothing is automatic in

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Sharma, Shashank
On 9/30/2022 11:13 AM, Lazar, Lijo wrote: On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Sharma, Shashank
On 9/30/2022 11:54 AM, Lazar, Lijo wrote: On 9/30/2022 2:52 PM, Sharma, Shashank wrote: On 9/30/2022 11:13 AM, Lazar, Lijo wrote: On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29

Re: [PATCH] amdgpu: add context creation flags in CS IOCTL

2022-08-02 Thread Sharma, Shashank
On 8/2/2022 5:58 PM, Michel Dänzer wrote: On 2022-08-02 15:55, Shashank Sharma wrote: This patch adds: - A new input parameter "flags" in the amdgpu_ctx_create2 call. - Some new flags defining workload type hints. - Some change in the caller function of amdgpu_ctx_create2, to accomodate this

Re: [PATCH] amdgpu: add context creation flags in CS IOCTL

2022-08-08 Thread Sharma, Shashank
On 8/8/2022 12:59 PM, Christian König wrote: Am 02.08.22 um 15:55 schrieb Shashank Sharma: This patch adds: - A new input parameter "flags" in the amdgpu_ctx_create2 call. - Some new flags defining workload type hints. - Some change in the caller function of amdgpu_ctx_create2, to    accomoda

RE: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-02-14 Thread Sharma, Shashank
[AMD Official Use Only - General] + Uday, for awareness. Regards Shashank -Original Message- From: Pekka Paalanen Sent: 14 February 2023 10:28 To: Melissa Wen Cc: Ville Syrjälä ; dri-de...@lists.freedesktop.org; airl...@gmail.com; laurent.pinchart+rene...@ideasonboard.com; Sharma

RE: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-21 Thread Sharma, Shashank
: Marek Olšák Sent: 21 March 2023 04:05 To: Sharma, Shashank Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl I think we should do it differently because this

RE: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-22 Thread Sharma, Shashank
one option from the patch: +#define AMDGPU_CTX_WORKLOAD_HINT_VR Regards Shashank From: Koenig, Christian Sent: 22 March 2023 15:29 To: Marek Olšák Cc: Christian König ; Sharma, Shashank ; Deucher, Alexander ; Somalapuram, Amaranath ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v3 1/5

RE: [PATCH 00/16] AMDGPU Doorbell manager

2023-03-30 Thread Sharma, Shashank
[AMD Official Use Only - General] Hey Luben, Agree and noted. I have configured my editor to write the code according to the alignment conventions, but probably something missed the mark. - Shashank -Original Message- From: Tuikov, Luben Sent: 30 March 2023 15:50 To: Sharma

RE: [PATCH v3 0/9] AMDGPU Usermode queues

2023-04-10 Thread Sharma, Shashank
: https://gitlab.freedesktop.org/contactshashanksharma/userq-amdgpu/-/tree/integrated-db-and-uq-v3 Please stay tuned for updated libDRM changes with doorbell objects. Regards Shashank -Original Message- From: Bas Nieuwenhuizen Sent: 10 April 2023 02:37 To: Sharma, Shashank Cc: amd-gfx

RE: [PATCH v3 0/9] AMDGPU Usermode queues

2023-04-10 Thread Sharma, Shashank
calls amdgpu_free_userq, which does the destroy_OP for the IOCTL. - Shashank -Original Message- From: Bas Nieuwenhuizen Sent: 10 April 2023 11:26 To: Sharma, Shashank Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Koenig, Christian ; Yadav, Arvind Subject

RE: [PATCH v4 05/10] drm/amdgpu: create context space for usermode queue

2023-04-25 Thread Sharma, Shashank
[Public] > CSA, GDS backup, and shadow are allocated by userspace now. Noted Alex, thanks. I will update the patch series and userspace accordingly. Regards Shashank -Original Message- From: Deucher, Alexander Sent: 25 April 2023 19:38 To: Sharma, Shashank ; Koenig, Christian ;

Re: [PATCH 1/2] drm/amdgpu: Convert to common fdinfo format v3

2022-05-13 Thread Sharma, Shashank
Hey Christian, On 5/11/2022 2:02 PM, Christian König wrote: Convert fdinfo format to one documented in drm-usage-stats.rst. It turned out that the existing implementation was actually completely nonsense. The calculated percentages indeed represented the usage of the engine, but with varying ti

Re: [PATCH 2/2] drm/amdgpu: add drm-client-id to fdinfo

2022-05-13 Thread Sharma, Shashank
On 5/11/2022 2:02 PM, Christian König wrote: This is enough to get gputop working :) Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c b/drive

Re: [PATCH 1/2] drm/amdgpu: Convert to common fdinfo format v5

2022-05-17 Thread Sharma, Shashank
Please feel free to use: Reviewed-by: Shashank Sharma On 5/17/2022 12:36 PM, Christian König wrote: Convert fdinfo format to one documented in drm-usage-stats.rst. It turned out that the existing implementation was actually completely nonsense. The calculated percentages indeed represented the

Re: [PATCH v1 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-20 Thread Sharma, Shashank
Hey Amar, On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Allocate memory for register value and use the same values for devcoredump. Remove dump_stack reset register dumps. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/am

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-20 Thread Sharma, Shashank
On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Added device coredump information: - Kernel version - Module - Time - VRAM status - Guilty process name and PID - GPU register dumps Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++ drivers/gpu/

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-24 Thread Sharma, Shashank
On 5/24/2022 8:42 AM, Somalapuram, Amaranath wrote: On 5/20/2022 7:52 PM, Sharma, Shashank wrote: On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Added device coredump information: - Kernel version - Module - Time - VRAM status - Guilty process name and PID - GPU register dumps

Re: [PATCH v1 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-24 Thread Sharma, Shashank
On 5/24/2022 8:12 AM, Somalapuram, Amaranath wrote: On 5/20/2022 7:36 PM, Sharma, Shashank wrote: Hey Amar, On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Allocate memory for register value and use the same values for devcoredump. Remove dump_stack reset register dumps. Signed-off

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-24 Thread Sharma, Shashank
On 5/24/2022 2:10 PM, Somalapuram, Amaranath wrote: On 5/24/2022 3:23 PM, Sharma, Shashank wrote: On 5/24/2022 8:42 AM, Somalapuram, Amaranath wrote: On 5/20/2022 7:52 PM, Sharma, Shashank wrote: On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Added device coredump information

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-24 Thread Sharma, Shashank
On 5/24/2022 3:18 PM, Somalapuram, Amaranath wrote: On 5/24/2022 6:20 PM, Sharma, Shashank wrote: On 5/24/2022 2:10 PM, Somalapuram, Amaranath wrote: On 5/24/2022 3:23 PM, Sharma, Shashank wrote: On 5/24/2022 8:42 AM, Somalapuram, Amaranath wrote: On 5/20/2022 7:52 PM, Sharma

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-24 Thread Sharma, Shashank
(snip) #ifdef CONFIG_DEV_COREDUMP     tmp_adev->reset_context_vram_lost = vram_lost; tmp_adev->reset_context_task_info.pid = 0;     if (reset_context->job && reset_context->job->vm) tmp_adev->reset_context_task_info = reset_context->jo

Re: [PATCH v2 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-26 Thread Sharma, Shashank
eset_dump_reg_value[i] = RREG32(adev->reset_dump_reg_list[i]); + trace_amdgpu_reset_reg_dumps(adev->reset_dump_reg_list[i], + adev->reset_dump_reg_value[i]); Please fix the alignment with the line above, after that, please feel free to use: Reviewed-by: Shashank Sharma - Shashank } return 0;

Re: [PATCH v2 2/2] drm/amdgpu: adding device coredump support

2022-05-26 Thread Sharma, Shashank
b->vm) + tmp_adev->reset_task_info = + reset_context->job->vm->task_info; + amdgpu_reset_capture_coredumpm(tmp_adev); +#endif if (vr

RE: [PATCH v2 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-31 Thread Sharma, Shashank
ashank From: Somalapuram, Amaranath Sent: Tuesday, May 31, 2022 3:09 PM To: Sharma, Shashank ; Somalapuram, Amaranath ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Deucher, Alexander Subject: Re: [PATCH v2 1/2] drm/amdgpu: save the reset dump register value for devcoredump On 5/26/

RE: [PATCH v3 2/2] drm/amdgpu: adding device coredump support

2022-06-03 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma for both the patches. Regards Shashank -Original Message- From: Somalapuram, Amaranath Sent: Thursday, June 2, 2022 10:16 AM To: amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Deucher, Alexander ; Sharma, Shashank ; Somalapuram, Amaranath Subject

<    1   2