Simplify the function by removing identical looking code blocks.
Signed-off-by: Tom St Denis
---
.../display/dc/dce120/dce120_timing_generator.c| 37 +++---
1 file changed, 12 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce120
Signed-off-by: Tom St Denis
---
.../drm/amd/display/dc/dce120/dce120_timing_generator.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c
b/drivers/gpu/drm/amd/display/dc/dce120
Use WREG32_FIELD instead.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c
b/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c
index cd793c262674..d4e35ff8d9cd 100644
--- a
Fix indentation and use WREG32_FIELD to clean up.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c
b/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c
index
The uintNN_t types were already in use except for a few
spots.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c
b/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c
index
Swap uNN for uintNN_t.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c
b/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c
index 8ab0f78794a5..eccf4c467fe1 100644
Rounding off the SI cleanups for now are small NFC edits to
the uvd42 and vce2 drivers.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On 16/05/17 06:51 AM, Christian König wrote:
Am 15.05.2017 um 20:25 schrieb Tom St Denis:
Swap uNN for uintNN_t.
Signed-off-by: Tom St Denis
Acked-by: Christian König
Do we actually do something else than busy waiting for idle in one of
the modules in the wait_for_idle callback?
If no
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
index 81f5aa9ff719..27db0710e9ab 100644
--- a/drivers/gpu/drm/amd/amdgpu
Swap uNN for uintNN_t.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 62 +--
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
index
Replace uNN with uintNN_t types. In various places
uintNN_t was already used.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 204 +-
1 file changed, 102 insertions(+), 102 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
index 1b6b9b22d780..ec7f7bb77f50 100644
--- a/drivers/gpu/drm/amd
Swap in uintNN_t types and a small clean up. Should be no functional changes.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Signed-off-by: Tom St Denis
---
src/app/enum.c | 2 +-
src/app/scan.c | 2 +-
src/app/scan_log.c | 2 +-
src/app/set_bit.c | 4 ++--
src/app/set_reg.c | 4 ++--
src/app/top.c | 2 +-
src/lib/create_mmio_accel.c | 2
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
index b7a70551d49f..2463fcae35a7 100644
--- a/drivers/gpu/drm/amd
Various cleanups to coding style for gfx6. Should be no
functional changes.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Clean up coding style in gfx_v6_0_write_harvested_raster_configs()
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd/amdgpu
Switch to uintNN_t from "uNN" types to be more consistent
with modern coding styles.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 150 +-
1 file changed, 75 insertions(+), 75 deletions(-)
diff --git a/drivers/gpu/drm/
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 1556 ++---
1 file changed, 676 insertions(+), 880 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
index 5d9e95bcd011..36a70e93b293 100644
Drop the function gmc_v6_0_init_compute_vmid() since it wasn't
implemented and commented out.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd/a
Signed-off-by: Tom St Denis
---
src/app/top.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/app/top.c b/src/app/top.c
index a4d3aa8e699d..09ab5f40de0b 100644
--- a/src/app/top.c
+++ b/src/app/top.c
@@ -813,8 +813,8 @@ static void top_build_vi_program(struct umr_asic
On 11/05/17 07:33 PM, Tom St Denis wrote:
On 11/05/17 02:35 PM, Alex Deucher wrote:
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can
someone with gfx9 capable hw test this (vega10 or raven)? This is needed
to enable powergating on gfx9.
Thanks,
If nobody gets
On 11/05/17 02:35 PM, Alex Deucher wrote:
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can
someone with gfx9 capable hw test this (vega10 or raven)? This is needed
to enable powergating on gfx9.
Thanks,
If nobody gets to it by morning I'll try it out first thing on my
Hi all,
I've pushed out a large commit which adds raven support to umr. Since
it's quite large I've bypassed the list.
The commit can be seen here:
https://cgit.freedesktop.org/amd/umr/commit/?id=6acc89e4ec159de470af1ec1b9f53d4e97c562bb
Cheers,
Tom
__
---
src/lib/discover_by_did.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/lib/discover_by_did.c b/src/lib/discover_by_did.c
index 2e06d5092847..7ecd7f353c92 100644
--- a/src/lib/discover_by_did.c
+++ b/src/lib/discover_by_did.c
@@ -221,7 +221,9 @@ static const struct {
{ 0x68
Fixes: 1fe8f78d00589904b830a0ebd092c7810f625f00
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
b/drivers/gpu/drm/amd/powerplay
MMIO registers (with bank selection)
- reading wave status and SGPR registers
Signed-off-by: Tom St Denis
---
doc/umr.1 | 5 +++
src/app/main.c| 5 ++-
src/app/scan.c| 6 +++-
src/app/set_bit.c | 4 +++
src/app/set_reg.c | 4 +++
src/lib/discover.c
Opening the DRM file (/dev/dri/card%d) triggers all sorts of KMD
work to happen which is not useful if the KMD is hung or not working.
Since --top is the only user of the file currently we simply defer
opening it until --top is invoked.
Signed-off-by: Tom St Denis
---
src/app/top.c | 7
On 19/04/17 11:07 AM, Christian König wrote:
Am 19.04.2017 um 17:03 schrieb Tom St Denis:
So it's more obvious which rings are using which INV engines.
Signed-off-by: Tom St Denis
I wonder if we shouldn't stop printing the ring numbers completely in
the ring and IB tests as well
So it's more obvious which rings are using which INV engines.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
umr expects the ring name to be a complete word. This also
makes it consistent with GFXv7/8.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd
umr expects the ring name to be a complete word. This also
makes it consistent with GFXv7/8.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd
On 18/04/17 01:00 PM, Andres Rodriguez wrote:
+static int gfx_v9_0_kiq_kcq_disable(struct amdgpu_device *adev)
+{
+struct amdgpu_ring *kiq_ring = &adev->gfx.kiq.ring;
+uint32_t scratch, tmp = 0;
+int r, i;
+
+r = amdgpu_gfx_scratch_get(adev, &scratch);
+if (r) {
+DRM_
Signed-off-by: Tom St Denis
---
src/lib/ring_decode.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/lib/ring_decode.c b/src/lib/ring_decode.c
index 372bb43595b8..48d840643bf9 100644
--- a/src/lib/ring_decode.c
+++ b/src/lib/ring_decode.c
@@ -379,6 +379,19 @@ static void
On 18/04/17 07:32 AM, Tom St Denis wrote:
With that fixed I can read (non-cached) IBs from the libdrm test suite.
Signed-off-by: Tom St Denis
+ pde_fields.pte_base_addr = (pde_entry & ((1ULL << 48) -
1)) & ~0xFFFULL; //pde_entry & 0xFF
With that fixed I can read (non-cached) IBs from the libdrm test suite.
Signed-off-by: Tom St Denis
---
src/lib/read_vram.c | 47 ---
1 file changed, 32 insertions(+), 15 deletions(-)
diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c
index
Obvious off by 1 also incorrect page table indecies.
Also added a lot more debugging output which is off by default.
Signed-off-by: Tom St Denis
---
src/lib/read_vram.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/lib/read_vram.c b/src/lib
As well as add EVENT type decoding to human readable
string.
Signed-off-by: Tom St Denis
---
src/lib/ring_decode.c | 66 ---
1 file changed, 63 insertions(+), 3 deletions(-)
diff --git a/src/lib/ring_decode.c b/src/lib/ring_decode.c
index
On 13/04/17 11:38 AM, Panariti, David wrote:
+ Vilas
-Original Message-
From: Deucher, Alexander
Sent: Wednesday, April 12, 2017 9:29 PM
To: 'Michel Dänzer' ; Panariti, David
Cc: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: Add kernel parameter to manage
memory error
On platforms without GPU_POWER sensors the thread reading sensors would proceed
far too quickly. So it is now rate limited to 50Hz to be consistent.
Signed-off-by: Tom St Denis
---
src/app/top.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/app/top.c b
other options/instance commands. It will ignore any updates for
asics that aren't currently being used so you can specify
multiple asic updates in a single file.
Signed-off-by: Tom St Denis
(v2): Considerable tidy up of code + add deletion support
---
src/app/main.c
ter any
other options/instance commands. It will ignore any updates for
asics that aren't currently being used so you can specify
multiple asic updates in a single file.
Signed-off-by: Tom St Denis
---
src/app/main.c | 10 ++
src/lib/CMakeLists.txt | 1 +
src/lib/update.c |
This series ports a variety of vega10 drivers over
to the new SOC15 macros and introduces a pair of
OFFSET ready macros to help with MC related code.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/a
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
index d351583785e5..34dbb60da752 100644
No functional changes.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 201
1 file changed, 100 insertions(+), 101 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
index
Note this commit also fixes a few typos in the commented
out portions which were missing closing parenthesis on the
original coding style.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 176 +-
1 file changed, 88 insertions(+), 88
Swap a couple of read/set/write patterns for WREG32_FIELD15.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
b/drivers/gpu/drm/amd/amdgpu
Change read/set/write patterns into WREG32_FIELD15 calls.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
Allows reading/writing via SOC15 macros with offset for
various register banks.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/soc15_common.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15_common.h
b/drivers/gpu/drm/amd/amdgpu
No functional changes in this patch. Simply re-writing
read/writes into new macros.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 182 +++
1 file changed, 91 insertions(+), 91 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 44 ++
1 file changed, 18 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c
b/drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c
index 97057f4a10de..57dd6aae4961 100644
As well swap a read/set/write pattern over to WREG32_FIELD15.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
This patch also fixes some bugs in commented out code where
parenthesis were missing on various SOC15 macros.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 206 +-
1 file changed, 103 insertions(+), 103 deletions(-)
diff --git a/drivers
On 07/04/17 08:05 AM, Christian König wrote:
Am 07.04.2017 um 13:55 schrieb Tom St Denis:
Signed-off-by: Tom St Denis
Acked-by: Christian König .
If I could get a RB by someone I could get going on the rest of the AI+
code.
Tom
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 406
On 07/04/17 12:01 PM, Felix Kuehling wrote:
Advertise CIK PCI IDs only when they are not supported by amdgpu.
Use the CONFIG_DRM_AMDGPU_CIK to check so that a single option in
the kernel config keeps both drivers in sync.
This is the simplest possible change. A more complete solution
may want to
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ---
drivers/gpu/drm/amd/amdgpu/soc15_common.h | 20 +++-
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 406 +-
1 file changed, 203 insertions(+), 203 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index cb6c7eb8a87e..d5492629d49a 100644
Replace verbose SOC15 macros with simpler
RREG32/WREG32_SOC15 macros to make the code a
lot easier to read (and write).
Signed-off-by: Tom St Denis
v2: Moved SOC15 macros to soc15_common.h and removed
VA_ARGS from RREG32_SOC15().
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3
Signed-off-by: Tom St Denis
---
src/app/top.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/app/top.c b/src/app/top.c
index b8a91e317ba5..96e33ff2e1da 100644
--- a/src/app/top.c
+++ b/src/app/top.c
@@ -252,6 +252,15 @@ static struct umr_bitfield
ess >> (page_table_depth*9 + (12 +
page_table_size - 4)));
Would result in a 9-bit page size if say page_table_size was 1 which
should actually be 13 bits (8KB).
Tom
On 06/04/17 02:14 PM, Tom St Denis wrote:
On 06/04/17 02:11 PM, Deucher, Alexander wrote:
-Original Message-
From
On 06/04/17 02:11 PM, Deucher, Alexander wrote:
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
Of Tom St Denis
Sent: Thursday, April 06, 2017 1:53 PM
To: amd-gfx@lists.freedesktop.org
Cc: StDenis, Tom
Subject: [PATCH umr] Add initial AI VM
Tested with VMID0 decodings just fine. Haven't tried VMID1-15 yet.
Signed-off-by: Tom St Denis
---
src/lib/read_vram.c | 180 ++--
1 file changed, 176 insertions(+), 4 deletions(-)
diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c
> To: Alex Deucher
> Cc: Andres Rodriguez; Deucher, Alexander; Tom St Denis; amd-
> g...@lists.freedesktop.org <mailto:g...@lists.freedesktop.org>
> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet"
>
> On 05/04/17 09:
On 05/04/17 10:15 AM, Christian König wrote:
Am 05.04.2017 um 15:26 schrieb Tom St Denis:
Introduce WREG32_FIELD15 macro for SOC15 architectures.
Signed-off-by: Tom St Denis
Reviewed-by: Christian König
For the series or just 1/10?
Tom
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h
Use new WREG32_FIELD15 macro.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 3888743bc868
Use new WREG32_FIELD15 macro.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 257d0d320f54
Use new WREG32_FIELD15 macro
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 6bc9856e67a7..80700356474c 100644
--- a
Use new WREG32_FIELD15 macro
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 2dd32466919d..33df0dbe7052 100644
--- a
Use new WREG32_FIELD macro
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index ebd35af7f400..49527c0c2696
Introduce WREG32_FIELD15 macro for SOC15 architectures.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 11 +++
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b
Use new WREG32_FIELD15 macro.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 714fd0f228cf..257d0d320f54
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 49527c0c2696..6bc9856e67a7 100644
--- a/drivers/gpu/drm/amd
It's not used in gfx 6/7/8 so drop it from gfx 9 as well.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 175 +-
1 file changed, 1 insertion(+), 174 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/dr
Use new WREG32_FIELD15 macro
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 80700356474c..2dd32466919d 100644
On 05/04/17 09:06 AM, Alex Deucher wrote:
On Wed, Apr 5, 2017 at 7:30 AM, Tom St Denis wrote:
My firmware is
fw.VCE == .feature==0 .firmware==0x34040300
fw.UVD == .feature==0 .firmware==0x015b0b00
fw.MC == .feature==0 .firmware==0x
fw.ME == .feature==46
wrote:
-Original Message-
From: Andres Rodriguez [mailto:andre...@gmail.com]
Sent: Tuesday, April 04, 2017 4:01 PM
To: Tom St Denis; Deucher, Alexander; StDenis, Tom; amd-
g...@lists.freedesktop.org
Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet"
This is my info
n Behalf
> > Of Andres Rodriguez
> > Sent: Tuesday, April 04, 2017 3:39 PM
> > To: StDenis, Tom; amd-gfx@lists.freedesktop.org
> > Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet"
> >
> >
> >
> > On 2017-04-04 08:27
Had the wrong sense in the loop
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
index 5191c45ffdf3..0900fdf0651b 100644
--- a
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
index 0900fdf0651b..c3588d1c7cb0 100644
--- a/drivers/gpu/drm/amd
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 5a8e8aea99b9..3571c4895120 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b
Use new WREG32_FIELD_OFFSET() to clean up code.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 40 +++
2 files changed, 15 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/amd
Clean up a toggle with ?:.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 46e2367405de..5a8e8aea99b9
Swap read/write pattern for WREG32_FIELD()
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 3c43c10d0ada
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index d09d69b0d096..46e2367405de 100644
--- a/drivers/gpu/drm/amd/amdgpu
Swap read/write pattern for WREG32_FIELD()
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 595dc14019dd
On 03/04/17 04:25 PM, Andres Rodriguez wrote:
Commit e579f56 results in a KCQ initialization error for polaris10
cards. Providing the full SET_RESOURCES packet instead of the truncated
version fixes the problem.
I think this patch may have been one of the stabs at fixing the KCQ
suspend/resume e
On 29/03/17 01:46 PM, Christian König wrote:
Am 29.03.2017 um 19:44 schrieb Tom St Denis:
On 29/03/17 01:41 PM, Christian König wrote:
Am 29.03.2017 um 19:07 schrieb Tom St Denis:
On 29/03/17 01:07 PM, Tom St Denis wrote:
On gfx9 hardware the value is not wrapped and is a 64-bit value. So
On gfx9 hardware the value is not wrapped and is a 64-bit value. So
we reduce it modulo the ring size.
Signed-off-by: Tom St Denis
(v2) use buf_mask instead of computing on the fly
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On 29/03/17 01:41 PM, Christian König wrote:
Am 29.03.2017 um 19:07 schrieb Tom St Denis:
On 29/03/17 01:07 PM, Tom St Denis wrote:
On gfx9 hardware the value is not wrapped and is a 64-bit value. So
we reduce it modulo the ring size.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd
On 29/03/17 01:07 PM, Tom St Denis wrote:
On gfx9 hardware the value is not wrapped and is a 64-bit value. So
we reduce it modulo the ring size.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
On gfx9 hardware the value is not wrapped and is a 64-bit value. So
we reduce it modulo the ring size.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
b
On 29/03/17 08:18 AM, Christian König wrote:
Ping!
Does anybody of you guys know what the background of those "untouched"
registers is?
That we leak uninitialized memory to userspace is a bit bad.
I don't know the history but wouldn't reading these just read the MMIO
registers? Or these are
On 27/03/17 09:41 AM, Tom St Denis wrote:
Eventually the GPU_POWER sensor will be rated at around
50Hz but that's still too slow to read from the main loop of
umr's --top so we move all sensor operations to a thread.
Signed-off-by: Tom St Denis
---
src/app/t
Eventually the GPU_POWER sensor will be rated at around
50Hz but that's still too slow to read from the main loop of
umr's --top so we move all sensor operations to a thread.
Signed-off-by: Tom St Denis
---
src/app/top.c | 110 +---
Signed-off-by: Tom St Denis
---
src/app/print_config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/app/print_config.c b/src/app/print_config.c
index 6dbe0d42b8dc..e295302ab7a3 100644
--- a/src/app/print_config.c
+++ b/src/app/print_config.c
@@ -91,6 +91,7 @@ static const struct
Signed-off-by: Tom St Denis
---
src/app/print_config.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/app/print_config.c b/src/app/print_config.c
index 6a4bf5dd594a..6dbe0d42b8dc 100644
--- a/src/app/print_config.c
+++ b/src/app/print_config.c
@@ -54,6 +54,12 @@ M
On 22/03/17 07:22 AM, 'j...@8bytes.org' wrote:
On Tue, Mar 21, 2017 at 04:30:55PM +, Deucher, Alexander wrote:
I am preparing a debug-patch that disables ATS for these GPUs so someone
with such a chip can test it.
Thanks Joerg.
Here is a debug patch, using the hard hammer of disabling th
On 22/03/17 01:18 PM, Tom St Denis wrote:
I tried this out but still got a lockup during init. I tried getting a
dmesg log but it locked up before it outputted anything more (after the
init).
nvm. Even with iommu disabled it fails to boot. Stoney support dies
occasionally on staging-4.9
On 21/03/17 12:25 PM, 'j...@8bytes.org' wrote:
On Tue, Mar 21, 2017 at 04:17:40PM +, Deucher, Alexander wrote:
-Original Message-
From: 'j...@8bytes.org' [mailto:j...@8bytes.org]
Sent: Tuesday, March 21, 2017 12:11 PM
To: Deucher, Alexander
Cc: Alex Deucher; Daniel Drake; Chris Chiu;
On many platforms /dev/mem is restricted to PCI I/O space
only. The /dev/fmem device driver can be found
on github and it allows unrestricted access to physical memory.
Signed-off-by: Tom St Denis
---
src/lib/read_vram.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a
601 - 700 of 909 matches
Mail list logo