Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-12-21 Thread Kazlauskas, Nicholas
*From:* Wang, Chao-kai (Stylon) *Sent:* Tuesday, November 10, 2020 2:49 AM *To:* amd-gfx@lists.freedesktop.org *Cc:* Wang, Chao-kai (Stylon) ; Kazlauskas, Nicholas ; Deucher, Alexander ; Wentland, Harry *Subject:* [PATCH] drm/amd/display: Fix

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-12-21 Thread Deucher, Alexander
(Stylon) ; Kazlauskas, Nicholas ; Deucher, Alexander ; Wentland, Harry Subject: [PATCH] drm/amd/display: Fix memory leaks in S3 resume EDID parsing in S3 resume pushes new display modes to probed_modes list but doesn't consolidate to actual mode list. This creates a race condition when

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-11-11 Thread Wang, Chao-kai (Stylon)
From: Deucher, Alexander Sent: November 11, 2020 12:55 AM To: Wentland, Harry ; Wang, Chao-kai (Stylon) ; amd-gfx@lists.freedesktop.org Cc: Kazlauskas, Nicholas Subject: Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume [AMD Official Use Only - Internal Distributio

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-11-10 Thread Deucher, Alexander
: Kazlauskas, Nicholas Subject: Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume It's missing the "drm_connector_list_update" call which I assume is important. Stylon, can you review Lee Starnes's patch? Is the drm_connector_list_update call maybe not needed? Thanks, Harry On 2020-1

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-11-10 Thread Harry Wentland
Wentland, Harry *Sent:* Tuesday, November 10, 2020 9:27 AM *To:* Wang, Chao-kai (Stylon) ; amd-gfx@lists.freedesktop.org *Cc:* Kazlauskas, Nicholas ; Deucher, Alexander *Subject:* Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume On 2020-11-10 2:49 a.m., Stylon Wang wrote: > EDID p

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-11-10 Thread Deucher, Alexander
, Chao-kai (Stylon) ; amd-gfx@lists.freedesktop.org Cc: Kazlauskas, Nicholas ; Deucher, Alexander Subject: Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume On 2020-11-10 2:49 a.m., Stylon Wang wrote: > EDID parsing in S3 resume pushes new display modes > to probed_modes list but d

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-11-10 Thread Harry Wentland
On 2020-11-10 2:49 a.m., Stylon Wang wrote: EDID parsing in S3 resume pushes new display modes to probed_modes list but doesn't consolidate to actual mode list. This creates a race condition when amdgpu_dm_connector_ddc_get_modes() re-initializes the list head without walking the list and

[PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-11-09 Thread Stylon Wang
EDID parsing in S3 resume pushes new display modes to probed_modes list but doesn't consolidate to actual mode list. This creates a race condition when amdgpu_dm_connector_ddc_get_modes() re-initializes the list head without walking the list and results in memory leak. Signed-off-by: Stylon Wang