RE: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-26 Thread Quan, Evan
turday, July 24, 2021 4:00 AM > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings > properly for NV1x > > On 7/21/21 9:20 PM, Evan Quan wrote: > > The customized OD settings can be divided into two

Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Matt Coffin
On 7/21/21 9:20 PM, Evan Quan wrote: The customized OD settings can be divided into two parts: those committed ones and non-committed ones. - For those changes which had been fed to SMU before S3/S4/Runpm suspend kicked, they are committed changes. They should be properly restored

RE: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Quan, Evan
or > restore or other purposes). > > Thanks, > Lijo > > -Original Message- > From: Quan, Evan > Sent: Friday, July 23, 2021 12:51 PM > To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: RE: [PATCH 1/2] drm/amd/pm: restore user cus

RE: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Lazar, Lijo
azar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x [AMD Official Use Only] Hi Lijo, Sorry, I doubled checked. The implementation of Navi1x is right. The original design for "restores to d

RE: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Quan, Evan
;user_dpm_profile.committed_od = false; + } BR Evan > -Original Message- > From: Quan, Evan > Sent: Friday, July 23, 2021 2:48 PM > To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: RE: [PATCH 1/2] drm/amd/pm: restore user customized OD

RE: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, July 22, 2021 5:03 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings &

Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-22 Thread Lazar, Lijo
On 7/22/2021 2:03 PM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Thursday, July 22, 2021 4:10 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 1/2] drm/amd/pm: restore user customized OD

RE: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-22 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, July 22, 2021 4:10 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings &

Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-22 Thread Lazar, Lijo
On 7/22/2021 8:50 AM, Evan Quan wrote: The customized OD settings can be divided into two parts: those committed ones and non-committed ones. - For those changes which had been fed to SMU before S3/S4/Runpm suspend kicked, they are committed changes. They should be properly

[PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-22 Thread Evan Quan
The customized OD settings can be divided into two parts: those committed ones and non-committed ones. - For those changes which had been fed to SMU before S3/S4/Runpm suspend kicked, they are committed changes. They should be properly restored and fed to SMU on S3/S4/Runpm resume. -