RE: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and deadlocking

2022-11-15 Thread Lin, Wayne
RM DRIVERS de...@lists.freedesktop.org>; open list > Subject: Re: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and > deadlocking > > On Wed, 2022-11-09 at 09:48 +, Lin, Wayne wrote: > > >   } > > > - if (!drm_dp_mst_atomic_check(state) &&a

Re: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and deadlocking

2022-11-14 Thread Lyude Paul
On Wed, 2022-11-09 at 09:48 +, Lin, Wayne wrote: > >    } > > - if (!drm_dp_mst_atomic_check(state) && !debugfs_overwrite) { > > + ret = drm_dp_mst_atomic_check(state); > > + if (ret == 0 && !debugfs_overwrite) { > >    set_dsc_configs_from_fairness_vars(params, vars, count, >

Re: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and deadlocking

2022-11-14 Thread Lyude Paul
Jerry > > ; Wu, Hersen ; Lin, Wayne > > ; Thomas Zimmermann ; > > Mahfooz, Hamza ; Hung, Alex > > ; Francis, David ; Mikita > > Lipski ; Liu, Wenjing ; > > open list:DRM DRIVERS ; open list > ker...@vger.kernel.org> > > Subject: [PATCH 1/2] drm/amdgpu

RE: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and deadlocking

2022-11-09 Thread Lin, Wayne
Liu, Wenjing ; > open list:DRM DRIVERS ; open list ker...@vger.kernel.org> > Subject: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and > deadlocking > > It appears that amdgpu makes the mistake of completely ignoring the return > values from the DP MST helpers, and in

[PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and deadlocking

2022-11-04 Thread Lyude Paul
It appears that amdgpu makes the mistake of completely ignoring the return values from the DP MST helpers, and instead just returns a simple true/false. In this case, it seems to have come back to bite us because as a result of simply returning false from compute_mst_dsc_configs_for_state(),