Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-24 Thread Greg KH
On Tue, Apr 18, 2023 at 07:15:22PM -0300, Guilherme G. Piccoli wrote: > commit 542a56e8eb4467ae654eefab31ff194569db39cd upstream. > > The VCN firmware loading path enables the indirect SRAM mode if it's > advertised as supported. We might have some cases of FW issues that > prevents this mode to w

Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-20 Thread Guilherme G. Piccoli
On 20/04/2023 12:56, gre...@linuxfoundation.org wrote: > [...] > That's 3000+ emails ago for me :) /head_exploding this is > 1000 emails per day, wow...my sympathies to you heh > [...] >> tl;dr: the offender is present on 6.1.y, but this fix is not, hence I'm >> hereby requesting the merge. Some

Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-20 Thread gre...@linuxfoundation.org
On Thu, Apr 20, 2023 at 12:36:00PM -0300, Guilherme G. Piccoli wrote: > On 20/04/2023 12:02, gre...@linuxfoundation.org wrote: > >> [...] > >>> Which "one" are you referring to here? > >>> > >>> confused, > >>> > >>> greg k-h > >> > >> This one, sent in this email thread. > > > > I don't have "thi

Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-20 Thread Guilherme G. Piccoli
On 20/04/2023 12:02, gre...@linuxfoundation.org wrote: >> [...] >>> Which "one" are you referring to here? >>> >>> confused, >>> >>> greg k-h >> >> This one, sent in this email thread. > > I don't have "this email thread" anymore, remember, some of us get > thousand+ emails a day... I don't reall

Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-20 Thread Alex Deucher
On Thu, Apr 20, 2023 at 11:04 AM gre...@linuxfoundation.org wrote: > > On Thu, Apr 20, 2023 at 09:59:17AM -0300, Guilherme G. Piccoli wrote: > > On 20/04/2023 09:42, gre...@linuxfoundation.org wrote: > > > [...] > > >> @Greg, can you pick this one? Thanks! > > > > > > Which "one" are you referring

Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-20 Thread gre...@linuxfoundation.org
On Thu, Apr 20, 2023 at 09:59:17AM -0300, Guilherme G. Piccoli wrote: > On 20/04/2023 09:42, gre...@linuxfoundation.org wrote: > > [...] > >> @Greg, can you pick this one? Thanks! > > > > Which "one" are you referring to here? > > > > confused, > > > > greg k-h > > This one, sent in this email

Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-20 Thread Guilherme G. Piccoli
On 20/04/2023 09:42, gre...@linuxfoundation.org wrote: > [...] >> @Greg, can you pick this one? Thanks! > > Which "one" are you referring to here? > > confused, > > greg k-h This one, sent in this email thread. The title of the patch is "drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken

Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-20 Thread gre...@linuxfoundation.org
On Thu, Apr 20, 2023 at 09:36:28AM -0300, Guilherme G. Piccoli wrote: > On 19/04/2023 17:04, Deucher, Alexander wrote: > > [...] > >> So, let me check if I understood properly: there are 2 trees (-fixes and > >> -next), > >> and the problem is that their merge onto mainline happens apart and there

Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-20 Thread Guilherme G. Piccoli
On 19/04/2023 17:04, Deucher, Alexander wrote: > [...] >> So, let me check if I understood properly: there are 2 trees (-fixes and >> -next), >> and the problem is that their merge onto mainline happens apart and there >> are kind of duplicate commits, that were first merged on -fixes, then "re- >

RE: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-19 Thread Deucher, Alexander
; ker...@gpiccoli.net; > kernel-...@igalia.com > Subject: Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on > Vangogh broken BIOSes > > On 19/04/2023 10:16, Deucher, Alexander wrote: > > [...] > >> This is quite strange for me, we have 2 commit hashes pointing to

Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-19 Thread Guilherme G. Piccoli
On 19/04/2023 10:16, Deucher, Alexander wrote: > [...] >> This is quite strange for me, we have 2 commit hashes pointing to the >> *same* commit, and each one is present..in a different release !!?! >> Since I've marked this patch as fixing 82132ecc5432 originally, 6.1.y stable >> misses it, since

[PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-19 Thread Guilherme G. Piccoli
commit 542a56e8eb4467ae654eefab31ff194569db39cd upstream. The VCN firmware loading path enables the indirect SRAM mode if it's advertised as supported. We might have some cases of FW issues that prevents this mode to working properly though, ending-up in a failed probe. An example below, observed

RE: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes

2023-04-19 Thread Deucher, Alexander
eo ; ker...@gpiccoli.net; kernel-...@igalia.com > Subject: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh > broken BIOSes > > commit 542a56e8eb4467ae654eefab31ff194569db39cd upstream. > > The VCN firmware loading path enables the indirect SRAM mode if it's >