RE: [PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc.

2020-09-14 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Better to split this into two patches: one for the dpm disablement skipping and another for gfxoff ctrl. Either way this patch is reviewed-by: Evan Quan -Original Message- From: Jiansong Chen Sent: Monday, September 14, 2020 4:10 PM

RE: [PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc.

2020-09-14 Thread Chen, Jiansong (Simon)
(Simon) Subject: RE: [PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc. [AMD Public Use] ret = smu_late_init(adev); + if (ret) + return ret; One counter leak happens? It needs to call amdgpu_gfx_off_ctrl(smu->adev, true) before returning? Rega

RE: [PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc.

2020-09-14 Thread Chen, Guchun
[AMD Public Use] ret = smu_late_init(adev); + if (ret) + return ret; One counter leak happens? It needs to call amdgpu_gfx_off_ctrl(smu->adev, true) before returning? Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Jiansong Chen Sent: Monday, Septembe

RE: [PATCH] drm/amd/pm: support runtime pptable update for sienna_cichlid etc.

2020-09-14 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kenneth Feng -Original Message- From: Jiansong Chen Sent: Monday, September 14, 2020 4:10 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Feng, Kenneth ; Quan, Evan ; Chen, Jiansong (Simon) Subject: [PATCH] drm/