Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-04 Thread Zhang, Jerry (Junwei)
On 06/05/2018 02:20 PM, Christian König wrote: Hi Jerry, Am 05.06.2018 um 03:50 schrieb Zhang, Jerry (Junwei): [SNIP] Can you check if the problem also vanishes when you disable the following optimization in amdgpu_vm_update_ptes? /* We don't need to update PTEs for huge page

Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-04 Thread Christian König
Hi Jerry, Am 05.06.2018 um 03:50 schrieb Zhang, Jerry (Junwei): [SNIP] Can you check if the problem also vanishes when you disable the following optimization in amdgpu_vm_update_ptes?     /* We don't need to update PTEs for huge pages */     if (entry->huge)

Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-04 Thread Zhang, Jerry (Junwei)
On 06/04/2018 07:01 PM, Christian König wrote: I've figured out what's going wrong here. Your analysis of the problem is correct, but the proposed fix just doesn't handle everything. The issue is that I assumed in the replace operation that the existing lose end of the mapping can stay as they

Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-04 Thread Zhang, Jerry (Junwei)
On 06/04/2018 05:51 PM, Christian König wrote: Am 04.06.2018 um 10:19 schrieb Zhang, Jerry (Junwei): On 06/04/2018 03:48 PM, Christian König wrote: Am 04.06.2018 um 09:02 schrieb Zhang, Jerry (Junwei): On 06/04/2018 02:43 PM, Christian König wrote: Actually that is not correct. According to t

Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-04 Thread Christian König
I've figured out what's going wrong here. Your analysis of the problem is correct, but the proposed fix just doesn't handle everything. The issue is that I assumed in the replace operation that the existing lose end of the mapping can stay as they are, but that assumption is actually not cor

Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-04 Thread Christian König
Am 04.06.2018 um 10:19 schrieb Zhang, Jerry (Junwei): On 06/04/2018 03:48 PM, Christian König wrote: Am 04.06.2018 um 09:02 schrieb Zhang, Jerry (Junwei): On 06/04/2018 02:43 PM, Christian König wrote: Actually that is not correct. According to the documentation the PRT flag should work for h

Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-04 Thread Zhang, Jerry (Junwei)
On 06/04/2018 03:48 PM, Christian König wrote: Am 04.06.2018 um 09:02 schrieb Zhang, Jerry (Junwei): On 06/04/2018 02:43 PM, Christian König wrote: Actually that is not correct. According to the documentation the PRT flag should work for huge pages as well. Mmm, I checked the doc earlier, did

Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-04 Thread Christian König
Am 04.06.2018 um 09:02 schrieb Zhang, Jerry (Junwei): On 06/04/2018 02:43 PM, Christian König wrote: Actually that is not correct. According to the documentation the PRT flag should work for huge pages as well. Mmm, I checked the doc earlier, didn't find the PRT flag for PDE. The PDE indeed

Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-04 Thread Zhang, Jerry (Junwei)
On 06/04/2018 02:43 PM, Christian König wrote: Actually that is not correct. According to the documentation the PRT flag should work for huge pages as well. Mmm, I checked the doc earlier, didn't find the PRT flag for PDE. In CTS PRT test, the reserved PRT mapping introduces huge page mapping,

Re: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-03 Thread Christian König
Actually that is not correct. According to the documentation the PRT flag should work for huge pages as well. Christian. Am 04.06.2018 um 07:59 schrieb Zhou, David(ChunMing): Good catch, Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freede

RE: [PATCH] drm/amdgpu: skip huge page for PRT mapping

2018-06-03 Thread Zhou, David(ChunMing)
Good catch, Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Junwei Zhang Sent: Monday, June 04, 2018 10:04 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH] drm/amdgpu: skip huge page for PRT m