Re: [apparmor] Cache update broken

2012-08-07 Thread Christian Boltz
Hello, (I've seen the updated patch and already submitted it to a test package in the OBS in home:cboltz - but I'll comment on this mail nevertheless. Most of the comments below should have a "SCNR" marker - don't take them too serious ;-) Am Dienstag, 7. August 2012 schrieb John Johansen: > O

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/07/2012 03:26 PM, Seth Arnold wrote: > Excellent, it feels much improved despite breaking Christian's Rules. :) > heh, well hopefully this version fixes that > Could you add another monkey test for --purge-cache? > sure > The short option -W leaked into the manpage update. > fixed, thank

Re: [apparmor] Cache update broken

2012-08-07 Thread Seth Arnold
Excellent, it feels much improved despite breaking Christian's Rules. :) Could you add another monkey test for --purge-cache? The short option -W leaked into the manpage update. Thanks John. -Original Message- From: John Johansen Sender: apparmor-boun...@lists.ubuntu.com Date: Tue, 07 A

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/04/2012 06:53 AM, Christian Boltz wrote: > Hello, > okay attached is v2 of the patch, its changes are: * makes cache clearing the default behavior if --write-cache is enabled * changes --no-clear-cache to --skip-bad-cache (really the same thing but hopefully a better name?) * adds a --pur

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/07/2012 01:34 PM, Christian Boltz wrote: > Hello, > > John, thanks for honoring the golden rules of bad programming in your > patch! I'm especially talking about rule 18 - "take great care in > setting bad defaults" ;-) > Hehe I did it on purpose to get a discussion of what it should be o

Re: [apparmor] Cache update broken

2012-08-07 Thread Christian Boltz
Hello, John, thanks for honoring the golden rules of bad programming in your patch! I'm especially talking about rule 18 - "take great care in setting bad defaults" ;-) Am Dienstag, 7. August 2012 schrieb Seth Arnold: > I expect --clear-cache-if-needed to be the default set in the config > file

Re: [apparmor] Cache update broken

2012-08-07 Thread Seth Arnold
Sorry for the rubbish bb quoting. I expect --clear-cache-if-needed to be the default set in the config file -- redundant for ubuntu but also a chance to bring both initscripts together again -- at least for this feature. A direct --clear-cache would just be a debugging tool for admins, and rare

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/07/2012 09:58 AM, Seth Arnold wrote: > The patch reads well, though the --help needs to indicate that the flag only > works if --write-cache is given _and_the features don't match. > > I would much rather --clear-cache be a debugging tool for sysadmin use that > immediately and directly cl

Re: [apparmor] Cache update broken

2012-08-07 Thread Seth Arnold
The patch reads well, though the --help needs to indicate that the flag only works if --write-cache is given _and_the features don't match. I would much rather --clear-cache be a debugging tool for sysadmin use that immediately and directly clears the cache, and introduce a different name for t

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/04/2012 06:53 AM, Christian Boltz wrote: > Hello, > > I received a bugreport that loading AppArmor needs 25 seconds at boot: > https://bugzilla.novell.com/show_bug.cgi?id=774529 > I can reproduce the problem on my system (AppArmor 2.8.0) > > It looks like the cache is not updated, and (