Re: [apparmor] GSoC review r35..39

2013-08-09 Thread Kshitij Gupta
Hello, Sorry, I was lost in deep thought about modes (read as: taking a nap ;) ) when you pinged me on IRC. Fixed all(most) of the problems stated in the reviews 32..39. I shamelessly made a few tiny pushes since you told me you extract out diff using a script and dont mind email spam ;) convert

Re: [apparmor] [PATCH v2] libapparmor: ENOENT should only signify label not found in label queries

2013-08-09 Thread Seth Arnold
On Fri, Aug 09, 2013 at 06:27:11PM -0700, Tyler Hicks wrote: > I thought about doing that, but obviously didn't. For no good reason > other than that I didn't put a lot of thought into those errno values > and didn't want to commit to them with documentation. ENOENT is really > the only one that I

Re: [apparmor] RFC: Patch [Bug 1207424] Re: mod_apparmor should let me use ServerName as default hat name

2013-08-09 Thread Seth Arnold
On Fri, Aug 09, 2013 at 05:13:10PM -0700, John Johansen wrote: > >> the hostname will be looked up and used. Obviously this patch isn't > >> complete, but its a first pass and I wanted feedback before I put any > >> more work into it. > right, the question now is do we want to support and ? I d

Re: [apparmor] [PATCH v2] libapparmor: ENOENT should only signify label not found in label queries

2013-08-09 Thread Tyler Hicks
On 2013-08-09 18:23:42, Seth Arnold wrote: > On Fri, Aug 09, 2013 at 12:11:02PM -0700, Tyler Hicks wrote: > > It may be useful to applications that do AppArmor queries to know if the > > subject label in the query is unknown to the kernel. For example, the > > corresponding profile may have been re

Re: [apparmor] [PATCH v2] libapparmor: ENOENT should only signify label not found in label queries

2013-08-09 Thread Seth Arnold
On Fri, Aug 09, 2013 at 12:11:02PM -0700, Tyler Hicks wrote: > It may be useful to applications that do AppArmor queries to know if the > subject label in the query is unknown to the kernel. For example, the > corresponding profile may have been removed/renamed. > > This patch eliminates all poten

[apparmor] GSoC review r35..39

2013-08-09 Thread Christian Boltz
Hallo, the reviews for r35..r39 are attached. I have no complaints about the revisions with even numbers ;-) Regards, Christian Boltz -- Aus der Beschreibung entnehme ich, daß deine Fonts nach Typ 3 konvertiert werden (Finger im Hals) und deine Bilder auf Screen- Qualität (Fuß zum Finger dazu

Re: [apparmor] [PATCH 2/2 v2] tests: Add regression tests for dbus

2013-08-09 Thread Seth Arnold
On Fri, Aug 02, 2013 at 03:29:52PM -0700, Tyler Hicks wrote: > Integrate dbus tests into the regression testing framework. > > This started out as dbus-send.c, from the dbus source, and then grew > from there. > > dbus_message is an example "client" program that only sends out > messages. dbus_se

Re: [apparmor] RFC: Patch [Bug 1207424] Re: mod_apparmor should let me use ServerName as default hat name

2013-08-09 Thread John Johansen
On 08/09/2013 05:03 PM, Seth Arnold wrote: > On Fri, Aug 02, 2013 at 01:41:37AM -0700, John Johansen wrote: >> This is a first pass at providing the feature requested in Bug 1207424 >> >> It leverages the appache config option >> >> AADefaultHatName >> >> and when its value is specified as >>

Re: [apparmor] [PATCH] required feature test for regression tests

2013-08-09 Thread Seth Arnold
On Fri, Aug 02, 2013 at 03:07:56AM -0700, John Johansen wrote: > This quick little patch adds the ability to specify the features required > for a test to run. This will help keep the regression suite from reporting > a lot of failures when it hits a kernel that doesn't support the feature > being

Re: [apparmor] RFC: Patch [Bug 1207424] Re: mod_apparmor should let me use ServerName as default hat name

2013-08-09 Thread Seth Arnold
On Fri, Aug 02, 2013 at 01:41:37AM -0700, John Johansen wrote: > This is a first pass at providing the feature requested in Bug 1207424 > > It leverages the appache config option > > AADefaultHatName > > and when its value is specified as > > > the hostname will be looked up and used. Obv

[apparmor] GSoC review r34

2013-08-09 Thread Christian Boltz
Hello, one more (quite harmless) review ;-) Regards, Christian Boltz -- [Windows krepiert nach Update] > Habt Ihr eine Idee, was ich tun könnte? Vermutlich ein Computervirus. Besorg etwas Aciclovir aus der Apotheke, oeffne das Rechnergehaeuse und troepfle das Mittel auf alle roten oder geschwo

[apparmor] GSoC review r33

2013-08-09 Thread Christian Boltz
Hello, the review for r33 is attached. The comments I initially had for r32 are included in r33 because you moved the convert_regexp function around ;-) Regards, Christian Boltz -- Zu meiner Entschuldigung: Ich konnte es nicht nochmal durchlesen, weil meine Kippenschachtel leer war und ich

Re: [apparmor] [PATCH 2/2] tests: Add regression tests for dbus

2013-08-09 Thread Tyler Hicks
On 2013-08-09 12:56:32, Seth Arnold wrote: > On Thu, Aug 01, 2013 at 02:01:39AM -0700, Tyler Hicks wrote: > > Integrate dbus tests into the regression testing framework. > > > > This started out as dbus-send.c, from the dbus source, and then grew > > from there. > > > > dbus_message is an example

Re: [apparmor] [PATCH 2/2] tests: Add regression tests for dbus

2013-08-09 Thread Seth Arnold
On Thu, Aug 01, 2013 at 02:01:39AM -0700, Tyler Hicks wrote: > Integrate dbus tests into the regression testing framework. > > This started out as dbus-send.c, from the dbus source, and then grew > from there. > > dbus_message is an example "client" program that only sends out > messages. dbus_se

Re: [apparmor] [PATCH 1/2] tests: Add an optional final check to checktestfg and checktestbg

2013-08-09 Thread Seth Arnold
On Thu, Aug 01, 2013 at 02:01:38AM -0700, Tyler Hicks wrote: > Allows for the test script to specify a final check to be performed > after checking the output of the test binary. This may be useful, for > example, if the test script wants to compare logging output of the test > binary to known-good

[apparmor] [PATCH v2] libapparmor: ENOENT should only signify label not found in label queries

2013-08-09 Thread Tyler Hicks
It may be useful to applications that do AppArmor queries to know if the subject label in the query is unknown to the kernel. For example, the corresponding profile may have been removed/renamed. This patch eliminates all potential return locations of aa_query_label() that may have errno set to EN