Re: [apparmor] GSoC review r48..51

2013-08-22 Thread Steve Beattie
On Thu, Aug 22, 2013 at 01:43:46PM -0700, Tyler Hicks wrote: > On 2013-08-22 22:19:59, Christian Boltz wrote: > > aa-genprof.py has: > > > > if os.path.exists('/var/log/audit/audit.log'): > > syslog = False > > > > I'm not sure if "audit.log exists" is the best way to choose the logfi

Re: [apparmor] GSoC review r48..51

2013-08-22 Thread Tyler Hicks
On 2013-08-22 22:19:59, Christian Boltz wrote: > Hello, > > the review for r48, 49, 50 and 51 is attached. > > Of course feedback to all the code is always welcome (I don't have a > monopoly on reviewing GSoC code ;-) but there's a detail I'd like to > discuss: > > aa-genprof.py has: > >

Re: [apparmor] GSoC review r48..51

2013-08-22 Thread Christian Boltz
Hello, Am Donnerstag, 22. August 2013 schrieb Christian Boltz: > the review for r48, 49, 50 and 51 is attached. ... or not :-/ Let me try a second time ;-) Regards, Christian Boltz -- # GO AWAY ! # YOU DO NOT WANT TO SEE THIS SCRIPT !!! [from /opt/kde3/share/apps/krpmview/setup_temp_source]

[apparmor] GSoC review r48..51

2013-08-22 Thread Christian Boltz
Hello, the review for r48, 49, 50 and 51 is attached. Of course feedback to all the code is always welcome (I don't have a monopoly on reviewing GSoC code ;-) but there's a detail I'd like to discuss: aa-genprof.py has: if os.path.exists('/var/log/audit/audit.log'): syslog = False