I've made all of the changes.
I'll let it percolate over the next 24 hours (or so) and then integrate
it into trunk.
- Joakim
Brett Porter wrote:
- I think it can use more tests
Agreed. Have any special use cases you want fleshed out?
Nah, just coverage for the other classes.
Will do.
- what about passing referenceFile as a final field, since every
method uses it?
I started ChecksumFile as a utility class,
On 12/04/2008, at 12:36 PM, Joakim Erdfelt wrote:
Brett Porter wrote:
Looks good to me. I say roll it into trunk.
A couple of uncertainties:
- isn't doFinal required?
doFinal ?
sorry, got confused with JCE :) it's digest() in MessageDigest, which
is there.
- I think it can use mor
Brett Porter wrote:
Looks good to me. I say roll it into trunk.
A couple of uncertainties:
- isn't doFinal required?
doFinal ?
- I think it can use more tests
Agreed. Have any special use cases you want fleshed out?
Here's some nitpicking that might reduce the amount of code and make
Looks good to me. I say roll it into trunk.
A couple of uncertainties:
- isn't doFinal required?
- I think it can use more tests
Here's some nitpicking that might reduce the amount of code and make
it clearer:
- rename Hash to ChecksumAlgorithm (might as well be consistent and
use checksum
Not sure I understand what you are asking. :-(
There was a suggestion in the #archiva irc channel that we should offer
the code in archiva-checksum to the commons-codec project. An idea I
fully support, but have no idea how to proceed with. ;-)
Also, Brett asked a passing question about how
Joakim,
Is this based on any work from commons or have you implemented this
stuff from whats provided in the JDK?
James
On Tue, 2008-04-08 at 21:54 -0700, Joakim Erdfelt wrote:
> Joakim Erdfelt wrote:
> > I've been taking a stab and removing some of our dependencies on
> > various plexus compone
Joakim Erdfelt wrote:
I've been taking a stab and removing some of our dependencies on
various plexus components.
First up, plexus-digest.
I've taken the varied code from many locations and come up with a
stand alone archiva-checksum lib/component that I hope to be able to
integrate into arc
I've been taking a stab and removing some of our dependencies on various
plexus components.
First up, plexus-digest.
I've taken the varied code from many locations and come up with a stand
alone archiva-checksum lib/component that I hope to be able to integrate
into archiva/trunk.
So ... uh
