Re: [asterisk-dev] Guidance required

2013-12-05 Thread xytis2000
Hi Matthew, Thanks for Your response. On 05 Dec 2013, at 19:56, Matthew Jordan wrote: > > On Thu, Dec 5, 2013 at 6:14 AM, Vytis Valentinavičius > wrote: > Hello, > > I am trying to resolve asterisk bug > https://issues.asterisk.org/jira/browse/ASTERISK-22911, but I have some > questions r

Re: [asterisk-dev] [Code Review] 3041: app_record: Add an option that allows DTMF '0' to act as an additional terminator

2013-12-05 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3041/ --- (Updated Dec. 5, 2013, 5:40 p.m.) Status -- This change has been mark

[asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-05 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/ --- Review request for Asterisk Developers, Mark Michelson, opticron, and rmudge

[asterisk-dev] [Code Review] 3052: ARI: Allow specifying channel variables during a POST /channels

2013-12-05 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3052/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22872 https://i

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/ --- (Updated Dec. 5, 2013, 3:21 p.m.) Review request for Asterisk Developers.

[asterisk-dev] Presence State in Asterisk 11

2013-12-05 Thread Jason Parker
Presence State is a feature that was added in Asterisk 11, which allows for more information to be captured about the state of a user. There appears to have been a rather large oversight in the implementation. There is currently no way to monitor the changes to this information, meaning that

Re: [asterisk-dev] [Code Review] 3039: Add manager event for presence state changes

2013-12-05 Thread Jason Parker
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3039/ --- (Updated Dec. 5, 2013, 3:30 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3018: testsuite: Add tests for Say application jump behavior with SAY_DTMF_INTERRUPT enabled and disabled

2013-12-05 Thread Jonathan Rose
> On Dec. 5, 2013, 9:13 p.m., opticron wrote: > > /asterisk/trunk/tests/apps/say_interrupt/configs/ast1/extensions.conf, > > lines 20-25 > > > > > > These could use Hangup()s. k, done. - Jonathan --

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-05 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/#review10315 --- branches/12/main/config.c

Re: [asterisk-dev] [Code Review] 3018: testsuite: Add tests for Say application jump behavior with SAY_DTMF_INTERRUPT enabled and disabled

2013-12-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3018/#review10316 --- /asterisk/trunk/tests/apps/say_interrupt/configs/ast1/extensio

Re: [asterisk-dev] [Code Review] 3022: res_pjsip: Respect outbound proxy in more places

2013-12-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3022/#review10311 --- /branches/12/res/res_pjsip/location.c

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-05 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/#review10313 --- branches/12/res/res_pjsip/pjsip_configuration.c

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-05 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2944/ --- (Updated Dec. 5, 2013, 2:26 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-05 Thread Kevin Harwell
> On Dec. 5, 2013, 6:56 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_messaging.c, lines 155-156 > > > > > > I don't like this. Falling back to the default outbound endpoint if the > > specified one could

[asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2013-12-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3050/ --- Review request for Asterisk Developers. Bugs: ASTERISK-21084 https://i

[asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2013-12-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3051/ --- Review request for Asterisk Developers. Bugs: ASTERISK-21084 https://i

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/ --- (Updated Dec. 5, 2013, 11:27 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3042: chan_pjsip: Fixup function is blocking when attempting to push a synchronous task which can lead to a stuck channel container lock.

2013-12-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3042/#review10310 --- Ship it! Code-wise this is what I'd expect and will do as adve

Re: [asterisk-dev] [Code Review] 3042: chan_pjsip: Fixup function is blocking when attempting to push a synchronous task which can lead to a stuck channel container lock.

2013-12-05 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3042/ --- (Updated Dec. 5, 2013, 6:14 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-05 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/#review10308 --- branches/12/include/asterisk/res_pjsip.h

Re: [asterisk-dev] Guidance required

2013-12-05 Thread Matthew Jordan
On Thu, Dec 5, 2013 at 6:14 AM, Vytis Valentinavičius wrote: > Hello, > > I am trying to resolve asterisk bug > https://issues.asterisk.org/jira/browse/ASTERISK-22911, but I have some > questions regarding existing code: > > [ I am working on 11.5.1 version ] > Hey Vytis - For the patch that you

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-05 Thread Joshua Colp
> On Dec. 5, 2013, 12:56 p.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_messaging.c, lines 155-156 > > > > > > I don't like this. Falling back to the default outbound endpoint if the > > specified one could

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-05 Thread Kevin Harwell
> On Dec. 5, 2013, 6:56 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_messaging.c, lines 155-156 > > > > > > I don't like this. Falling back to the default outbound endpoint if the > > specified one could

[asterisk-dev] [Code Review] 3048: PJSIP: Add T.38 fax tests

2013-12-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3048/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

[asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3046/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] Asterisk 12 production release ...

2013-12-05 Thread bala murugan
Hi , I see asterisk 12 is in beta release , any idea when is the production release officially expected ... thanks, -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSU

Re: [asterisk-dev] [Code Review] 3044: Switch PJSIP auth to use a vector

2013-12-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3044/#review10306 --- Ship it! Ship It! - Joshua Colp On Dec. 4, 2013, 10 p.m., M

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

2013-12-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3035/#review10305 --- /branches/12/funcs/func_pjsip_endpoint.c

Re: [asterisk-dev] [Code Review] 3042: chan_pjsip: Fixup function is blocking when attempting to push a synchronous task which can lead to a stuck channel container lock.

2013-12-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3042/#review10304 --- /trunk/channels/chan_pjsip.c

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2944/#review10303 --- branches/12/configs/pjsip.conf.sample

[asterisk-dev] Guidance required

2013-12-05 Thread Vytis Valentinavičius
Hello, I am trying to resolve asterisk bug https://issues.asterisk.org/jira/browse/ASTERISK-22911, but I have some questions regarding existing code: [ I am working on 11.5.1 version ] Currently ICE session is initialised on first SDP INVITE, during initialisation it pairs received remote candid