Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

> On Dec. 9, 2013, 8:02 p.m., Mark Michelson wrote: > > The loop situation Matt described is possible. > > > > When ast_channel_suppress() is called, it results in AST_FRAME_VOICE being > > turned into AST_FRAME_NULL. > > If there is a jitter buffer on a channel, then AST_FRAME_NULL gets turned

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

> On Dec. 9, 2013, 8:02 p.m., Mark Michelson wrote: > > The loop situation Matt described is possible. > > > > When ast_channel_suppress() is called, it results in AST_FRAME_VOICE being > > turned into AST_FRAME_NULL. > > If there is a jitter buffer on a channel, then AST_FRAME_NULL gets turned

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3035/#review10349 --- Ship it! Ship It! - Joshua Colp On Dec. 10, 2013, 2:34 a.m.

Re: [asterisk-dev] [Code Review] 3039: Add manager event for presence state changes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3039/#review10350 --- Ship it! Ship It! - Joshua Colp On Dec. 5, 2013, 9:30 p.m.,

[asterisk-dev] Fwd: [svn-commits] jrose: trunk r403588 - in /trunk: ./ channels/chan_pjsip.c

I'm not sure this should have been committed. I hadn't seen that this had already been put up for review, otherwise I would have commented on the review - however, I did note the following on the issue: You can't delay a masquerade. Failing to complete the fix up here will result in a masqueraded

Re: [asterisk-dev] Fwd: [svn-commits] jrose: trunk r403588 - in /trunk: ./ channels/chan_pjsip.c

Matthew Jordan wrote: I'm not sure this should have been committed. I hadn't seen that this had already been put up for review, otherwise I would have commented on the review - however, I did note the following on the issue: You can't delay a masquerade. Failing to complete the fix up here will

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/#review10351 --- /trunk/res/res_sorcery_astdb.c

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3057/#review10352 --- /branches/12/apps/app_cdr.c

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

> On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote: > > /branches/12/channels/pjsip/dialplan_functions.c, lines 316-327 > > > > > > These descriptions are inaccurate when used on outgoing channels. > > Matt Jordan

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

> On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote: > > /branches/12/channels/pjsip/dialplan_functions.c, lines 338-345 > > > > > > These descriptions are inaccurate when used on outbound channels. > > Matt Jordan

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

> On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote: > > /branches/12/channels/pjsip/dialplan_functions.c, lines 316-327 > > > > > > These descriptions are inaccurate when used on outgoing channels. > > Matt Jordan

[asterisk-dev] Asterisk 11 from Ubuntu Repos

Is it possible to install Asterisk 11 via the Ubuntu 12.04 repos? Is a PPA needed? If so, which one is recommended? TIA, -Pablo vDevices.com | Providing Hosted IT Solutions for Lawyers & Other Mobile Professionals -- ___

[asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3063/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

> On Dec. 10, 2013, 2:37 p.m., Joshua Colp wrote: > > /branches/12/apps/app_cdr.c, line 187 > > > > > > I think using a message router here is overkill. You already do a check > > in your callback for whether it is

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3057/ --- (Updated Dec. 10, 2013, 4:48 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3052: ARI: Allow specifying channel variables during a POST /channels

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3052/ --- (Updated Dec. 10, 2013, 10:51 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3052: ARI: Allow specifying channel variables during a POST /channels

> On Dec. 10, 2013, 4:10 a.m., Matt Jordan wrote: > > branches/12/main/http.c, lines 630-632 > > > > > > Check for memory allocation failure of type here. > > > > What happens here if v->value is NULL? Mat

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/#review10358 --- I fundamentally disagree with a design decision made in this pa

Re: [asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3063/#review10359 --- I don't think changing this default is a good idea. Enabling i

Re: [asterisk-dev] [Code Review] 3052: ARI: Allow specifying channel variables during a POST /channels

> On Dec. 9, 2013, 10:10 p.m., Matt Jordan wrote: > > branches/12/main/http.c, lines 630-632 > > > > > > Check for memory allocation failure of type here. > > > > What happens here if v->value is NULL? > >

Re: [asterisk-dev] [Code Review] 3052: ARI: Allow specifying channel variables during a POST /channels

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3052/ --- (Updated Dec. 10, 2013, 11:25 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

> On Dec. 10, 2013, 5:14 p.m., rmudgett wrote: > > I don't think changing this default is a good idea. Enabling it is only > > useful if you are using the relative channel format. I have yet to see > > anyone on the Asterisk users list actually use this format. ignore_failed_channels was ind

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

> On Dec. 10, 2013, 5:01 p.m., Matt Jordan wrote: > > I fundamentally disagree with a design decision made in this patch. > > > > The concept of a 'context' is an Asterisk thing - specifically, a concept > > that is derived from static .conf files. It has no semantic meaning outside > > of Ast

Re: [asterisk-dev] [Code Review] 3027: Valgrind support in TestSuite

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3027/ --- (Updated Dec. 10, 2013, 11:51 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3027: Valgrind support in TestSuite

> On Nov. 27, 2013, 11:37 a.m., Matt Jordan wrote: > > /asterisk/team/sgriepentrog/testsuite-valgrind/runtests.py, lines 84-93 > > > > > > It's very strange for us to call __parse_run_output twice here. We > > shoul

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

> On Dec. 10, 2013, 5:01 p.m., Matt Jordan wrote: > > I fundamentally disagree with a design decision made in this patch. > > > > The concept of a 'context' is an Asterisk thing - specifically, a concept > > that is derived from static .conf files. It has no semantic meaning outside > > of Ast

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

> On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote: > > /branches/12/channels/pjsip/dialplan_functions.c, lines 316-327 > > > > > > These descriptions are inaccurate when used on outgoing channels. > > Matt Jordan

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3038/#review10365 --- /branches/12/channels/pjsip/dialplan_functions.c

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3038/#review10366 --- Ship it! Heh, looking at the paltry feedback I just provided,

Re: [asterisk-dev] [Code Review] 3060: pjsip tests: interactions with chan_sip cause test failures

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3060/#review10367 --- Ship it! Ship It! - Mark Michelson On Dec. 9, 2013, 10:52 p

Re: [asterisk-dev] [Code Review] 3060: pjsip tests: interactions with chan_sip cause test failures

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3060/#review10368 --- asterisk/trunk/configs/modules.conf

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

> On Dec. 10, 2013, 6:51 p.m., Mark Michelson wrote: > > /branches/12/channels/pjsip/dialplan_functions.c, lines 650-652 > > > > > > It may just be reviewboard, but the second and third lines of this are > > indent

Re: [asterisk-dev] [Code Review] 3055: pbx.c: put copy of ast_exten.data on stack to prevent memory corruption

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/ --- (Updated Dec. 10, 2013, 1:39 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3055: pbx.c: put copy of ast_exten.data on stack to prevent memory corruption

> On Dec. 7, 2013, 9:48 a.m., Matt Jordan wrote: > > /branches/1.8/main/pbx.c, lines 4477-4491 > > > > > > I don't think we need the extra lock here. > > > > The purpose of the contexts lock is to prevent

Re: [asterisk-dev] [Code Review] 3056: testsuite: dialplan stress test to find memory allocation problems (valgrind)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3056/ --- (Updated Dec. 10, 2013, 1:41 p.m.) Review request for Asterisk Developers

[asterisk-dev] [BOUNTY] ASTERISK-19454: outbound proxy not being cleared

We'd like to have bug ASTERISK-19454 (https://issues.asterisk.org/jira/browse/ASTERISK-19454) fixed and are offering a $500 bounty for this. Please email me if you are interested. -H-- _ -- Bandwidth and Colocation Provided by

Re: [asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3063/#review10372 --- Ship it! Ship It! - rmeyerriecks On Dec. 10, 2013, 4:25 p.m

Re: [asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

> On Dec. 10, 2013, 8:46 p.m., rmeyerriecks wrote: > > Ship It! After talking with rmudgett about this, I feel pretty confident that the risks would be low. From what I understand, in order to get Asterisk to generate invalid channels you would need to have multiple cards/devices and either c

Re: [asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3063/#review10374 --- Ship it! Please add a note about this default change in the UP

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3035/#review10375 --- Ship it! /branches/12/funcs/func_pjsip_endpoint.c

Re: [asterisk-dev] [Code Review] 3034: Tests for PJSIP_ENDPOINT

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3034/#review10376 --- Ship it! Ship It! - Mark Michelson On Nov. 28, 2013, 4:31 a

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

> On Dec. 10, 2013, 9:59 p.m., Mark Michelson wrote: > > /branches/12/funcs/func_pjsip_endpoint.c, lines 126-130 > > > > > > Just curious, but why does "disallow" get this special treatment? ast_getformatname_multi

[asterisk-dev] [Code Review] 3064: realtime: Create extensions in alembic ast-db-manage contribution

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3064/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22815 https://i

Re: [asterisk-dev] [Code Review] 3055: pbx.c: put copy of ast_exten.data on stack to prevent memory corruption

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/#review10378 --- /branches/1.8/main/pbx.c