[asterisk-dev] dahdi firmwares in /usr/lib/hotplug/firmware

2013-12-12 Thread Tzafrir Cohen
Hi Currently dahdi-linux's install target installs firmware files to two locations. One is /lib/firmware and the other is /usr/lib/hotplug/fimware . /lib/firmware is nowadays the standard location for firmware files. Is there any distribution still supported by DAHDI that loads firmware files

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/#review10390 --- For the most part, this looks good to go.

Re: [asterisk-dev] [Code Review] 3018: testsuite: Add tests for Say application jump behavior with SAY_DTMF_INTERRUPT enabled and disabled

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3018/#review10391 --- Ship it! Ship It! - opticron On Dec. 2, 2013, 11:10 a.m.,

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/#review10392 --- branches/12/bridges/bridge_native_rtp.c

Re: [asterisk-dev] [Code Review] 3054: ARI: Add call forwarding events and automatically follow new channel

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3054/#review10393 --- Ship it! /branches/12/main/stasis_channels.c

[asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-12 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3057/#review10394 --- /branches/12/apps/app_cdr.c

[asterisk-dev] [Code Review] 3068: ARI: provide a default format capability to channels that are created

2013-12-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3068/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22962

Re: [asterisk-dev] [Code Review] 3022: res_pjsip: Respect outbound proxy in more places

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3022/#review10395 --- Ship it! Ship It! - opticron On Dec. 7, 2013, 5:38 p.m.,

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread Matt Jordan
On Dec. 12, 2013, 11:48 a.m., opticron wrote: /branches/12/funcs/func_cdr.c, lines 472-474 https://reviewboard.asterisk.org/r/3057/diff/2/?file=49301#file49301line472 Return and reduce indentation. Normally I'd agree, but that approach has one drawback here. Providing block scope

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3057/ --- (Updated Dec. 12, 2013, 12:03 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3052: ARI: Allow specifying channel variables during a POST /channels

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3052/#review10396 --- branches/12/main/http.c

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-12-12 Thread Kevin Harwell
On Dec. 12, 2013, 9:16 a.m., Kevin Harwell wrote: There are other places as well where functions or parameters should return the enum instead of a bare int. After speaking with opticron it was decided that for now the items mentioned should remain ints and not be changed to an enumeration

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-12 Thread Kevin Harwell
On Dec. 12, 2013, 9:58 a.m., opticron wrote: branches/12/bridges/bridge_native_rtp.c, lines 114-122 https://reviewboard.asterisk.org/r/3066/diff/1/?file=49482#file49482line114 This doxygen should get a retval section as well (probably my fault). The return value for this function

Re: [asterisk-dev] [Code Review] 3027: Valgrind support in TestSuite

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3027/#review10399 --- /asterisk/trunk/README.txt

Re: [asterisk-dev] [Code Review] 3027: Valgrind support in TestSuite

2013-12-12 Thread Scott Griepentrog
On Dec. 12, 2013, 12:56 p.m., opticron wrote: /asterisk/trunk/runtests.py, lines 69-73 https://reviewboard.asterisk.org/r/3027/diff/3/?file=49321#file49321line69 It would be a bit cleaner to use the glob module to get a list of matching paths and then get the length of the list.

[asterisk-dev] balancing irqs

2013-12-12 Thread jg
Hi! It looks as if this is the most appropriate group for my posting. I patched irqbalance such that it no longer depends on certain symbolic links within the sysfs virtual file system. In order to get the node associations of the cpus I do an extra evaluation of the nodes subdir. This patch

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/#review10402 --- Ship it! Ship It! - opticron On Nov. 21, 2013, 2:24 p.m.,

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread opticron
On Dec. 12, 2013, 11:48 a.m., opticron wrote: /branches/12/funcs/func_cdr.c, lines 472-474 https://reviewboard.asterisk.org/r/3057/diff/2/?file=49301#file49301line472 Return and reduce indentation. Matt Jordan wrote: Normally I'd agree, but that approach has one drawback

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread Matt Jordan
On Dec. 12, 2013, 11:48 a.m., opticron wrote: /branches/12/funcs/func_cdr.c, lines 472-474 https://reviewboard.asterisk.org/r/3057/diff/2/?file=49301#file49301line472 Return and reduce indentation. Matt Jordan wrote: Normally I'd agree, but that approach has one drawback

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread Matt Jordan
On Dec. 12, 2013, 11:48 a.m., opticron wrote: /branches/12/funcs/func_cdr.c, lines 472-474 https://reviewboard.asterisk.org/r/3057/diff/2/?file=49301#file49301line472 Return and reduce indentation. Matt Jordan wrote: Normally I'd agree, but that approach has one drawback

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-12 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/ --- (Updated Dec. 12, 2013, 3:03 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/#review10407 --- Ship it! Looks good other than the documentation tweak below.

[asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/ --- Review request for Asterisk Developers, Joshua Colp, Jonathan Rose, Matt

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/#review10408 --- Josh and I talked on IRC, and it would really be great if the

Re: [asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

2013-12-12 Thread rmudgett
On Dec. 10, 2013, 5:14 p.m., rmudgett wrote: I don't think changing this default is a good idea. Enabling it is only useful if you are using the relative channel format. I have yet to see anyone on the Asterisk users list actually use this format. Tzafrir Cohen wrote:

Re: [asterisk-dev] CDR bug in 1.8, 10 and 11 - Comments on patch please

2013-12-12 Thread Matthew Jordan
On Mon, Dec 9, 2013 at 9:58 AM, Steve Davies davies...@gmail.com wrote: I believe there is a regression in the CDR code since 1.8.11. It also affects versions 10 and 11, but probably not version 12. https://issues.asterisk.org/jira/browse/ASTERISK-22954 After a SIP attended transfer, the