Re: [asterisk-dev] Asterisk Media Performance

2014-01-07 Thread Olle E. Johansson
Josh, Thank you for starting to work on this. It's something very important for me. I build platforms where many Asterisk servers handle the same call and we're hunting all latency we can. I have no intelligent comments on your work, more than what you write seems correct - we should only do

[asterisk-dev] ny Help ?every time AST_FRAME_DTMF_END .Asterisk-11.5.1 confbridge

2014-01-07 Thread hardik
http://forums.asterisk.org/viewtopic.php?f=1t=88967 http://stackoverflow.com/questions/20966934/any-help-every-time-ast-frame-dtmf-end- asterisk-11-5-1-app-confbridge-c In Asterisk11.5.1/funcs/func_frame_trace.c it works fine, but in my code issue : frame-frametype . BEGIN and END are not

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-07 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review10519 --- Please also check the sender IP address in the IP packet.

[asterisk-dev] Modifying Asterisk sRTP

2014-01-07 Thread Dylan Herman
Hello, I have a question regarding sRTP with Asterisk. I posted this question on the Asterisk wiki and was suggested to post it on the Developer mailing list. I am working on an encryption project. The project consists of using my own encryption method to encrypt SIP phone calls using an

Re: [asterisk-dev] Modifying Asterisk sRTP

2014-01-07 Thread Olle E. Johansson
On 07 Jan 2014, at 15:12, Dylan Herman herma...@pascack.k12.nj.us wrote: Hello, I have a question regarding sRTP with Asterisk. I posted this question on the Asterisk wiki and was suggested to post it on the Developer mailing list. I am working on an encryption project. The project

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Olle E. Johansson
On 07 Jan 2014, at 15:55, SVN commits to the Digium repositories svn-comm...@lists.digium.com wrote: if (endpoint-nat.rewrite_contact (contact = pjsip_msg_find_hdr(rdata-msg_info.msg, PJSIP_H_CONTACT, NULL)) - (PJSIP_URI_SCHEME_IS_SIP(contact-uri) ||

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Joshua Colp
Olle E. Johansson wrote: On 07 Jan 2014, at 15:55, SVN commits to the Digium repositoriessvn-comm...@lists.digium.com wrote: if (endpoint-nat.rewrite_contact (contact = pjsip_msg_find_hdr(rdata-msg_info.msg, PJSIP_H_CONTACT, NULL)) - (PJSIP_URI_SCHEME_IS_SIP(contact-uri) ||

Re: [asterisk-dev] [Code Review] 3106: res_pjsip_session: If a reinvite without an SDP is received, unhold the call.

2014-01-07 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3106/#review10520 --- Ship it! I think this unconditional behavior is fine since

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Matthew Jordan
On Tue, Jan 7, 2014 at 9:27 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: On 07 Jan 2014, at 15:55, SVN commits to the Digium repositoriessvn-comm...@lists.digium.com wrote: if (endpoint-nat.rewrite_contact (contact = pjsip_msg_find_hdr(rdata-msg_info.msg,

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Daniel Jenkins
On Tue, Jan 7, 2014 at 5:03 PM, Matthew Jordan mjor...@digium.com wrote: On Tue, Jan 7, 2014 at 9:27 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: On 07 Jan 2014, at 15:55, SVN commits to the Digium repositoriessvn-comm...@lists.digium.com wrote: if

[asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-07 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22834 and

[asterisk-dev] [Code Review] 3108: confbridge: Prevent race condition leading to crash in state transitions during bridge announcement in MULTI_MARKED state

2014-01-07 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3108/ --- Review request for Asterisk Developers. Bugs: AST-1258

[asterisk-dev] [Code Review] 3109: chan_sip: Local From tag regression fixed by eliminating dialog after 200 OK

2014-01-07 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3109/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22946

[asterisk-dev] [Code Review] 3110: live_ast: run wrapped programs with exec

2014-01-07 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3110/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Paul Belanger
On 14-01-07 10:10 AM, Olle E. Johansson wrote: On 07 Jan 2014, at 15:55, SVN commits to the Digium repositories svn-comm...@lists.digium.com wrote: if (endpoint-nat.rewrite_contact (contact = pjsip_msg_find_hdr(rdata-msg_info.msg, PJSIP_H_CONTACT, NULL)) -

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Joshua Colp
Paul Belanger wrote: IMO, these are also perfect candidates for parsing unit tests. It would have been great to also see us add something to better increase out code coverage. PJSIP has unit tests already which covers the URI parser. I just did a rough count and there's 39 different ones.

Re: [asterisk-dev] [Code Review] 3110: live_ast: run wrapped programs with exec

2014-01-07 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3110/#review10521 --- Ship it! Ship It! - wdoekes On Jan. 7, 2014, 7:28 p.m.,

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-07 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/#review10522 --- The patch is mostly good. One thing that should be done though

Re: [asterisk-dev] [Code Review] 3105: Testsuite: Test PJSIP hold and unhold for various conditions for INVITE SDPs

2014-01-07 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3105/#review10523 --- Ship it! Your findings regarding the to-tag with chan_sip.c

Re: [asterisk-dev] [Code Review] 3109: chan_sip: Local From tag regression fixed by eliminating dialog after 200 OK

2014-01-07 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3109/#review10524 --- I'm curious, has the reporter of ASTERISK-22946 confirmed that

Re: [asterisk-dev] [Code Review] 3108: confbridge: Prevent race condition leading to crash in state transitions during bridge announcement in MULTI_MARKED state

2014-01-07 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3108/#review10525 --- Ship it! Ship It! - Mark Michelson On Jan. 7, 2014, 6:33

Re: [asterisk-dev] Modifying Asterisk sRTP

2014-01-07 Thread Dylan Herman
Thank you for responding. I already have the libsrtp on my system, I believe, since I have the same files that were on the libsrtp github. Are you saying that I could just write my code in one of the scripts with the encryption algorithms leaving it under its original name of the algorithm?

Re: [asterisk-dev] Modifying Asterisk sRTP

2014-01-07 Thread Olle E. Johansson
8 jan 2014 kl. 01:24 skrev Dylan Herman herma...@pascack.k12.nj.us: Thank you for responding. I already have the libsrtp on my system, I believe, since I have the same files that were on the libsrtp github. Are you saying that I could just write my code in one of the scripts with the