[asterisk-dev] Fax with Asterisk internal flow (conversion)

2014-01-09 Thread Chandramouli P
Hi, I have some basis queries about the internal flow (conversion) and architecture of FoIP. Please note that I have done enough research on Internet to clarify my queries. But, I didn't get proper information. I thought of sending you guys an email to clarify my queries: I want to implement

Re: [asterisk-dev] ARI leaking memory?

2014-01-09 Thread Joshua Colp
Watson, Kenneth wrote: Hi, Greetings, What we're interested in finding out at the moment is, is this a known issue (nothing like this on the issue tracker at the moment), and is this perhaps considered an "acceptable" leak at the moment, considering the apparent slow speed at which it allocat

[asterisk-dev] Regd: Posting of Vacancy for Asterisk Developer on mailing list.

2014-01-09 Thread Nishant Kundalia
We require Asterisk Developers with 2 yrs of experience in Asterisk development in our Ahmedabad and Mumbai Office Regards, Nishant Kundalia | Senior Technical Recruiter|HR | Off: +91 22- 4055 3013 | nisha...@interactcrm.com|

Re: [asterisk-dev] ARI leaking memory?

2014-01-09 Thread Watson, Kenneth
> Thank you for bringing this up! This wasn't a known reported bug but I've > tracked down what is happening and filed an issue so now it has magically > become one. > > You can track progress here: > https://issues.asterisk.org/jira/browse/ASTERISK-23128 Fantastic, thanks! - Ken On 09/01/2

[asterisk-dev] [Code Review] 3112: wideband streaming with res_musiconhold

2014-01-09 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3112/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] Regd: Posting of Vacancy for Asterisk Developer on mailing list.

2014-01-09 Thread David Duffett
Please keep this kind of post to the asterisk-biz list, which is the right list for recruitment, contact offers, etc. On 9 January 2014 12:19, Nishant Kundalia wrote: > We require Asterisk Developers with 2 yrs of experience in Asterisk > development in our Ahmedabad and Mumbai Office > > > >

Re: [asterisk-dev] Fax with Asterisk internal flow (conversion)

2014-01-09 Thread Scott Griepentrog
To add some details to your call flow for clarity, I would write it as: Sending FAX machine (T.30) ==POTS==> Local CO ==PRI/G711/T.30==> (PSTN) ==> VoIP Gateway with T.38 support ==IP/SIP/RTP/T.38==> (INTERNET) ==> Asterisk (with T.38 capable fax modem software) => .TIFF file I'm using ==protocol

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
> On Jan. 8, 2014, 1:56 p.m., opticron wrote: > > /branches/12/main/stasis.c, line 593 > > > > > > When synchronous dispatch is required, why not just dispatch directly > > as if there were no mailbox? It's a good

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/ --- (Updated Jan. 9, 2014, 9:16 a.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3089: Presenting AO2_ITERATOR_SAFE_LOOP_START() for ao2_iterator looping safety.

2014-01-09 Thread Matt Jordan
> On Jan. 3, 2014, 11:12 a.m., Mark Michelson wrote: > > So...I just don't really like this. > > > > 1) Making a macro like this makes the code more esoteric than it previously > > was. > > 2) The fact that the loop_obj has to be NULLed out before breaking or > > returning from the loop if no

[asterisk-dev] [Code Review] 3113: PJSIP: Print "" instead of a UUID for artificial PJSIP endpoints' account IDs in security events

2014-01-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3113/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2014-01-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3050/#review10533 --- /trunk/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 3113: PJSIP: Print "" instead of a UUID for artificial PJSIP endpoints' account IDs in security events

2014-01-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3113/#review10535 --- Ship it! I'd be down with this in 12, makes it more clearer.

Re: [asterisk-dev] [Code Review] 3108: confbridge: Prevent race condition leading to crash in state transitions during bridge announcement in MULTI_MARKED state

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3108/ --- (Updated Jan. 9, 2014, 4:40 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3112: wideband streaming with res_musiconhold

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3112/#review10534 --- Ship it! Might want to make a note in the CHANGES file that Mo

Re: [asterisk-dev] [Code Review] 3091: Add SHA-256 and MD5 checksums to releases

2014-01-09 Thread Ben Langfeld
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3091/ --- (Updated Jan. 9, 2014, 11:08 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3109: chan_sip: Local From tag regression fixed by eliminating dialog after 200 OK

2014-01-09 Thread Scott Griepentrog
> On Jan. 7, 2014, 6:19 p.m., Mark Michelson wrote: > > I'm curious, has the reporter of ASTERISK-22946 confirmed that this patch > > fixes his issue? While this may be fixing the issue of ambiguous sip_pvts > > during quick re-registrations, I don't think that this is actually what is > > hap

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2014-01-09 Thread opticron
> On Jan. 9, 2014, 10:36 a.m., Joshua Colp wrote: > > /trunk/res/res_pjsip_path.c, lines 158-167 > > > > > > Is there any reason you did this instead of calling > > ast_sip_set_outbound_proxy? > > > > Doin

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2014-01-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3050/ --- (Updated Jan. 9, 2014, 11:33 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2014-01-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3050/ --- (Updated Jan. 9, 2014, 11:34 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review10540 --- /branches/12/res/res_pjsip_multihomed.c

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-09 Thread Matt Jordan
> On Jan. 7, 2014, 3:29 a.m., Olle E Johansson wrote: > > Please also check the sender IP address in the IP packet. That's where > > things go wrong with chan_sip. Thanks. Olle - just so I understand your comment, are you referring to what would happen if the sender was behind a NAT? - Matt

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-09 Thread Joshua Colp
> On Jan. 9, 2014, 7:19 p.m., Matt Jordan wrote: > > /branches/12/res/res_pjsip_multihomed.c, lines 83-86 > > > > > > If we don't have a multihomed transport and/or the transport hasn't > > changed, I'm not sure why

[asterisk-dev] [Code Review] 3114: verbosity: Fix performance of console verbose messages.

2014-01-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3114/ --- Review request for Asterisk Developers. Bugs: AST-1252 https://issues.

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-09 Thread Olle E Johansson
> On Jan. 7, 2014, 10:29 a.m., Olle E Johansson wrote: > > Please also check the sender IP address in the IP packet. That's where > > things go wrong with chan_sip. Thanks. > > Matt Jordan wrote: > Olle - just so I understand your comment, are you referring to what would > happen if the se

Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-01-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3093/#review10544 --- /branches/12/res/res_pjsip_dialog_info.c

Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-01-09 Thread Matt Jordan
> On Jan. 9, 2014, 2:11 p.m., opticron wrote: > > /branches/12/res/res_pjsip_dialog_info.c, line 109 > > > > > > "dialog-info+xml" seems to get used quite a bit in this file. Put this > > in a #define or a static v

[asterisk-dev] [Code Review] 3115: res_pjsip: Fix CLI tab completion issues

2014-01-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3115/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23081 https://i

Re: [asterisk-dev] [Code Review] 3111: astobj2: Correct ao2_iterator opacity violations

2014-01-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3111/ --- (Updated Jan. 9, 2014, 2:38 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/#review10547 --- Ship it! >From a "Does this appear to do the proper thing and

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/#review10548 --- Ship it! Ship It! - opticron On Jan. 9, 2014, 9:16 a.m., Ma

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/#review10549 --- /branches/12/main/stasis.c

Re: [asterisk-dev] [Code Review] 3114: verbosity: Fix performance of console verbose messages.

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3114/#review10550 --- /branches/11/main/cli.c

Re: [asterisk-dev] [Code Review] 3115: res_pjsip: Fix CLI tab completion issues

2014-01-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3115/#review10551 --- branches/12/res/res_pjsip/pjsip_cli.c

[asterisk-dev] [Code Review] 3116: chan_sip: eliminate channel state down prior to hangup

2014-01-09 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3116/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23010 https://i

[asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson. Re

[asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/ --- Review request for Asterisk Developers, Kevin Harwell, Matt Jordan, and Mark

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
> On Jan. 9, 2014, 4:12 p.m., David Lee wrote: > > /branches/12/main/stasis.c, lines 634-647 > > > > > > I'm curious why you didn't just dispatch_message(sub, message, sync_sub > > == sub); > > > > As it's

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/ --- (Updated Jan. 9, 2014, 5:34 p.m.) Review request for Asterisk Developers a

[asterisk-dev] [Code Review] 3119: res_ari: Fix memory leaks.

2014-01-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3119/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23128 https://i

Re: [asterisk-dev] ARI leaking memory?

2014-01-09 Thread Joshua Colp
Watson, Kenneth wrote: > Thank you for bringing this up! This wasn't a known reported bug but I've tracked down what is happening and filed an issue so now it has magically become one. > > You can track progress here: > https://issues.asterisk.org/jira/browse/ASTERISK-23128 Fantastic, thanks

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/ --- (Updated Jan. 9, 2014, 5:38 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/ --- (Updated Jan. 9, 2014, 5:40 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3094: res_pjsip_messaging: potential for field values in from/to headers to be missing

2014-01-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3094/ --- (Updated Jan. 9, 2014, 5:44 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3114: verbosity: Fix performance of console verbose messages.

2014-01-09 Thread rmudgett
> On Jan. 9, 2014, 4:44 p.m., Matt Jordan wrote: > > /branches/11/main/logger.c, lines 1915-1917 > > > > > > Why an int *? This struct is used by thread storage on the reading side of a remote console server whic

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-09 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/#review10556 --- /branches/12/rest-api/api-docs/mailboxes.json

Re: [asterisk-dev] [Code Review] 3115: res_pjsip: Fix CLI tab completion issues

2014-01-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3115/ --- (Updated Jan. 9, 2014, 8:21 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3116: chan_sip: eliminate channel state down prior to hangup

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3116/#review10557 --- Ship it! Ship It! - Matt Jordan On Jan. 9, 2014, 5:07 p.m.,

Re: [asterisk-dev] [Code Review] 3105: Testsuite: Test PJSIP hold and unhold for various conditions for INVITE SDPs

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3105/#review10558 --- While I know this was copied from the test I wrote for chan_sip

Re: [asterisk-dev] [Code Review] 3113: PJSIP: Print "" instead of a UUID for artificial PJSIP endpoints' account IDs in security events

2014-01-09 Thread Matt Jordan
> On Jan. 9, 2014, 10:38 a.m., Joshua Colp wrote: > > I'd be down with this in 12, makes it more clearer. And more clearer == more better. :-) - Matt --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.as