Re: [asterisk-dev] [Code Review] 3132: Test for allow=all sdp issue

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3132/#review10644 --- /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/test-config

Re: [asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/#review10645 --- /branches/1.8/configs/manager.conf.sample

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

> On Jan. 17, 2014, 5:46 p.m., George Joseph wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test for > > "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the > > meaning of "disallow", the "!" doesn't really make sense. It actually > > negates the d

[asterisk-dev] [Code Review] 3144: Protect manager data structures during shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3144/ --- Review request for Asterisk Developers. Bugs: AST-1242 https://issues.

[asterisk-dev] [Code Review] 3143: pjsip_configuration: in ast_sip_auth_array_init, change assert(auths->names == NULL) to ast_sip_auth_array_destroy(auths)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3143/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23168 https://i

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

On Mon, Jan 20, 2014 at 9:09 PM, George Joseph wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3136/ > > On January 17th, 2014, 4:46 p.m. MST, *George Joseph* wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test fo

[asterisk-dev] What is dahdi.auto_assigned_spans and why should you care?

What is dahdi.auto_assign_spans and why should you care? In later versions the kernel module dahdi[Q] includes a new parameter: auto_assign_spans. It defaults to 1, and if you set it to 0, DAHDI can start behaving in strange and completely expected ways. Chances are the default will be set to 1 in

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

> On Jan. 17, 2014, 4:46 p.m., George Joseph wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test for > > "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the > > meaning of "disallow", the "!" doesn't really make sense. It actually > > negates the d

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

> On Jan. 17, 2014, 5:46 p.m., George Joseph wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test for > > "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the > > meaning of "disallow", the "!" doesn't really make sense. It actually > > negates the d

Re: [asterisk-dev] [Code Review] 3130: testsuite: Update hold test to monitor device state of PJSIP channels

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3130/ --- (Updated Jan. 20, 2014, 12:19 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3129: chan_pjsip: Provide a means for updating device state when going on/off hold

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3129/ --- (Updated Jan. 20, 2014, 12:08 p.m.) Status -- This change has been ma

[asterisk-dev] [Code Review] 3142: Thread Debugging: Add LWP to core show locks output

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3142/ --- Review request for Asterisk Developers and Mark Michelson. Repository: Ast

[asterisk-dev] [Code Review] 3141: res_config_pgsql: Make sure PQClear is used for all PGResults

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3141/ --- Review request for Asterisk Developers and Mark Michelson. Repository: Ast

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

> On Jan. 17, 2014, 4:46 p.m., George Joseph wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test for > > "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the > > meaning of "disallow", the "!" doesn't really make sense. It actually > > negates the d

Re: [asterisk-dev] [Code Review] 3134: pbx.c: avoid segfault on uninitialized time values

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3134/#review10639 --- Ship it! Ship It! - rmudgett On Jan. 20, 2014, 9:47 a.m., S

Re: [asterisk-dev] [Code Review] 3135: Protect ast_filestream object when on a channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3135/#review10638 --- Ship it! Looks good to me. - rmudgett On Jan. 17, 2014, 6:5

Re: [asterisk-dev] [Code Review] 3122: ARI: Add support for specifying channel variables during originate

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3122/#review10637 --- Ship it! Ship It! - Kevin Harwell On Jan. 13, 2014, 11:09 a

Re: [asterisk-dev] [Code Review] 3134: pbx.c: avoid segfault on uninitialized time values

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3134/ --- (Updated Jan. 20, 2014, 9:47 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3134: pbx.c: avoid segfault on uninitialized time values

> On Jan. 17, 2014, 6:46 p.m., rmudgett wrote: > > Only the corryfarrel patch is needed. The other patch is not complete and > > is supurfluous. You're right, I should have caught that. - Scott --- This is an automatically generated e

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint shows allow/disallow codecs the same

> On Jan. 17, 2014, 5:46 p.m., George Joseph wrote: > > Not sure this is a good idea. First, I wouldn't hardcode a test for > > "disallow" in the generic ast_sip_cli_print_sorcery_objset and given the > > meaning of "disallow", the "!" doesn't really make sense. It actually > > negates the d

Re: [asterisk-dev] [Code Review] 3112: wideband streaming with res_musiconhold

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3112/ --- (Updated Jan. 20, 2014, 8:57 a.m.) Status -- This change has been mar