[asterisk-dev] [Code Review] 3280: Makefile: replace -O6 with -O3

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3280/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] Installing Asterisk in Mac OS X Mavericks

On Thu, Feb 27, 2014 at 12:55:43PM -0600, David M. Lee wrote: > Asterisk requires GCC to build properly. The most recent version of Xcode > symlinks gcc to Clang’s compiler. Which is… unfortunate. > > I install GCC myself (gcc-4.8 for 12 and trunk; gcc-4.2 for 11 and earlier) > for compiling Ast

Re: [asterisk-dev] CentOS packaging

On Thu, Feb 27, 2014 at 04:51:29PM -0500, Jared Smith wrote: > On Thu, Feb 27, 2014 at 12:56 PM, Matthew Jordan wrote: > > > (1) I fully appreciate the annoyance of having embedded libraries in > > Asterisk. While some of those embedded libraries may be difficult to > > extract, some - most likel

Re: [asterisk-dev] Asterisk for GSM core network (MSC)

Hello Stefan,    I need to convert the BSSAP over SS7 messages to SIP. This should happen at BSS only and not at MSC. So that's the requirement. In this scenario, can I use the asterisk server? Also, which channel modules will I need? Kindly help me out. Thanks in advance. regards, Treesa On Wed,

[asterisk-dev] [Code Review] 3279: Iterate through logger.conf [general] section

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3279/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] Asterisk 11.8.0-rc2 Now Available

The Asterisk Development Team has announced the second release candidate of Asterisk 11.8.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 11.8.0-rc2 resolves an issue reported by the community and would h

[asterisk-dev] Asterisk 12.1.0-rc2 Now Available

The Asterisk Development Team has announced the second release candidate of Asterisk 12.1.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 12.1.0-rc2 resolves several issues reported by the community and w

Re: [asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3248/#review10990 --- By the way - thanks a lot for working on this problem. I know W

Re: [asterisk-dev] [Code Review] 3275: res_rtp_asterisk: Fix the one way audio problems when resuming held calls with ICE

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3275/ --- (Updated Feb. 27, 2014, 3:53 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] CentOS packaging

On Thu, Feb 27, 2014 at 12:56 PM, Matthew Jordan wrote: > (1) I fully appreciate the annoyance of having embedded libraries in > Asterisk. While some of those embedded libraries may be difficult to > extract, some - most likely - could be removed at this point. I would > love to see patches propo

Re: [asterisk-dev] [Code Review] 3275: res_rtp_asterisk: Fix the one way audio problems when resuming held calls with ICE

> On Feb. 27, 2014, 2:14 p.m., Matt Jordan wrote: > > /branches/11/res/res_rtp_asterisk.c, line 565 > > > > > > You're actually leaking left_candidate here as well. The original > > ao2_link of left_candidate is on

Re: [asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

> On Feb. 27, 2014, 9:05 a.m., opticron wrote: > > /branches/11/res/res_http_websocket.c, lines 717-718 > > > > > > Drop this debug message. I wouldn't mind if we had a debug message for some of these things, but i

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/ --- (Updated Feb. 27, 2014, 2:45 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

> On Feb. 27, 2014, 10:59 a.m., opticron wrote: > > branches/12/funcs/func_sorcery.c, line 6 > > > > > > This might not be correct. Heh, cut and paste. > On Feb. 27, 2014, 10:59 a.m., opticron wrote: > > branches/1

Re: [asterisk-dev] CentOS packaging

On Thu, Feb 27, 2014 at 3:13 PM, Jared Smith wrote: > > On Thu, Feb 27, 2014 at 12:26 PM, Matthew Jordan wrote: >> >> If the packages were restructured, it could be set up so that Asterisk >> only provides chan_dahdi in a subpackage - although there are >> obviously some issues with subpackages a

Re: [asterisk-dev] [Code Review] 3240: res_pjsip_exten_state: Presence for digium phones

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3240/ --- (Updated Feb. 27, 2014, 3:19 p.m.) Status -- This change has been mar

Re: [asterisk-dev] CentOS packaging

On Thu, Feb 27, 2014 at 12:26 PM, Matthew Jordan wrote: > If the packages were restructured, it could be set up so that Asterisk > only provides chan_dahdi in a subpackage - although there are > obviously some issues with subpackages as well. I'm still not sure of > a good structure for subpackag

Re: [asterisk-dev] [Code Review] 3265: media_formats: Move app_fax over

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3265/#review10987 --- /team/file/media_formats-impl/apps/app_fax.c

Re: [asterisk-dev] CentOS packaging

On Wed, Feb 26, 2014 at 3:51 PM, Tzafrir Cohen wrote: > This is funny. In 11 pjproject is bundled (though patching it out is not > an issue). In 12 it is not included in the tree anymore. > I know, and the humor isn't lost on me. :-) That being said, I'm hoping to get the Asterisk fork of pjproj

Re: [asterisk-dev] CentOS packaging

On Thu, Feb 27, 2014 at 11:56:03AM -0600, Matthew Jordan wrote: > If that is the policy of Fedora, then quite frankly, it should just > stop including packages of Asterisk. There have been embedded > libraries in Asterisk all the way back to version 1.0.0 - and if the > Fedora packagers are going

Re: [asterisk-dev] CentOS packaging

On Thu, Feb 27, 2014 at 11:26:02AM -0600, Matthew Jordan wrote: > On Tue, Feb 25, 2014 at 1:03 PM, Ben Langfeld wrote: > > After a conversation with Rusty last week, I've become aware that for a > > simple installation of asterisk (11) from the CentOS repositories at > > http://packages.asterisk.o

Re: [asterisk-dev] [Code Review] 3246: res_pjsip_send_to_voicemail: transferring to voicemail for digium phones

> On Feb. 27, 2014, 8:53 a.m., opticron wrote: > > asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/test-config.yaml, line > > 34 > > > > > > If you are only using invite.xml to generate a call, this is more >

Re: [asterisk-dev] [Code Review] 3246: res_pjsip_send_to_voicemail: transferring to voicemail for digium phones

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3246/ --- (Updated Feb. 27, 2014, 2:32 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3272: func_audiohookinheritance: Check If Channel Was Specified

> On Feb. 27, 2014, 4:26 p.m., Joshua Colp wrote: > > This is fine but we should probably do an audit and try to find other cases. > > Corey Farrell wrote: > If nobody is working on the audit of channel usage in dialplan functions > I can. Should I start a new JIRA ticket? That'd be nifty

Re: [asterisk-dev] [Code Review] 3272: func_audiohookinheritance: Check If Channel Was Specified

> On Feb. 27, 2014, 11:26 a.m., Joshua Colp wrote: > > This is fine but we should probably do an audit and try to find other cases. If nobody is working on the audit of channel usage in dialplan functions I can. Should I start a new JIRA ticket? - Corey

Re: [asterisk-dev] [Code Review] 3275: res_rtp_asterisk: Fix the one way audio problems when resuming held calls with ICE

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3275/#review10982 --- /branches/11/res/res_rtp_asterisk.c

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/ --- (Updated Feb. 27, 2014, 1:19 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3275: res_rtp_asterisk: Fix the one way audio problems when resuming held calls with ICE

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3275/#review10981 --- /branches/11/res/res_rtp_asterisk.c

[asterisk-dev] [Code Review] 3277: testsuite: ARI Originate test for assigning UniqueId on channel creation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3277/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23120 https://i

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3256/ --- (Updated Feb. 27, 2014, 2:03 p.m.) Status -- This change has been mar

[asterisk-dev] [Code Review] 3275: res_rtp_asterisk: Fix the one way audio problems when resuming held calls with ICE

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3275/ --- Review request for Asterisk Developers, Joshua Colp, Kevin Harwell, and Matt

Re: [asterisk-dev] Installing Asterisk in Mac OS X Mavericks

Asterisk requires GCC to build properly. The most recent version of Xcode symlinks gcc to Clang’s compiler. Which is… unfortunate. I install GCC myself (gcc-4.8 for 12 and trunk; gcc-4.2 for 11 and earlier) for compiling Asterisk on OS X. Both are easily installed via Homebrew (brew install app

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3256/#review10980 --- Ship it! Ship It! - Joshua Colp On Feb. 27, 2014, 6:41 p.m.

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3256/ --- (Updated Feb. 27, 2014, 12:41 p.m.) Review request for Asterisk Developers

[asterisk-dev] Installing Asterisk in Mac OS X Mavericks

Hi all, Does anyone could get asterisk work in Mac OS X Mavericks? When I try to install it and compile the source I got the following error: * [CC] astcanary.c -> astcanary.o* *clang: warning: argument unused during compilation: '-fnested-functions'* *error: invalid value '6' in '-O6'* *make[

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

> On Feb. 27, 2014, 6:14 p.m., Joshua Colp wrote: > > /branches/11/res/res_rtp_asterisk.c, line 1689 > > > > > > There's actually a bug here you didn't cause, but can fix! > > > > If the component is RTP t

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3256/#review10977 --- /branches/11/res/res_rtp_asterisk.c

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/#review10971 --- branches/12/funcs/func_sorcery.c

Re: [asterisk-dev] CentOS packaging

On Wed, Feb 26, 2014 at 7:48 AM, Jared Smith wrote: > On Tue, Feb 25, 2014 at 3:23 PM, Ben Langfeld wrote: >> >> Unfortunately those packages are of Asterisk 1.8: >> http://dl.fedoraproject.org/pub/epel/6/x86_64/repoview/asterisk.html. That's >> a total no-go for me, I'm afraid, but thanks for th

Re: [asterisk-dev] CentOS packaging

On Thu, Feb 27, 2014 at 10:28 AM, Sean Darcy wrote: > On 02/26/2014 02:02 AM, Tzafrir Cohen wrote: > >> On Tue, Feb 25, 2014 at 05:04:26PM -0500, Sean Darcy wrote: >> >>> On 02/25/2014 02:03 PM, Ben Langfeld wrote: >>> After a conversation with Rusty last week, I've become aware that for a >

Re: [asterisk-dev] [Code Review] 3273: Corrected cross-platform stat nanosecond code.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3273/ --- (Updated Feb. 27, 2014, 11:33 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3273: Corrected cross-platform stat nanosecond code.

> On Feb. 27, 2014, 10:48 a.m., rmudgett wrote: > > /branches/1.8/main/config.c, line 1102 > > > > > > It is acceptable to just set the nanoseconds to zero if the platform > > doesn't support the resolution. Howe

Re: [asterisk-dev] CentOS packaging

On 02/26/2014 02:02 AM, Tzafrir Cohen wrote: On Tue, Feb 25, 2014 at 05:04:26PM -0500, Sean Darcy wrote: On 02/25/2014 02:03 PM, Ben Langfeld wrote: After a conversation with Rusty last week, I've become aware that for a simple installation of asterisk (11) from the CentOS repositories at http:

Re: [asterisk-dev] CentOS packaging

On Tue, Feb 25, 2014 at 1:03 PM, Ben Langfeld wrote: > After a conversation with Rusty last week, I've become aware that for a > simple installation of asterisk (11) from the CentOS repositories at > http://packages.asterisk.org/centos/, the 'current' repo at > http://packages.digium.com/centos is

Re: [asterisk-dev] [Code Review] 3273: Corrected cross-platform stat nanosecond code.

> On Feb. 27, 2014, 10:51 a.m., wdoekes wrote: > > /branches/1.8/main/config.c, lines 1102-1103 > > > > > > Setting nsec isn't needed. It's calloc'ed to 0 anyway. > > > > And #warning's are not used anywhe

Re: [asterisk-dev] [Code Review] 3273: Corrected cross-platform stat nanosecond code.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3273/#review10974 --- /branches/1.8/main/config.c

Re: [asterisk-dev] [Code Review] 3273: Corrected cross-platform stat nanosecond code.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3273/#review10973 --- /branches/1.8/main/config.c

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3256/ --- (Updated Feb. 27, 2014, 10:38 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3273: Corrected cross-platform stat nanosecond code.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3273/ --- (Updated Feb. 27, 2014, 10:37 a.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3273: Correct cross-platform stat nanosecond code.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3273/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3272: func_audiohookinheritance: Check If Channel Was Specified

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3272/#review10972 --- Ship it! This is fine but we should probably do an audit and t

Re: [asterisk-dev] [Code Review] 3261: res_fax: Warn that minrate=2400 is not valid for V.27 instead of failing load

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3261/ --- (Updated Feb. 27, 2014, 11:18 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3249: Testsuite: manager live_dangerously tests are missing a parameter for on_failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3249/#review10970 --- Ship it! Ship It! - opticron On Feb. 22, 2014, 8:18 p.m., C

Re: [asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3248/#review10969 --- /branches/11/res/res_http_websocket.c

[asterisk-dev] [Code Review] 3272: func_audiohookinheritance: Check If Channel Was Specified

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3272/ --- Review request for Asterisk Developers. Summary (updated)

Re: [asterisk-dev] [Code Review] 3246: res_pjsip_send_to_voicemail: transferring to voicemail for digium phones

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3246/#review10968 --- asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/sipp/refe

Re: [asterisk-dev] [Code Review] 3238: Testsuite: Test MWI aggregation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3238/#review10967 --- Ship it! This looks good other than the minor item below. /a

Re: [asterisk-dev] [Code Review] 3132: Test for allow=all sdp issue

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3132/#review10966 --- Ship it! Ship It! - opticron On Feb. 25, 2014, 1:12 p.m., S

Re: [asterisk-dev] [Code Review] 3247: rtp_engine: lock channel during get_codecs calls to prevent NULL pvt dereference after channel masquerade

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3247/ --- (Updated Feb. 27, 2014, 7:10 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3244: res_pjsip_sdp_rtp: Apply packetization rules on inbound SDP handling

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3244/ --- (Updated Feb. 27, 2014, 6:30 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3261: res_fax: Warn that minrate=2400 is not valid for V.27 instead of failing load

> On Feb. 25, 2014, 7:23 a.m., Matt Jordan wrote: > > This was already covered in a previous UPGRADE note as well. > > > > I agree; I'd block changes at trunk. > > Corey Farrell wrote: > Since 12.1.0-rc1 has already been released, do I need to do anything > special to add this to 12.1.0?