Re: [asterisk-dev] [Code Review] 3365: res_pjsip_session: decline SDP offers with no audio streams

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3365/ --- (Updated March 17, 2014, 8:09 p.m.) Status -- This change has been di

Re: [asterisk-dev] [Code Review] 3365: res_pjsip_session: decline SDP offers with no audio streams

> On March 17, 2014, 2:12 a.m., Olle E Johansson wrote: > > That Asterisk *needs* audio was not true before. If it is, then we've > > broken things. When I worked with T.140 realtime text we made it possible > > to place calls with video and text, no audio. It took a while, but it did > > work

Re: [asterisk-dev] [Code Review] 3350: Add AES-GCM support for SRTP

> On March 13, 2014, 11:12 p.m., Matt Jordan wrote: > > Ship It! > > Kristian Kielhofner wrote: > I appreciate the enthusiasm but I don't think it's ready quite yet... > > The code isn't conditional in any way and as I said various autoconf > checks will need to be included to test

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/ --- (Updated March 17, 2014, 5:53 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3369: res_pjsip_multihomed: Be less aggressive when changing address

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3369/ --- (Updated March 17, 2014, 5:46 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3369: res_pjsip_multihomed: Be less aggressive when changing address

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3369/#review11263 --- Ship it! Ship It! - Matt Jordan On March 17, 2014, 1:23 p.m

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/ --- (Updated March 17, 2014, 4:14 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3326: Sorcery: Do not apply the same wizard to an object type twice; Automatically apply sorcery configuration when sorcery is opened.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3326/ --- (Updated March 17, 2014, 8:31 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3326: Sorcery: Do not apply the same wizard to an object type twice; Automatically apply sorcery configuration when sorcery is opened.

> On March 17, 2014, 6:43 p.m., rmudgett wrote: > > /branches/12/main/sorcery.c, lines 750-752 > > > > > > Should not fail if the sorcery.conf file doesn't exist. The Bucket > > core module will fail asterisk star

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/ --- (Updated March 17, 2014, 8:12 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

> On March 17, 2014, 3:43 a.m., Corey Farrell wrote: > > /trunk/channels/sip/reqresp_parser.c, lines 422-433 > > > > > > This will cause sip_uri_full_parse_test to fail, as the test loop > > requires non-error resu

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

> On March 17, 2014, 9:39 a.m., wdoekes wrote: > > /trunk/channels/sip/reqresp_parser.c, lines 100-105 > > > > > > I don't like it that we skip past the parameters. > > > > If we have: > > > > te

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/ --- (Updated March 17, 2014, 8:01 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3326: Sorcery: Do not apply the same wizard to an object type twice; Automatically apply sorcery configuration when sorcery is opened.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3326/#review11258 --- /branches/12/main/sorcery.c

[asterisk-dev] [Code Review] 3369: res_pjsip_multihomed: Be less aggressive when changing address

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3369/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] Alembic in 12 SVN

Matthew Jordan wrote: Technically, it's probably not hard. I wonder how horrible it'd be for end users, however. Probably pretty horrible, since it's basically changing everything. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US C

Re: [asterisk-dev] [Code Review] 3338: ARI: Prevent corner cases where channel in bridge can wait forever for playback to finish

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3338/ --- (Updated March 17, 2014, 11:52 a.m.) Status -- This change has been m

Re: [asterisk-dev] Alembic in 12 SVN

On Mon, Mar 17, 2014 at 11:45 AM, Joshua Colp wrote: > Matthew Jordan wrote: >> >> On Mon, Mar 17, 2014 at 11:02 AM, Joshua Colp wrote: >>> >>> Greetings all, >>> >>> Awhile ago when I was working on PJSIP DNS Matt brought up adding the >>> option >>> to Alembic. Through doing so I created a basi

Re: [asterisk-dev] Alembic in 12 SVN

Matthew Jordan wrote: On Mon, Mar 17, 2014 at 11:02 AM, Joshua Colp wrote: Greetings all, Awhile ago when I was working on PJSIP DNS Matt brought up adding the option to Alembic. Through doing so I created a basic alembic.ini and started a new migration script. Unfortunately when attempting to

Re: [asterisk-dev] Alembic in 12 SVN

On Mon, Mar 17, 2014 at 11:02 AM, Joshua Colp wrote: > Greetings all, > > Awhile ago when I was working on PJSIP DNS Matt brought up adding the option > to Alembic. Through doing so I created a basic alembic.ini and started a new > migration script. Unfortunately when attempting to add a new revis

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/ --- (Updated March 17, 2014, 4:23 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/ --- (Updated March 17, 2014, 4:22 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/#review11257 --- Ship it! Ship It! - Sean Bright On March 17, 2014, 1:15 p.m

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

> On March 17, 2014, 2:46 p.m., Tilghman Lesher wrote: > > http://svn.asterisk.org/svn/asterisk/branches/1.8/res/res_config_pgsql.c, > > line 682 > > > > > > Just a nitpick. I really hate the double-negative form

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/ --- (Updated March 17, 2014, 4:16 p.m.) Review request for Asterisk Developers

[asterisk-dev] Alembic in 12 SVN

Greetings all, Awhile ago when I was working on PJSIP DNS Matt brought up adding the option to Alembic. Through doing so I created a basic alembic.ini and started a new migration script. Unfortunately when attempting to add a new revision I received: Only a single head is supported. The sc

Re: [asterisk-dev] [Code Review] 3350: Add AES-GCM support for SRTP

> On March 14, 2014, 4:12 a.m., Matt Jordan wrote: > > Ship It! I appreciate the enthusiasm but I don't think it's ready quite yet... The code isn't conditional in any way and as I said various autoconf checks will need to be included to test for feature-openssl support in system libsrtp as w

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/#review11254 --- Ship it! Other than this small nitpick, looks good to go. ht

Re: [asterisk-dev] DNS & PJSIP

Making people configure DNS for each application might the start of an exciting new trend in software! We could call the "what nutjob thought of THAT feature" feature. -Original Message- From: asterisk-dev-boun...@lists.digium.com [mailto:asterisk-dev-boun...@lists.digium.com] On Beh

Re: [asterisk-dev] [Code Review] 3368: chan_sip segfault: INTERNAL_OBJ at astobj2.c:120

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3368/ --- (Updated March 17, 2014, 2:21 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] DNS & PJSIP

On 17 Mar 2014, at 15:00, Matthew Jordan wrote: > On Mon, Mar 17, 2014 at 4:47 AM, Olle E. Johansson wrote: >> Friends, >> After a bit of heated discussion I can try to make a conclusion from what I >> see when the dust settled: >> >> - We are still in control of our own product and make our

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/#review11253 --- Ship it! There has been a long and healthy debate on this patc

Re: [asterisk-dev] DNS & PJSIP

On Mon, Mar 17, 2014 at 4:47 AM, Olle E. Johansson wrote: > Friends, > After a bit of heated discussion I can try to make a conclusion from what I > see when the dust settled: > > - We are still in control of our own product and make our own decisions about > Asterisk architecture. Any arguments

Re: [asterisk-dev] [Code Review] 3359: res_stasis: Extend bridge type to include attributes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3359/ --- (Updated March 17, 2014, 1:57 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [asterisk-commits] mjordan: branch 11 r409990 - /branches/11/res/res_fax_spandsp.c

On Mon, Mar 17, 2014 at 7:57 AM, Johann Steinwendtner wrote: > On 2014-03-17 13:27, Matthew Jordan wrote: >> >> On Mon, Mar 17, 2014 at 6:25 AM, Johann Steinwendtner >> wrote: >>> >>> On 2014-03-06 02:58, SVN commits to the Asterisk project wrote: >> >>> >>> Hello, >>> >>> is this patch

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/ --- (Updated March 17, 2014, 1:15 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [asterisk-commits] mjordan: branch 11 r409990 - /branches/11/res/res_fax_spandsp.c

On 2014-03-17 13:27, Matthew Jordan wrote: On Mon, Mar 17, 2014 at 6:25 AM, Johann Steinwendtner wrote: On 2014-03-06 02:58, SVN commits to the Asterisk project wrote: Hello, is this patch using the g711 decode function from spandsp ? It is better to use g711_free(...), g711_release does

Re: [asterisk-dev] DNS & PJSIP

On 3/17/2014 5:47 AM, Olle E. Johansson wrote: - We are still in control of our own product and make our own decisions about Asterisk architecture. Any arguments like "PJSIP has it so we have to enable it" falls to the ground as not valid and disappear in a cloud of smoke. Those that are in c

Re: [asterisk-dev] [Code Review] 3322: media_formats: Move resource modules over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3322/ --- (Updated March 17, 2014, 12:45 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3368: chan_sip segfault: INTERNAL_OBJ at astobj2.c:120

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3368/#review11251 --- The patch feels kind of empty ;) - wdoekes On March 17, 2014

[asterisk-dev] [Code Review] 3368: chan_sip segfault: INTERNAL_OBJ at astobj2.c:120

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3368/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22079 https://i

Re: [asterisk-dev] [asterisk-commits] mjordan: branch 11 r409990 - /branches/11/res/res_fax_spandsp.c

On Mon, Mar 17, 2014 at 6:25 AM, Johann Steinwendtner wrote: > On 2014-03-06 02:58, SVN commits to the Asterisk project wrote: >> > > Hello, > > is this patch using the g711 decode function from spandsp ? It is better to > use g711_free(...), g711_release does actually nothing. > > Yes, it is us

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/ --- (Updated March 17, 2014, 12:17 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

> On March 17, 2014, 11:48 a.m., wdoekes wrote: > > http://svn.asterisk.org/svn/asterisk/branches/1.8/res/res_config_pgsql.c, > > line 682 > > > > > > Try to limit line lengths to about 100. Done:) - zvision -

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/ --- (Updated March 17, 2014, 11:56 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/#review11249 --- Ship it! Looks good to go. http://svn.asterisk.org/svn/aster

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3335/#review11248 --- Ship it! For trunk, this is good to go. - wdoekes On March

Re: [asterisk-dev] [Code Review] 3321: media_formats: Move dialplan functions over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3321/ --- (Updated March 17, 2014, 6:29 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [asterisk-commits] mjordan: branch 11 r409990 - /branches/11/res/res_fax_spandsp.c

On 2014-03-06 02:58, SVN commits to the Asterisk project wrote: Author: mjordan Date: Wed Mar 5 19:58:10 2014 New Revision: 409990 URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=409990 Log: res_fax_spandsp: Fix crash when passing ulaw/alaw data to spandsp When acting as a T.38 fax ga

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

On March 17, 2014, 9:28 a.m., zvision wrote: > > So, the changes look good. But that regression thing is .. not so nice. > > > > For trunk and up, we could change the behaviour. But we can't for 1.8..12. > > > > The options are: > > > > - leave the bug in place, only fix in trunk > > > > - ch

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3335/ --- (Updated March 17, 2014, 11:12 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

> On March 17, 2014, 9:08 a.m., wdoekes wrote: > > http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_pgsql.c, > > lines 761-772 > > > > > > The double occurrence of count++ smells bad. > > > >

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/ --- (Updated March 17, 2014, 9:58 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/ --- (Updated March 17, 2014, 9:57 a.m.) Review request for Asterisk Developers

[asterisk-dev] DNS & PJSIP

Friends, After a bit of heated discussion I can try to make a conclusion from what I see when the dust settled: - We are still in control of our own product and make our own decisions about Asterisk architecture. Any arguments like "PJSIP has it so we have to enable it" falls to the ground as n

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3335/#review11245 --- http://svn.asterisk.org/svn/asterisk/branches/12/res/res_confi

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

> On March 13, 2014, 3:52 p.m., Mark Michelson wrote: > > Excellent job fixing the problem! > > > > A note to whoever ends up committing this: This bug also exists in 1.8, 12, > > and trunk. The 1.8 fix is exactly the same as this one. The 12 and trunk > > fixes will be slightly different sinc

Re: [asterisk-dev] [Code Review] 3346: [res_config_pgsql] Correct handling of nullable int fields in update_realtime

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/#review11243 --- You're right that this is a bug fix. (We change no working beha

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/ --- (Updated March 17, 2014, 8:46 a.m.) Status -- This change has been di

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

> On March 17, 2014, 8:39 a.m., wdoekes wrote: > > /trunk/channels/sip/reqresp_parser.c, lines 100-105 > > > > > > I don't like it that we skip past the parameters. > > > > If we have: > > > > te

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11241 --- /trunk/channels/sip/reqresp_parser.c

Re: [asterisk-dev] [Code Review] 3362: func_beep: New function for periodic beeps.

> On March 15, 2014, 6:46 p.m., Russell Bryant wrote: > > So, after talking to pabelanger about it, this could be a bit more generic > > without a lot of effort. Right now it's hard coded to do a Playback(beep) > > into the call. It could pretty easily changed to just be a periodic > > dialp

Re: [asterisk-dev] [Code Review] 3365: res_pjsip_session: decline SDP offers with no audio streams

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3365/#review11239 --- That Asterisk *needs* audio was not true before. If it is, then