Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

On March 17, 2014, 9:28 a.m., zvision wrote: > > So, the changes look good. But that regression thing is .. not so nice. > > > > For trunk and up, we could change the behaviour. But we can't for 1.8..12. > > > > The options are: > > > > - leave the bug in place, only fix in trunk > > > > - ch

[asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23459 https://i

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3335/ --- (Updated March 18, 2014, 10:42 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3371: assigned-uniqueids: Misc cleanup and fixes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3371/ --- (Updated March 18, 2014, 5:11 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11255 --- I would like to propose we backport ast_register_cleanup, use t

[asterisk-dev] [Code Review] 3374: testsuite: Verify that each of three users entering a conference enters muted when using the startmuted user profile option

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3374/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23461 https://i

Re: [asterisk-dev] JIRA, Commit Messages, and Smart Commits (oh my)

To answer my own question, yes there are some other commands, but they're not really useful for typical ASTERISK issues on the issue tracker (time-tracking commands and workflow transition commands). Mark Michelson Tuesday, March 18, 2014 2:24 PM It'll take some g

Re: [asterisk-dev] JIRA, Commit Messages, and Smart Commits (oh my)

It'll take some getting used to, but I don't mind switching. Are there other handy commands besides #close and #comment that you can use? Oh, and be sure to update the wiki page that has the commit message template! Matthew Jordan Tuesday, March 18, 2014 1:25 PM Hey

[asterisk-dev] JIRA, Commit Messages, and Smart Commits (oh my)

Hey everyone - Due to a security vulnerability in JIRA, we recently had to upgrade JIRA to version 6.2. While this was a good thing (tm), it did break the snot out of the Subversion plugin. That plugin does a number of things; one of those things is auto-closing issues based on the commit message.

Re: [asterisk-dev] [Code Review] 3330: Testsuite: e( ) Options BridgeWait Application

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3330/ --- (Updated March 18, 2014, 1:19 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3327: Test for endmarked users in confbridge

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3327/ --- (Updated March 18, 2014, 1:01 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3328: Agent Acknowledgement Nominal and Error Tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3328/ --- (Updated March 18, 2014, 12:58 p.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3370: masquerade-supertest: Relax DTMF timing requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3370/ --- (Updated March 18, 2014, 12:47 p.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3373: app_confbridge: Users with start_muted set aren't starting muted (although the first appears to)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3373/#review11283 --- Ship it! Ship It! - rmudgett On March 18, 2014, 12:43 p.m.,

[asterisk-dev] [Code Review] 3373: app_confbridge: Users with start_muted set aren't starting muted (although the first appears to)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3373/ --- Review request for Asterisk Developers, Matt Jordan and rmudgett. Bugs: AS

Re: [asterisk-dev] [Code Review] 3372: Allow local ICE candidates to be overridden with specified address

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3372/#review11282 --- I hadn't considered multihomed machines when I wrote this patch

Re: [asterisk-dev] [Code Review] 3330: Testsuite: e( ) Options BridgeWait Application

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3330/ --- (Updated March 18, 2014, 12:29 p.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3371: assigned-uniqueids: Misc cleanup and fixes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3371/ --- (Updated March 18, 2014, 12:09 p.m.) Review request for Asterisk Developer

[asterisk-dev] [Code Review] 3371: assigned-uniqueids: Misc cleanup and fixes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3371/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] [Code Review] 3372: Allow local ICE candidates to be overridden with specified address

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3372/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11266 --- /trunk/channels/sip/reqresp_parser.c

Re: [asterisk-dev] [Code Review] 3370: masquerade-supertest: Relax DTMF timing requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3370/#review11281 --- Ship it! Ship It! - Matt Jordan On March 18, 2014, 11:45 a.

Re: [asterisk-dev] [Code Review] 3315: BridgeWait Roles Test

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3315/ --- (Updated March 18, 2014, 11:50 a.m.) Status -- This change has been m

[asterisk-dev] [Code Review] 3370: masquerade-supertest: Relax DTMF timing requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3370/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22846 https://i

Re: [asterisk-dev] [Code Review] 3320: media_formats: Move format modules over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3320/#review11280 --- /team/group/media_formats-reviewed/formats/format_h263.c

Re: [asterisk-dev] [Code Review] 3318: media_formats: Move bridges over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3318/#review11279 --- /team/group/media_formats-reviewed/bridges/bridge_softmix.c

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/#review11278 --- /team/group/media_formats-reviewed/include/asterisk/frame.h

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

On March 17, 2014, 9:28 a.m., zvision wrote: > > So, the changes look good. But that regression thing is .. not so nice. > > > > For trunk and up, we could change the behaviour. But we can't for 1.8..12. > > > > The options are: > > > > - leave the bug in place, only fix in trunk > > > > - ch

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

On March 17, 2014, 9:28 a.m., zvision wrote: > > So, the changes look good. But that regression thing is .. not so nice. > > > > For trunk and up, we could change the behaviour. But we can't for 1.8..12. > > > > The options are: > > > > - leave the bug in place, only fix in trunk > > > > - ch

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

On March 17, 2014, 9:28 a.m., zvision wrote: > > So, the changes look good. But that regression thing is .. not so nice. > > > > For trunk and up, we could change the behaviour. But we can't for 1.8..12. > > > > The options are: > > > > - leave the bug in place, only fix in trunk > > > > - ch

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

On March 17, 2014, 9:28 a.m., zvision wrote: > > So, the changes look good. But that regression thing is .. not so nice. > > > > For trunk and up, we could change the behaviour. But we can't for 1.8..12. > > > > The options are: > > > > - leave the bug in place, only fix in trunk > > > > - ch

Re: [asterisk-dev] [Code Review] 3359: res_stasis: Extend bridge type to include attributes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3359/#review11273 --- Ship it! Ship It! - Matt Jordan On March 17, 2014, 8:57 a.m

Re: [asterisk-dev] [Code Review] 3360: ARI: allow json content type with zero length body

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3360/ --- (Updated March 18, 2014, 9:51 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3335: [res_config_odbc] Fix for nullable integer columns and keyfield existence check in update_odbc

On March 17, 2014, 9:28 a.m., zvision wrote: > > So, the changes look good. But that regression thing is .. not so nice. > > > > For trunk and up, we could change the behaviour. But we can't for 1.8..12. > > > > The options are: > > > > - leave the bug in place, only fix in trunk > > > > - ch

Re: [asterisk-dev] [Code Review] 3360: ARI: allow json content type with zero length body

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3360/#review11271 --- Ship it! Ship It! - Matt Jordan On March 18, 2014, 9:17 a.m

Re: [asterisk-dev] Alembic in 12 SVN

On Tue, Mar 18, 2014 at 10:07 AM, Matthew Jordan wrote: > On Tue, Mar 18, 2014 at 8:31 AM, Russell Bryant > wrote: > > On Mon, Mar 17, 2014 at 1:01 PM, Joshua Colp wrote: > >> > >> Matthew Jordan wrote: > >> > >> > >> > >> > >>> > >>> Technically, it's probably not hard. I wonder how horrible

Re: [asterisk-dev] [Code Review] 3360: ARI: allow json content type with zero length body

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3360/ --- (Updated March 18, 2014, 9:17 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] Alembic in 12 SVN

On Tue, Mar 18, 2014 at 8:31 AM, Russell Bryant wrote: > On Mon, Mar 17, 2014 at 1:01 PM, Joshua Colp wrote: >> >> Matthew Jordan wrote: >> >> >> >> >>> >>> Technically, it's probably not hard. I wonder how horrible it'd be for >>> end users, however. >>> >> >> Probably pretty horrible, since it

Re: [asterisk-dev] Alembic in 12 SVN

On Mon, Mar 17, 2014 at 1:01 PM, Joshua Colp wrote: > Matthew Jordan wrote: > > > > > >> Technically, it's probably not hard. I wonder how horrible it'd be for >> end users, however. >> >> > Probably pretty horrible, since it's basically changing everything. Well ... you completely drop suppor

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

> On March 18, 2014, 12:43 p.m., wdoekes wrote: > > /branches/12/res/res_pjsip/config_system.c, lines 200-206 > > > > > > No ao2_ref(discovered_nameservers, -1); here? Fixed in SVN, cheers! - Joshua ---

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/#review11269 --- I realise this was committed already, but: /branches/12/res/r

Re: [asterisk-dev] [asterisk-commits] mjordan: branch 11 r409990 - /branches/11/res/res_fax_spandsp.c

On 3/17/2014 9:48 AM, Matthew Jordan wrote: Ugh. That stinks - there was no g711_free in 0.0.5. Looks like we're going to need a patch for this that examines the libspandsp version and uses one or the other. This has been fixed: http://svnview.digium.com/svn/asterisk?view=revision&revision=41

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11268 --- Ship it! The changes make me happy. - wdoekes On March 17,