Re: [asterisk-dev] [Code Review] 3320: media_formats: Move format modules over.

2014-04-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3320/ --- (Updated April 1, 2014, 6:24 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3404: app_queue removing callers from queue when reloading

2014-04-01 Thread Italo Rossi
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3404/ --- (Updated April 1, 2014, 2:17 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3392: Test for PJSIP_HEADER

2014-04-01 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3392/ --- (Updated April 1, 2014, 10:17 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3314: Testsuite: BridgeWait's S Option Test

2014-04-01 Thread Scott Emidy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3314/ --- (Updated April 1, 2014, 10:11 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3329: AGI Exit Status Test

2014-04-01 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3329/ --- (Updated April 1, 2014, 10:24 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3400: Nominal DISA Authentication Test

2014-04-01 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3400/ --- (Updated April 1, 2014, 10:30 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP

2014-04-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/#review11462 --- Ship it! Ship It! - Joshua Colp On March 21, 2014, 2:20

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3399: PJSIP DTMF INFO Test

2014-04-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3399/#review11464 --- Ship it! Ship It! - opticron On March 28, 2014, 2:54 p.m.,

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/ --- (Updated April 1, 2014, 4:43 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3404: app_queue removing callers from queue when reloading

2014-04-01 Thread Italo Rossi
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3404/ --- (Updated April 1, 2014, 11:48 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

2014-04-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/#review11467 --- ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py

Re: [asterisk-dev] [Code Review] 3403: Test for channel Pickup

2014-04-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3403/#review11468 ---

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

2014-04-01 Thread Scott Emidy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/ --- (Updated April 1, 2014, 7:57 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

2014-04-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/#review11469 --- Ship it! Ship It! - opticron On April 1, 2014, 2:57 p.m.,

Re: [asterisk-dev] [Code Review] 3408: app_voicemail: fix regression caused by dialplan function safety fixes - Asterisk 11 only

2014-04-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3408/ --- (Updated April 1, 2014, 3:44 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3410: media_formats: Move chan_multicast_rtp, chan_console, app_jack, and chan_ooh323 over.

2014-04-01 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3410/#review11470 --- /team/group/media_formats-reviewed/addons/chan_ooh323.c

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

2014-04-01 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/#review11471 --- ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py

[asterisk-dev] [Code Review] 3411: Add some asserts that were handy when looking for a stasis cache problem.

2014-04-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3411/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3412: testsuite: Add call setup tracking to masquerade supertest.

2014-04-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3412/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22846