Re: [asterisk-dev] [Code Review] 3439: chan_sip: Support a=rtcp attribute in SDP

> On April 16, 2014, 2:13 a.m., Corey Farrell wrote: > > /trunk/channels/chan_sip.c, line 11195 > > > > > > I will not get in the way if this change does not support parsing the > > optional address of the rtcp a

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 15, 2014, 5:15 p.m., Mark Michelson wrote: > > First off, I agree that anonymizing P-Asserted-Identity is not the correct > > way to be going here. The concept of trust is something that is not > > well-defined in chan_sip. The closest thing we currently have is the > > trustrpid op

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 15, 2014, 5:15 p.m., Mark Michelson wrote: > > First off, I agree that anonymizing P-Asserted-Identity is not the correct > > way to be going here. The concept of trust is something that is not > > well-defined in chan_sip. The closest thing we currently have is the > > trustrpid op

Re: [asterisk-dev] [Code Review] 3337: Code for DTLS retransmission

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3337/ --- (Updated April 16, 2014, 8:26 a.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3454: When Asterisk initiates an ICE-based session, then it must send it's STUN check messages using role "ICE-CONTROLLING". Currently it uses "ICE-CONTROLLED". Though the

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3454/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23026 https://i

Re: [asterisk-dev] [Code Review] 3439: chan_sip: Support a=rtcp attribute in SDP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3439/#review11629 --- /trunk/res/res_rtp_asterisk.c

Re: [asterisk-dev] [Code Review] 3430: [channels/chan_unistim.c]: Improvements and bugfixes to chan_unistim.c

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/ --- (Updated April 16, 2014, 11:07 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3454: When Asterisk initiates an ICE-based session, then it must send it's STUN check messages using role "ICE-CONTROLLING". Currently it uses "ICE-CONTROLLED". Though

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3454/#review11630 --- http://svn.asterisk.org/svn/asterisk/trunk/res/res_rtp_asteris

Re: [asterisk-dev] [Code Review] 3451: app_dial and app_queue: Make lock the forwarding channel while taking the channel snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3451/#review11631 --- Ship it! Ship It! - Matt Jordan On April 15, 2014, 9:05 p.m

Re: [asterisk-dev] [Code Review] 3427: ARI: Add tones playback resource

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3427/#review11632 --- Ship it! The tests that have been written should also include

Re: [asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3428/#review11633 --- Add an iteration to one of the existing tests or a separate tes

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/ --- (Updated April 16, 2014, 10:16 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3450: Stasis: Ensure control's bridge pointer has a ref

> On April 15, 2014, 4:45 p.m., Matt Jordan wrote: > > I know I was thinking that this would be necessary everywhere; it may still > > be. > > > > However, when I wrote that particular bug report, we were still having > > crashes with reference counting issues in the main Stasis application lo

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/ --- (Updated April 16, 2014, 4:14 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/ --- (Updated April 16, 2014, 11:23 a.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3450: Stasis: Ensure control's bridge pointer has a ref

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3450/ --- (Updated April 16, 2014, 1:05 p.m.) Status -- This change has been di

Re: [asterisk-dev] [Code Review] 3450: Stasis: Ensure control's bridge pointer has a ref

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3450/ --- (Updated April 16, 2014, 2:14 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/#review11635 --- Hey wdoekes, I'm trying to figure out a similar chart for sendr

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 16, 2014, 7:37 p.m., Jonathan Rose wrote: > > Hey wdoekes, I'm trying to figure out a similar chart for sendrpid=rpid > > > > | pres=allowed > > | pres=prohibited >

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 16, 2014, 2:37 p.m., Jonathan Rose wrote: > > Hey wdoekes, I'm trying to figure out a similar chart for sendrpid=rpid > > > > | pres=allowed > > | pres=prohibited >

[asterisk-dev] [Code Review] 3455: testsuite: Add chan_sip tests for sendrpid=pai/rpid tests (baseline and with trust_id_outbound)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3455/ --- Review request for Asterisk Developers, Joshua Colp, Matt Jordan, Mark Mich

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/ --- (Updated April 16, 2014, 4:23 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/#review11639 --- /branches/1.8/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/ --- (Updated April 16, 2014, 4:46 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3455: testsuite: Add chan_sip tests for sendrpid=pai/rpid tests (baseline and with trust_id_outbound)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3455/#review11640 --- Ship it! Ship It! - Joshua Colp On April 16, 2014, 9:08 p.m

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/#review11641 --- /branches/1.8/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 16, 2014, 4:55 p.m., Joshua Colp wrote: > > /branches/1.8/channels/chan_sip.c, line 11397 > > > > > > Where do the anonymous values now get placed into the num/name/domain? They come from the fromdomai

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 16, 2014, 4:55 p.m., Joshua Colp wrote: > > /branches/1.8/channels/chan_sip.c, line 11397 > > > > > > Where do the anonymous values now get placed into the num/name/domain? > > Jonathan Rose wrote: >

Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated April 16, 2014, 5:34 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3444: Testsuite: PJSIP Callee Initiated Nominal Blind Transfers

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3444/#review11644 --- ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3447/#review11646 --- /branches/1.8/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3434: libpri: Make TE-PTP mode respond to MDL TEI check requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3434/#review11647 --- Ship it! Ship It! - Matt Jordan On April 15, 2014, 2:22 p.m

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> On April 16, 2014, 7:37 p.m., Jonathan Rose wrote: > > Hey wdoekes, I'm trying to figure out a similar chart for sendrpid=rpid > > > > | pres=allowed > > | pres=prohibited >

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

> > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3447/#review11635 > --- > > > Hey wdoekes, I'm trying to figure out a similar