[asterisk-dev] confbridge struct (object) not release

Asterisk 11.5.1 and Centos 6 module:app_confbridge.c Issue: How to delete confbridge struct in case of multiserver Confbridge using IAX2. NOTE:In single server there is no any such issue ? void conf_ended(struct conference_bridge *conference_bridge){ ao2_unlink(conference_bridges, confere

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 17, 2014, 7:49 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Bounty] Stasis bug/finishing implementation - $1, 000

Heh, but you just posted your own patch. Are you still interested in help here? -- Russell Bryant On Wed, Jul 16, 2014 at 11:23 PM, Krandon wrote: > Up'ing bounty to $1,000 > > -- > KB > > On Wednesday, July 16, 2014 at 5:56 AM, Krandon wrote: > > "ARI /continue fails to actually continue i

Re: [asterisk-dev] [Code Review] 3666: res_fax: fax show session, fax show sessions, fax show stats - providing similar AMI commands

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3666/#review12708 --- Ship it! Only the one minor finding below. /trunk/res/res_fa

Re: [asterisk-dev] [Bounty] Stasis bug/finishing implementation - $1, 000

On Thu, Jul 17, 2014 at 8:08 AM, Russell Bryant wrote: > Heh, but you just posted your own patch. Are you still interested in help > here? > The patch is pretty much what I figured would have to be done... I guess you could pay yourself? :-) -- Matthew Jordan Digium, Inc. | Engineering Manage

Re: [asterisk-dev] [Bounty] Stasis bug/finishing implementation - $1, 000

Matt, Just tried - but paypal took $30 of my own money to pay myself. Thanks Obama. Russell, I don't believe so, as the patch seems to be working now. There will be more. Sorry for the less than 24 hour total time! Thanks all, -- KB On Thursday, July 17, 2014 at 8:54 AM, Matthew Jordan w

[asterisk-dev] Asterisk 13: Feature Frozen!

Hey everyone - Yesterday was the feature freeze deadline for Asterisk 13, and thanks to the hard work of everyone in the community, I think we're in really good shape to declare Asterisk 13 feature frozen. Thank you! Over the next few weeks, the patches currently up on review board [1] will go th

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12709 --- Could you maybe explain why this is needed? I couldn't find any

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12710 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3796/#review12711 --- My comments can be applied to both tests, and multiple instance

Re: [asterisk-dev] [Code Review] 3728: ARI: Add missing transfer information

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3728/#review12712 --- branches/12/main/stasis_bridges.c

Re: [asterisk-dev] [Code Review] 3729: Stasis: Allow prestart actions to be queued

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3729/#review12713 --- branches/12/res/stasis/control.c

Re: [asterisk-dev] [Code Review] 3762: testsuite: Tests for endpoint subscription (nominal + basic off-nominal)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3762/#review12714 --- Ship it! /asterisk/trunk/tests/rest_api/applications/subscrib

Re: [asterisk-dev] [Code Review] 3731: Stasis: Prevent non-stasis channels from entering stasis bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3731/#review12715 --- team/rmudgett/stasis_linkedids/res/stasis/stasis_bridge.c

Re: [asterisk-dev] [Code Review] 3731: Stasis: Prevent non-stasis channels from entering stasis bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3731/#review12716 --- team/rmudgett/stasis_linkedids/res/res_stasis.c

Re: [asterisk-dev] [Code Review] 3721: Masquerades: Framehook and Audiohook fixup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3721/#review12717 --- /branches/12/funcs/func_audiohookinherit.c

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3812/#review12718 --- trunk/doc/appdocsxml.dtd

Re: [asterisk-dev] [Code Review] 3809: features config: prevent assert on no featuregroups or applicationmap

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3809/#review12719 --- /team/group/media_formats-reviewed-trunk/main/features_config.

[asterisk-dev] Addition of menuselect to trunk (https://reviewboard.asterisk.org/r/3773/)

As an FYI, I'm going to start the process of merging menuselect into trunk: https://reviewboard.asterisk.org/r/3773/ This will include removing the svn:externals property from trunk, as well as the merged menuselect (as Sean Bright has a subsequent patch that makes menuselect use libxml2, removin

Re: [asterisk-dev] [Code Review] 3815: Improve AstDb I/O When Updating Rows

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3815/ --- (Updated July 17, 2014, 1:57 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3816: Publish transferee and transfer target channels, when possible, during transfers.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3816/ --- (Updated July 17, 2014, 6:01 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3822/#review12720 --- ast_format_compatibility_format2bitfield() and ast_format_comp

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

> On July 17, 2014, 2:32 p.m., rmudgett wrote: > > ast_format_compatibility_format2bitfield() and > > ast_format_compatibility_codec2bitfield() are used by other modules than > > just chan_iax2. It appears my description is wrong, these two functions are the only ones that are not moved out o

Re: [asterisk-dev] [Code Review] 3815: Improve AstDb I/O When Updating Rows

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3815/#review12722 --- Ship it! Ship It! - Mark Michelson On July 17, 2014, 5:57 p

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3822/ --- (Updated July 17, 2014, 2:39 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/ --- (Updated July 17, 2014, 2:02 p.m.) Status -- This change has been mar

Re: [asterisk-dev] Addition of menuselect to trunk (https://reviewboard.asterisk.org/r/3773/)

On Thu, Jul 17, 2014 at 12:56 PM, Matthew Jordan wrote: > As an FYI, I'm going to start the process of merging menuselect into trunk: > > https://reviewboard.asterisk.org/r/3773/ > > This will include removing the svn:externals property from trunk, as > well as the merged menuselect (as Sean Brigh

Re: [asterisk-dev] [Code Review] 3809: features config: prevent assert on no featuregroups or applicationmap

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3809/ --- (Updated July 17, 2014, 2:16 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3817/ --- (Updated July 17, 2014, 2:27 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3796/ --- (Updated July 17, 2014, 7:29 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

> On July 17, 2014, 12:37 p.m., Corey Farrell wrote: > > trunk/doc/appdocsxml.dtd, line 34 > > > > > > I'd prefer to see a new xml tag for responses instead of managerEvent. > > The BridgeInfo responses are actuall

Re: [asterisk-dev] [Code Review] 3768: ARI: add a copy operation for stored recordings

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3768/ --- (Updated July 17, 2014, 2:41 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3822/ --- (Updated July 17, 2014, 3:48 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3769: testsuite: Add tests for copying a stored recording

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3769/ --- (Updated July 17, 2014, 2:52 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3721: Masquerades: Framehook and Audiohook fixup

> On July 17, 2014, 12:12 p.m., rmudgett wrote: > > /branches/12/funcs/func_audiohookinherit.c, lines 43-45 > > > > > > Hmm. I think for v12 the current documentation needs to be preserved > > with the deprecation

Re: [asterisk-dev] [Code Review] 3809: features config: prevent assert on no featuregroups or applicationmap

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3809/#review12726 --- Ship it! Minor nit about why the asserts are there. /team/gr

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3822/ --- (Updated July 17, 2014, 4:06 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3721: Masquerades: Framehook and Audiohook fixup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3721/ --- (Updated July 17, 2014, 3:10 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3768: ARI: add a copy operation for stored recordings

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3768/#review12728 --- Ship it! Ship It! - Samuel Galarneau On July 17, 2014, 7:41

Re: [asterisk-dev] [Code Review] 3721: Masquerades: Framehook and Audiohook fixup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3721/#review12729 --- Ship it! /branches/12/funcs/func_audiohookinherit.c

Re: [asterisk-dev] [Code Review] 3816: Publish transferee and transfer target channels, when possible, during transfers.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3816/#review12730 --- Ship it! A few minor logging related things that were moved, b

Re: [asterisk-dev] [Code Review] 3721: Masquerades: Framehook and Audiohook fixup

> On July 17, 2014, 3:33 p.m., rmudgett wrote: > > /branches/12/funcs/func_audiohookinherit.c, lines 95-96 > > > > > > ... result of a small ... > > > > Extra space between "the original" It's a trap! It's

Re: [asterisk-dev] [Code Review] 3700: sip.conf progressinband=never should mean 'never'

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3700/ --- (Updated July 17, 2014, 4:04 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

> On July 17, 2014, 1:37 p.m., Corey Farrell wrote: > > trunk/doc/appdocsxml.dtd, line 34 > > > > > > I'd prefer to see a new xml tag for responses instead of managerEvent. > > The BridgeInfo responses are actually

Re: [asterisk-dev] [Code Review] 3804: sample configs: Move sample configs into a subfolder of configs to allow for additional sets of configuration files in the future

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3804/ --- (Updated July 17, 2014, 4:17 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3822/#review12732 --- Compiles with almost all modules enabled. /team/group/media_f

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3811/#review12733 --- /trunk/main/stasis_channels.c

Re: [asterisk-dev] [Code Review] 3806: Testsuite: Ensure AMI connections are cleaned up before stopping asterisk

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3806/#review12734 --- Ship it! Ship It! - Matt Jordan On July 16, 2014, 8:54 p.m.

[asterisk-dev] [Code Review] 3825: testsuite: Add a PJSIPNotify manager command test for using URIs instead of endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3825/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson. Re

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

> On July 17, 2014, 9:43 a.m., Paul Belanger wrote: > > Could you maybe explain why this is needed? I couldn't find anything on > > Jira / wiki that explained the need. I assume it is because of performance > > issues? This patch is the 'sledgehammer' option for tweaking your system's perform

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12736 --- trunk/configs/stasis.conf.sample

Re: [asterisk-dev] [Code Review] 3809: features config: prevent assert on no featuregroups or applicationmap

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3809/ --- (Updated July 17, 2014, 5:17 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

> On July 17, 2014, 5:41 p.m., Matt Jordan wrote: > > /trunk/main/stasis_channels.c, lines 1071-1077 > > > > > > I'm not sure why these changes (removal of the .to_ami callback) were > > necessary. > > > >

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

> On July 17, 2014, 5:38 p.m., rmudgett wrote: > > /team/group/media_formats-reviewed-trunk/main/format_compatibility.c, line > > 176 > > > > > > I'm not sure this should be moved from the core since the conversion

Re: [asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3796/#review12739 --- Ship it! Ship It! - Scott Griepentrog On July 17, 2014, 2:2

Re: [asterisk-dev] [Code Review] 3806: Testsuite: Ensure AMI connections are cleaned up before stopping asterisk

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3806/ --- (Updated July 17, 2014, 10:32 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 17, 2014, 10:47 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3822/ --- (Updated July 18, 2014, 12:15 a.m.) Review request for Asterisk Developers