[asterisk-dev] [Code Review] 4052: chan_sip: Failure to receive ACK to SIP re-INVITE results in dialog leak.

2014-10-08 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4052/ --- Review request for Asterisk Developers. Bugs: ASTERISK-20784

[asterisk-dev] Asterisk ARI improper usage pattern for channels REST API

2014-10-08 Thread Nir Simionovich
Hi Guys, While working on PHPARI, I've come to a realization that the channels REST API has a slight issue - primarily, its usage of the priority member in the REST API. Currently, the specification states that priority is either int or long (depending on the request). The problem with

[asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

2014-10-08 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

2014-10-08 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13467 --- If we were to follow the CLI convention, it would be: pjsip

[asterisk-dev] [Code Review] 4054: Stasis: Reduce processing for declined message types

2014-10-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4054/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 4055: testsuite: chan_sip: Test unscheduling reINVITE after call hangup.

2014-10-08 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4055/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22791

[asterisk-dev] [Code Review] 4056: chan_sip: Fix so asterisk won't send reINVITE after a BYE.

2014-10-08 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4056/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22791

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-08 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/ --- (Updated Oct. 8, 2014, 4:13 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

2014-10-08 Thread Matt Jordan
On Oct. 8, 2014, 9:53 a.m., Scott Griepentrog wrote: If we were to follow the CLI convention, it would be: pjsip show histories 4 9 and pjsip show history 4 It might be helpful to also add an alias for 'pjsip show historys' Er... I'm not sure I like the plural form.

[asterisk-dev] [Code Review] 4057: bridge: Every time a bridge lies during the smart bridge operation I cry

2014-10-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4057/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-08 Thread Joshua Colp
On Oct. 7, 2014, 6:45 p.m., Joshua Colp wrote: I don't think this goes far enough. What if I receive no candidates for RTCP? It would still crash. Kevin Harwell wrote: I tested for this. The only time it crashes is when there are no RTP candidates in the list. If there are no

Re: [asterisk-dev] Asterisk ARI improper usage pattern for channels REST API

2014-10-08 Thread Scott Griepentrog
The only two ARI methods I'm seeing where a priority is used are: 1) Channel origination (optionally sending channel to dialplan instead of into a Stasis app) 2) Channel continue (jump out of application into a specific point in dialplan) And yes, you are correct in pointing out that the

Re: [asterisk-dev] [Code Review] 4054: Stasis: Reduce processing for declined message types

2014-10-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4054/ --- (Updated Oct. 8, 2014, 1:11 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4061: testsuite: Initial test for res_phoneprov

2014-10-08 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4061/ --- Review request for Asterisk Developers. Repository: testsuite