Re: [asterisk-dev] [Code Review] 4050: Add ability for Channel Drivers to provide Presence State information

> On Oct. 14, 2014, 1:51 p.m., Matt Jordan wrote: > > /trunk/main/presencestate.c, lines 160-177 > > > > > > So, I'm not sure this is the behaviour that we would want. > > > > If a channel driver provides p

Re: [asterisk-dev] [Code Review] 4050: Add ability for Channel Drivers to provide Presence State information

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4050/ --- (Updated Oct. 17, 2014, 4:26 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4074: AMI: Add missing VarSet events when a channel inherits variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4074/ --- (Updated Oct. 16, 2014, 9:32 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/ --- (Updated Oct. 16, 2014, 8:55 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration

> On Oct. 15, 2014, 4:43 p.m., Matt Jordan wrote: > > /asterisk/trunk/runtests.py, lines 82-83 > > > > > > While the extra parantheses are probably needed, generally, this > > doesn't feel like the pythonic way to w

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13561 --- /asterisk/trunk/lib/python/asterisk/asterisk.py

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

> On Oct. 10, 2014, 1:57 p.m., Corey Farrell wrote: > > /asterisk/trunk/runtests.py, line 159 > > > > > > Per IRC discussion with mjordan this is not always the correct location > > of refcounter.py. Update will f

Re: [asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/#review13559 --- Ship it! Ship It! - Kevin Harwell On Oct. 16, 2014, 4:41 p.

Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/#review13558 --- Ship it! Otherwise this works as advertised. /asterisk/trunk

[asterisk-dev] [Code Review] 4091: build: Force -fsigned-char on platforms where the default for char is unsigned.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4091/ --- Review request for Asterisk Developers and Corey Farrell. Repository: Aste

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13555 --- /trunk/res/res_pjsip_history.c

Re: [asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/ --- (Updated Oct. 16, 2014, 4:41 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/#review13557 --- /asterisk/trunk/lib/python/asterisk/sippversion.py

[asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 4077: Test Suite: Unregister registered outbound registrations

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4077/#review13556 --- Ship it! Ship It! - Kevin Harwell On Oct. 14, 2014, 11:03 a

Re: [asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/ --- (Updated Oct. 16, 2014, 3:39 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add "virtual line" support for automatic inbound matching

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2964/#review13554 --- What's the load order for the identifier? What if it needs to

[asterisk-dev] Queue discussion at Astricon

Greetings, I'd like to see if there is any interest in people coming together at astricon to discussion the future of queues in Asterisk? As some are aware, we're already building a queue application using ARI and would like to collaborate with people how they are doing their replacements or even

Re: [asterisk-dev] [Code Review] 4085: ExtensionStatus: Add additional documentation describing the ExtensionStatus event

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4085/ --- (Updated Oct. 16, 2014, 2:06 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

> On Oct. 16, 2014, 11:32 a.m., Joshua Colp wrote: > > /trunk/res/res_pjsip_history.c, line 87 > > > > > > I'm not a fan of these scoped mutexes being here. Despite the enabled > > check being fast you've still got

Re: [asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4073/#review13552 --- Ship it! Ship It! - Marquis On Oct. 13, 2014, 6:09 p.m., Jo

Re: [asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4073/#review13551 --- Ship it! Ship It! - Matt Jordan On Oct. 13, 2014, 1:09 p.m.

Re: [asterisk-dev] [Code Review] 4085: ExtensionStatus: Add additional documentation describing the ExtensionStatus event

> On Oct. 15, 2014, 4:30 p.m., Mark Michelson wrote: > > /branches/13/main/manager.c, line 1225 > > > > > > In an experiment, I had one busy and one inuse device in a hint, and > > the ExtensionStatus showed 2 as

Re: [asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4089/ --- (Updated Oct. 16, 2014, 12:30 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4089/#review13549 --- Ship it! Ship It! - Mark Michelson On Oct. 16, 2014, 5:18 p

Re: [asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4089/#review13548 --- Ship it! Ship It! - Joshua Colp On Oct. 16, 2014, 5:18 p.m.

Re: [asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4089/ --- (Updated Oct. 16, 2014, 11:18 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/#review13547 --- Ship it! Ship It! - Mark Michelson On Oct. 16, 2014, 2:41 p

Re: [asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4089/ --- (Updated Oct. 16, 2014, 10:05 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4089/#review13546 --- branches/12/main/config.c

Re: [asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4089/#review13545 --- branches/12/tests/test_config.c

[asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4089/ --- Review request for Asterisk Developers and Joshua Colp. Repository: Asteri

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

> On Oct. 16, 2014, 6:32 a.m., Joshua Colp wrote: > > /trunk/res/res_pjsip_history.c, line 87 > > > > > > I'm not a fan of these scoped mutexes being here. Despite the enabled > > check being fast you've still got a

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/ --- (Updated Oct. 16, 2014, 2:41 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4062: PJSIP: Enforce module load dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4062/ --- (Updated Oct. 16, 2014, 9:25 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4062: PJSIP: Enforce module load dependencies

> On Oct. 15, 2014, 5:38 p.m., George Joseph wrote: > > Can you make the change in res_pjsip_phoneprov_provider while you're there? > > It was just committed. It'd need CHECK_PJSIP_MODULE_LOADED(). I can take care of that. - opticron ---

Re: [asterisk-dev] [Code Review] 4079: testsuite: Update Offer/Answer PJSIP Tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4079/#review13542 --- Ship it! I've looked over the SDP and SIP responses, they cove

Re: [asterisk-dev] [Code Review] 4063: res_pjsip_session/res_pjsip_sdp_rtp: Fix a variety of situations where Asterisk would incorrectly reject offers

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4063/#review13541 --- Ship it! Ship It! /branches/13/res/res_pjsip_sdp_rtp.c

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13540 --- /trunk/res/res_pjsip_history.c

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/ --- (Updated Oct. 16, 2014, 11:24 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

> On Oct. 15, 2014, 8:37 p.m., Mark Michelson wrote: > > /trunk/res/res_pjsip_keepalive.c, lines 151-153 > > > > > > I'm not very familiar with the PJSIP transport state machine, but I can > > see that there are tw

Re: [asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/#review13538 --- /asterisk/trunk/runtests.py