Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-29 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/ --- (Updated Oct. 29, 2014, 5:04 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-29 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4122/#review13604 --- /asterisk/trunk/tests/pbx/dialplan_reload/run-test

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-29 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/#review13605 --- /asterisk/trunk/contrib/scripts/refleaks-summary

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-29 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/ --- (Updated Oct. 29, 2014, 5:47 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4126: app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.

2014-10-29 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4126/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24190

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-29 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/#review13606 --- Ship it! LGTM. /asterisk/trunk/runtests.py

Re: [asterisk-dev] [Code Review] 4094: Install refcounter.py to /var/lib/asterisk/scripts

2014-10-29 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4094/#review13607 --- Ship it! Ship It! - wdoekes On Oct. 17, 2014, 11:16 a.m.,

Re: [asterisk-dev] [Code Review] 4117: Fix building chan_phone on big endian systems

2014-10-29 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4117/ --- (Updated Oct. 29, 2014, 5:33 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-29 Thread Corey Farrell
On Oct. 29, 2014, 5:18 a.m., wdoekes wrote: /asterisk/trunk/tests/pbx/dialplan_reload/run-test, line 64 https://reviewboard.asterisk.org/r/4122/diff/1/?file=68588#file68588line64 Is it needed to callLater() instead of just calling it? Applies to the other 0-second callLaters too.

Re: [asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-29 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4122/ --- (Updated Oct. 29, 2014, 7:27 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-10-29 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/#review13611 --- I suggest reusing the 'media_encryption' pjsip.conf option

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-10-29 Thread Joshua Colp
On Oct. 29, 2014, 1:49 p.m., jbigelow wrote: I suggest reusing the 'media_encryption' pjsip.conf option with possible values of 'yes', 'no', 'attempt'/'try' instead of a new option. If not I suggest renaming the option to something like 'media_encryption_attempt' or

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-29 Thread Daniel McFarlane
Hi, I've been reading recent emails on the developers list and just wanted to add my 2 cents: While the AGI approach was never useful for my needs, I recently finished 2 years of almost straight development time to develop a full-fledged call answering solution and I would be VERY annoyed

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-10-29 Thread jbigelow
On Oct. 29, 2014, 8:49 a.m., jbigelow wrote: I suggest reusing the 'media_encryption' pjsip.conf option with possible values of 'yes', 'no', 'attempt'/'try' instead of a new option. If not I suggest renaming the option to something like 'media_encryption_attempt' or

Re: [asterisk-dev] [Code Review] 4126: app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.

2014-10-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4126/#review13614 --- /branches/1.8/apps/app_voicemail.c

Re: [asterisk-dev] [Code Review] 4126: app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.

2014-10-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4126/#review13610 --- /branches/1.8/apps/app_voicemail.c

Re: [asterisk-dev] [Code Review] 4124: audiohooks: Clean references to formats

2014-10-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4124/#review13616 --- Ship it! Ship It! - Matt Jordan On Oct. 28, 2014, 11:22

Re: [asterisk-dev] [Code Review] 4125: app_queue: fix a couple leaks to struct call_queue in set_member_value

2014-10-29 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4125/#review13615 --- Ship it! One more queue_unref(q) needed and this should be

Re: [asterisk-dev] [Code Review] 4121: testsuite: Close ARI websocket connections before stopping reactor

2014-10-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4121/#review13617 --- Ship it! Ship It! - Matt Jordan On Oct. 28, 2014, 4:19

Re: [asterisk-dev] [Code Review] 4126: app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.

2014-10-29 Thread wdoekes
On Oct. 29, 2014, 2:41 p.m., Matt Jordan wrote: /branches/1.8/apps/app_voicemail.c, lines 3233-3243 https://reviewboard.asterisk.org/r/4126/diff/1/?file=68594#file68594line3233 The struct vm_state in vm_execmain is allocated on the stack. init_vm_state is called on it if

Re: [asterisk-dev] [Code Review] 4126: app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.

2014-10-29 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4126/ --- (Updated Oct. 29, 2014, 3:40 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4119: pjsip: handle outbound unregister correctly

2014-10-29 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4119/#review13619 --- Ship it! /branches/12/res/res_pjsip_outbound_registration.c

Re: [asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add virtual line support for automatic inbound matching

2014-10-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2964/#review13620 --- Ship it! Ship It! - opticron On Oct. 10, 2014, 8:18 a.m.,

Re: [asterisk-dev] [Code Review] 4099: Optimistic SRTP Tests.

2014-10-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4099/#review13621 ---

Re: [asterisk-dev] [Code Review] 4126: app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.

2014-10-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4126/#review13622 --- Ship it! Ship It! - Matt Jordan On Oct. 29, 2014, 10:40

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-29 Thread Paul Albrecht
On Oct 28, 2014, at 5:03 PM, Ben Langfeld b...@langfeld.me wrote: On 28 October 2014 19:47, Derek Andrew derek.and...@usask.ca wrote: What is the alternative to the dial plan? Is everyone talking about getting rid of the statements like: exten = s,1, what is the alternative? Remote

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-29 Thread Ben Klang
On 10/28/2014 06:03 PM, Ben Langfeld wrote: On 28 October 2014 19:47, Derek Andrew derek.and...@usask.ca mailto:derek.and...@usask.ca wrote: What is the alternative to the dial plan? Is everyone talking about getting rid of the statements like: exten = s,1, what is the alternative?

Re: [asterisk-dev] [Code Review] 4125: app_queue: fix a couple leaks to struct call_queue in set_member_value

2014-10-29 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4125/ --- (Updated Oct. 29, 2014, 4:33 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

2014-10-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13624 --- /trunk/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 4116: res_pjsip: incorrect qualify statistics after disabling for contact

2014-10-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4116/#review13625 --- Ship it! Ship It! - opticron On Oct. 27, 2014, 4:43 p.m.,

Re: [asterisk-dev] [Code Review] 4120: res_pjsip_acl: contact ACL permits are being interpreted incorrectly

2014-10-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4120/#review13626 --- Ship it! Ship It! - opticron On Oct. 28, 2014, 2:45 p.m.,

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-29 Thread Jared Smith
On Wed, Oct 29, 2014 at 12:31 PM, Paul Albrecht palbre...@glccom.com wrote: None of said “discussion” ever happened on the lists nor was the broader Asterisk community involved as far as I can determine. A parallel “discussion” was started by a shill at AstiCon this year to begin to get the

Re: [asterisk-dev] [Code Review] 4120: res_pjsip_acl: contact ACL permits are being interpreted incorrectly

2014-10-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4120/#review13627 --- As an addendum to opticron's Ship It: This needs a test. -

Re: [asterisk-dev] [Code Review] 4107: Wiki: Some new PJSIP-related pages

2014-10-29 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4107/#review13623 --- Configuring res_pjsip for Presence Subscriptions Under the

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

2014-10-29 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/#review13628 --- 1) In stringfields.h:ast_string_field_ptr_set_by_fields(), the

Re: [asterisk-dev] [Code Review] 2478: Support multiple Require: and Supported: headers in the same request

2014-10-29 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2478/ --- (Updated Oct. 29, 2014, 8:39 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3437: chan_sip: Add support for a few more 4xx error responses

2014-10-29 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3437/ --- (Updated Oct. 29, 2014, 8:57 p.m.) Status -- This change has been