Re: [asterisk-dev] Should internal timer implementing session timers be stopped and restarted on response to re-invite?

Mark Michelson wrote: Looking in my Asterisk 11 version of chan_sip.c, in start_session_timer(), the first if block looks like this:     if (p->stimer->st_schedid > -1) {            /* in the event a timer is already going, stop i

Re: [asterisk-dev] Process change proposal: allowing new features and improvements into release branches

Matt and Community, This looks great to me. I've tweaked the wiki page a little bit to better reflect the branch merging since 1.8 is now EOL. Otherwise, I think this meets a very nice balance between "allowing features in to keep pace with the industry" and anarchy. I look forward to next AstriC

Re: [asterisk-dev] Process change proposal: allowing new features and improvements into release branches

+1 This sounds more than reasonable to me. Sent from my iPhone > On Nov 10, 2014, at 5:57 PM, Matthew Jordan wrote: > > At AstriDevCon, we spent a good amount of time discussing whether or > not we should allow new features or improvements to be made in release > branches. As I summarized prev

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4151/ --- (Updated Nov. 12, 2014, 7:44 a.m.) Status -- This change has been mar

[asterisk-dev] [Code Review] 4163: Stasis: Fix StasisEnd message ordering

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4163/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24501 https://i

Re: [asterisk-dev] [Code Review] 4162: pbx: Fix crash in off-nominal when add_priority encounters a failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4162/ --- (Updated Nov. 12, 2014, 10:10 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4164: res_pjsip_outbound_registration: stack overflow when using non-default sorcery wizard

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4164/#review13734 --- Ship it! Ship It! - Mark Michelson On Nov. 11, 2014, 8:56 p

Re: [asterisk-dev] [Code Review] 4155: PJSIP: Allow contact rewriting to fall back for reliable transports

> On Nov. 10, 2014, 8:24 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_nat.c, line 230 > > > > > > Just a question - is this already on the dialog? (Do you need to clone > > it?) > > Joshua Colp wrote: >

Re: [asterisk-dev] [Code Review] 4163: Stasis: Fix StasisEnd message ordering

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4163/#review13736 --- As a general comment, I suggest adding errror messages for all

Re: [asterisk-dev] [Code Review] 4167: Allow mis-dialed DTMF-initiated transfers to be re-attempted.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4167/ --- (Updated Nov. 12, 2014, 6:32 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4163: Stasis: Fix StasisEnd message ordering

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4163/ --- (Updated Nov. 12, 2014, 12:56 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4173: bridge: Protect bridge channel when changing state and make it smarter

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4173/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24440 https://i

Re: [asterisk-dev] [Code Review] 4160: chan_sip: Fix theoretical leak of p->refer

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4160/ --- (Updated Nov. 12, 2014, 3:28 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4175: Fix race condition where identical SIP requests are processed by multiple threads (Asterisk 13)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4175/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] [Code Review] 4174: Fix race condition where identical SIP requests are processed by multiple threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4174/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4165: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4165/ --- (Updated Nov. 12, 2014, 3:08 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 4093: Codec Format Is Not Included in the SDP Media Attributes When SLIN48 Codec Is Used

> On Nov. 5, 2014, 12:49 p.m., Joshua Colp wrote: > > /tags/12.4.0/main/rtp_engine.c, lines 2012-2018 > > > > > > This is not compliant to the way L16 is supposed to be declared within > > SDP. The payload name is

Re: [asterisk-dev] [Code Review] 4163: Stasis: Fix StasisEnd message ordering

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4163/#review13737 --- Ship it! Ship It! - Mark Michelson On Nov. 12, 2014, 6:56 p

Re: [asterisk-dev] [Code Review] 4158: rtp_engine: Fix crash when endpoints send more RTCP report info blocks then we can handle

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4158/ --- (Updated Nov. 12, 2014, 5:59 p.m.) Status -- This change has been mar