Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

2014-11-15 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4178/#review13781 --- branches/13/res/res_pjsip_outbound_publish.c

Re: [asterisk-dev] [Code Review] 4172: Testsuite: tests for res_pjsip_config_wizard

2014-11-15 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4172/#review13782 ---

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

2014-11-15 Thread Matt Jordan
On Nov. 4, 2014, 4:53 p.m., Mark Michelson wrote: Why the change to being a standalone script? I personally like the idea of it being a filter more. George Joseph wrote: I changed it locally months back for 2 reasons... The first was that runtests wasn't pre-calculating and

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

2014-11-15 Thread George Joseph
On Nov. 4, 2014, 3:53 p.m., Mark Michelson wrote: Why the change to being a standalone script? I personally like the idea of it being a filter more. George Joseph wrote: I changed it locally months back for 2 reasons... The first was that runtests wasn't pre-calculating and

Re: [asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

2014-11-15 Thread Michael K.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3867/ --- (Updated Nov. 15, 2014, 10:31 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3980: cel_odbc: Add microseconds precision in the eventtime column

2014-11-15 Thread Etienne Lessard
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3980/ --- (Updated Nov. 15, 2014, 10:51 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

2014-11-15 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4145/ --- (Updated Nov. 15, 2014, 12:05 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-15 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/ --- Review request for Asterisk Developers and rmudgett. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4166: testsuite: tests/bridge/bridge_action leaves a channel open

2014-11-15 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4166/ --- (Updated Nov. 15, 2014, 2:37 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4166: testsuite: tests/bridge/bridge_action leaves a channel open

2014-11-15 Thread Corey Farrell
On Nov. 13, 2014, 11:30 a.m., Mark Michelson wrote: With the fix being made to the leaked bridge in Asterisk, is this change still required? Does hanging up self.channels[1] not result in self.channels[3] and the bridge being destroyed as expected? Corey Farrell wrote: Still

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

2014-11-15 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4145/ --- (Updated Nov. 15, 2014, 3:36 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

2014-11-15 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4145/ --- (Updated Nov. 15, 2014, 4:57 p.m.) Review request for Asterisk