[asterisk-dev] ringinuse seems to include busy; also performance of available queue member search

Whilst looking at the performance of the search for an available queue member I've come across code that handles the ringinuse flag that seems to count busy an inuse as the same, that doesn't make sense to me. I've also come across very long standing code that means ringinuse disables state che

Re: [asterisk-dev] ringinuse seems to include busy; also performance of available queue member search

On 11/20/2014 07:31 AM, Dave WOOLLEY wrote: Whilst looking at the performance of the search for an available queue member I’ve come across code that handles the ringinuse flag that seems to count busy an inuse as the same, that doesn’t make sense to me. I’ve also come across very long standi

Re: [asterisk-dev] [Code Review] 4120: res_pjsip_acl: contact ACL permits are being interpreted incorrectly

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4120/ --- (Updated Nov. 20, 2014, 9:46 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4185: sorcery: Make ast_sorcery_is_object_field_registered handle field names that are regexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4185/#review13828 --- We should probably have a unit test for this as well. - Joshua

Re: [asterisk-dev] [Code Review] 4185: sorcery: Make ast_sorcery_is_object_field_registered handle field names that are regexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4185/#review13827 --- branches/12/main/sorcery.c

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Nov. 5, 2014, 5:43 p.m., Joshua Colp wrote: > > Matt brought it up that this is actually a backwards incompatible change - > > specifically changing priority into a string from an integer. What about > > having label as a separate argument that is optional? If present it's > > treated as

Re: [asterisk-dev] [Code Review] 4093: Codec Format Is Not Included in the SDP Media Attributes When SLIN48 Codec Is Used

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4093/#review13831 --- Ship it! Ship It! - Joshua Colp On Nov. 17, 2014, 2:51 a.m.

Re: [asterisk-dev] [Code Review] 4185: sorcery: Make ast_sorcery_is_object_field_registered handle field names that are regexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4185/ --- (Updated Nov. 20, 2014, 11:17 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4196/#review13832 --- Ship it! Richard's suggestion is fine but I don't find it nece

Re: [asterisk-dev] [Code Review] 4185: sorcery: Make ast_sorcery_is_object_field_registered handle field names that are regexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4185/#review13833 --- branches/12/main/sorcery.c

Re: [asterisk-dev] [Code Review] 4185: sorcery: Make ast_sorcery_is_object_field_registered handle field names that are regexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4185/#review13834 --- branches/12/main/sorcery.c

Re: [asterisk-dev] [Code Review] 4200: manager: Fix could not extend string messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4200/#review13835 --- Ship it! /branches/13/main/manager.c

Re: [asterisk-dev] [Code Review] 4185: sorcery: Make ast_sorcery_is_object_field_registered handle field names that are regexes.

> On Nov. 20, 2014, 11:53 a.m., Mark Michelson wrote: > > branches/12/main/sorcery.c, lines 144-145 > > > > > > Admittedly, I haven't used regex in C much, but looking at man pages, > > why have you elected to use

Re: [asterisk-dev] [Code Review] 4193: Stasis: allow for subscriptions to dictate message delivery on a threadpool for certain situations

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4193/#review13836 --- /team/mjordan/12-threadpool/main/stasis.c

Re: [asterisk-dev] [Code Review] 4185: sorcery: Make ast_sorcery_is_object_field_registered handle field names that are regexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4185/ --- (Updated Nov. 20, 2014, 12:42 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4193: Stasis: allow for subscriptions to dictate message delivery on a threadpool for certain situations

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4193/#review13838 --- I think updating the setup_stasis_subs() function in app_queue.

Re: [asterisk-dev] [Code Review] 4185: sorcery: Make ast_sorcery_is_object_field_registered handle field names that are regexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4185/#review13839 --- Ship it! Ship It! - Mark Michelson On Nov. 20, 2014, 7:42 p

Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4178/ --- (Updated Nov. 20, 2014, 3:43 p.m.) Review request for Asterisk Developers.

[asterisk-dev] Asterisk 1.8.28-cert3, 1.8.32.1, 11.6-cert8, 11.14.1, 12.7.1, 13.0.1 Now Available (Security Release)

The Asterisk Development Team has announced security releases for Certified Asterisk 1.8.28 and 11.6 and Asterisk 1.8, 11, 12, and 13. The available security releases are released as versions 1.8.28-cert3, 11.6-cert8, 1.8.32.1, 11.14.1, 12.7.1, and 13.0.1. These releases are available for immediat

[asterisk-dev] AST-2014-012: Mixed IP address families in access control lists may permit unwanted traffic.

Asterisk Project Security Advisory - AST-2014-012 ProductAsterisk SummaryMixed IP address families in access control lists may permit unwanted traffic.

[asterisk-dev] AST-2014-013: PJSIP ACLs are not loaded on startup

Asterisk Project Security Advisory - AST-2014-013 ProductAsterisk SummaryPJSIP ACLs are not loaded on startup Nature of Advisory Unauthorized Access

[asterisk-dev] AST-2014-014: High call load may result in hung channels in ConfBridge.

Asterisk Project Security Advisory - AST-2014-014 ProductAsterisk SummaryHigh call load may result in hung channels in ConfBridge.

[asterisk-dev] AST-2014-015: Remote Crash Vulnerability in PJSIP channel driver

Asterisk Project Security Advisory - AST-2014-015 ProductAsterisk SummaryRemote Crash Vulnerability in PJSIP channel driver Nature of Advisory Denial of Service

[asterisk-dev] AST-2014-016: Remote Crash Vulnerability in PJSIP channel driver

Asterisk Project Security Advisory - AST-2014-016 ProductAsterisk SummaryRemote Crash Vulnerability in PJSIP channel driver Nature of Advisory Denial of Service

[asterisk-dev] AST-2014-018: AMI permission escalation through DB dialplan function

Asterisk Project Security Advisory - AST-2014-018 ProductAsterisk SummaryAMI permission escalation through DB dialplan function

[asterisk-dev] AST-2014-017: Permission escalation through ConfBridge actions/dialplan functions

Asterisk Project Security Advisory - AST-2014-017 ProductAsterisk SummaryPermission escalation through ConfBridge actions/dialplan functions

Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4196/ --- (Updated Nov. 20, 2014, 8:17 p.m.) Status -- This change has been mar