Re: [asterisk-dev] [Code Review] 4215: sorcery: Add additional observer capabilities.

> On Dec. 4, 2014, 4:08 p.m., Kevin Harwell wrote: > > branches/12/main/sorcery.c, lines 1268-1272 > > > > > > This particular observer's invocation was pushed to the taskprocessor. > > Do the replacement(s)/new

Re: [asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

> On Dec. 4, 2014, 3:45 p.m., Matt Jordan wrote: > > /branches/12/res/res_pjsip_session.c, line 497 > > > > > > Completely ancillary to this... but I don't see where this gets used > > anywhere. :-) > > Mark Miche

Re: [asterisk-dev] [Code Review] 4216: res_pjsip: Direct Media calls within private network sometimes get one way audio

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4216/#review13897 --- Ship it! Ship It! - Matt Jordan On Dec. 4, 2014, 4:36 p.m.,

Re: [asterisk-dev] [Code Review] 4215: sorcery: Add additional observer capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4215/#review13896 --- branches/12/main/sorcery.c

Re: [asterisk-dev] [Code Review] 4216: res_pjsip: Direct Media calls within private network sometimes get one way audio

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4216/ --- (Updated Dec. 4, 2014, 4:36 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

> On Dec. 4, 2014, 9:45 p.m., Matt Jordan wrote: > > /branches/12/res/res_pjsip_session.c, line 497 > > > > > > Completely ancillary to this... but I don't see where this gets used > > anywhere. :-) It's used by T

Re: [asterisk-dev] [Code Review] 4216: res_pjsip: Direct Media calls within private network sometimes get one way audio

> On Dec. 4, 2014, 3:58 p.m., Matt Jordan wrote: > > Where's the change for PJSIP? Or was one not necessary? PJSIP didn't need a change since it calls the original api and the original api call just calls the new one. So it gets the correct address, but didn't need to update the PJSIP code.

Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4178/ --- (Updated Dec. 4, 2014, 4:26 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4230: add capath support to res_pjsip

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4230/ --- (Updated Dec. 4, 2014, 10:09 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4232: Testsuite: Tests for AMI NewConnectedLine and ARI ChannelConnectedLine events

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4232/ --- (Updated Dec. 4, 2014, 9:59 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4216: res_pjsip: Direct Media calls within private network sometimes get one way audio

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4216/#review13893 --- Where's the change for PJSIP? Or was one not necessary? branc

Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

> On Dec. 4, 2014, 12:28 p.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_outbound_publish.c, line 688 > > > > > > Should this also be in the lock? Is there a possible race condition > > here? Hmmm, I don't

Re: [asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4233/#review13891 --- Ship it! /branches/12/res/res_pjsip_session.c

Re: [asterisk-dev] [Code Review] 4234: Testsuite: Ensure that changes in /r/4233 result in Asterisk no longer crashing.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4234/#review13890 --- Ship it! Ship It! - Matt Jordan On Dec. 4, 2014, 3:22 p.m.,

Re: [asterisk-dev] [Code Review] 4216: res_pjsip: Direct Media calls within private network sometimes get one way audio

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4216/ --- (Updated Dec. 4, 2014, 3:31 p.m.) Review request for Asterisk Developers a

[asterisk-dev] [Code Review] 4234: Testsuite: Ensure that changes in /r/4233 result in Asterisk no longer crashing.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4234/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24556 https://i

[asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4233/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24556 https://i

Re: [asterisk-dev] [Code Review] 4231: New AMI/ARI events for connected line updates on a channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4231/#review13889 --- /branches/13/main/manager_channels.c

Re: [asterisk-dev] [Code Review] 4231: New AMI/ARI events for connected line updates on a channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4231/#review13888 --- Ship it! Ship It! - opticron On Dec. 4, 2014, 11:07 a.m., M

Re: [asterisk-dev] [Code Review] 4232: Testsuite: Tests for AMI NewConnectedLine and ARI ChannelConnectedLine events

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4232/#review13887 --- /asterisk/trunk/tests/rest_api/channels/connected_line_update/

Re: [asterisk-dev] [Code Review] 4226: Testsuite: Add tests for external interactions with ARI/Stasis

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4226/#review13886 --- Ship it! asterisk/trunk/tests/rest_api/external_interaction/a

Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4178/#review13885 --- branches/13/res/res_pjsip_outbound_publish.c

Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4178/ --- (Updated Dec. 4, 2014, 12:13 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4226: Testsuite: Add tests for external interactions with ARI/Stasis

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4226/ --- (Updated Dec. 4, 2014, 11:52 a.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4232: Testsuite: Tests for AMI NewConnectedLine and ARI ChannelConnectedLine events

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4232/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24554 https://i

[asterisk-dev] [Code Review] 4231: New AMI/ARI events for connected line updates on a channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4231/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24554 https://i

Re: [asterisk-dev] [Code Review] 4221: test framework: Fix race condition between AMI topic and Test Suite topic raising of AMI events

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4221/ --- (Updated Dec. 4, 2014, 9:47 a.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

> On Dec. 3, 2014, 10:48 a.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_outbound_publish.c, lines 1268-1269 > > > > > > You need to be in a loop here. It's possible for this to get spuriously > > triggered

Re: [asterisk-dev] [Code Review] 4226: Testsuite: Add tests for external interactions with ARI/Stasis

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4226/#review13883 --- asterisk/trunk/lib/python/asterisk/ari.py

Re: [asterisk-dev] [Code Review] 4226: Testsuite: Add tests for external interactions with ARI/Stasis

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4226/ --- (Updated Dec. 4, 2014, 9:01 a.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 4230: add capath support to res_pjsip

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4230/#review13882 --- The alembic scripts should get an update for this. - opticron

Re: [asterisk-dev] [Code Review] 4188: segfault when playing back voicemail under high concurrency with an IMAP backend

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4188/#review13881 --- I know this is committed already, but /trunk/apps/app_voicema