Re: [asterisk-dev] [Code Review] 4377: Testsuite: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4377/ --- (Updated Jan. 27, 2015, 11:02 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

> On Jan. 27, 2015, 9:01 p.m., Ashley Sanders wrote: > > /branches/13/res/res_pjsip_outbound_registration.c, line 1543 > > > > > > Since there are no other attributes being initialized, does this line > > need a c

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4381/#review14337 --- Ship it! Ship It! - Ashley Sanders On Jan. 27, 2015, 10:10

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4381/ --- (Updated Jan. 27, 2015, 10:10 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4381/#review14334 --- Ship it! Thanks for the explanation of the changes, particular

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4381/ --- (Updated Jan. 27, 2015, 9:53 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

> On Jan. 27, 2015, 7:48 p.m., rmudgett wrote: > > ./branches/13/main/http.c, line 640 > > > > > > This seems kind of small for the amount that could be put in here. May > > want to switch to using an ast_str fo

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

> On Jan. 27, 2015, 9:01 p.m., Ashley Sanders wrote: > > /branches/13/res/res_pjsip_outbound_registration.c, line 1543 > > > > > > Since there are no other attributes being initialized, does this line > > need a c

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

> On Jan. 27, 2015, 7:53 p.m., Matt Jordan wrote: > > Given this problem description: > > > > {quote} > > Performing a CLI "module reload" command when there are new pjsip.conf > > registration objects defined frequently failed to load them correctly. > > What happens is a race condtion betwe

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

> On Jan. 27, 2015, 7:48 p.m., rmudgett wrote: > > ./branches/13/main/http.c, line 639 > > > > > > What you had before was better: > > char *status_title = "Unauthorized"; > > > > char status_title[16

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

> On Jan. 27, 2015, 7:51 p.m., rmudgett wrote: > > ./branches/13/main/http.c, line 384 > > > > > > Does this need to be skipped if http_server_name is empty? I think in the case of the status and the CLI, we should

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4381/#review14328 --- /branches/13/res/res_pjsip_outbound_registration.c

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/ --- (Updated Jan. 27, 2015, 8:55 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/#review14326 --- /branches/13/main/bridge.c

[asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/ --- (Updated Jan. 27, 2015, 8:11 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4381/#review14327 --- Given this problem description: {quote} Performing a CLI "modu

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/#review14325 --- ./branches/13/main/http.c

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/#review14324 --- ./branches/13/main/http.c

[asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup up swap channel

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24649 https://i

[asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4381/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24729 https://i

Re: [asterisk-dev] [Code Review] 4377: Testsuite: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4377/ --- (Updated Jan. 27, 2015, 6:19 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/ --- (Updated Jan. 27, 2015, 6:16 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

> On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: > > ./branches/13/main/http.c, line 2155 > > > > > > Setting a blank string will really mean a blank servername output value: > > Server: > > > > Is it i

Re: [asterisk-dev] [Code Review] 4377: Testsuite: For httpd server, need option to define server name for security purposes

> On Jan. 27, 2015, 1:46 a.m., wdoekes wrote: > > > 1) Server: Asterisk/ > > 2) Server: JohnMcClane > > > 3) Server: > > > > Any particular reason why we don't simply omit the header in the third case? > > > > The ABNF at 14.38 here [1] says: > > Server = "Server" ":" 1*( product | comm

Re: [asterisk-dev] [Code Review] 4380: tcptls: Bad file descriptor error when reloading chan_sip

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4380/ --- (Updated Jan. 27, 2015, 4:54 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4380: tcptls: Bad file descriptor error when reloading chan_sip

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4380/#review14321 --- Ship it! Ship It! - Matt Jordan On Jan. 27, 2015, 2:25 p.m.

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/#review14320 --- /branches/13/configs/examples/super_awesome_company/asterisk.c

Re: [asterisk-dev] [Code Review] 4380: tcptls: Bad file descriptor error when reloading chan_sip

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4380/ --- (Updated Jan. 27, 2015, 2:25 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4380: tcptls: Bad file descriptor error when reloading chan_sip

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4380/#review14319 --- branches/11/main/tcptls.c

[asterisk-dev] [Code Review] 4380: tcptls: Bad file descriptor error when reloading chan_sip

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4380/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24728 https://i

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/#review14318 --- /branches/13/configs/examples/super_awesome_company/indication

Re: [asterisk-dev] [Code Review] 4367: chan_sip: stale nonce causes failure

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4367/ --- (Updated Jan. 27, 2015, 1:19 p.m.) Status -- This change has been mar

[asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4363: res_pjsip: make it unloadable (take 2)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4363/ --- (Updated Jan. 27, 2015, 1:08 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

> On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: > > ./branches/13/main/http.c, lines 567-568 > > > > > > Why are the allocation sizes passed in? > > Ashley Sanders wrote: > To account for this handling the error

Re: [asterisk-dev] How to catch the source of a deadlock?

On Tue, Jan 27, 2015 at 11:04 AM, Yousf Ateya wrote: > > Yes, and I supplied the debug logs in the issue ASTERISK-24478 . I was trying > to find a solution to this bug. > > What I am doing now is to run asterisk in debugger (gdb); but it prints TONs > of debug message. > That is why I am looking

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

> On Jan. 27, 2015, 11:05 a.m., rmudgett wrote: > > I'm fine with the bridge core change. Quoting from my statements on IRC: (11:27:55 AM) mjordan: file: I'd say go ahead and ship in https://reviewboard.asterisk.org/r/4378/ (11:28:03 AM) mjordan: file: if we have some testsuite blow ups, I'd r

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 11:32 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4373: Manager Action ModuleLoad gives incorrect response when used to reload modules

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/ --- (Updated Jan. 27, 2015, 11:22 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4351: ARI: improve wiki documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4351/ --- (Updated Jan. 27, 2015, 11:20 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4372/ --- (Updated Jan. 27, 2015, 11:10 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4369: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v13 version)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4369/ --- (Updated Jan. 27, 2015, 5:12 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4368: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v11 version)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4368/ --- (Updated Jan. 27, 2015, 11:12 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/#review14316 --- Ship it! I'm fine with the bridge core change. - rmudgett O

Re: [asterisk-dev] How to catch the source of a deadlock?

Yes, and I supplied the debug logs in the issue ASTERISK-24478 . I was trying to find a solution to this bug. What I am doing now is to run asterisk in debugger (gdb); but it prints TONs of debug message. That is why I am looking fot any way

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 4:59 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 4:49 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

> On Jan. 27, 2015, 9:57 a.m., rmudgett wrote: > > /branches/13/main/bridge_channel.c, lines 1998-2001 > > > > > > The reason a swap channel is pulled after the new channel is pushed is > > because pulling the las

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 4:34 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/#review14314 --- /branches/13/res/res_pjsip_sdp_rtp.c

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

> On Jan. 27, 2015, 9:57 a.m., rmudgett wrote: > > /branches/13/main/bridge_channel.c, lines 1998-2001 > > > > > > The reason a swap channel is pulled after the new channel is pushed is > > because pulling the las

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 4:27 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

> On Jan. 27, 2015, 3:57 p.m., rmudgett wrote: > > /branches/13/main/bridge_channel.c, lines 1998-2001 > > > > > > The reason a swap channel is pulled after the new channel is pushed is > > because pulling the las

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

> On Jan. 27, 2015, 3:57 p.m., rmudgett wrote: > > /branches/13/main/bridge_channel.c, lines 1998-2001 > > > > > > The reason a swap channel is pulled after the new channel is pushed is > > because pulling the las

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/#review14308 --- /branches/13/main/bridge_channel.c

Re: [asterisk-dev] [Code Review] 4362: chan_sip Invite: Replaces hangup bug fix

> On Jan. 23, 2015, 3:30 p.m., Matt Jordan wrote: > > After reading through the analysis on the underlying ASTERISK issue, I > > don't have any findings with the patch. I'm always a little concerned when > > we have to add a new state to keep track of on the sip_pvt, but right now I > > can't

Re: [asterisk-dev] rtptimeout

On Mon, Jan 26, 2015 at 8:22 PM, Kelvin Chua wrote: > Hi guys, > > I noticed rtptimeout on asterisk 12 is not working, so i looked at the > source. > looks like, it has no effect on res_rtp_asterisk? > > It never has. rtptimeout is a little odd in that the value is stored in the RTP instance, bu

Re: [asterisk-dev] How to catch the source of a deadlock?

On Tue, Jan 27, 2015 at 7:01 AM, Yousf Ateya wrote: > Dear, > > While investigating iax2 bug ASTERISK-24478 > ; > I found some dead

Re: [asterisk-dev] [Code Review] 4371: Update res_format_attr_opus & res_format_attr_silk to new media formats architecture

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4371/#review14307 --- Ship it! Ship It! - Joshua Colp On Jan. 26, 2015, 11:38 a.m

[asterisk-dev] How to catch the source of a deadlock?

Dear, While investigating iax2 bug ASTERISK-24478 ; I found some dead locks. Which happens very often in my setup. I tried to debug

[asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4375: res_parking: Unsubscribe and join when unloading.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4375/ --- (Updated Jan. 27, 2015, 5:47 a.m.) Status -- This change has been mar