Re: [asterisk-dev] [Code Review] 4427: Fix crash when AOC-E message is received after the channel has been destroyed.

> On Feb. 16, 2015, 6:50 p.m., Matt Jordan wrote: > > /branches/12/main/aoc.c, lines 1871-1880 > > > > > > I don't think this is the right way to fix the problem. > > > > This is really just working around

Re: [asterisk-dev] [Code Review] 4428: Allow graceful shutdown to unload modules that register bucket scheme's or codec's.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4428/#review14474 --- /branches/13/main/loader.c

Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4429/#review14475 --- branches/11/bridges/bridge_softmix.c

Re: [asterisk-dev] Adding the support for NACK in asterisk

Hi Matt, It seems that my reply was lost in the pile of mails during holiday period? Is there any update on this? Regards, Nitesh On Tue, Dec 30, 2014 at 5:54 PM, Nitesh Bansal wrote: > Hi Matt, > > The scenario which i have in my mind is as follows: > > WebRTC browser ---> (Inbound)

Re: [asterisk-dev] [Code Review] 4417: res_pjsip_refer: Fix crash from a REFER and BYE collision.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4417/ --- (Updated Feb. 17, 2015, 9:32 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4428: Allow graceful shutdown to unload modules that register bucket scheme's or codec's.

> On Feb. 17, 2015, 9:51 a.m., Joshua Colp wrote: > > /branches/13/main/loader.c, line 1487 > > > > > > Why the !mod addition? Something trigger it? codec_builtin.c runs __ast_codec_register with a NULL module. T

Re: [asterisk-dev] [Code Review] 4427: Fix crash when AOC-E message is received after the channel has been destroyed.

> On Feb. 16, 2015, 12:50 p.m., Matt Jordan wrote: > > /branches/12/main/aoc.c, lines 1871-1880 > > > > > > I don't think this is the right way to fix the problem. > > > > This is really just working aroun

Re: [asterisk-dev] [Code Review] 4427: Fix crash when AOC-E message is received after the channel has been destroyed.

> On Feb. 16, 2015, 12:50 p.m., Matt Jordan wrote: > > /branches/12/main/aoc.c, lines 1871-1880 > > > > > > I don't think this is the right way to fix the problem. > > > > This is really just working aroun

[asterisk-dev] [Code Review] 4430: ISDN AOC: Fix crash from an AOC-E message that doesn't have a channel association.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4430/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22670, ASTERISK-246

Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4429/#review14479 --- Ship it! Looks fine to me. Minor nit. branches/11/bridges/b

Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

> On Feb. 17, 2015, 9:19 a.m., Joshua Colp wrote: > > branches/11/bridges/bridge_softmix.c, line 317 > > > > > > The setting of 0 here confuses me. If it's zero and on the next run > > some channels request it... w

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Feb. 16, 2015, 10:59 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/awesome/asterisk.conf, line 1 > > > > > > This isn't a template Yup. Oddly it is this way in the asterisk.conf.sample as well, and

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Feb. 16, 2015, 4:59 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/awesome/asterisk.conf, line 1 > > > > > > This isn't a template > > rnewton wrote: > Yup. Oddly it is this way in the asterisk.c

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Feb. 16, 2015, 10:59 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/awesome/logger.conf, line 5 > > > > > > Go with least to greatest: > > > > console => verbose,notice,warning,error That wo

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/#review14484 --- /branches/13/configs/examples/awesome/extensions.conf