Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Diederik de Groot
On Feb. 4, 2015, 3:43 p.m., Joshua Colp wrote: /branches/11/configure.ac, lines 1082-1085 https://reviewboard.asterisk.org/r/4370/diff/1/?file=71055#file71055line1082 If the compiler being used is clang I think this should be required here and not just a warning when you actually

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Diederik de Groot
On Feb. 4, 2015, 3:43 p.m., Joshua Colp wrote: /branches/11/configure.ac, lines 1082-1085 https://reviewboard.asterisk.org/r/4370/diff/1/?file=71055#file71055line1082 If the compiler being used is clang I think this should be required here and not just a warning when you actually

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Diederik de Groot
On Jan. 26, 2015, 6:36 a.m., Diederik de Groot wrote: /branches/11/include/asterisk/inline_api.h, lines 44-51 https://reviewboard.asterisk.org/r/4370/diff/1/?file=71056#file71056line44 You might want to check out: #define forceinline __inline__

[asterisk-dev] [Code Review] 4434: ARI/PJSIP: Apply requesting channel's capabilities to originated channels in ARI; clean up a bit of PJSIP's usage of format capabalities

2015-02-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4434/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24812

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-20 Thread Mark Michelson
On Feb. 18, 2015, 8:58 p.m., Mark Michelson wrote: /asterisk/trunk/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/test-config.yaml, lines 10-13 https://reviewboard.asterisk.org/r/4420/diff/1/?file=71429#file71429line10 I think that the lifetime checks should include the bottom

Re: [asterisk-dev] [Code Review] 4431: Increase WebSocket frame size and improve large read handling

2015-02-20 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4431/#review14512 --- Ship it! Minor nit /branches/11/res/res_http_websocket.c

Re: [asterisk-dev] Possible bug – missing mandatory field Max-Forwards

2015-02-20 Thread Anatoli
Mark, Rusty, The proposed config option fixes the problem. I've sent feedback mentioning this in the issue tracker. Regards, Anatoli From: asterisk-dev-boun...@lists.digium.com [mailto:asterisk-dev-boun...@lists.digium.com] On Behalf Of Mark Michelson Sent: Friday, February 20, 2015

Re: [asterisk-dev] [Code Review] 4436: asterisk/lock.h: Fix syntax errors for non-gcc OSX with 64-bit integers

2015-02-20 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4436/ --- (Updated Feb. 20, 2015, 8:45 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Matt Jordan
On Jan. 25, 2015, 11:36 p.m., Diederik de Groot wrote: /branches/11/include/asterisk/inline_api.h, lines 44-51 https://reviewboard.asterisk.org/r/4370/diff/1/?file=71056#file71056line44 You might want to check out: #define forceinline __inline__

Re: [asterisk-dev] [Code Review] 4435: Reverse #if statement in asterisk.c to fix code folding

2015-02-20 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4435/ --- (Updated Feb. 20, 2015, 8:51 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4428: Allow graceful shutdown to unload modules that register bucket scheme's or codec's.

2015-02-20 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4428/ --- (Updated Feb. 20, 2015, 8:55 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370/ --- (Updated Feb. 20, 2015, 8:35 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/#review14511 --- /branches/13/configs/examples/awesome/extensions.conf

Re: [asterisk-dev] [Code Review] 4431: Increase WebSocket frame size and improve large read handling

2015-02-20 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4431/ --- (Updated Feb. 20, 2015, 9:39 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Matt Jordan
On Feb. 20, 2015, 11:03 a.m., Corey Farrell wrote: /branches/11/include/asterisk/utils.h, lines 946-948 https://reviewboard.asterisk.org/r/4370/diff/2/?file=71539#file71539line946 I feel that configure should create a #define for the type of nested procedure supported. This

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Diederik de Groot
On Jan. 26, 2015, 6:36 a.m., Diederik de Groot wrote: /branches/11/include/asterisk/inline_api.h, lines 44-51 https://reviewboard.asterisk.org/r/4370/diff/1/?file=71056#file71056line44 You might want to check out: #define forceinline __inline__

Re: [asterisk-dev] Possible bug – missing mandatory field Max-Forwards

2015-02-20 Thread Mark Michelson
Thanks for pointing this out. I have commented on the issue with instructions with what I think is going wrong here. On Thu, Feb 19, 2015 at 6:33 PM, Anatoli m...@anatoli.ws wrote: Hi All, I was evaluating the latest Asterisk (13.2.0) with the latest PJSIP (2.3) and found a critical problem

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370/#review14514 --- /branches/11/configure.ac

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370/#review14513 --- /branches/11/include/asterisk/utils.h

Re: [asterisk-dev] [Code Review] 4433: ASTERISK-24811: Add ast_sorcery_apply_config() to res_pjsip_publish_asterisk and res_pjsip_acl.

2015-02-20 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4433/ --- (Updated Feb. 20, 2015, 11:46 a.m.) Status -- This change has been