Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4453/#review14697 --- Ship it! I think this addresses the complexity that would be i

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 13, 2015, 5:19 p.m., gareth wrote: > > Ship It! Well, if we're okay with the patch, then my initial comments still stand :-) {quote} 1. For this to go into Asterisk 13, tests will need to be provided that cover the new parameter. (Really, those tests should be written regardless) 2.

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4488/#review14698 --- /branches/13/configs/basic-pbx/extensions.conf

Re: [asterisk-dev] [Code Review] 4491: chan_sip: Fix dialog reference leaked to scheduler for reinvite_timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4491/#review14700 --- Ship it! Ship It! - Matt Jordan On March 14, 2015, 6:07 a.m

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/#review14701 --- /trunk/include/asterisk/dns_core.h

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

> On March 16, 2015, 2:12 p.m., Matt Jordan wrote: > > /trunk/main/dns_recurring.c, lines 89-91 > > > > > > This could result in an explosion later if this is the last ref to hold > > recurring. This can't be the l

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

> On March 16, 2015, 9:12 a.m., Matt Jordan wrote: > > /trunk/main/dns_recurring.c, lines 89-91 > > > > > > This could result in an explosion later if this is the last ref to hold > > recurring. > > Joshua Colp wro

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/ --- (Updated March 16, 2015, 2:33 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

> On March 16, 2015, 8:57 a.m., Matt Jordan wrote: > > /branches/13/configs/basic-pbx/extensions.conf, lines 36-42 > > > > > > Does this really need to be a separate context? > > > > I'm all for having conte

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/#review14705 --- /trunk/include/asterisk/dns_core.h

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

> On March 16, 2015, 2:55 p.m., Mark Michelson wrote: > > /trunk/include/asterisk/dns_core.h, line 225 > > > > > > First off, apologies for bringing this up now rather than earlier, but > > I did not think of this

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/ --- (Updated March 16, 2015, 3:26 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

> On March 16, 2015, 2:55 p.m., Mark Michelson wrote: > > /trunk/include/asterisk/dns_core.h, line 225 > > > > > > First off, apologies for bringing this up now rather than earlier, but > > I did not think of this

Re: [asterisk-dev] [Code Review] 4462: DNS core unit tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4462/ --- (Updated March 16, 2015, 3:37 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4471: Recurring asynchronous DNS query unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4471/ --- (Updated March 16, 2015, 3:37 p.m.) Status -- This change has been ma

[asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4503/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/ --- (Updated March 16, 2015, 3:22 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/ --- (Updated March 16, 2015, 3:24 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

> On March 16, 2015, 2:55 p.m., Mark Michelson wrote: > > /trunk/include/asterisk/dns_core.h, line 225 > > > > > > First off, apologies for bringing this up now rather than earlier, but > > I did not think of this

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/ --- (Updated March 16, 2015, 3:56 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/#review14709 --- Ship it! Only problem is an easy memory leak to fix on commit.

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4453/ --- (Updated March 16, 2015, 5:40 p.m.) Status -- This change has been ma

[asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4504/ --- Review request for Asterisk Developers and rnewton. Repository: Asterisk

[asterisk-dev] [Code Review] 4498: res_pjsip: Enable unload of all modules at shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4498/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24731 https://i

Re: [asterisk-dev] [Code Review] 4499: Support in dialog OPTIONS

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4499/#review14710 --- This change is full of red blobs (extra whitespace). In additi

[asterisk-dev] Apologies for messy commit of the uacreg counters

Apologies for the messy merge of my branch. One learns all the time. I tried merging the branch locally instead of using the pull request web interface. One has to be careful with every commit - even to a local branch - or just copy files between the branches and commit without a proper merge...

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

> On March 16, 2015, 8:57 a.m., Matt Jordan wrote: > > /branches/13/configs/basic-pbx/extensions.conf, lines 36-42 > > > > > > Does this really need to be a separate context? > > > > I'm all for having conte

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4189/#review14712 --- /branches/13/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

> On March 16, 2015, 6:47 p.m., rmudgett wrote: > > /branches/13/channels/chan_sip.c, lines 1183-1184 > > > > > > Is there a reason why char *file cannot be const? Looks like I copy/pasted the new parameters from

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4189/ --- (Updated March 16, 2015, 7:37 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4189/ --- (Updated March 16, 2015, 7:42 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4505: Asterisk 13 PJSIP sends RTP packets in wrong byte order on Intel platform when using slin codec

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4505/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24858 https://i

Re: [asterisk-dev] [Code Review] 4505: Asterisk 13 PJSIP sends RTP packets in wrong byte order on Intel platform when using slin codec

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4505/ --- (Updated March 17, 2015, 3:35 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4505: Asterisk 13 PJSIP sends RTP packets in wrong byte order on Intel platform when using slin codec

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4505/ --- (Updated March 17, 2015, 3:36 a.m.) Review request for Asterisk Developers