Re: [asterisk-dev] [Code Review] 4512: dns: Add res_resolver_unbound module with unit tests.

2015-03-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4512/#review14748 --- Ship it! This gets a ship it! from me based on the resolver

Re: [asterisk-dev] [Code Review] 4511: Audit ast_pjsip_rdata_get_endpoint() usage for ref leaks.

2015-03-19 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4511/#review14749 --- Ship it! Ship It! - Jonathan Rose On March 17, 2015, 10:04

Re: [asterisk-dev] [Code Review] 4511: Audit ast_pjsip_rdata_get_endpoint() usage for ref leaks.

2015-03-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4511/#review14751 --- Ship it! /branches/13/res/res_pjsip_messaging.c

Re: [asterisk-dev] [Code Review] 4500: ast_register_atexit should only be used when absolutely needed (11 version)

2015-03-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/#review14750 --- Ship it! I'm in the same boat as Matt on this one, but I'll

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

2015-03-19 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4189/ --- (Updated March 19, 2015, 4:53 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4497: logger: init_logger_chain has unreachable code

2015-03-19 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4497/ --- (Updated March 19, 2015, 5:19 a.m.) Status -- This change has been

[asterisk-dev] [BOUNTY] FATAL: unhandled exception PJLIB/No memory!

2015-03-19 Thread Ross Beer
Hi, We are getting the following error with asterisk 12 and 13: [Mar 19 10:14:08] ERROR[40185]: pjsip:0 ?: except.c .!!!FATAL: unhandled exception PJLIB/No memory! Can you please advise if I can either increase the memory for PJLIB or the best way to identify what is causing the

Re: [asterisk-dev] [Code Review] 4491: chan_sip: Fix dialog reference leaked to scheduler for reinvite_timeout.

2015-03-19 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4491/ --- (Updated March 19, 2015, 4:40 a.m.) Status -- This change has been

[asterisk-dev] Re: [BOUNTY] FATAL: unhandled exception PJLIB/No memory!

2015-03-19 Thread Sean Bright
On 3/19/2015 6:38 AM, Ross Beer wrote: We are getting the following error with asterisk 12 and 13: [Mar 19 10:14:08] ERROR[40185]: pjsip:0 ?: except.c .!!!FATAL: unhandled exception PJLIB/No memory! Ross, Is there an associated issue in Jira? https://issues.asterisk.org/ Kind

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

2015-03-19 Thread gareth
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4391/ --- (Updated March 20, 2015, 2:34 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

2015-03-19 Thread gareth
On Jan. 30, 2015, 1:22 a.m., George Joseph wrote: If you run the Testsuite, you'll get a good indication of whether this is truly backwards compatible. gareth wrote: I ran the test apps/queue/set_penalty which makes use of ami.command and it failed. However this

Re: [asterisk-dev] [Code Review] 4500: ast_register_atexit should only be used when absolutely needed (11 version)

2015-03-19 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/#review14754 --- Thanks for taking a look. I plan to give this review a couple

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-19 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4503/#review14752 --- As an update - when testing with my external connectivity

Re: [asterisk-dev] [Code Review] 4515: build_peer peer mailbox management bug

2015-03-19 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4515/#review14755 --- /trunk/channels/chan_sip.c

[asterisk-dev] [Code Review] 4515: build_peer peer mailbox management bug

2015-03-19 Thread gareth
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4515/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24871

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-19 Thread Kevin Harwell
On March 18, 2015, 12:39 p.m., rmudgett wrote: branches/11/apps/app_confbridge.c, lines 1847-1853 https://reviewboard.asterisk.org/r/4477/diff/2/?file=72633#file72633line1847 Swaping which plays first will allow the channel's prompt to be interruptable. Although doing this will

Re: [asterisk-dev] [BOUNTY] FATAL: unhandled exception PJLIB/No memory!

2015-03-19 Thread Ross Beer
Hi Sean, I was just about to pose the reference: https://issues.asterisk.org/jira/browse/ASTERISK-24893 I have just uploaded a backtrace for the latest crash. I would be extremely grateful if you could take a look. Kind regards, Ross To: asterisk-dev@lists.digium.com From: sean.bri...@gmail.com

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-19 Thread rnewton
On March 17, 2015, 9:44 p.m., Mark Michelson wrote: Everything looks good here. Should this review stay open for the external extensions to be added, or will that be a separate review? Jonathan Rose wrote: I'll leave both reviews open for now. I'm finally testing with these with

Re: [asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

2015-03-19 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4504/#review14741 --- Looks good. I'm finally testing with these with outside

Re: [asterisk-dev] [Code Review] 4512: dns: Add res_resolver_unbound module with unit tests.

2015-03-19 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4512/ --- (Updated March 19, 2015, 6:36 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

2015-03-19 Thread rnewton
On March 16, 2015, 1:57 p.m., Matt Jordan wrote: /branches/13/configs/basic-pbx/extensions.conf, lines 36-42 https://reviewboard.asterisk.org/r/4488/diff/1/?file=72117#file72117line36 Does this really need to be a separate context? I'm all for having contexts break up

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

2015-03-19 Thread Matt Jordan
On Jan. 29, 2015, 7:22 p.m., George Joseph wrote: If you run the Testsuite, you'll get a good indication of whether this is truly backwards compatible. gareth wrote: I ran the test apps/queue/set_penalty which makes use of ami.command and it failed. However this

Re: [asterisk-dev] [Code Review] 4513: res_pjsip_sdp_rtp, sorcery: Fix invalid access and memory leak respectively.

2015-03-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4513/#review14745 --- Ship it! Ship It! - Matt Jordan On March 18, 2015, 4:51

Re: [asterisk-dev] [Code Review] 4505: Asterisk 13 PJSIP sends RTP packets in wrong byte order on Intel platform when using slin codec

2015-03-19 Thread Matt Jordan
On March 17, 2015, 11:57 a.m., Matt Jordan wrote: /tags/13.2.0/include/asterisk/codec.h, lines 77-80 https://reviewboard.asterisk.org/r/4505/diff/1/?file=72588#file72588line77 I don't think you can trust that the codec will know its endianness. Looking at the resample code, I

Re: [asterisk-dev] [Code Review] 4500: ast_register_atexit should only be used when absolutely needed (11 version)

2015-03-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/#review14747 --- I looked through everything, and it all made sense to me - but

Re: [asterisk-dev] [Code Review] 4510: app_confbridge (13): file playback blocks dtmf

2015-03-19 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4510/ --- (Updated March 19, 2015, 4:59 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-19 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/ --- (Updated March 19, 2015, 4:59 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add rpid_immediate option to prevent unnecessary 180 Ringing messages.

2015-03-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- (Updated March 19, 2015, 10:59 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4514: Add raw DNS answer to DNS results

2015-03-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4514/ --- (Updated March 19, 2015, 10:16 a.m.) Status -- This change has been